From nobody Thu Apr 2 20:21:28 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 592113F0752 for ; Wed, 1 Apr 2026 23:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775086681; cv=none; b=HQl1AogeWmCpwCVEASAx9/6qVHKKX1kjeozaYS1pjPZulx2kBb8I+DBoJO9FyApZ8IGDsrj24qFDTMv/PxzRRPFdvlVV2CpnNu2fla9Gm3LwTg5KA3LW6K52ffXb5ZVnsV/S5zQNH7Izbj8nm0rQn24QljI61lZLhVyZq9IbUWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775086681; c=relaxed/simple; bh=qqTo0OGVy97q53yKZcD7KVbNbUy3LwcG0BT5l19gi00=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mUfk7Bz3XlN30zHVNciNXwfAa0a1f/yQmVaNeR1su3+EmOKEaX+ughFHAZvZDUy0qwXgJmraEY+4aQZhgkQuTR0eG2ZxyFbdxzSBxNt7LIEOU5JmYBggKtGMuAO5illKAR2ra01kFlb0gKmPrFIu2ec1K1UPgal43kxw/eGHybw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=IFu2GVE5; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="IFu2GVE5" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ad617d5b80so1407115ad.1 for ; Wed, 01 Apr 2026 16:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1775086680; x=1775691480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ifpHKJdUDsXQbmh4bEHFURA21vSlk2ladF+OAXDwL3I=; b=IFu2GVE5SzXHx6Q/M8eG0wdhUJXqQtc5HC/u2g+ziy2CbJAmG5qqle5NUcTnq7pX+6 qbJGDynZdlGas+VtjIdM7pHkEkcOKdjlHGmW7uyK4uXpJXRJ50GPfzNvq7eAPjCr88Fs nF33XryfNn8iSG7bJNwcjCEFdEb686zZVWZrygpB3EngrHMsWZn5OE7b397VST8J37Te xelWgttHR7+UaariXI9duRDSmwg4ATmq99JsSGhP3ZzngGg3im9mSHi39ol3bE2sK3M8 cGQCLpev7cYwkPzD+wJNxxygrzzxamoLPdUtjasGyK4ZzdW0+ERdeTElAAvdaAKrN1k/ M6lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775086680; x=1775691480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ifpHKJdUDsXQbmh4bEHFURA21vSlk2ladF+OAXDwL3I=; b=gYRrN8F5nZ+FgxBINsSlBgAG5VWoPMkNoGbzv94NoDegGOfhYcWt3xT4XGUU/pZoCt yx1Z1/5/dtKZGU3jl7caAR30kA8HX2bOnX+YNWIadOZ0wfK5kygdbcIEAF9ra0ytKvRj S2pF2GU7WgBt9r0FU7rr92DO93uJJUvgm7sXZIQqdhO5dBQYoOnF3QhbfeZ0sw4A5L+m MEDUHvW2suhL5LzXDmM0kkVjx8zmrQ1Ss+NQxTRYFCZs+qO9RgGXMHRiIm/7W7hCpeZo UYrBTpCYRp8OtGvsCXZZsUBqp2gIYD6n7fUSzBhzOzcsHls8XefuO5hLvfc0OTivS4VJ ZPMg== X-Forwarded-Encrypted: i=1; AJvYcCW8CPsy/tzXYu/9ICTUfuyKIvMFM/Z08Dmfio7iXZffChTfVFGw66oyLWOal6n3bSrZipydgLp8ZfgGiL8=@vger.kernel.org X-Gm-Message-State: AOJu0YxE8drje61/FMF2sQVfMJZyiTXbpzWVFbEzFAtyWfEXODi0ZyTt i2Q5H7/TvO2t+B3biuHrYA1JAor814LLfxJ9yWemGSHeKnrTqtv4PickHJHNXej2MAI= X-Gm-Gg: ATEYQzxAWQ0f5vTilo12X0cKbh9/j13gqkBNAw6jiI0LrjeLqfFp6sHDmCRi6x8+UZn QUToMi4Du/Mk1wku9sH7Cu76vn7YYiUTrGzmlb51FaHl7d3UUKMGAknYjxAkCSBmeKBLdw57/c7 mXKsAAXC9f93zVVxMrYy/hjIPhXP705SfUL3Qij9L1CAC70hGGUlGjzEVCiakSTzz+FvF9VlQKe 7v0ZMcqJYjkKLGbymtx6rJl+YcOnKqRjKUGBR+XnvA9abZR2vzWQ/qakrMsd9M3Ulc0/6qtJkC9 q7iQPPox/TlIHQVp/vZI6nvMXMkVjhy91DJXfK0ofw4wOTN3xTeQyZrcAjc9XHyJFr97GXRJ+0e lWrI2zyxvzV1XW+c00XPkHUvrslvfABCpg5vUS8pTfRO9H2auSJqKF5sssPMnkfd3AMTf3DD5tu 8qFa64 X-Received: by 2002:a17:903:90f:b0:2b0:5ec1:97c1 with SMTP id d9443c01a7336-2b269a950c8mr50391395ad.7.1775086679678; Wed, 01 Apr 2026 16:37:59 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:44::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478cb4fsm9202845ad.29.2026.04.01.16.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 16:37:59 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v7 03/10] net: bnxt: Add a helper for tx_bd_ext Date: Wed, 1 Apr 2026 16:37:31 -0700 Message-ID: <20260401233745.2333858-4-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260401233745.2333858-1-joe@dama.to> References: <20260401233745.2333858-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v4: - Added Pavan's Reviewed-by tag. No functional changes. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index a6ff234c2864..6abe4bef8afd 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index ce7291c68370..24a32ba7157a 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2836,6 +2836,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0