From nobody Sun Jun 14 08:20:33 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462DF30DEDC for ; Wed, 1 Apr 2026 22:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081137; cv=none; b=l0hmuIdYXCrgAj/T99E/BjsMr9ZwXV5MXt+3io+HWIeJUH3ZgROmgmkd3AAnT7FOwH+OtJshvRV+zJ/b491DIgjcdRa1Q+Y1zkntNlu+8gweOBu7S6gaUs+16tNXRYRONxtn9R4/ITDd/8m3pGPcID2dd/F7tAaPkO3st1WpReA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081137; c=relaxed/simple; bh=ivLuBMj3afuxcWbJ4kR7GVNuMbDpAlA6WCS8sfy7YNs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pGyssyyjcLjg355RK/RgMgGF8t+C2VCBjsu9+1uieugq3EB4qLb1tH+ynyxf/qhpf14ys6R5R9xSvG8DLgabDCRWBSJYr/AyWCHYG4roKshOHCr9T+phXrY2qjex9CH7YDlWpJNQfwg8WCTe1t1aMk6Yx2hQgcQkM8Uj9qb0W2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DsZniCGq; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DsZniCGq" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a871daa98fso1400245ad.1 for ; Wed, 01 Apr 2026 15:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775081136; x=1775685936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C+INgdF2y4zYdV9C/6oA6fBsIPWiGFzxJTAQLj9wY3M=; b=DsZniCGqrCLIxNCvtrc5J5ZZVHcCfWhP03PWd0W/DoC/mFKROv9+ehsNwLzW18YfCS UGdC7fYch3YIuWafpHV6cHc4iRIgWudB64k3g1AqINmEUbfdpx+FERhDPf4Rt5h6Wp0L e8jB6mE4IMu5BhvaZuNKw1HniumZCQArtq4NoYZmbX8KbWKo5jMmBcN2NMETd6ek28zH Xhstl3zmH9KO5ORuUoxS8zwX3sLB0d64q9XoBtl2vuEKUfIlij95XktlncIg5GbGGUt1 JtHn+X8nrxq1U85RduFOvxwkz0zwmWA7LxSneRzjhmgRpMZ80bkoGNndWyqoTwihgtQQ x5Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775081136; x=1775685936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=C+INgdF2y4zYdV9C/6oA6fBsIPWiGFzxJTAQLj9wY3M=; b=XTwM+tzvJXgYqxDM1asrX6GfdLmjitRrpVt0e+AK9/pTbssGUNjGmUlYipBEanmpf9 W7vlNY0i6WzSI3gnahrLNFv7kOUFrrRemxtmX3TQEOzYCUBeUZPjQnMQu1rijwthNDhh 3SGIdbYJfohx4mwcPUiapa7KgmYn7VvXEGJ8cQi8TU3HHkfpsqIbk5RGk0hFlYnfbGCL b2EL/VATehyWNtaj5sIwbvpxbltYU+NC2JLO6vRfTeQ/RuYYvy2Q/AV+UkLtIOfkLexj jX1idGAQ7GGLMJ9XPWSEYJVupUhdG/GcsJoh4PkCmyZ1+mg+DWCCAo7H7uH1h6w3J5dx K18Q== X-Forwarded-Encrypted: i=1; AJvYcCVE0Et2IWlQ3X5da8hmaNuO/BMJD84z1xfkGGcvRnxsYzsVmcUUKvyw+ydlIv0+pFpHPvEHegzSufK4Hp0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1XbwTm5kfITwfpbwW3KBtmZMUFGFpOdaQa7Qvz6AFVi0Ow997 Q1WXJtF5E9dBS/I7mQToKlK8J6EoE6p39BN8H2k/L6JFD1gz7mw3mAq+ X-Gm-Gg: ATEYQzxzdvqk/QdS5I3WUQWzBylOpBup5ar8GyJnzz1FBjQ/Mv85+7UJnYS2yUzGmXs Ma4rr0AVYkw+0EIiRePHw0xgkDlDoHnEOpczCXJrgGkl2zV9Ok8Bu2yFNModd9YBxGHpTa3r3Pc 4dKXmdv4St3u5Ft0jM7d49zB4mTMT1yQFmJEeUrGCB32c2NQyWBBbOAgQ33kD/rupalBf4/pBYg 1gjRcrrLPpzyNSpHhO3UqWRE4R6tVnfgDNf7+HgsWMvURuAPuE3g6E4gpapquJo6INKQufVErJq C4CzIs9sKSbzgf44Ju46wyR+PT/86CmkF/9dADN+MhYG9Z6XuamxFLRp/07JBXSfpqTQNQ8oslj jdXnPwNj0iPN853OuxFP9eZSQ5E0PfZlPBOrqJ5DACFePdY6rcyWCbV5ANnGu+Dc4kaHZBdecYG jBMqbyo0aM5J2E48w9I8kZ5M9kpVQzqvJPa4ZLfjN5x0IP X-Received: by 2002:a17:903:1b67:b0:2b0:c90f:44b2 with SMTP id d9443c01a7336-2b269aa757cmr55917515ad.12.1775081135656; Wed, 01 Apr 2026 15:05:35 -0700 (PDT) Received: from debian.killsync.com ([45.116.230.137]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af47sm9050815ad.42.2026.04.01.15.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 15:05:35 -0700 (PDT) From: aravindanilraj0702@gmail.com To: cezary.rojewski@intel.com, broonie@kernel.org Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v6 1/4] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Wed, 1 Apr 2026 18:05:04 -0400 Message-ID: <20260401220507.23557-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401220507.23557-1-aravindanilraj0702@gmail.com> References: <20260401220507.23557-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing cleanup call to prevent the clock from leaking. Signed-off-by: Aravind Anilraj Reviewed-by: Cezary Rojewski --- sound/soc/intel/boards/bytcr_rt5640.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..e4c21c9c5b38 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -289,6 +289,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); + if (ret < 0) + clk_disable_unprepare(priv->mclk); } else { /* * Set codec clock source to internal clock before --=20 2.47.3 From nobody Sun Jun 14 08:20:33 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07BE430DEDC for ; Wed, 1 Apr 2026 22:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081143; cv=none; b=I7IgAKw2zEHVXQmng3wmPvCFzQit4zauwXKxyJCkgvKMobbbns/hePrj9o+DZUs6zbVQMIhxV4LeUg901xaKhtnki7+PVD/Fkk5SPAbmSb0WJSmLY7DYLAI3pnILjLXGRsPv5yd3kR+MlcaHAy2sdIQ1t9QhSDozfaapOV+uKDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081143; c=relaxed/simple; bh=ogWqg6oWczQKeONUP6X+jBTzfEY4XriMHJr6ybPCOOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E7Mm/3MVkh+8uLnJSI7o3quR8jHTVg4K1X7wqbiRZlNojhqJ+zdNdGAeMh+DrM6i0qc510qYX6ncjuNGVpPJCTlsW19BxzLYeJ2/oQTqk/vD6bZ8ZH+mnBd8bpr5eiVvtnz9X5n7lE6z4PECL91AQU+AXskiYVvLu8wFh5i0UHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hj218eHd; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hj218eHd" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b24fede2acso753325ad.3 for ; Wed, 01 Apr 2026 15:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775081141; x=1775685941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PKJ4EBGQNHpCdGraAAnQNk15tqvANYFRUGyQCrvO9ms=; b=Hj218eHdtlRkA6hcrJJUY3gwS2mu7t0xQnTiypBLVUfeIelbJNFubvcihUO0H1UO6t lKTFHWWJBD9sgqlCzLSNJcUdDkhKu2DXiTNkksUBxN3srhDVlYW6TKsCcjTGkfKW2Iby yVp2vqGki991+l5tmup2+qKPBpXhvaLdTCnlwLt3lO+3IUBu11OQPGhO5dofzBBhwT+R vsO4Fn6EIKjtvbKCq3R5NUPbewsoLbxXp93V0FJ9f6zq5BLw7+YWyz+0GTfzQJ0sXu2o 4Gj8hGcw43pS4YOW/KnsKSd/UNb8dgJ4+XJWrkZBGWlkUcXIif/8Vo0tyo81pStZfkKm tC6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775081141; x=1775685941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PKJ4EBGQNHpCdGraAAnQNk15tqvANYFRUGyQCrvO9ms=; b=POHkJg9QckduRWj9dY388/VcDifhAWM3lG28ziXLIpJk69uHXt3I8vJuVQzYbGSV6n CVSR3VLO4vYmUGtNriOeRP2Be/kCpAFsIDgGyp8P99xSMx/xUBsMPe0UfkcFRHg9nOvJ +YUtBbeqXL1HjNgZ2F0WSarCnA6Ix/Ic0Fq4+w4v+hdBwP0LT4V6tFOtg0DpTcHZpXJt WMKkVjzGjoFwpOVTfGU8kkfJ5ejNH/ZvTpjv48pNKb/5ykywqUmnD+yYILBaAhbFqui3 /AvSLq4ReqVT3cFl0qNnYGegCh6ZxGiCEo+SrSadbMVFvBWDoGAvlF4QLvdiI/pTssug ivMw== X-Forwarded-Encrypted: i=1; AJvYcCVHdo6KHpQq+iHBXisrz+K/1VGWCVkKQHdg2lZSZXqoTvN0TO3ff09FkdhnE8TZyLroLhfHR9/PUNJIEB8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzhy5fgAo9Iu7IMdwbrJJj8erNLxETle9ZXi1YCgiG6hxsaNUcR WxGn1OWQhCWHaXkiHcRXl8RxxxPLQFJeNecnm4Ex9BNa1Kc11z3SNlGM X-Gm-Gg: ATEYQzz/CEbNjsn1LUTNzVpeq4Bz19eVfwIVQwZsdhiDQmNK1p1/vh0sJSlc5RQ8HCF MOHzxzQe7PZ51j8X04ywUFCJ0rVEYjNXljM65W+vpcRUTbIxiIaSgXOoAxdKBpAVdR9YTTPWD5p kE+Rhnfca3jE+Kr4rJdXLzNPggCk3XjAl+2/NpafHy/PwwMVAIEaHpZFqSxBRF4XgXycJRN10gz YC97X028qcxfaO35yfYENUdctY4RZq5Xzm3z9WGzxkmpOT/0xL/rzHVJV5FL9egn3nEG9d9IS16 Hc8o4Trrhj8avPzDRQCS6J9nuSODpzK2GIB2V+//aJfjkW3hR0lWiXkte8N9pWQi4+Nc74OhYYu Gm2mD7L0FiWC6ykBYMy9epSV1sZqHnFgi/inqIDer6r0vwtKvAibFmf2/vZhfB7q2l4juFRN7Ng dUiyvODwu/DtOZJnWoAzpMHjTYpnOqxNMZD0BB+5e3rECE X-Received: by 2002:a17:903:2c04:b0:2b0:917c:bc4 with SMTP id d9443c01a7336-2b269a9a34cmr49199335ad.4.1775081141337; Wed, 01 Apr 2026 15:05:41 -0700 (PDT) Received: from debian.killsync.com ([45.116.230.137]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af47sm9050815ad.42.2026.04.01.15.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 15:05:40 -0700 (PDT) From: aravindanilraj0702@gmail.com To: cezary.rojewski@intel.com, broonie@kernel.org Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v6 2/4] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Wed, 1 Apr 2026 18:05:05 -0400 Message-ID: <20260401220507.23557-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401220507.23557-1-aravindanilraj0702@gmail.com> References: <20260401220507.23557-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing cleanup call to prevent the clock from leaking. Signed-off-by: Aravind Anilraj Reviewed-by: Cezary Rojewski --- sound/soc/intel/boards/bytcr_rt5651.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..8932fc5d6f4f 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -209,6 +209,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); + if (ret < 0) + clk_disable_unprepare(priv->mclk); } else { /* * Set codec clock source to internal clock before --=20 2.47.3 From nobody Sun Jun 14 08:20:33 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F49B317162 for ; Wed, 1 Apr 2026 22:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081148; cv=none; b=Th/6dr41PagJ4rKpBbZY/lR0lG4MGpjXY23XxInB7ZoJiKoAHGlrnn5Q37ki/GTNnXnimNwnz9PUbVbmr6MF1rSC33rtj2ryS5fzDlxw6/uNXqHhVBtedNXx0a2o42LTe2cuu7DAQ9LcmNcAnKuVcNUflX8uZOxLfX42VFY9S5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081148; c=relaxed/simple; bh=zUJJDAbtzvpDcOqcmqp+NA8QwnTq2SC+9EAGZ/+/Jt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IyP2tVx7OZdwt9uGQeaa1KlYnZLyPtFPLtOcBuCduBR7qV4l2wt2i3d3VKo3+hm++nQnKtWY+cA5s0mKzLHSbHeL5gcumLahb6GMxNhE0hYP0mYvo+9bz9WMQr1aH5e1k1RGogOSJuzCG+rOoGsU5do7rdFi8VSFgZwUqVeQAKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NXwT7KVE; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXwT7KVE" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ad9516a653so861995ad.0 for ; Wed, 01 Apr 2026 15:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775081147; x=1775685947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I1oyC8Cvd6AWK012n2/G1MqbD1mUbk8DUkYVolymW+Q=; b=NXwT7KVEQPlzUnDSNDokSy8OFX1CKp0wLINV6CjiIE6I+nWcpJOnRq28oUCjdInvBV xau9VP+UUZtEfdXFDoO84W5CMShHVHRXhzQm7DeJrNn2B1lSXXyX7oi/lV52OdFp3D86 6HcDTHv9DfyTRfemwXhe9sEyKIuhSfGSSOdKGsaQ1MyeYdY89eJzl1bI43h5A9rar1/2 sGuu40JuoLc0Uxg5U0daTCwDR2zUD6llOnegid9uOkPHBQVcK6nQV3r4pdjy3mPzWM0W 3FY/1nYpp1SHJZxNRWUnyU6EUpjY61opa99xv1/iZkFUrSfCmTnYEXdv2B9rkNui6Ddg HhiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775081147; x=1775685947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I1oyC8Cvd6AWK012n2/G1MqbD1mUbk8DUkYVolymW+Q=; b=VlSQSEHaiiAgfX8J/eL3n9Fy5uRTd/6aZhjqxco4szZfcmdQfj1sbjkFGSogxM5P0Z TCRtqP2pSdYJZAKs5G5XanWfYDUKjpyvqa7aOr5hFYh57omtfRcXuqdAlmdkcQFFdPIH ghPHlc6f1jdnP5MVQuiBmdw+uEKwlGuXZuw3h+7ZBUE04gPCDpJCVklFz3P+BM2ar5hY 3BzdamqX+rldeChWfcC3BAy39DMS9wMrN41lRIs/wf+E5amdafHNK4Cuq2cPjLCspWPJ KUvx8jGG0RpJQ0mgKXb2qVM2HF341Fy9WRRiMLOE6/89Kqf5c+lMu9I5s44+kKOQmiWa k4sA== X-Forwarded-Encrypted: i=1; AJvYcCWg1mriJyQeklzek7DIVdEjgiDzcFt0GOmnVPzsKCUSaV8UhIoLrtCFyiWIxOXRlWfRdKX/FIuYiCYq/Ek=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2DvajNfGXnMZsMUcniXS9WHE07lDIk7QrJgWTP5sUd5fRiQ1t eblnLFoTOrQADLB4F/QBrtqUawB8CBR7mDj4g5m5EUTxGRFMUnF1WCmR X-Gm-Gg: ATEYQzyrb3lvipiqXR5kQLkNSOAcq3n9EtfoSenJ6VQLOWQ6pzHwUARDICg3CDxarr1 96IRIO98St5lmaALTgOGVhfQG74D9aJIIEp21XbA6kxFcwI2g1pfrE08pfbgo8z3Q5yjRP6hfJn g6CnShfXAm2w40VlRPmkpyZ9myg846v88aMsBMsk0BgAKj1jjJ8hdqC7elnIot4hyEDgrrglZ1o NOh29TkoCc2So22ukm27f/Uod8kMUGj6qeiOqO28G4nhgAJeOwZKKHrxym6VzBJp80xWW9K72iC mQJ/SfpPk1W0YbRMjPx2da3ycEtSbND6dd7m96N4Wb1tPOBpvOEcZpNa5YWciirqBsC6wUOwrJw +W8OKtXioEYKY7dT/z3GL6FBTg7zZZYV59Dgyqwbtf5CcMhfs/A+xcD0uYRJJwOHFO17DpVcKby n2NtSIbVjcrf8Sgrw1AnvdP5mI9j/4ZZ19w2ld/sZVenfp X-Received: by 2002:a17:902:f54f:b0:2b2:54c1:2067 with SMTP id d9443c01a7336-2b269aca7admr50478125ad.21.1775081146838; Wed, 01 Apr 2026 15:05:46 -0700 (PDT) Received: from debian.killsync.com ([45.116.230.137]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af47sm9050815ad.42.2026.04.01.15.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 15:05:46 -0700 (PDT) From: aravindanilraj0702@gmail.com To: cezary.rojewski@intel.com, broonie@kernel.org Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v6 3/4] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak on platform_clock_control error Date: Wed, 1 Apr 2026 18:05:06 -0400 Message-ID: <20260401220507.23557-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401220507.23557-1-aravindanilraj0702@gmail.com> References: <20260401220507.23557-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj Reviewed-by: Cezary Rojewski --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..57d6997eb12f 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -77,6 +77,8 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + if (ctx->mclk) + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +87,8 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (ctx->mclk) + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3 From nobody Sun Jun 14 08:20:33 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C593317162 for ; Wed, 1 Apr 2026 22:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081154; cv=none; b=svpkHrMQdvOxvxO2VyAkhPSUtQzLCYjuqjwdf9AW+TUXtGEcR0FlAILQbeFlCcK/gN3g6E8dJ4fDzH7W/fcypujqoNYmRlRQefJQuRFnbViAXPaaypLUanasCFICKAaH8Z7nP9LkDjj5ONpxUPB6V81xPrxK7vSsIjUl85Zgjwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775081154; c=relaxed/simple; bh=iIrVilUWy3IXBnDjBVEDTRUew2qBPGHsp0NzPLbLtG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JTryE1eEc0vtT155Uo2H28sTobOhpuinpqqNnTxrxxl3VFHbe0lb9U0tJhkh7YjaIjZn1sVen4IIthsmI2zgWdi9/UoDEB3gDI/fW6sN+McwhbfHHeTvT7eXZPo1iwvEe+FVgwk5ee97gy8CLls39y1iaSIDx+oZeI6NSCPpr3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fLOm7Owj; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fLOm7Owj" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a871daa98fso1401935ad.1 for ; Wed, 01 Apr 2026 15:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775081152; x=1775685952; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i7UpYypELbP7D7tEyGcylQSQOLvrWO0IaOkYBSuYTm4=; b=fLOm7OwjuUbesVIr72jOljqM68QmA1znE9M8AtBnphC1HiR0KbT43GA9i7Y9l1Pfmx EhuXaK6raCbrkiMXWFzCfuLxKQJ03vvkTz9FpKPk6ylb18YWRRtbxLDBq2Lsi+dU4UFP 2xlkl06QjI/q5eIk309LoEGqCQv8LpX3Yc0+fhHr21aou4vuWFUeYgiBHKYx4p4pinnf sj5ZONzeo5bcb+pgKnsL2mDJBpO7+sm/Fy4QyqIbanFWSp6gTFhdOAf09ZwU2RQ+3PlM +wNRKIu6YBzwXGnGbrusOCo/1JQyahz6csCLzPo9kmY3m2hhW7yndY0GB7Tdd166V7UF w2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775081152; x=1775685952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i7UpYypELbP7D7tEyGcylQSQOLvrWO0IaOkYBSuYTm4=; b=Cw6csmuUP08/eWeym8uzHt3ekS9MaHlV8kafWnUW3af0icdnnKfbWKqFZzDaNFVhmu 1cbXzJpnLuoVkWpmxv8SkZYPMsEO/WKtRMqGInGAk5Zz3R08Ia+ebGRtZ7qA7rXTFDFX 770wwifF5d4L638Mxe1tHUM25pO4BX4J1xNQqkGRE0fYAeGODZ2d6Obcp6IC8ZjX1tKY eyE+RgWnB2e1GCc06m6kAlLF1SnedpdaqIGrpGgahHXJ2Izcw7bSxAsR7c0rVIKpMaw3 4rOM2RWdZJnFdzXVyfW0M+Ts89ZYu9+E8Pm8UJVTofYknTb4j719CdDanIwpn6adSXXL g4Qw== X-Forwarded-Encrypted: i=1; AJvYcCWPSm6Owa2uZLLDltb0dwB7fbHQ9G6mmfLMcFNNVKQe9T3Vqn1MJQRq1PlZR7Oju1KAD6uVRZAUHiavSgM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyrm/WfEsvvEWFQhJhwcWhg1QkGnB8iguhGWCTFgkTZcon8zZ0o lXzkp8PjxpBWeSMhL91Ina74tkkGRDEvPy+RTNmazHfG7Dekpu/p7se0VSIX+yAP X-Gm-Gg: ATEYQzyMLU5D7a3EuAGnM26pNNq7rf5kxUtaecgRb1enk6LgrFw40PYv+yaklcUHdzC omz7BmBvNhEqxFCv3lFTVQOkNG1+9tyGmKJVyIjsYoQHlYUZLflcj2TECBK3zzMcmEycrAFzjkI 7SAj2ku+neGQmqzCE2TveI8Gl7sqPr1dWH0wPfnkBErSLCYXTG/521s8L/ahiEFTEkZXDBJCu8o H3BU4F7J+EDKlhL5a69TCfw5ndHDdn+vDNpVko0XQKwwD2DkXMv2rCkv3wT+NRinS4Qy24iJAMq BfWquCjydoQfDS1VsXLNmzaV6qUEVLAIEqGAXhYkBsH6svdInUqNXiP9gr5K95tKEcemRdiUOXJ sbcI/rsuz5HTD6mevZNhWn9cODzd1crDw4WyuiQgHUQ5ogGnFzQoCSdIU+hmEF1aGjPi2vu3g+o EX1T/HgtKrF+ELDt35x7BH0rXU12OWs2iUCzzmxSwaT3wC X-Received: by 2002:a17:902:8647:b0:2b0:ccc9:dc2f with SMTP id d9443c01a7336-2b269ce0852mr44751675ad.47.1775081152438; Wed, 01 Apr 2026 15:05:52 -0700 (PDT) Received: from debian.killsync.com ([45.116.230.137]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af47sm9050815ad.42.2026.04.01.15.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 15:05:52 -0700 (PDT) From: aravindanilraj0702@gmail.com To: cezary.rojewski@intel.com, broonie@kernel.org Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v6 4/4] ASoC: Intel: Standardize MCLK error logs across RT boards Date: Wed, 1 Apr 2026 18:05:07 -0400 Message-ID: <20260401220507.23557-5-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401220507.23557-1-aravindanilraj0702@gmail.com> References: <20260401220507.23557-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj Standardize the error logging in platform_clock_control() by adding missing newline characters to dev_err() strings. Additionally, include the return code in the error messages to assist with debugging. Signed-off-by: Aravind Anilraj Reviewed-by: Cezary Rojewski --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index e4c21c9c5b38..40da3eea5fa7 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,7 +285,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 8932fc5d6f4f..62cb4856c797 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 57d6997eb12f..fd4cefd298d2 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state: %d\n", ret); return ret; } } --=20 2.47.3