From nobody Mon Apr 6 16:47:31 2026 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05985175A79 for ; Wed, 1 Apr 2026 21:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775078300; cv=none; b=swdnQEtU0sdLHYN0vQ/Np5/7w8n+ON3lYLWxYMw/3GrYt47WH8qnKXBxveLRN7IozJ3GUThH3eoJ+h4hx+7r31ippibJA36NcZ++kRvgRH8BjnrfR7gKjglcm79aG3CSsJ2OScnBKVSGrNZt82xiRu1IRNjbxUGAzs3c8eXOCGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775078300; c=relaxed/simple; bh=rOAsQakjm6L2yJ2O1p+nZxMaYBvl0H8UPO0JxI0NUp4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=EZi8+HnAmsURVQ2mqFOlYdrEfbc3fwX2GcIOplgnIIYoFsbQ9ovP/uVfkopltc43w32W61Es3t3YtNdWq23G0DLLyXGiH2Df3ibECJqpYsJaY9BJP9u2ASlNxbVsVEte1u96XH1m3SGD0iIkts1gF4vC9b+WORilz+2uVsyhMFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C28B3571E4; Wed, 1 Apr 2026 21:18:11 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf03.hostedemail.com (Postfix) with ESMTPA id 4998E60012; Wed, 1 Apr 2026 21:18:09 +0000 (UTC) Date: Wed, 1 Apr 2026 17:19:10 -0400 From: Steven Rostedt To: LKML Cc: John 'Warthog9' Hawley , "Ricardo B. =?UTF-8?B?TWFybGnDqHJl?=" Subject: [for-next][PATCH] ktest: Store failure logs also in fatal paths Message-ID: <20260401171910.2cd687a2@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: kcgz4mwaj83sn6gdffkmhssobcqyjmib X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 4998E60012 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX18vHqjg+yMus84wRoBptxN7UsjJGSWakNs= X-HE-Tag: 1775078289-698622 X-HE-Meta: U2FsdGVkX19LBu5YWWWxD8ltA1EHMPA1F24hhyCmN1moL5XTbFke9Us5RjI57LEo9kAhf//eu9heps4i0dYaLpz4T22HAWXTKGqb766CxaCLcwJ8oxyUDPWtwU888FFRCY7sUtYvKH+k2jguoPaNjaQM/+DhSAw/gpE2epwNHgeliGpmGGSQ+xQOeLNPTjbk/zwiUjGuuk3yN66kE2fVtbNT6lFStQZHiT4Ckr7NQBGi8pkXwjD5zg4WS+w9LCLU9Ex4m7nGdgUH5RAYvW4Upf2VTV6peaHHBF/xjA6ddhuNLgReZnpYQ+lihP1qwO2xOsp3VPRh0ZSfUbg3CirEvjRwVMifsb9tUk1hW6SCWzA1qnFzOcW3nnI6niAzUYiryn6H3kbLpPF5ODauLPMOu6KZrb+WzyKqsapUlTIGyHZ9323Jod9r4q+97Paq4QfQI9a/dU5x1rZXBWPNmLg+/wiAGukWbdDOhdDBufrEt9th5SMwO23Qe2ddDZTHlFcnZPWygFCSkU3td61xQblHrK6jspYv2m5yyANalZLAmxSI9DXUR9aNFcBfTRgNaSKw8HXVCK1BbHpdT7QEHDOoGicfqs+JPV+n Content-Type: text/plain; charset="utf-8" git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git for-next Head SHA1: 81fca7087466bd81fff7100d824b2c788edf7a97 Ricardo B. Marli=C3=A8re (1): ktest: Store failure logs also in fatal paths ---- tools/testing/ktest/ktest.pl | 5 +++++ 1 file changed, 5 insertions(+) --------------------------- commit 81fca7087466bd81fff7100d824b2c788edf7a97 Author: Ricardo B. Marli=C3=A8re Date: Wed Mar 18 16:00:43 2026 -0300 ktest: Store failure logs also in fatal paths =20 STORE_FAILURES was only saved from fail(), so paths that reached dodie() could exit without preserving failure logs. =20 That includes fatal hook paths such as: =20 POST_BUILD_DIE =3D 1 =20 and ordinary failures when: =20 DIE_ON_FAILURE =3D 1 =20 Call save_logs("fail", ...) from dodie() too so fatal failures keep the same STORE_FAILURES artifacts as non-fatal fail() paths. =20 Cc: John Hawley Link: https://patch.msgid.link/20260318-ktest-fixes-v1-1-9dd94d46d84c@s= use.com Signed-off-by: Ricardo B. Marli=C3=A8re Signed-off-by: Steven Rostedt diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index de99b82d16ad..112f9ca2444b 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -1635,6 +1635,11 @@ sub dodie { print " See $opt{LOG_FILE} for more info.\n"; } =20 + # Fatal paths bypass fail(), so STORE_FAILURES needs to be handled her= e. + if (defined($store_failures)) { + save_logs("fail", $store_failures); + } + if ($email_on_error) { my $name =3D get_test_name; my $log_file;