From nobody Wed Apr 1 22:00:04 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBD9C30B532 for ; Wed, 1 Apr 2026 14:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053888; cv=none; b=l4b2lx2Y3m4m4MmI1Vc5oqs03pCCEPyp8qusI6Bw2fNsrnD52PaVRiLTCQkG7Ju3q6+MPgWqSHFbldU/DRrjNRJZds2JTrROIdYp7WdHZjH/8pVVSuqKB47037TfylT7Vdob9COXtnSrBvi1T0zjk3B58UuPQFY7IWQC4FaHHHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053888; c=relaxed/simple; bh=8T68ciFzv9ByAxgjyQbrWL6zyFvUylJ8zF5UcucRsJg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WQi1fi/VSot+y3qQNeQe4pJOHXI/T9BY/upoZq83JAyvSXnfY1g0iorh5RMIyLJGmnfOCVib4sf91ONwG2+1CUqqjKX/bIg0p0QjxRX3Z8nEEdIXgnokIobQkNuow1dPiWKrvXpvJin18nkPkZE/QWkHoakv+q64S4Tp6tVnTNE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NyAEPi7k; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NyAEPi7k" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b982b0889d8so852119866b.2 for ; Wed, 01 Apr 2026 07:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775053885; x=1775658685; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3kk0t0a+MKlgW0hq41owgJBjPy6XE8mL2ApTeI5SbiM=; b=NyAEPi7koFJ+0CM+TEGQtashimklFhPnd5Qwf+tnZ1AmWiahXInDZFGMvReMjV2+ej PZDwnk1H8guZt3Q744zEye68uELkXQhVcbD4l6gcrcxXpQ+wKJiZePQKUmQPq2g80LwY vWbCLrxyTmAYkKQYagLBO6XDnYyDbviPU0wBOdEV4jEVelAXVG4AEOZ6VdVPuIltRenO EPBODQVA83f6ivKUX3eBlMh9OgG9yVGUULOGlQ42N8Ttn14R9ZzK6Wt9i5NYH2cRVbyw 13hYmOf7XEgU2UHWCj8LIj8kmTF5aSa4z8ZUfWcjGDVZjJN28I59JQTkcoEKIWP4cD2N RI8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775053885; x=1775658685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3kk0t0a+MKlgW0hq41owgJBjPy6XE8mL2ApTeI5SbiM=; b=Nx7FrHxODTXduJGxwJPw73Kz1gj/hbSQ0TWa9BZlOl3DMgZ7opzvbthSgetRJekEkB 1eGFPy/IQTlb5brxbXFFhmguHlykjrb0byKbxenT7i1h6hjmf3NCCR6osDllLlDOysNh lJKrcSi5nn9FqtTXDQU7GxNPSTfpTOaOzxQpZoMd64Bk22DbLYpRKbaLXhElhzEfVVmU KTbUCdF2wMNtIgXMkp4okxE6RVpkrnNiqEsCTWI4jkstVbrw9qyazJ0LBOQEBuDYMDVI qbunXfmdLE/GAHkhPPepY/b/en/tebitpichtz37yieC9SHn2AiDZQh4LV9OLq4XoZAK AZhg== X-Forwarded-Encrypted: i=1; AJvYcCWUEbfaGsLBFgYqOfCyFgAXBLopzNEZo8saeltDHokLGcEQMy4qF0jyfG0RqydWnZymViRvf+OtJHnUht0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Z7Auw6DvP0MviL6Fr9JHahrPRNJdj+Mzf17gXFUI2GabhFwR 3GyvT/A1xEDXfzHYLJxNO+Tij9k7Q2MUftGCQ4bSRrfnEDlIz/73Ulpc09Mt7QEZ18Q= X-Gm-Gg: ATEYQzwY3J3fiHERQ57ZYSB4KBfPyDs9aKb8PNDMaqB3JiHiSAAdfYHVzny/0iVr/qk UaQtfIy5B61fZlAsDgrngK8DcEtamHR8r7O4JKjsz9aJgfSn4kSNIW8/yXTRzGpT0XUv50bW5ED ZOCzzGlYs7ulsJJbut2/jE4hnJUwV/PW14nshfFc9UtZa0aAwi9NdqXWYz4M3R+S5QaRT4a4QkG LuEPPyo2T8Xag8OeR7lbBabYXgl5Njl7w7t1yY/H7AAJSyvDfqd9We8pclsX0AYs62K+yXlqnxB VvzScstLJTHniurkMLs0CUHIzz+jdJHf6Oma4+4iYWzI/eDwRAuW1CWfJhu9g5BnoL/I6jhx0Xe Qdo5Ue9H/ozMSjJ56a/UgInOpT6klb+QFC5NQplh0HKr0+9xi64kJlshvEfMLqiF+1+99y/mYda soJ0oLin/JW0KwMSbxsdCeSq6EKZzUOXUBSQToSBTCmfhnxd2PFrthM0XuZZbV8A== X-Received: by 2002:a17:906:4709:b0:b98:6a8f:7916 with SMTP id a640c23a62f3a-b9c1390270bmr211946166b.15.1775053885105; Wed, 01 Apr 2026 07:31:25 -0700 (PDT) Received: from f16.localdomain ([121.167.230.140]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2427658e4sm199047295ad.48.2026.04.01.07.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 07:31:24 -0700 (PDT) From: Hoyeon Lee To: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau Cc: Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan , Feng Yang , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v7 1/3] libbpf: use direct error codes for kprobe/uprobe attach Date: Wed, 1 Apr 2026 23:29:29 +0900 Message-ID: <20260401143116.185049-2-hoyeon.lee@suse.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260401143116.185049-1-hoyeon.lee@suse.com> References: <20260401143116.185049-1-hoyeon.lee@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" perf_event_open_probe() and perf_event_{k,u}probe_open_legacy() helpers are returning negative error codes directly on failure. This commit changes bpf_program__attach_{k,u}probe_opts() to use those return values directly instead of re-reading possibly changed errno. Signed-off-by: Hoyeon Lee Acked-by: Jiri Olsa --- tools/lib/bpf/libbpf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 9ea41f40dc82..536c19c14d21 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -11835,7 +11835,7 @@ bpf_program__attach_kprobe_opts(const struct bpf_pr= ogram *prog, offset, -1 /* pid */); } if (pfd < 0) { - err =3D -errno; + err =3D pfd; pr_warn("prog '%s': failed to create %s '%s+0x%zx' perf event: %s\n", prog->name, retprobe ? "kretprobe" : "kprobe", func_name, offset, @@ -12825,7 +12825,7 @@ bpf_program__attach_uprobe_opts(const struct bpf_pr= ogram *prog, pid_t pid, binary_path, func_offset, pid); } if (pfd < 0) { - err =3D -errno; + err =3D pfd; pr_warn("prog '%s': failed to create %s '%s:0x%zx' perf event: %s\n", prog->name, retprobe ? "uretprobe" : "uprobe", binary_path, func_offset, --=20 2.52.0