From nobody Wed Apr 1 20:37:22 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628AB2C15BE for ; Wed, 1 Apr 2026 13:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775051379; cv=none; b=gtwWjP7QW4BSd7ioMCTHySbbBkrFd/oKEisVzjrOC3zRAycMh+OtX770TnVF+WDqxuiy4BSKHsHi0j+y1Z1tLHiYKJCC4mjeUJIZFUDTwja37AHZvjxTio9aIUo3UaJbrL/KN+onOXl//RDW/m4JzFXJPv8PTwQSWCtqvNe2igc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775051379; c=relaxed/simple; bh=hgeoXRZ5cSNPAxt3Egkd+p+yTdwDhoSYzz++GWpOuak=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c22sk64oMKwq+OYsU+gH6TTzzFxHVtm/TM/1Ka4MXVQ8LefNgeLq2MVXY5IrICaNv2DOhwfSQyHLSZr6O0eQ+6SJ9znwDRye7c9pW5RwrJt/o0wbuhBDFYKA+tCHqMOv8E06+9+LXYDRjGxeVysfjkT3zGKUMxxkAdA8mhkeegY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZiCAwXSW; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZiCAwXSW" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b0c8362d93so41453835ad.3 for ; Wed, 01 Apr 2026 06:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775051378; x=1775656178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WUEKhgyUH+EnaEpKP6HMgut1APyt2IvzBtqO/UudEAg=; b=ZiCAwXSWzm8uZjGm4DcVhn1D718hghhJvMWaYWSnGOtiTHKMeVSRqb31f+njMiRYFT 27GxXzKLYc9IivVBowY9QwXd4MV0Kx9zHB0vH/DyPU6ACbgFx2f8dEVYehBOMxLLkKwT VPSeCepbVd/0P6LQ7j8RCvAS+B8n2Z8s+gii32wkD9FBkILJX3rnAG5B66ngBICx5Cp6 z/yRJ+LVPSeaSnoIDld/NZXBp90XF3v41fpz1ITw7LQbTeY2VSF1VSa/hOJ7j6HI9QVv AKariArmV27z7rCPd9TNBJGRytPOZAXzzdPFiGK+HqNta4hAyEGzOm5Ixv4trZbHfd9j OT4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775051378; x=1775656178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WUEKhgyUH+EnaEpKP6HMgut1APyt2IvzBtqO/UudEAg=; b=V2Rwg8hSt6RlfDYK4Fhurmn4vkVQtQRY64FgG4xQfX7TW4kWsJNfmabQ3nqcIDH6DZ pMUYNZe5YB1bvFfD7iFuJkfAVWbxgIQIX64NxGfcaT/e53QJ+0KZpyQn/NENUsRzzYPQ IoZTT0WAahvLtIXGr54FlXq+4I84qTzkKO3/NjWCt7lkFk07zr6z/qenoFK3etuPIX4f LE8mYhKmwhHKiuPjnhtjWhUQkYmyG/viGiC8BGlloV1jOLLLBrYah+M0PMxH1rX6B7A6 v4QPRA3RuSoZ1Jjo2QRPUL96Qm+OdW5Y9AWtxcWejIdMeVRBmkqVFbE5moN7S+VN/+Ll DwIA== X-Forwarded-Encrypted: i=1; AJvYcCWW932FV4ucSjooa8j5NjS+pCTTFSjel3iR8KfLBOtKY3rvw9dPTZqgsxa2C67ES1hlhb8er0XTx76eOaA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2/mfF+r7sy/1BhE695lpq+QDRlZocFuch+gJjTMp5VeU3NETy grU+/BdNwDnEvOfRvR78O7/ONNpDdYv1hI3iUgo7kWBWPYpp4RQpAqXJ X-Gm-Gg: ATEYQzxzT3xrd0BXmlREFiHpj99Vioc9tmR2ljcKhZG+le54rueh61bvT9Kwnq8l66f PcptOxjv7gTOa5MGOjOT+nbjMTW8tOlcPB0kAfSeV5bLM9NSmb8utzEtiPQuxJleb1tDJfw8eyc O3W+9/bQSY8cxDEZ0jDnu/XO37FzQ2EuH/2p2NomYg2Pf/IaKAk4JhDuIhgFzFRLV0XzKCkE1VO /+iO8Lz/l5zwXlnECYVP5uKRC4NPJhtJ9Ou4x6IMCNKoBBrtKjHFU7c14TJZnT8FZST1oMLuiP/ v4fHchE5+SPcoHkseBbWr4/octlamAyEGbLr7cCR5/VRq/ycX13foH3jEqtEmHFuY5BqbUo4qwR bzYq5pFO6k9S2mEw2k5OsIn+LB8vuI0ITkh7Js090HXpxT8IAGgRAZX7pMyeCSkyFOfz9ngGuUJ 90ENS/qt/ZIls9YFZEKZouTlBj+C4gsg5Jv/kyBxFqP/NQRLR8Ohi0/vF2nSrjv6IfGUcg20g+N 1+NoQ== X-Received: by 2002:a17:902:f54f:b0:2b2:4d36:7ba with SMTP id d9443c01a7336-2b269977a8cmr33888775ad.0.1775051377662; Wed, 01 Apr 2026 06:49:37 -0700 (PDT) Received: from computer.goose-salary.ts.net ([2a09:bac5:40b2:a82::10c:35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b267ec1615sm36300935ad.57.2026.04.01.06.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 06:49:37 -0700 (PDT) From: Varun R Mallya To: varunrmallya@gmail.com Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, martin.lau@linux.dev, mathieu.desnoyers@efficios.com, mattbobrowski@google.com, memxor@gmail.com, mhiramat@kernel.org, rostedt@goodmis.org, song@kernel.org, yonghong.song@linux.dev Subject: [PATCH bpf] bpf: Reject sleepable kprobe_multi programs at attach time Date: Wed, 1 Apr 2026 19:19:21 +0530 Message-ID: <20260401134921.362148-1-varunrmallya@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kprobe.multi programs run in atomic/RCU context and cannot sleep. However, bpf_kprobe_multi_link_attach() did not validate whether the program being attached had the sleepable flag set, allowing sleepable helpers such as bpf_copy_from_user() to be invoked from a non-sleepable context. This causes a "sleeping function called from invalid context" splat: BUG: sleeping function called from invalid context at ./include/linux/uac= cess.h:169 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1787, name: sudo preempt_count: 1, expected: 0 RCU nest depth: 2, expected: 0 Fix this by rejecting sleepable programs early in bpf_kprobe_multi_link_attach(), before any further processing. Fixes: 0dcac272540613d41c05e89679e4ddb978b612f1 ("bpf: Add multi kprobe lin= k") Signed-off-by: Varun R Mallya --- kernel/trace/bpf_trace.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 0b040a417442..af7079aa0f36 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -2752,6 +2752,10 @@ int bpf_kprobe_multi_link_attach(const union bpf_att= r *attr, struct bpf_prog *pr if (!is_kprobe_multi(prog)) return -EINVAL; =20 + /* kprobe_multi is not allowed to be sleepable. */ + if (prog->sleepable) + return -EINVAL; + /* Writing to context is not allowed for kprobes. */ if (prog->aux->kprobe_write_ctx) return -EINVAL; --=20 2.53.0