From nobody Wed Apr 1 20:38:03 2026 Received: from outbound.ci.icloud.com (ci-2003i-snip4-8.eps.apple.com [57.103.91.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6162472AE for ; Wed, 1 Apr 2026 12:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.91.219 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775048043; cv=none; b=pF5ol5aksqMn45QFiRK+MkSDj9hYWHHxvVIY9dkR712IkDv09t6BcSbfm1ApXaDmXmnif49ZctqPzzjygLxNxyGdA1RSDlPvJ1U/tZ0q9kggVxsEP2zp2hOJ6zYA33AMt2xu0KyxZEFtohpcxZY20rySN8W8tKD+PX7j5CWIQso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775048043; c=relaxed/simple; bh=Dmlf6Aerb9vaonhC8E2LqwRswFNQOGuVJJobPXjEv4w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Yc0PQHoAf0iKM3zqdRvYtaaFvtNVyozXO03VthFJwAZcfEFjiV9pL+e5G1+Oo+u+NOsrOTXHbJgTYTbx1P3+LhsBZZdoNyvjh7nlt6P5f9GaEsB9Em3luzy3xX552qBzbSfz7tocxiu/nj+6yBu3FaUiZRYCoDlSujUTZP5AFyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=J2L1+Jwj; arc=none smtp.client-ip=57.103.91.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="J2L1+Jwj" Received: from outbound.ci.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-central-1k-20-percent-0 (Postfix) with ESMTPS id 86B30180015F; Wed, 01 Apr 2026 12:53:58 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1775048041; x=1777640041; bh=wgtdszrSGtBHrmxfWNeS1I+CHUblEXIUyM1IV226OlI=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=J2L1+JwjVv2FTH8SRqRsGQQgHYT1yQac/Ir6k/q+sJzvGeI2a2PJVSI6T8nh0vlK9Rq0Nl8lNR9gZE7bxrU0xbbmwd7fELyi1msEvNtf/wQmnH7AE24INkfaoP/VXlgKLt6g67LbE3FcsdNErCfbx3SyH0YECERThWTzi+P6Zvuns7FOkxpmTPVOxDLq3jAgHuF+td/o5RkBNQr/676iJA5Zh6TjCVTb9oxoNtDhjPWtqju9MgFOR83LRomcly8GzhWLyhS62XEXKPryRb4etofL6cjtDsMPyA7QGaKjpl9tAa3D1ZhWMprDvowNSpphrLr7UWfYP7jFXc3IfiiFmw== Received: from nixos-thinkpad (unknown [17.57.156.36]) by p00-icloudmta-asmtp-us-central-1k-20-percent-0 (Postfix) with ESMTPSA id 1837C180009B; Wed, 01 Apr 2026 12:53:56 +0000 (UTC) From: Hadi Chokr To: gregkh@linuxfoundation.org Cc: linux-staging@vger.kernel.org, linux-kernel@vger.kernel.org, Hadi Chokr Subject: [PATCH] staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep() Date: Wed, 1 Apr 2026 14:53:53 +0200 Message-ID: <20260401125353.80163-1-hadichokr@icloud.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Info-Out: v=2.4 cv=OYyVzxTY c=1 sm=1 tr=0 ts=69cd1568 cx=c_apl:c_pps:t_out a=2G65uMN5HjSv0sBfM2Yj2w==:117 a=2G65uMN5HjSv0sBfM2Yj2w==:17 a=A5OVakUREuEA:10 a=x7bEGLp0ZPQA:10 a=r945xf9LNZYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=v3ZZPjhaAAAA:8 a=xhEBv-n3a8ZqHk2sTh0A:9 X-Proofpoint-ORIG-GUID: MxzZ2wxv1-GgRUee0ZY_VAVTZ0PIE4A7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDExOSBTYWx0ZWRfX+10uCXg/hy2+ 7PNs9wlhmGJb9CXpX27SWtuagAb6A2YH9ujmEoaVcp+b+waKnCTj1h8hGoTJW5QVenqeVXMQMe3 BW+FGQS/CxEgJrr9ft7lvL0dFhN2LLWdGf0tK+mftmvRElqBS05ILyjB0l2GOSmenoxj2kxyyAg bCHeuxEIMK0F/BeEjc5N5pljl6itYIAoKG+QQUUEs329GKT5IlAFdtSncpYcm8NEmaWnX/CLI5B KBhTDOpygTa3qhXbZWNdolpjr4yMkHDgAi3N6Ri4dA9x/HbK5Ywk4wYTiUpcLXLD+o44MiEVK4g 5WzY/nP93oKzj87yMgnGiczQakm4M0PEX8x5877/SVOcvqpo4xwzSktVgrtln0= X-Proofpoint-GUID: MxzZ2wxv1-GgRUee0ZY_VAVTZ0PIE4A7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_04,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2604010119 Content-Type: text/plain; charset="utf-8" The overflow checks in skb_to_mamac() and skb_to_mep() are always false: mdp_len =3D (skb->len - ETH_HLEN) + MDP_HDR_LEN =3D skb->len + 2 mep_len =3D skb->len + MEP_HDR_LEN =3D skb->len + 8 Remove these checks to clean up the code. Signed-off-by: Hadi Chokr --- drivers/staging/most/net/net.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c index fffdb60cd230..07fd18e9096d 100644 --- a/drivers/staging/most/net/net.c +++ b/drivers/staging/most/net/net.c @@ -80,11 +80,6 @@ static int skb_to_mamac(const struct sk_buff *skb, struc= t mbo *mbo) unsigned int payload_len =3D skb->len - ETH_HLEN; unsigned int mdp_len =3D payload_len + MDP_HDR_LEN; =20 - if (mdp_len < skb->len) { - pr_err("drop: too large packet! (%u)\n", skb->len); - return -EINVAL; - } - if (mbo->buffer_length < mdp_len) { pr_err("drop: too small buffer! (%d for %d)\n", mbo->buffer_length, mdp_len); @@ -132,11 +127,6 @@ static int skb_to_mep(const struct sk_buff *skb, struc= t mbo *mbo) u8 *buff =3D mbo->virt_address; unsigned int mep_len =3D skb->len + MEP_HDR_LEN; =20 - if (mep_len < skb->len) { - pr_err("drop: too large packet! (%u)\n", skb->len); - return -EINVAL; - } - if (mbo->buffer_length < mep_len) { pr_err("drop: too small buffer! (%d for %d)\n", mbo->buffer_length, mep_len); --=20 2.53.0