From nobody Wed Apr 1 20:45:44 2026 Received: from outbound.st.icloud.com (p-east2-cluster6-host1-snip4-1.eps.apple.com [57.103.76.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 335564070EA for ; Wed, 1 Apr 2026 12:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.76.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775047350; cv=none; b=EEWMBYQSHdw2l89o63ISWn/1tfP6AQlZNtRG8hug4jQf/BSSy1rOFppZNYknYahmieXRvuS/zfjN9pTwxMwOr8dw/Dv23ACzhfRfve4HvKeO66GiPUNQ1RaLpzpnfcZL4Pxl38GbnER+Wr9uAp/QvHfLAIWgh1dWX5XW0eFesY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775047350; c=relaxed/simple; bh=Dmlf6Aerb9vaonhC8E2LqwRswFNQOGuVJJobPXjEv4w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ykq/fVrF+li8ow6xjkyRFmp1KI8vZiFBwSi/VhC8HBF0YW03Wk5XAbR5asnJAwZ0Pr8HHl7B2rs6sPBh5GRm/YbfifCB6nFwUKswmD0sOvP+NW495YNRM7UF+5ObPhrIuWs/RBY3oKYjQitWUhLF/919zYneNuVmpdOmPBW6X3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=bGhK83xa; arc=none smtp.client-ip=57.103.76.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="bGhK83xa" Received: from outbound.st.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-1a-20-percent-0 (Postfix) with ESMTPS id 023261800F87; Wed, 01 Apr 2026 12:42:25 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1775047348; x=1777639348; bh=wgtdszrSGtBHrmxfWNeS1I+CHUblEXIUyM1IV226OlI=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=bGhK83xaUh+qTdjmP/1c+/nPAQquD+L/n4rVIiXObRIHfj2iXfgW+fLVg5y48nr7tCjU8Ycp57ei7zvDi16DtC+oc9C6icy5XlNqIIaa7as73Be5ad7Ng2CnzAWdp1B4b/xqxyGRsmMuuaLGxL53A0CMe6/YJ/xSoToJAWRAOrqCPeecZ4HaIj9R/W0+rQ7Ge/lproVveM5ff/g46RrbZT4K553y30duALk3t1T7O8Cn21LrLhmvfgWHVR969HtFQnhdANTNTLftWnLyEKx2bqFSPETq16AyYlRfFLtxX6T/BV8PB6a46QmeKiyMvGfxgEociMXVmmjyeIVLWCx94w== Received: from nixos-thinkpad (unknown [17.42.251.67]) by p00-icloudmta-asmtp-us-east-1a-20-percent-0 (Postfix) with ESMTPSA id 5E2791800123; Wed, 01 Apr 2026 12:42:24 +0000 (UTC) From: Hadi Chokr To: linux-staging@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Hadi Chokr Subject: [PATCH] staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep() Date: Wed, 1 Apr 2026 14:42:20 +0200 Message-ID: <20260401124220.78930-1-hadichokr@icloud.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: GnXU1knae2HIV7QnLYSXLrX15Xm4WvcL X-Proofpoint-GUID: GnXU1knae2HIV7QnLYSXLrX15Xm4WvcL X-Authority-Info-Out: v=2.4 cv=fuDRpV4f c=1 sm=1 tr=0 ts=69cd12b2 cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117 a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=x7bEGLp0ZPQA:10 a=r945xf9LNZYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=v3ZZPjhaAAAA:8 a=xhEBv-n3a8ZqHk2sTh0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDExNSBTYWx0ZWRfX5Y6PVVqLfTIp DMfTgvlqbFRjsoKKo1ASeUHJWLsO0YJufV/cnzWM7BkHugAqnPet7OVjjHLiOR+oxQnTX+0cY2I IaoRz58DuyvQjwUyDDObxYk2zFRKrjc4uRQiZK9iH69NCRp6GWvhuvBFbYUtv6zKn7QqwjDfALm 7wwT63cxrlTmjlRHgOJrP97SkL/bAWrvIKmKgQflRIqlShc6UrpMeEBs9iPC6qUCsPiMCEtKRR/ aTpkYFSvt9gwU/xE1tLbyqyaNHLc2OF9XOgSg6RWPB/SSD1QZquhz3Rrqve48BhmlzVCpEundz5 qRyEQW+j2Rogyu3FnhH2odTgzZVCYRC5d3k6ugGNEAXINjsF+oVEGwH7/B+PmQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1011 phishscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2604010115 Content-Type: text/plain; charset="utf-8" The overflow checks in skb_to_mamac() and skb_to_mep() are always false: mdp_len =3D (skb->len - ETH_HLEN) + MDP_HDR_LEN =3D skb->len + 2 mep_len =3D skb->len + MEP_HDR_LEN =3D skb->len + 8 Remove these checks to clean up the code. Signed-off-by: Hadi Chokr --- drivers/staging/most/net/net.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c index fffdb60cd230..07fd18e9096d 100644 --- a/drivers/staging/most/net/net.c +++ b/drivers/staging/most/net/net.c @@ -80,11 +80,6 @@ static int skb_to_mamac(const struct sk_buff *skb, struc= t mbo *mbo) unsigned int payload_len =3D skb->len - ETH_HLEN; unsigned int mdp_len =3D payload_len + MDP_HDR_LEN; =20 - if (mdp_len < skb->len) { - pr_err("drop: too large packet! (%u)\n", skb->len); - return -EINVAL; - } - if (mbo->buffer_length < mdp_len) { pr_err("drop: too small buffer! (%d for %d)\n", mbo->buffer_length, mdp_len); @@ -132,11 +127,6 @@ static int skb_to_mep(const struct sk_buff *skb, struc= t mbo *mbo) u8 *buff =3D mbo->virt_address; unsigned int mep_len =3D skb->len + MEP_HDR_LEN; =20 - if (mep_len < skb->len) { - pr_err("drop: too large packet! (%u)\n", skb->len); - return -EINVAL; - } - if (mbo->buffer_length < mep_len) { pr_err("drop: too small buffer! (%d for %d)\n", mbo->buffer_length, mep_len); --=20 2.53.0