From nobody Wed Apr 1 20:42:56 2026 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E116402B90 for ; Wed, 1 Apr 2026 12:19:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775045960; cv=none; b=Tg5dWeSdOlaS3ik4G74SdPfsyi/Q0Nvo3oWikyulI5xZOd+j9ahxZ/IwUIXs0PDMhrzru64ONfHTKA7UfxyLneHXHPpsEUkQVuSFMypXRGm/N7WqVvX2ZJ9g+bJ0zxkn9K04YzyjFygJZIS/sB58jRSeCbvpAo1qu5yPGIUDuTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775045960; c=relaxed/simple; bh=x6WXeSZWVt4a2zYVs/4EbxVlbkdET5QdS7RBm52VSFs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IXeWL4OyGLaVOg04S1w7X/maFji1HMio4mifKzNdUURjj6gi3UcRo9oIssZKq0ZARK9Zy9vezgr4g/1t5+36TCTOg3j8DepFcWJzYFu/LOvD2j6zkBlkK/hIETyo3NovhgHBej2dMdi2mIo0/QV5mJYjCowvcognfp1RioSoVdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gg/dunDc; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gg/dunDc" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-1271195d2a7so2290001c88.0 for ; Wed, 01 Apr 2026 05:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775045956; x=1775650756; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L1OiliMXENpNlUeXTkiwAk5fsKUJbcwISyUwh8pYldk=; b=gg/dunDc3RcSeSpL7I5i1H8m4yCyxGjBHO0Udd7ghkiTeIClGQcwa560BXOPa/oSUJ j//HOZKYYlxh1boky6ROwW/jpdzD9TzXzDR5a4ttRxl0im5Q8AYr/o5Kedw5dfukqVK9 0TeRgMOwgE/uJPR1afQysnjMxIM010J02PPyUrUhx8/RieMYAqIld7iJzmXHakoy55Sr v80m1JUXrQlbT5EGnVcNTVV3AAs+dFOct2Ahwlfddm8gLMOw/JP4fwZYHxeWlceoRAlA tRTZPHUGUcSYaXoo0rpPsY2gTr0NxiW7eYWuuDNfz8owu0JU0gNi7cayNnMAcNmCOaOc gpyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775045956; x=1775650756; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L1OiliMXENpNlUeXTkiwAk5fsKUJbcwISyUwh8pYldk=; b=R3+JIUG5OApK8M3mSNcXKHMIGU7D4TITbR4soYEEdH3Uw0h48LyPwWIltIjqq4cBZQ 37gjgllc3zKctFfssUxRE0YiqQ9Dkua9ZSjG1z8nqnc8vJDOapmtQsdDgxGitgolpoQg 9FR7wZMuKQ34FIME5WQronH0MiNhXdXuFUXFzjkFbAKvwYiyA+qXUI3YEBtWSaw8TL+p sDjlTLmA0Ob+L8LZxx2SYR/mL5qi4gnkE5XT3bhYqzVzJxX2+uZWMTXdwP7yKx3lyb+n fASFy1BHfDclBZ4GfRlo1qD5ufvCLjC4PP3Q57shh4tv8sT3Z5DU5InC8sVA/97XA7k0 cvLQ== X-Forwarded-Encrypted: i=1; AJvYcCW4CymKx2W2fk+k/7y0ESU3LxGoM8mkrCnIDBOrtn4b9dmpwIhVSRM9sWKukdJIEbZtLqI2N9x4BIdjaXo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+bxwB7gN3tmiLERuloD3upuZ0LL16DBZZwyFmxuj4HwtZRWoi ddTlWFffLxqGoy0QfbPlQHyFDPYYZEFaWhvP2VzqUIN4OFgjO9KoY2/W X-Gm-Gg: ATEYQzwCk3zUe4LcbCZNbLWd2e6Os/KJNInCxEATcXybaBjQfPPEItEr8j+kwbQI79A Fj0MpkUiqUoBkUH4hpBFzB3IQI5HLStdmJsnXuGn1JCwaC5WBLddlxerDPb/ahrRMB/ep1zfoV0 eO9uI7//n2R257znqB+wGaG/HCjiCh3YPpq+6CtRaxPP+L1Hbjxk76brxoQe5VT425jh6dL70yu aXm86Jo41rQfx7yXluZnc/aaQV4uQcHBo15ojyOPoGMWed6X9MfGXLinkOoybcLcHSpK3dmmJHe l16pQkXT1PTBknpXYUybB9MP+ToUuRYTZu8ffHmcfBWghaBg2xELQTK/Zgxywp7IQK4M6LQAoyl E4k6Au8fz2vBqYRtBSmLl3PqnDxDFGLvRQbqaPRDMAaoIT5eAH9vlxtlVz5Cr5/jRPaFJh/hTAl HWk/Zz9QOt92HYHpjabXdYai9f6KSAsPya6EcBggMX/UwqZcmumZmDwsj1XOGDPywN4g== X-Received: by 2002:a05:7301:1f04:b0:2c5:721d:99e2 with SMTP id 5a478bee46e88-2c93088eb63mr1783508eec.2.1775045956149; Wed, 01 Apr 2026 05:19:16 -0700 (PDT) Received: from localhost.localdomain (104.194.93.216.16clouds.com. [104.194.93.216]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c8d8776dc0sm2851058eec.2.2026.04.01.05.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 05:19:15 -0700 (PDT) From: hkbinbin To: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, w@1wt.eu Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, hkbinbin , stable@vger.kernel.org Subject: [PATCH] RDMA: rxe: validate pad and ICRC before payload_size() in rxe_rcv Date: Wed, 1 Apr 2026 12:19:07 +0000 Message-ID: <20260401121907.1468366-1-hkbinbinbin@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rxe_rcv() currently checks only that the incoming packet is at least header_size(pkt) bytes long before payload_size() is used. However, payload_size() subtracts both the attacker-controlled BTH pad field and RXE_ICRC_SIZE from pkt->paylen: payload_size =3D pkt->paylen - offset[RXE_PAYLOAD] - bth_pad(pkt) - RXE_ICRC_SIZE This means a short packet can still make payload_size() underflow even if it includes enough bytes for the fixed headers. Simply requiring header_size(pkt) + RXE_ICRC_SIZE is not sufficient either, because a packet with a forged non-zero BTH pad can still leave payload_size() negative and pass an underflowed value to later receive-path users. Fix this by validating pkt->paylen against the full minimum length required by payload_size(): header_size(pkt) + bth_pad(pkt) + RXE_ICRC_SIZE. Fixes: 8700e3e7c485 ("Soft RoCE driver") Cc: stable@vger.kernel.org Signed-off-by: hkbinbin Reviewed-by: Zhu Yanjun --- drivers/infiniband/sw/rxe/rxe_recv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/r= xe/rxe_recv.c index 5861e4244049..f79214738c2b 100644 --- a/drivers/infiniband/sw/rxe/rxe_recv.c +++ b/drivers/infiniband/sw/rxe/rxe_recv.c @@ -330,7 +330,8 @@ void rxe_rcv(struct sk_buff *skb) pkt->qp =3D NULL; pkt->mask |=3D rxe_opcode[pkt->opcode].mask; =20 - if (unlikely(skb->len < header_size(pkt))) + if (unlikely(pkt->paylen < header_size(pkt) + bth_pad(pkt) + + RXE_ICRC_SIZE)) goto drop; =20 err =3D hdr_check(pkt); --=20 2.49.0