From nobody Wed Apr 1 20:57:06 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D1C3E866D for ; Wed, 1 Apr 2026 11:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775043910; cv=none; b=j7JUqFA0/rQmZDNHvRoYYiYnm+gaenGQikNg538xaPL4oaYy4xvg+wsmXjWNixRTbVm6zYwAT+2fvmCLkHSwi1f5dauwXzSYiI6DI/UCGbFg4u+bn94hVycKEHRiUTX14j2EzFOXMATtHqEAKhlyw47zbi2/Mr9n7Pz4xHYhf/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775043910; c=relaxed/simple; bh=sX5Q9psoDkwYFXjEwonbSRbV7XcMncEJKqJRvvOhEXw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HjAVRIjVvVJ37juXGc/+AkDann/Ha44iJLNhM2jQAZLPk++HgeXhBimD0hdm/9uacKfLWWV5xTNt/EaGS3jk7YdLVB9hVEH57oF4bWiHWd+yADkbX8BWauVXrC9O+vb5b17SYpXIUos/apks88Cq++lrHhuqWd7rOl7FB+zg7R4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=POuV7vQ6; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="POuV7vQ6" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43d01d6b50cso2414328f8f.1 for ; Wed, 01 Apr 2026 04:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775043907; x=1775648707; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=S7tUhnKJfryQMq8UMuwWIK2pWGEPPiKybIC2U2jfHfs=; b=POuV7vQ6tfGXaLs10P2zpDyc8tEjP50iFNEa5iKHkmNHc/dcC2Bq4MF17UXFKiKzPw Asr6qj1JMJOstas7NBW9p17pD77HcpyPBrw1ROC/u+SdewH/mTYpzvIRaLwScsYIrf7R WRfBDy65hiMKGeJ2pEAUNxDI5KxqB5PF1yCsYDCYU7afvYLgad4a3ReSPYDR+7OJEPwY C0Qy+C9KBOLqnzI79Nkz3u+N8TUyGCzYAiC95EnfwpiMthhqsazkafGRoJ8LukXcy6R3 49TDqHTxezpxMc4BJ3RPZJTAVffSfEJZ+LYBtd9P0vBo0bq0jnNg0MoqDXilWW2QqMbn yL2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775043907; x=1775648707; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S7tUhnKJfryQMq8UMuwWIK2pWGEPPiKybIC2U2jfHfs=; b=eV7D3OCNEk/vPEIfe1Y6++CQqamtXHIclkIzDK16QYIUP/HZh4h+kfrNNsMO8pCawp ijBwurfzUmTVD4B80Cma+yZf5tR8aSvHsVa6E4/UDy+MiK1ElItDWS+BasBmEOpETrl0 JuVevqGnHDJlP7s3WVk/vWDIPEsKF+qkDy8+HcCS7iLhg6vlH+HD1PB0i8ATXwwWXK4o wpToI3JGyShiZtkBbif+6R0KFenT8iWVzLYq6wJg0PPgO8uxkjrQM1r/wPQedA76gqHp yQ5RoJoYaZaiREvPkuM8JbQM9TwbF4l7PxOThIh/Ix8bJ5kWiBlFTbPwMXfcpCXO2UJs uF+Q== X-Forwarded-Encrypted: i=1; AJvYcCXjy+BhP1m9h28Ren2bZ3JqSRqf6I8DnEVWYND1M4VYiqCvmd25wJtpO0Kv9U7WOmzGR+cyL6+EDpWwVQc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Rd3guPZd+mpmjb956a7OnHIqDAmJu0zsuGHB9dMk1kvDTZUe 7Ep9s3qNMLeqoO4kEISiOfHXULinp/uIGupeVcOMv5VXjXs0mLAc9c9d X-Gm-Gg: ATEYQzyVB5WsXOJoslAJ5gRK5fj2+56hIb4Jn4b7AolT6sHF+Oevd6WFzu0grlD4GVz wKWeVIjJgOXwW18WD94dF2whZizb42M3sOFJhudxoK0JtwPaPIRS4euxaVigvhTbkstMaQkx3Zp H0aVt2SDq8afB6zH6N9I5w8hU2HGXyJZF7y1YovRh5jK0OwmmMA8OLMM7+96iaTOCHiFvoWae3H Si3HblqVPNwGKf+EHxeTQ/3xTepjfj3PCXBV/jxYJiHwTaNpWnvPBPWQ3dVmWeke673SGqScib8 +SkIESKG2yZdDVq8/1RJ8Eq1PEayIxJRAQJweCV8uQlbEGoa29241mED+3D6F+TIqvZ0AR+e0ou I3wBfLsfh4/OM9JigdFpolCLn4Xu6YWPZevoujtKlMgEM9MsNhKP8FnYQ15G12oA9fLpspEzQLp NQfsC42XDW5XleXXzMASjMAoMbxpPQASCZ5R0pQYiYLQcpocLE X-Received: by 2002:a05:6000:40dd:b0:439:b60a:b400 with SMTP id ffacd0b85a97d-43d150bd4acmr6289232f8f.31.1775043906853; Wed, 01 Apr 2026 04:45:06 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:cd6c:7c48:e40b:4bf3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf330872asm32929035f8f.17.2026.04.01.04.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 04:45:06 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v2] irqchip/renesas-rzg2l: Add NMI support Date: Wed, 1 Apr 2026 12:45:00 +0100 Message-ID: <20260401114504.332825-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The RZ/G2L SoC has an NMI interrupt. Add support for the NMI interrupt. Signed-off-by: Biju Das --- v1->v2: * Added a comment in rzg2l_clear_nmi_int() and dropped the lock in the caller as it is not an RMW operation. * Added the macro NSCR_NSTAT to indicate the NMI status bit. * Dropped the function parameter hwirq in rzg2l_clear_nmi_int(). * Updated the commit description from RZ/G3L to RZ/G2L to cover all SoCs. --- drivers/irqchip/irq-renesas-rzg2l.c | 91 ++++++++++++++++++++++++++++- 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index 199b3c6b02c8..b94949987ae3 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -20,11 +20,14 @@ #include #include =20 +#define IRQC_NMI 0 #define IRQC_IRQ_START 1 #define IRQC_TINT_COUNT 32 #define IRQC_SHARED_IRQ_COUNT 8 #define IRQC_IRQ_SHARED_START (IRQC_IRQ_START + IRQC_SHARED_IRQ_COUNT) =20 +#define NSCR 0x0 +#define NITSR 0x4 #define ISCR 0x10 #define IITSR 0x14 #define TSCR 0x20 @@ -43,6 +46,10 @@ #define TSSR_OFFSET(n) ((n) % 4) #define TSSR_INDEX(n) ((n) / 4) =20 +#define NSCR_NSTAT 0 +#define NITSR_NTSEL_EDGE_FALLING 0 +#define NITSR_NTSEL_EDGE_RISING 1 + #define TITSR_TITSEL_EDGE_RISING 0 #define TITSR_TITSEL_EDGE_FALLING 1 #define TITSR_TITSEL_LEVEL_HIGH 2 @@ -63,11 +70,13 @@ =20 /** * struct rzg2l_irqc_reg_cache - registers cache (necessary for suspend/re= sume) + * @nitsr: NITSR register * @iitsr: IITSR register * @inttsel: INTTSEL register * @titsr: TITSR registers */ struct rzg2l_irqc_reg_cache { + u32 nitsr; u32 iitsr; u32 inttsel; u32 titsr[2]; @@ -116,6 +125,23 @@ static struct rzg2l_irqc_priv *irq_data_to_priv(struct= irq_data *data) return data->domain->host_data; } =20 +static void rzg2l_clear_nmi_int(struct rzg2l_irqc_priv *priv) +{ + u32 bit =3D BIT(NSCR_NSTAT); + u32 reg; + + /* Writing is allowed only when NSTAT is 1 */ + reg =3D readl_relaxed(priv->base + NSCR); + if (reg & bit) { + writel_relaxed(reg & ~bit, priv->base + NSCR); + /* + * Enforce that the posted write is flushed to prevent that the + * just handled interrupt is raised again. + */ + readl_relaxed(priv->base + NSCR); + } +} + static void rzg2l_clear_irq_int(struct rzg2l_irqc_priv *priv, unsigned int= hwirq) { unsigned int hw_irq =3D hwirq - IRQC_IRQ_START; @@ -155,6 +181,14 @@ static void rzg2l_clear_tint_int(struct rzg2l_irqc_pri= v *priv, unsigned int hwir } } =20 +static void rzg2l_irqc_nmi_eoi(struct irq_data *d) +{ + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); + + rzg2l_clear_nmi_int(priv); + irq_chip_eoi_parent(d); +} + static void rzg2l_irqc_irq_eoi(struct irq_data *d) { struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); @@ -341,6 +375,29 @@ static void rzg2l_irqc_tint_enable(struct irq_data *d) irq_chip_enable_parent(d); } =20 +static int rzg2l_nmi_set_type(struct irq_data *d, unsigned int type) +{ + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); + u32 sense; + + switch (type & IRQ_TYPE_SENSE_MASK) { + case IRQ_TYPE_EDGE_FALLING: + sense =3D NITSR_NTSEL_EDGE_FALLING; + break; + + case IRQ_TYPE_EDGE_RISING: + sense =3D NITSR_NTSEL_EDGE_RISING; + break; + + default: + return -EINVAL; + } + + writel_relaxed(sense, priv->base + NITSR); + + return 0; +} + static int rzg2l_irq_set_type(struct irq_data *d, unsigned int type) { struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); @@ -467,11 +524,23 @@ static int rzg2l_irqc_tint_set_type(struct irq_data *= d, unsigned int type) return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH); } =20 +static int rzg2l_irqc_nmi_set_type(struct irq_data *d, unsigned int type) +{ + int ret; + + ret =3D rzg2l_nmi_set_type(d, type); + if (ret) + return ret; + + return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH); +} + static int rzg2l_irqc_irq_suspend(void *data) { struct rzg2l_irqc_reg_cache *cache =3D &rzg2l_irqc_data->cache; void __iomem *base =3D rzg2l_irqc_data->base; =20 + cache->nitsr =3D readl_relaxed(base + NITSR); cache->iitsr =3D readl_relaxed(base + IITSR); if (rzg2l_irqc_data->info.shared_irq_cnt) cache->inttsel =3D readl_relaxed(base + INTTSEL); @@ -496,6 +565,7 @@ static void rzg2l_irqc_irq_resume(void *data) if (rzg2l_irqc_data->info.shared_irq_cnt) writel_relaxed(cache->inttsel, base + INTTSEL); writel_relaxed(cache->iitsr, base + IITSR); + writel_relaxed(cache->nitsr, base + NITSR); } =20 static const struct syscore_ops rzg2l_irqc_syscore_ops =3D { @@ -507,6 +577,23 @@ static struct syscore rzg2l_irqc_syscore =3D { .ops =3D &rzg2l_irqc_syscore_ops, }; =20 +static const struct irq_chip rzg2l_irqc_nmi_chip =3D { + .name =3D "rzg2l-irqc", + .irq_eoi =3D rzg2l_irqc_nmi_eoi, + .irq_mask =3D irq_chip_mask_parent, + .irq_unmask =3D irq_chip_unmask_parent, + .irq_disable =3D irq_chip_disable_parent, + .irq_enable =3D irq_chip_enable_parent, + .irq_get_irqchip_state =3D irq_chip_get_parent_state, + .irq_set_irqchip_state =3D irq_chip_set_parent_state, + .irq_retrigger =3D irq_chip_retrigger_hierarchy, + .irq_set_type =3D rzg2l_irqc_nmi_set_type, + .irq_set_affinity =3D irq_chip_set_affinity_parent, + .flags =3D IRQCHIP_MASK_ON_SUSPEND | + IRQCHIP_SET_TYPE_MASKED | + IRQCHIP_SKIP_SET_WAKE, +}; + static const struct irq_chip rzg2l_irqc_irq_chip =3D { .name =3D "rzg2l-irqc", .irq_eoi =3D rzg2l_irqc_irq_eoi, @@ -662,7 +749,9 @@ static int rzg2l_irqc_alloc(struct irq_domain *domain, = unsigned int virq, * from 16-31 bits. TINT from the pinctrl driver needs to be programmed * in IRQC registers to enable a given gpio pin as interrupt. */ - if (hwirq > priv->info.irq_count) { + if (hwirq =3D=3D IRQC_NMI) { + chip =3D &rzg2l_irqc_nmi_chip; + } else if (hwirq > priv->info.irq_count) { tint =3D TINT_EXTRACT_GPIOINT(hwirq); hwirq =3D TINT_EXTRACT_HWIRQ(hwirq); chip =3D priv->tint_chip; --=20 2.43.0