From nobody Wed Apr 1 20:44:25 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010067.outbound.protection.outlook.com [52.101.61.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF95F3D5672; Wed, 1 Apr 2026 11:25:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042745; cv=fail; b=AFd0VV5mXApa065NHnqY6/GP0gDzo1ruFS1H1896hUx+OHjxkYl/3TYCQylK4mmYv7GY3hJoPAjg1nDR9fGctWA78Q2TZ/Q2yyO1XwFiStsUHtBgxwS6sQtd8scZ9RTHV4yae1cHkB9U//OtzRTYQ9TtFzBIY+VsejBWf1Nvyao= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042745; c=relaxed/simple; bh=hOLgUlXstXn4TchGmexlf+MxRm4hBKswQl9AjYazGuA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YZnt8dGu6XPiAb0tX8Oi0uK1eimpEk2mYcNNUbKDEzdeJ4kugADtFzK/Pe77+bHp3c1hJoHw57hchk3PVlZQAPeBZD2UJ3mGerjhMqdfN2xCL7XJJoiLexk0LmJLp+5YUBMo+O7QQ37adzAkQkiHbQnll+6ul4odfwt9NGftkGw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=aJoLAx4H; arc=fail smtp.client-ip=52.101.61.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="aJoLAx4H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A4FaKTFVI+dKYng+Fh3K6L+AtKysvwOo9ojDaetJJS6Xq3c58CSCngNBm6IrGqQuih3hQrZIYEJmOXpltUpUSQxmUSFaZbIZLfTlLpwZRGZpcHTFPQxhujSUxD1Rd6kXD+olHTIXM6pitxjQFtN2ImAM9ZAEOe4cQ8wJ8H1du88URASkDhq1lFUOqYfwcMDlsuTEWtk2Ywq2ALD1ZChx5V4BlPAc10HXb6t+BsrgMiSPWoUBGTk8KAaBib0hmGsV5B4PehrLK7xeVJXCBBpFgad7H6m1vFpgLm5kvhj15GKq4m3jRamZVHSAfLTgw3VSb3/sKvpXqOyweDFPWODxUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BvirwrUE/YExDvcA9SPmgv3tlGooNzaTEIGNDwREI2k=; b=s9c0bkrFg1wcnOoVDNeFhjuLuvEGBVSYdWp0DTEbiZnaqMH4xSGrIVUJQQgghBtkmCPCchoU8CsnUmvPL18GefzEN75ImeLq+Sx1iMXGfOrXsoCME6N1IpslOvTtucxKV1NvcdZwaT1dN0fjo9IAXVJifVLxJIOAHjl+2ao+fdjUKr1ggklH6y/UG6YvUCGYeDsKqa+1n6CRddg4Y4WXGo2s+RxP8Mn5flccX3FWEeeNpETR3AakrghcTDg4peTe2xHOirXWN9FyV1bp7iS67IRqaJnJmAZ1XeNN7uun3Wb0iVCP7rMUAn9GpMsL7O7ks0HqXm8g11sNFWhqk07LNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvirwrUE/YExDvcA9SPmgv3tlGooNzaTEIGNDwREI2k=; b=aJoLAx4Hg9vxXIm0bmLyerrxrKjmJTzUxW5CqLTqAW2MaR6A7N0fiTLk3wBd84lbmJZwXFSbcw5ifpEqfMkvH3NuzQTZ4hhPxMa9o7kaU5DY6e2OmkgRaz4gFPVZSLUyXxCd7uWtzJ1Hc/xO6C3WxO6YUEklBdzQHg7qo88snXihSUKWAb3jf3U1PCX6TSi6N+TTXBlHl1YXlkzU7HnxLB9ZHzv9/5LFpapFvQooX9FzJhAmmMIWF/IGPAlQqpAzQSOFThr0SNeN/EEGuyDWiCHrp6b+UJRhyoCNya6I7nu6tp5tIEtFlKvAEgT8cKLdBc3anYyP2Q2QhamMEsDRiQ== Received: from SA9PR10CA0011.namprd10.prod.outlook.com (2603:10b6:806:a7::16) by CY3PR12MB9653.namprd12.prod.outlook.com (2603:10b6:930:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.16; Wed, 1 Apr 2026 11:25:37 +0000 Received: from SN1PEPF0002BA4C.namprd03.prod.outlook.com (2603:10b6:806:a7:cafe::68) by SA9PR10CA0011.outlook.office365.com (2603:10b6:806:a7::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.29 via Frontend Transport; Wed, 1 Apr 2026 11:25:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA4C.mail.protection.outlook.com (10.167.242.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Wed, 1 Apr 2026 11:25:36 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:19 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:19 -0700 Received: from build-sheetal-bionic-20251202.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 1 Apr 2026 04:25:18 -0700 From: Sheetal To: Liam Girdwood , Mark Brown , Thierry Reding , Jonathan Hunter CC: Jaroslav Kysela , Takashi Iwai , "Mohan Kumar" , Kuninori Morimoto , , , , Sheetal Subject: [PATCH v4 1/4] ASoC: tegra: Add error logging in tegra210_admaif driver Date: Wed, 1 Apr 2026 11:24:57 +0000 Message-ID: <20260401112500.4076861-2-sheetal@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260401112500.4076861-1-sheetal@nvidia.com> References: <20260401112500.4076861-1-sheetal@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4C:EE_|CY3PR12MB9653:EE_ X-MS-Office365-Filtering-Correlation-Id: cfb8bff2-eb3a-4b6e-e551-08de8fe165a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700016|1800799024|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 7I4wsPoOjIyPwlvDsb7vWxgyHX+cRfwQGbxC19+PCIiIr2bprPn57qVTwKIidCu8ZJBb80XjOesmXuYKSl8mRo3GBM9gqCeUBCT32vcTaLKe+2Qrqnm6+XWWLbREdvtmidIMU+5gSWQQZdyQHNYqfKDm7GzJa6i1L9xgFim39CIFz8kcUKWEjSKqH2A6ituTj/esUsnXwEDIxcS469QY4fgdJudTbvRI/5mg0EK8yhNQp6I5AnXaMkSA/NsR0uAQNySDH/bp7vEKI2xCcVscYQuYzAflwV2XyDSIU+pL35DjlTM7+w4rtzYLxHC8znEwBbFluJcai74wFJrUo9y9zK3ba2x/IEBpWR8jqKBKOjJC1JYvRRi80AL8/qp10LjRHlagaQ15w5e7e9iQni7P76eA9QVg70pGAyFadlnmXApJA3VPJbDw8dOaPZKa4MOoV2tR+TcMORFf5td5pI9MMaG5BapuzOrsRl+9RxyQlpeuas0CBDg2mtkvef0Bxi0vWJjbjj2Se+nnWyvoLSCf7yfOXNVvyAc9myvkwnisf1pvOTLOzf4W0YqNVeRTJI3PnOPYQfVkxq+4+DKA1fqvQx1kiPKJPFTE4CYFce1wTlJLjLsIv6pEcRa/B+Wpue8IWvAP4bYkg3sBsE7Uy24hu1mnEsuxMXE0BFqLkWTKIW6b69oDdGHNy1P/NwYAg6H1o5mo4XPcVqL8p6HlnVMhPCjTgZDXsN9eg2po4k80IVQUfcvNUbwZ0n9Dx4IgJ8EKRmgAsIRkW1CAu8tS424jkQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700016)(1800799024)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cGn/F14wdivIO8WeGq5vGD0Et47t2Q71o05znUePwExp1+dHXUkDOBRWGjrwGMBAGIMvkETgdH6ob7sBPHbbrNzEWlDSLrIhMAQANrw1t5Bqc9ISy3ivLCKF5YMJKs687icF6dCp8iIqg/I6q3n1KNfnTgVxBFSmY7M3o1x23ZU8p2J7B5w3qplivWE3GTNxk0Z10isRKpve2t7B8K5hJdeErIcPiBa1puHbnTCsyMLPjTOhhRNt2PqhH1AawhprpKUJfpROsZtHD4pbLXtQBvkNtsxP40HvyzluD2E1bLRJOBo3pdQfjBnLUSZ8nsj0p0kngoMMESijYiOh7PpnCjQqcXzLwaG2XTmegGjCfkBFO4Hb9LULbcFmwowQDMixxISQqvgWW7MGz26CVnneKwmIEX26J8pXJwfWzwsRgfHzaM5O+F1JCwZDVDjksL/l X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 11:25:36.6979 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cfb8bff2-eb3a-4b6e-e551-08de8fe165a6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4C.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY3PR12MB9653 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Log errors in the Tegra210 ADMAIF probe and runtime callback paths. Drop redundant dev_err() at tegra_isomgr_adma_register() call site since it already logs errors internally. Signed-off-by: Sheetal --- sound/soc/tegra/tegra210_admaif.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/sound/soc/tegra/tegra210_admaif.c b/sound/soc/tegra/tegra210_a= dmaif.c index 0976779d29f2..a1b2c3d4e5f6 100644 --- a/sound/soc/tegra/tegra210_admaif.c +++ b/sound/soc/tegra/tegra210_admaif.c @@ -408,6 +408,7 @@ static int tegra_admaif_start(struct snd_soc_dai *dai, = int direction) reg =3D CH_RX_REG(TEGRA_ADMAIF_RX_ENABLE, dai->id); break; default: + dev_err(dai->dev, "invalid stream direction: %d\n", direction); return -EINVAL; } =20 @@ -441,6 +442,7 @@ static int tegra_admaif_stop(struct snd_soc_dai *dai, i= nt direction) reset_reg =3D CH_RX_REG(TEGRA_ADMAIF_RX_SOFT_RESET, dai->id); break; default: + dev_err(dai->dev, "invalid stream direction: %d\n", direction); return -EINVAL; } =20 @@ -489,6 +491,7 @@ static int tegra_admaif_trigger(struct snd_pcm_substrea= m *substream, int cmd, case SNDRV_PCM_TRIGGER_SUSPEND: return tegra_admaif_stop(dai, substream->stream); default: + dev_err(dai->dev, "invalid trigger command: %d\n", cmd); return -EINVAL; } } @@ -958,10 +961,9 @@ static int tegra_admaif_probe(struct platform_device *= pdev) =20 admaif->regmap =3D devm_regmap_init_mmio(&pdev->dev, regs, admaif->soc_data->regmap_conf); - if (IS_ERR(admaif->regmap)) { - dev_err(&pdev->dev, "regmap init failed\n"); - return PTR_ERR(admaif->regmap); - } + if (IS_ERR(admaif->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(admaif->regmap), + "regmap init failed\n"); =20 regcache_cache_only(admaif->regmap, true); =20 @@ -968,7 +970,5 @@ static int tegra_admaif_probe(struct platform_device *p= dev) err =3D tegra_isomgr_adma_register(&pdev->dev); - if (err) { - dev_err(&pdev->dev, "Failed to add interconnect path\n"); - return err; - } + if (err) + return err; =20 regmap_update_bits(admaif->regmap, admaif->soc_data->global_base + @@ -1009,11 +1009,9 @@ static int tegra_admaif_probe(struct platform_device= *pdev) admaif->soc_data->cmpnt, admaif->soc_data->dais, admaif->soc_data->num_ch); - if (err) { - dev_err(&pdev->dev, - "can't register ADMAIF component, err: %d\n", err); - return err; - } + if (err) + return dev_err_probe(&pdev->dev, err, + "can't register ADMAIF component\n"); =20 pm_runtime_enable(&pdev->dev); =20 --=20 2.17.1 From nobody Wed Apr 1 20:44:25 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010000.outbound.protection.outlook.com [52.101.85.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1651D3F7A8E; Wed, 1 Apr 2026 11:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042748; cv=fail; b=KrCniwuxqiQXPyI6yzjDf2e0umBGo+cexFVdzHfNX/pkShBtg1v85n8IGC3Oi2i23dSZFR4tvA/XHRJP+gpLXIeg5BNNGd5s5tbUSogatu7a/E/PIrVAYql+TY3b+10ZCjbALk+IQnRFeF4ySR7/HkeLn2NhxsrHD0MQZ2yr1+I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042748; c=relaxed/simple; bh=c1FwFPi38nkFh/0Lbbg9UBofAs7X+Jch4qx+TZE+a+M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KshAFZ8D3MBG0FuYQ7G/Xantl47gHKA6h9NMD9pudj4HWtmnE/jRXnmcwotvEf73pJZ8kWWtDS9BDxtCMsEKJcxBAD7jgqnPH7bSLJkywnV9zj5Ktx6X8Rzed5ia1pDh5LbgE2p3gY6VtnwlIr+0k6XsIgoJ92YVV/G4BawRn6c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=GsyS/k1x; arc=fail smtp.client-ip=52.101.85.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="GsyS/k1x" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XXzhCreVqXNX4QkFSdOBjkVOg95EJGfy45I6uRBUMyE2jSLjrRDxHVEpWEaQzGnSW9f8ACQEY0WaX2LBnRmaQeSilMD6aTXXXxGqRWvIOcezIeHCcFDCEDAefM6d5cif+Tt9hWt8Ht5W4DATG/tpZLl1QBgwZWov8CAs4Hp15mJkoun7XOPAGROBpIB8Z0URyJRh2FXDTzX19OTfV3OApVUTeSIFflgVF6yaYWvXuvXg85kMLLr6ij4FXkklmSoyptVi1vVg8KV5WoMzOYqk3i0cY828O8i/7K26J1TXNYjpZISp4UF/Q++qc6P8JQikVihlEBALVIOQedaxruI34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K1Oid8xl+AzPC0WVnPtFZQgnKBbYiGoGmsOkz48Jv/s=; b=neKNAZ99HbOpZR5hrUuAQAQqTslGHbLgHYS2S515GlkaShybzigMkg60dQXsXzN10qeP7b/qBZD9mKfbxZvOby5Dq3gGoIdQmBnBY4WVZ6p6SLYLF8kssQ8XQGl2UF+kb+sm+jUwhgUn5X5sF93Sv3TE9PjLlaNjTKB6dMBoRoN0pLxyV3/Kt5T6JbqNdT+dnIwvGVBTtKoJ+WHnS2B3mB7Hn8jP4JlxsZShiPvlBGCdI6IXU69EGFlMTee8WDIKVfFtvD8j6ulqFUqcCR0JzezCGiCZL2WE2qhsCqFmfsWkH8VMXeQ6fV32DyVXXw9SZX5mqcDXvO3Le2IMjeCqWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K1Oid8xl+AzPC0WVnPtFZQgnKBbYiGoGmsOkz48Jv/s=; b=GsyS/k1xhpRpCsNefTj//UishpiaBYrfrf+oMBAsd1rvvWUj3JTxipnF1lRIlx2TGPNBQfo1EzVRC4F+3OWhRbIxNCGfryt8mIbtERUuaxMMMy7esf1UneFeO6aEvPW5q6aS8wOGcNsw/2OnB+HSEb/2mOfIAWLfZtdJ8cEJtMlwQgrUT3ZS5mBqWyq8Pi29ACikbSPmxXqnyAswNDvRrASCiSobrV7u4nWwFK6ELx4jLA/7iNWIL89/VB/Bk1DjYpgc2G+XLsHFGf/KyQej1WDQxBuCeQEDlPC9++LNkHGXHe6+LGHzcuS2NUl9lLo6/OFQGGdbdRbjNVNFiII47Q== Received: from PH7P222CA0027.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::10) by LV3PR12MB9265.namprd12.prod.outlook.com (2603:10b6:408:215::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 1 Apr 2026 11:25:42 +0000 Received: from SN1PEPF0002BA50.namprd03.prod.outlook.com (2603:10b6:510:33a:cafe::ca) by PH7P222CA0027.outlook.office365.com (2603:10b6:510:33a::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.29 via Frontend Transport; Wed, 1 Apr 2026 11:25:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA50.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Wed, 1 Apr 2026 11:25:41 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:23 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:22 -0700 Received: from build-sheetal-bionic-20251202.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 1 Apr 2026 04:25:21 -0700 From: Sheetal To: Liam Girdwood , Mark Brown , Thierry Reding , Jonathan Hunter CC: Jaroslav Kysela , Takashi Iwai , "Mohan Kumar" , Kuninori Morimoto , , , , Sheetal Subject: [PATCH v4 2/4] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers Date: Wed, 1 Apr 2026 11:24:58 +0000 Message-ID: <20260401112500.4076861-3-sheetal@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260401112500.4076861-1-sheetal@nvidia.com> References: <20260401112500.4076861-1-sheetal@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA50:EE_|LV3PR12MB9265:EE_ X-MS-Office365-Filtering-Correlation-Id: f01a7eae-9ee6-499b-95cd-08de8fe16891 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|376014|82310400026|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Q4s++ViANzS5Ya7y+aLIpwK7+8oNvfZzzB6/DUARRogid/NS2CSEnQHqTRTWXL6I3TtV1hf3HxxmHdDVbfU3uvH1njVPbia6S1hyF+wWLLrRd34hfQFF+XUg9QmZ2SmqdmiF4OTPiF0Rrbjm++q7Xmla8nKvqdnp0mpE/eSHJGqfefcHnNavKacgDd9H3xGks+uBAiz+OcRmoAejJpHSqZ0z2gyAClj35Z5Ij+YDz5dxFLyD8jNLlUEiaFEvJilkkWniJwKDRXZUbuREkuTtHlvLT8+AO/jxXgxpjbqs05iet8vgvGpKrpX1ahZmLcfiN8OQOuvcSvXUf8p908DdERBhRi8w/eCTVsJPLsUSqWkXhplPdDA5hKWbflqtMIXMGZl+FMNh1zKehRvMGej8E617B9R4Gd9JYe+lyaMj2jJv3IJM1bHXkI5YDFJrsYkcc+dy8P8mgADI5zgZ31YyjI9ZqjWrAGg1ad0FHXxlI1PngKOUdNVrq/FtuAw+Ex3crTI4dWLstdoTPimpC8msz4+UreFCzv39gSwXSQ4F5Om8rcD/93S+S2JTICsPO/8XGNRnsncgUhw6w+2HFqy+kHenf5CzcPUp8IAz1HREi2OW8PKCqgvp6LOWUDnqK/NjJkUBzTB9XBccLjGIUGdxIq/ByloWeRKCzbAM2lvEW+mrrM5Mpdv/QvTQzKpmybYd/cB+AxwHVuBUVqeHWn7nevG4X+NdJsPqWMDQMykAshiLiWZP611wtBO22Mq6/6GxycH6N2pA0CFBlJULU0St9Q== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uCnX6AZmiSFC+XUmT/GGJoR2pm48Qo9fCx8bLuc2+kM3ZR8R4o29Y51yQX87WGGGWblEtbYLaRJh8mBGPX8tlqkPl0mgnwJTHni/58PNsDIRJJGtsxx6bcWF/lkf2ejH6wx+kXsisPdmd6HK0buZ1ffcP6fDW4gngJLKJN4hOoEefgL3jxBokj5naFgVay2BhJh6qFJ0Yu8FfnKM5iLDYF3wXRYoMUjNsgJpxUD7Q/xeaCAj6bpwMM/HWoRFzhp1JW5wD1ckA2c+ICyelG+UZJhXAsikNqUFzdQ/covfaprC5ERc0wzriX9nhU158rLljYrFamiwhf3XvhDdHZmmomgp8pHW6fuquV6sqxH849X4pj2Gis5EwsqnCwhldn/rZ4Z3A1Ne/TNcliE02ARXQ6Cowh4UvpTnBBo/6/q8TZ0dAQBY8Ue6IuRYTutE4yy+ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 11:25:41.6824 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f01a7eae-9ee6-499b-95cd-08de8fe16891 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA50.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9265 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Log errors in the Tegra210 OPE, PEQ and MBDRC probe paths using dev_err_probe(). Drop redundant dev_err() at tegra210_peq_regmap_init() and tegra210_mbdrc_regmap_init() call sites in ope_probe() since these functions already log errors internally. Signed-off-by: Sheetal --- sound/soc/tegra/tegra210_mbdrc.c | 19 ++++++++++--------- sound/soc/tegra/tegra210_ope.c | 26 ++++++++++---------------- sound/soc/tegra/tegra210_peq.c | 19 ++++++++++--------- 3 files changed, 30 insertions(+), 34 deletions(-) diff --git a/sound/soc/tegra/tegra210_mbdrc.c b/sound/soc/tegra/tegra210_mb= drc.c index 6a268dbb7197..b1c2d3e4f5a6 100644 --- a/sound/soc/tegra/tegra210_mbdrc.c +++ b/sound/soc/tegra/tegra210_mbdrc.c @@ -988,14 +988,14 @@ int tegra210_mbdrc_regmap_init(struct platform_device= *pdev) =20 child =3D of_get_child_by_name(dev->of_node, "dynamic-range-compressor"); if (!child) - return -ENODEV; + return dev_err_probe(dev, -ENODEV, + "missing 'dynamic-range-compressor' DT child node\n"); =20 err =3D of_address_to_resource(child, 0, &mem); of_node_put(child); - if (err < 0) { - dev_err(dev, "fail to get MBDRC resource\n"); - return err; - } + if (err < 0) + return dev_err_probe(dev, err, + "failed to get MBDRC resource\n"); =20 mem.flags =3D IORESOURCE_MEM; regs =3D devm_ioremap_resource(dev, &mem); @@ -1004,10 +1004,9 @@ int tegra210_mbdrc_regmap_init(struct platform_devic= e *pdev) =20 ope->mbdrc_regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_mbdrc_regmap_cfg); - if (IS_ERR(ope->mbdrc_regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(ope->mbdrc_regmap); - } + if (IS_ERR(ope->mbdrc_regmap)) + return dev_err_probe(dev, PTR_ERR(ope->mbdrc_regmap), + "MBDRC regmap init failed\n"); =20 regcache_cache_only(ope->mbdrc_regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_ope.c b/sound/soc/tegra/tegra210_ope.c index a440888dcdbd..c1d2e3f4a5b6 100644 --- a/sound/soc/tegra/tegra210_ope.c +++ b/sound/soc/tegra/tegra210_ope.c @@ -318,10 +318,9 @@ static int tegra210_ope_probe(struct platform_device *= pdev) =20 ope->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_ope_regmap_config); - if (IS_ERR(ope->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(ope->regmap); - } + if (IS_ERR(ope->regmap)) + return dev_err_probe(dev, PTR_ERR(ope->regmap), + "regmap init failed\n"); =20 regcache_cache_only(ope->regmap, true); =20 @@ -328,14 +327,10 @@ static int tegra210_ope_probe(struct platform_device = *pdev) dev_set_drvdata(dev, ope); =20 err =3D tegra210_peq_regmap_init(pdev); - if (err < 0) { - dev_err(dev, "PEQ init failed\n"); - return err; - } + if (err < 0) + return err; =20 err =3D tegra210_mbdrc_regmap_init(pdev); - if (err < 0) { - dev_err(dev, "MBDRC init failed\n"); - return err; - } + if (err < 0) + return err; =20 @@ -342,10 +337,9 @@ static int tegra210_ope_probe(struct platform_device *= pdev) err =3D devm_snd_soc_register_component(dev, &tegra210_ope_cmpnt, tegra210_ope_dais, ARRAY_SIZE(tegra210_ope_dais)); - if (err) { - dev_err(dev, "can't register OPE component, err: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, + "can't register OPE component\n"); =20 pm_runtime_enable(dev); =20 diff --git a/sound/soc/tegra/tegra210_peq.c b/sound/soc/tegra/tegra210_peq.c index 2f72e9d541dc..d1e2f3a4b5c6 100644 --- a/sound/soc/tegra/tegra210_peq.c +++ b/sound/soc/tegra/tegra210_peq.c @@ -408,14 +408,14 @@ int tegra210_peq_regmap_init(struct platform_device *= pdev) =20 child =3D of_get_child_by_name(dev->of_node, "equalizer"); if (!child) - return -ENODEV; + return dev_err_probe(dev, -ENODEV, + "missing 'equalizer' DT child node\n"); =20 err =3D of_address_to_resource(child, 0, &mem); of_node_put(child); - if (err < 0) { - dev_err(dev, "fail to get PEQ resource\n"); - return err; - } + if (err < 0) + return dev_err_probe(dev, err, + "failed to get PEQ resource\n"); =20 mem.flags =3D IORESOURCE_MEM; regs =3D devm_ioremap_resource(dev, &mem); @@ -423,10 +423,9 @@ int tegra210_peq_regmap_init(struct platform_device *p= dev) return PTR_ERR(regs); ope->peq_regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_peq_regmap_config); - if (IS_ERR(ope->peq_regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(ope->peq_regmap); - } + if (IS_ERR(ope->peq_regmap)) + return dev_err_probe(dev, PTR_ERR(ope->peq_regmap), + "PEQ regmap init failed\n"); =20 regcache_cache_only(ope->peq_regmap, true); =20 --=20 2.17.1 From nobody Wed Apr 1 20:44:25 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011061.outbound.protection.outlook.com [52.101.57.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546703FF8A7; Wed, 1 Apr 2026 11:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042750; cv=fail; b=TvUFHVH/1wFOFAn6ymD3WdL1QGUvyDppXTvwxYa2XrpANN2iJg2O+pbVmVdgM71BtX8IlD5sGJkllN3N2G1FGZwSfUNTLSlPyN8hi52Vu104yHl/Y2L27hfzbhclSSRFfsX+lGEdbNZmw0j9j28AQx1zQ8/yYCmg/60Xw+L1fQc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042750; c=relaxed/simple; bh=EbIeRfsy39aSDfvWCLtcaWpE0M5QxkZOHoo0s3B5pOI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gynbjDgSUdlNDl+CCvtxWCucrjinXzsKKESHvlJbqMrgozUy4IU71pyf12M1LpWPAG3V/A+MKBhoTDjy4ycl6Ar1GKQ/Jz5TwY29wtg35/l+73FZFGalL6P+lHG8jNBclvANgVsQG2kZ6sWYKj1BvJ7XDDP/JmIfV2myuAgLKPY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=CTKsSZRj; arc=fail smtp.client-ip=52.101.57.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="CTKsSZRj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vMOf6BZB66k4MPHuIrn6Qc60kFEERDs4U4FuK5zBxHJkdVPZlpJ2DRlIJJJkmB0PWfIia+8PkDDDpHQaYh4MtLZIliMy4cDd+/NJxYv6icDpMf60DXdy9q38GK1tHFGbkuCYIBchU4vdCGR3X/bfKIIdKFUhp1TmdLjZGIeW1kUws8h6BJ3Th9mPuNeEh2OHRz/UpCn2j7V9lHP4VjnnUS5OjsinjUP4l1eMZkw8z86wtUX3glVZBfGsMOjADTmahEeOUTfOZWjWHuFJkMTbgBy95+UKCgOpxMQ6tBeDjfGbLfLN1vSG5Fwt/7LFbtZl7iw/SMCOwTIa9LLgpP8nMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gB3265jc3QkancotM8dMKAIacfp+WXk8R5pBfM21fk4=; b=rMl1r6ufUjKAwGLkFpCQDogrxfxRImnAEmr9tLLvRFV2H9jfLyclKjzVqnFGV1TCjaIpZd6omoKK09hdU3P/zfy9J4FPzDEQ0NAYZ29tGqXFHl4GM8GxnGi4hySYGi3CA+Q5hF92XGrpXwwH4qiREwKVsxxjeII+cFSNH+bA+bWp6f1t34d2R4MWO+6LM3QyGu+qRRmGdl49tz2z4zu9eXbpww8QCULR0kfdzdGGE7Wxlmme80BnCLvKZ9Bw7iVpoEOFeGXoM0PDh+XzF3TWhK0WiJ3RMVkXxc6Wk+/LxCBmxK/cFnBhu6M5UPt9sz+Q0HzFlkZGUmS5gKE4xbmWRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gB3265jc3QkancotM8dMKAIacfp+WXk8R5pBfM21fk4=; b=CTKsSZRjJFvjOnOl/dVtmFaqVfSwmUspwdCH6v1bvnX7go5gGCsN8R9pDoM7HzS68uHCpnsoJOQ5HOO0kx3JojHVAHb3PULrsMZXJss5iakU46jLiFatw887NCGnUkYebsN0AASZwDDrtNq29yUJfRCezY1PBytgmIeOTsKbmoZWS+fSGEGWgUeK5FVGpspgZIH0k76a0U03w03GFjUwCYJ+uLylvx4UXGX/XlPlk2zt4+Yts0VUU+GIsbUnsuyUDRQHOcUk1afMz8ds97C4MdwT/2rxXHDaXHQZrh928Py+vXmWG0aTsLin97I9cCAFFk0RwZV2AHqwdNSWqfB2bg== Received: from PH7P222CA0019.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::22) by SJ2PR12MB9237.namprd12.prod.outlook.com (2603:10b6:a03:554::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 1 Apr 2026 11:25:43 +0000 Received: from SN1PEPF0002BA50.namprd03.prod.outlook.com (2603:10b6:510:33a:cafe::61) by PH7P222CA0019.outlook.office365.com (2603:10b6:510:33a::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.30 via Frontend Transport; Wed, 1 Apr 2026 11:25:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA50.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Wed, 1 Apr 2026 11:25:43 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:25 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:24 -0700 Received: from build-sheetal-bionic-20251202.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 1 Apr 2026 04:25:24 -0700 From: Sheetal To: Liam Girdwood , Mark Brown , Thierry Reding , Jonathan Hunter CC: Jaroslav Kysela , Takashi Iwai , "Mohan Kumar" , Kuninori Morimoto , , , , Sheetal Subject: [PATCH v4 3/4] ASoC: tegra: Use dev_err_probe() for regmap init failures Date: Wed, 1 Apr 2026 11:24:59 +0000 Message-ID: <20260401112500.4076861-4-sheetal@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260401112500.4076861-1-sheetal@nvidia.com> References: <20260401112500.4076861-1-sheetal@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA50:EE_|SJ2PR12MB9237:EE_ X-MS-Office365-Filtering-Correlation-Id: 13ba1a57-fe31-47c6-981c-08de8fe16981 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|82310400026|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: w/Zk/YSo21imbLSpEnDO+eR9rRTFVoUMfz0qp0Ocn1JiiaBs8LWP5l076/gRBlaCBplhuBO9Tj6kjVTnDsiunsdkF3x8xXv1RUzV9HZZJdaKcIqpxuDdTWRaocvkgFD3e1eJiGYca1Adhu8b8UECe0KjMCgSPw4LCyyYdjnO4GWfEalNgs8Y6q/Y1cQAJCOOfrjnnwdV+1W+FhbCWR5YkklpJSn6YJv55+zVZuwzXydS1neNtArdxLQRzO9OKo3hVo9nTZjbfXv4ZhmWznxcd9hJMYxajymUPn60QH64YPlyQ4CpCr25nCurzgsyLFVIAYicby4H0HQQKG5xRacrSE7gGJaQJgCJqme7SFw0rw86QLsNNjjGN64ue3KQUpDGP/Ivg8eI+wu0KFqhd2EksksVdtr69tpBG9shF7MF5Hkg+OwJ3kbXfx97WKJRxGHs9WT0bk6BC6lW/shYWx/Ieo0YqDFsYweeoRIgUgcUkKjqhsZuWu9zVgPu3caWyDU7Xxa9ZP2Oy80W1bWZP3iYqeihGsLlS3mXgO8eLE56ACFWmMFa8eMxpqGtmjelidJ5ixIkc9OuL6F0k4X8/6sc7Bt1qhXWM5XoH9jL+cJlnJj2rpq6TgSaNBzDEi+xH3/8BDfq0qogPBaHcRIQAewT+hRZwwXaAslvwAqjMXgnnLC4HHBKXZ9k1fNv2UA821iTMbVE3qhgRaoiKSFmTsWA8XA31Pi5y6l90h64FXziY5Np546ra+tj0+IG1OFYQWORYCNPrV1KKE8oWwfbZrllRQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(36860700016)(82310400026)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SaTQ1ayITAodM2+6VnMCsWbFMLusIAzZbYDVG7e+9J16yvAoT8lX9IJijEM8JE3C11uhXJnJF2HsPQkzPbP/mR4zRB7M58tNK+GkIJ6jHm5kEqY0KO4L8knqy+DZkMhB5TTZWqjvNR4IQGQ1F0Nv8Xm0ioAlIL7eIUQblmQ402U6F6mMADD+kWwmacb1rXBiC/KmJmBeDbbY4a05ncDJM3seRvvU7MycRK+Autpj70DDyTO0h++vEKwWspD7uk9Pq38Cgwof5d3KyXlGZlerJDWNLUJMvHpyLlAw0P/3151VYu4JBG3NzB0ArHew8tQ1CQmiycTkcJqBbj7M5DxK2F+iIGGlSHLpXuwe0FQ9J2SZFKEw/Ih8GgxkAeSbSe6nDK6a9RBDC2Ee4hHscO+rRdoQM4EnFQkbetqYKssCzHGvWNZAchqqFVv3HZ8kJseJ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 11:25:43.2240 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13ba1a57-fe31-47c6-981c-08de8fe16981 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA50.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9237 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for regmap init failures in Tegra audio driver probe paths. Signed-off-by: Sheetal --- sound/soc/tegra/tegra186_asrc.c | 7 +++---- sound/soc/tegra/tegra186_dspk.c | 7 +++---- sound/soc/tegra/tegra210_adx.c | 7 +++---- sound/soc/tegra/tegra210_ahub.c | 7 +++---- sound/soc/tegra/tegra210_amx.c | 7 +++---- sound/soc/tegra/tegra210_dmic.c | 7 +++---- sound/soc/tegra/tegra210_i2s.c | 7 +++---- sound/soc/tegra/tegra210_mixer.c | 7 +++---- sound/soc/tegra/tegra210_mvc.c | 7 +++---- sound/soc/tegra/tegra210_sfc.c | 7 +++---- 10 files changed, 30 insertions(+), 40 deletions(-) diff --git a/sound/soc/tegra/tegra186_asrc.c b/sound/soc/tegra/tegra186_asr= c.c index 98e911e2ed74..a2b3c4d5e6f7 100644 --- a/sound/soc/tegra/tegra186_asrc.c +++ b/sound/soc/tegra/tegra186_asrc.c @@ -989,10 +989,9 @@ static int tegra186_asrc_platform_probe(struct platfor= m_device *pdev) =20 asrc->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra186_asrc_regmap_config); - if (IS_ERR(asrc->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(asrc->regmap); - } + if (IS_ERR(asrc->regmap)) + return dev_err_probe(dev, PTR_ERR(asrc->regmap), + "regmap init failed\n"); =20 asrc->soc_data =3D of_device_get_match_data(&pdev->dev); =20 diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dsp= k.c index 1aa94c98294a..b3c4d5e6f7a8 100644 --- a/sound/soc/tegra/tegra186_dspk.c +++ b/sound/soc/tegra/tegra186_dspk.c @@ -505,10 +505,9 @@ static int tegra186_dspk_platform_probe(struct platfor= m_device *pdev) return PTR_ERR(regs); =20 dspk->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra186_dspk_regmap); - if (IS_ERR(dspk->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(dspk->regmap); - } + if (IS_ERR(dspk->regmap)) + return dev_err_probe(dev, PTR_ERR(dspk->regmap), + "regmap init failed\n"); =20 regcache_cache_only(dspk->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_adx.c b/sound/soc/tegra/tegra210_adx.c index d7d075fd54b2..c4d5e6f7a8b9 100644 --- a/sound/soc/tegra/tegra210_adx.c +++ b/sound/soc/tegra/tegra210_adx.c @@ -697,10 +697,9 @@ static int tegra210_adx_platform_probe(struct platform= _device *pdev) =20 adx->regmap =3D devm_regmap_init_mmio(dev, regs, soc_data->regmap_conf); - if (IS_ERR(adx->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(adx->regmap); - } + if (IS_ERR(adx->regmap)) + return dev_err_probe(dev, PTR_ERR(adx->regmap), + "regmap init failed\n"); =20 regcache_cache_only(adx->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahu= b.c index 4626dd0a4d55..d5e6f7a8b9c0 100644 --- a/sound/soc/tegra/tegra210_ahub.c +++ b/sound/soc/tegra/tegra210_ahub.c @@ -2275,10 +2275,9 @@ static int tegra_ahub_probe(struct platform_device *= pdev) =20 ahub->regmap =3D devm_regmap_init_mmio(&pdev->dev, regs, ahub->soc_data->regmap_config); - if (IS_ERR(ahub->regmap)) { - dev_err(&pdev->dev, "regmap init failed\n"); - return PTR_ERR(ahub->regmap); - } + if (IS_ERR(ahub->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(ahub->regmap), + "regmap init failed\n"); =20 regcache_cache_only(ahub->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_amx.c b/sound/soc/tegra/tegra210_amx.c index 1b7fb84a0f34..e6f7a8b9c0d1 100644 --- a/sound/soc/tegra/tegra210_amx.c +++ b/sound/soc/tegra/tegra210_amx.c @@ -745,10 +745,9 @@ static int tegra210_amx_platform_probe(struct platform= _device *pdev) =20 amx->regmap =3D devm_regmap_init_mmio(dev, regs, amx->soc_data->regmap_conf); - if (IS_ERR(amx->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(amx->regmap); - } + if (IS_ERR(amx->regmap)) + return dev_err_probe(dev, PTR_ERR(amx->regmap), + "regmap init failed\n"); =20 regcache_cache_only(amx->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_dmic.c b/sound/soc/tegra/tegra210_dmi= c.c index 5a4bd5cef30a..f7a8b9c0d1e2 100644 --- a/sound/soc/tegra/tegra210_dmic.c +++ b/sound/soc/tegra/tegra210_dmic.c @@ -517,10 +517,9 @@ static int tegra210_dmic_probe(struct platform_device = *pdev) =20 dmic->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_dmic_regmap_config); - if (IS_ERR(dmic->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(dmic->regmap); - } + if (IS_ERR(dmic->regmap)) + return dev_err_probe(dev, PTR_ERR(dmic->regmap), + "regmap init failed\n"); =20 regcache_cache_only(dmic->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_i2s.c b/sound/soc/tegra/tegra210_i2s.c index 7bf76c9b640f..a8b9c0d1e2f3 100644 --- a/sound/soc/tegra/tegra210_i2s.c +++ b/sound/soc/tegra/tegra210_i2s.c @@ -1093,10 +1093,9 @@ static int tegra210_i2s_probe(struct platform_device= *pdev) =20 i2s->regmap =3D devm_regmap_init_mmio(dev, regs, i2s->soc_data->regmap_conf); - if (IS_ERR(i2s->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(i2s->regmap); - } + if (IS_ERR(i2s->regmap)) + return dev_err_probe(dev, PTR_ERR(i2s->regmap), + "regmap init failed\n"); =20 tegra210_parse_client_convert(dev); =20 diff --git a/sound/soc/tegra/tegra210_mixer.c b/sound/soc/tegra/tegra210_mi= xer.c index d9318aaaf32e..b9c0d1e2f3a4 100644 --- a/sound/soc/tegra/tegra210_mixer.c +++ b/sound/soc/tegra/tegra210_mixer.c @@ -814,10 +814,9 @@ static int tegra210_mixer_platform_probe(struct platfo= rm_device *pdev) =20 mixer->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_mixer_regmap_config); - if (IS_ERR(mixer->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(mixer->regmap); - } + if (IS_ERR(mixer->regmap)) + return dev_err_probe(dev, PTR_ERR(mixer->regmap), + "regmap init failed\n"); =20 regcache_cache_only(mixer->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_mvc.c b/sound/soc/tegra/tegra210_mvc.c index 11bd0ea22797..c0d1e2f3a4b5 100644 --- a/sound/soc/tegra/tegra210_mvc.c +++ b/sound/soc/tegra/tegra210_mvc.c @@ -731,10 +731,9 @@ static int tegra210_mvc_platform_probe(struct platform= _device *pdev) =20 mvc->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_mvc_regmap_config); - if (IS_ERR(mvc->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(mvc->regmap); - } + if (IS_ERR(mvc->regmap)) + return dev_err_probe(dev, PTR_ERR(mvc->regmap), + "regmap init failed\n"); =20 regcache_cache_only(mvc->regmap, true); =20 diff --git a/sound/soc/tegra/tegra210_sfc.c b/sound/soc/tegra/tegra210_sfc.c index 0f342fae058f..d1e2f3a4b5c6 100644 --- a/sound/soc/tegra/tegra210_sfc.c +++ b/sound/soc/tegra/tegra210_sfc.c @@ -3598,10 +3598,9 @@ static int tegra210_sfc_platform_probe(struct platfo= rm_device *pdev) =20 sfc->regmap =3D devm_regmap_init_mmio(dev, regs, &tegra210_sfc_regmap_config); - if (IS_ERR(sfc->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(sfc->regmap); - } + if (IS_ERR(sfc->regmap)) + return dev_err_probe(dev, PTR_ERR(sfc->regmap), + "regmap init failed\n"); =20 regcache_cache_only(sfc->regmap, true); =20 --=20 2.17.1 From nobody Wed Apr 1 20:44:25 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010022.outbound.protection.outlook.com [52.101.46.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60C973F7E94; Wed, 1 Apr 2026 11:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042758; cv=fail; b=Iiw2NCVP/OZBSZU4vPaZJHXQp/x0fmCHYSVhkK6o7vfameZ6At2WXZsw7GrFRqp5uyw4KevLN580VxmNFBU5G8fyq+VV0QRpDq8qQ/AbLOMsQHqXoXen7pEdlfUgpPxazYgPbE3VRJSLzikBxBOXLvvgFizoLYWF3wV6+6kLtWc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042758; c=relaxed/simple; bh=yhDJC+TsLxYTd81b/aw0MiU2eVBm88gAm8DZ70cfR2E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q3uljZtDoiL2ktBv8ICcRRio++QFjruAUS0hGYCf3jFI+xuccNPc/HrEM9O6Sogp7s3gMzkxyllyxD8thS20DRWI0Zy/tkvXdvqXsM9rqvq7F5AeH9/yUppS8r6opGEthu8pdDdkMGUGZIhdbFS7MoPNRUDcyMfuXyv7AePKyJ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cXFtdnNb; arc=fail smtp.client-ip=52.101.46.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cXFtdnNb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ujuGCgP9K0JIwQPWj0Lc4b67W69tCst+4w5WuLbCjdfgVzjLbHFs3piOj2nhLrd+8DHq+fN9ElNpLGurqntS2MUnqJNGRonRos1RgH37bELsgJIgeiI2pLauY5seRSv2ir2Np7ccPhW0tgjpr71iXVtSKfNeUOKtr4v+0ixCN5FeOJEaHqkYoxCDm9SIUr/0wjIpfeXmp8YLEN0ST0nRSv7XwNv0KpEwja3P7a46LR3d0id1ed9F3wKYyFHTQRy6z07pONu1nx44K0NyGOVnW8EsATkxFadB9MLRf2CZfX8WRDZYYNzpnGrUebNU89tA4PmGQhVbN4kpGPI1LfAJGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3XngAbde1wUlbS7m3WjRe2mQnkWEHPo9NbAekOxADM4=; b=huE5bEBIzvQ/jTswknclb6Qi3SW2WE1LbQRMmW5DVJ8ekrX0hZPWNSToTLoDfG+0/2Ci0LxpquE6O5Y4oihOcHY+r84cCPoqdHcRWsJUnU8wfbQbqmSgfS11yHWJSIkzV2hFBegNrzBGZcEOKEuv2PyX+N3ajxaHJ0bD2unW0u4ntkXbra0brFAE7K67Aeqio9Y5zUmsuYcUirwaZgP9h3nxPBpJiyK5ODpKEyWZbitKUP8lsysNpSBKDIZGpkbZw6aLfuKhGqKBB4OxeKO4wyNIVxyQt2GoQVHtZI2U6A5tThlFm+RI0M+gsYRTop/Io9LlIqboxBhx6x1ubywi2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XngAbde1wUlbS7m3WjRe2mQnkWEHPo9NbAekOxADM4=; b=cXFtdnNb8KiKsR03qdL5aVzGH6JRbBN593f/fPnojy4il7i9vXBQKyR5KZucXvjetqlP0NjaCVkUxbViMU2MftlScuP9Dj8l8KYp2BgWkz/I1ACh84/Grakp6QNOedoAQNyNSI2gc7TrxuqHylwqRzcJxoIycUa95Q5uF2A++8r+QSfTenWXX9UUOQWhkr5/5kPmG9uAUNXqXl7/A62cmoO5i0Om+IJX2vhK9JaUJAZHDjIZaCt9q+cvfwV+cftrNQFmmC5F5HR2noDs4Gwiv+BsMNpRDOxO3d6kuYDSlULtevOZOXLSTXUvSd2jhk8bkMVLGYTwjI25bcaqBf3gjw== Received: from PH7P222CA0027.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::10) by BN7PPF48E601ED5.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6ce) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 1 Apr 2026 11:25:52 +0000 Received: from SN1PEPF0002BA50.namprd03.prod.outlook.com (2603:10b6:510:33a:cafe::e8) by PH7P222CA0027.outlook.office365.com (2603:10b6:510:33a::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.29 via Frontend Transport; Wed, 1 Apr 2026 11:25:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA50.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Wed, 1 Apr 2026 11:25:50 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:33 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr 2026 04:25:33 -0700 Received: from build-sheetal-bionic-20251202.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 1 Apr 2026 04:25:32 -0700 From: Sheetal To: Liam Girdwood , Mark Brown , Thierry Reding , Jonathan Hunter CC: Jaroslav Kysela , Takashi Iwai , "Mohan Kumar" , Kuninori Morimoto , , , , Sheetal Subject: [PATCH v4 4/4] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe Date: Wed, 1 Apr 2026 11:25:00 +0000 Message-ID: <20260401112500.4076861-5-sheetal@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260401112500.4076861-1-sheetal@nvidia.com> References: <20260401112500.4076861-1-sheetal@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA50:EE_|BN7PPF48E601ED5:EE_ X-MS-Office365-Filtering-Correlation-Id: afecaea1-d0cf-4754-b54d-08de8fe16e16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|1800799024|376014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: dhcZ0pR0m6OmfzJZmDC9EcSAkfgaKckTR9FFfI0+JvRxadsn7G3xFoUXn0VhplHwSrwPWnnO8Pr8WF6AmA6pOvEvZjNs6lhP4ALTiacqUzgwZBMbQKHHzOKoMP2rJdfHVPHh43c6Nb3ry+V5AzHxLLQLIPs7bMygAku41dVCTxIrjJf6tIAnLS4bu5KQs0pZ3dXOwbeWKHSCuzYZMeZfsz+ikgnW7cUpIyemklLpCy0dddaBjaByvCThFhm4RX88YvR6VirK1A5jXzWG1t322xQsZ2AUFNiO2X0bkYxwqSdwwlfTJexNZY7yvvt/NSUddHfKa40EFqpanK0B0Psa+gocKmbohpKF5z7AqYOSo3oX8euPhxQIw07FSHcHaCzuOlI1deusHiEhWL53pnd4mFxVQBvtKU6pcwtXA4SxrDOUlRnnId8NsdGEa10VyxWrZDju7MP4mYkZBZMh7DTUdN6QqriqnEK+n83uyD6xv9HE5BUFDIQt8Pi8YYAIsCfTbGP2BHQUEaScok71d7dZ7E2IADA8/C4DRgsZTLlPF9engZ5sYj0dpG9GEYl6OrfBWIrofLTFsYo34BRWwBfxmmsKbYUtLnkFaS0iua6/vMBXoqJtCQIbfqgTLykqwWEoxc109Bk1UVw06AKaKM0wAz4sipspFNqytJLl+t4QQ2dC0kvn8mo7cunNDYNmJ35WBX+yt6JQgvOXHesbDrV45VP9HRgIJM3/pvZjCFjJ594+Atl+wDMRrspihlNftPwK/gi/CVqX+tI10ekkoOf+Og== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(1800799024)(376014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jTkKAEAWTRhrVvSwOIn4PD91UiV5VNVl5SEkwTW569p9ArWyygO6vDsZjGXkfDajubzgR3ro9cm49RGcfIhPdNdKL3Vphwd1qNtQ2DbHPKPLlEcx6Tv09+QWpSfU7jJRrCW263W+q11jRgWlv0aWMgUv84B+3Z7lbjSchKrIq9JKHX050wxhQZrqc00Hd4IP9qxX4JPB/opncBAmPry8jTiAVpmT4g8vK0rRSbtAMysHOrRSMuP3TnByLAmQyKeyrAs8q39qfGpg/bfEmscHJax0z5Mcnk6vFemaueFV+AoFfgYiGX7v/Nnt/Y6EY8ZT+8YZgufyYpJPxamrrsnZFYHuNcz/0dJ/WOLQ0aW8LvzjLHhO2PmP3ogCTDTK+I0G+vRAj4fzlInkSIEq4KoFnSQ5cKVLZ+zwkuVPyvKUODBG/mJPaOl/wzs8VZGrcwZi X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 11:25:50.9079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afecaea1-d0cf-4754-b54d-08de8fe16e16 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA50.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PPF48E601ED5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for clock errors in the tegra_asoc_machine probe path. Signed-off-by: Sheetal --- sound/soc/tegra/tegra_asoc_machine.c | 21 ++++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/sound/soc/tegra/tegra_asoc_machine.c b/sound/soc/tegra/tegra_a= soc_machine.c index d7245a10bba1..e1f2a3b4c5d6 100644 --- a/sound/soc/tegra/tegra_asoc_machine.c +++ b/sound/soc/tegra/tegra_asoc_machine.c @@ -591,16 +591,14 @@ int tegra_asoc_machine_probe(struct platform_device *= pdev) * host controller and the external codec */ err =3D clk_set_rate(machine->clk_pll_a, 73728000); - if (err) { - dev_err(dev, "Can't set pll_a rate: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, + "can't set pll_a rate\n"); =20 err =3D clk_set_rate(machine->clk_pll_a_out0, 24576000); - if (err) { - dev_err(dev, "Can't set pll_a_out0 rate: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, + "can't set pll_a_out0 rate\n"); =20 machine->set_baseclock =3D 73728000; machine->set_mclk =3D 24576000; @@ -612,10 +610,9 @@ int tegra_asoc_machine_probe(struct platform_device *p= dev) * only needed for audio. */ err =3D clk_prepare_enable(machine->clk_cdev1); - if (err) { - dev_err(dev, "Can't enable cdev1: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, + "can't enable cdev1\n"); =20 err =3D devm_snd_soc_register_card(dev, card); if (err) --=20 2.17.1