From nobody Wed Apr 1 22:21:55 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C880F372B59 for ; Wed, 1 Apr 2026 10:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775040430; cv=none; b=V4ylvJ2xVhVIW2+pRbYQwyPkXiuF80wwcSPHN/knAUV/y1MzIHlAfvB218NzEp49llxk9MmNmXbEupiRY0z8ge+8X5PZfcF1ejdUVVcTgb1Ocyr9Xl38uSzTUyvJw3y4uQ+t2ZyY0i8m1qsXBPBHuLWBeKiv+T8jzg/tZKUkcPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775040430; c=relaxed/simple; bh=RpB1zjwaXHUsRklRUhIXHDbsSlZ0oTS3vlqc/OnKIK0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sdFKYGbsGCWfvpw5OnNNhp/j5CJDihT6ZAIwLj5XmYX84r85CQf9/+wdwv9J+GRjnh9ryA8AVb9fcQFt5n8BUL+lpXerwgCw0BgOFWxr1qQCriTb+5oDzEaKy3F9XdN6RoQ4Ni/EWwPyJxsdH4aPAgNrK6nZJN3WZhkcD4oJ1/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZRaX+DWC; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZRaX+DWC" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b25cf1b5f0so16927565ad.3 for ; Wed, 01 Apr 2026 03:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775040425; x=1775645225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Wa5HXRdFc4yMekK2BPIApP+BH1L7ADzvbTdkQhArixs=; b=ZRaX+DWCMLF6XK6rFY/oVrFYbFzP++xAS+qCilqcV9zRe/908O0ZGe+zENa0o0kwj7 eC2vUaA1teWntEcQjC28SySs/YMcxXn3vCb7hwdSjrXx1p47FvIyCota6/gM5xKP0RuQ XKmWeSm1ykQ7nFDxCU12weiGoCrc0ZzxejRgXeq5M4FcXvbFPfQmhvJQUQIYzkljJ+J/ NlWz9u/jt+TvmoZLLSWnujKCltTeV+XCdY/HHOH6J5PApyN/1jvnMu1Re0ih12/lmhL7 fSYsduvNZ8fWg3gO3XIvzma/pvADXxBd8P+Q01aMrV3V+qsJLT2YFsCMyIquCgKgGTqk QvTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775040425; x=1775645225; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wa5HXRdFc4yMekK2BPIApP+BH1L7ADzvbTdkQhArixs=; b=DUqlV4/nsKG8/Jw+fbDbE3D77K4tzX0TSPyiQBsKQ253GQ0GSBF2fgK7j9lT25nabK 05uBxaL5Y/ewzpL3LuAY1UUWoSoLW3Wuf2OiWJkkXMtKnrqeAtoAYASb+UuSKvWQwNV3 v2O0DIu5bZ0nrXXoooeUceuR88JPCRUUyBAEFdmUAlISNyN18DSPA8LY3hN0zt42GZQ5 XoLfHWMTasE4WmE7G5WNjFaTkzfP05SpZrP6rWiUAvWEO5y6RJ28b314lgUXudlr9+pG Bntsu2HH7BnfzX3Y4TNue6Ur8kkDpoHS89LXGDt81FBz1hiq2Tgi1KE9MYaWBqTdOLJ/ eTjA== X-Forwarded-Encrypted: i=1; AJvYcCUUt8ZtScRmGSSIq35tv1iow7QMulsGCTCiw5tmolOQ+vvcJnkYMWx5znEf91ecxzQ9NlIXeYXhd19BeGs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8J/zJz+xZPUdG0V0b0sOJmViIn9pmCLb0BQ3wWVuIBGJ0ecj5 oheKktMliFtPtigr1suZ2E8Fe0ZLNFUiMuiUqvpHxw0km2gcraGbmekJ X-Gm-Gg: ATEYQzzRauziRUvPlOgv7+2sjk/WGipEkplr/0BzaOzGMUs+88ExuK0r61iDZiI2lsj qSMqtuHzwPKDzE7aCLp3umsfTn5waWxFdqsC6LWBL3OEW72C6gvf8PAz3tAoJLBoqwYID2U3TfL 0GIi17efGnu51mLy0rZx+mwTBbRaZOv1C+4p1yvs0FcyhtcFEwFD7CapmqxeppP8fJjSCbIsH8h HIs8G+d4x0pvKE+jxwxMJ+N8Mbuy9dVWL/ZVblrRdTFwt/zBa594bPYOQ/J5v6OibKttSbHJytO 8NQQb3TTfWNxtIzXRiWO2wY7eLTP1aAQQIVS+Ev2upAUWSTXcpJ1qBWXKqNTCnf67FUt6X8vnV7 ME2iulhvshdvzDUGsq09XrnkECk/+rV4sQCIiNiDw932eweMOkCRZbW/36sNUIU4Ac+OALOKC1r JF3RqS1vHy2chOfXcPhhjkWYSaHs/FSMnbH5FD X-Received: by 2002:a17:903:904:b0:2ae:57e6:616c with SMTP id d9443c01a7336-2b269a80ba6mr33070995ad.3.1775040425448; Wed, 01 Apr 2026 03:47:05 -0700 (PDT) Received: from localhost.localdomain ([220.83.29.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24265aafbsm182439675ad.19.2026.04.01.03.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 03:47:04 -0700 (PDT) From: Taegu Ha To: linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, kees@kernel.org, linux-kernel@vger.kernel.org, Taegu Ha Subject: [PATCH] usb: gadget: f_uac1_legacy: validate control request size Date: Wed, 1 Apr 2026 19:46:11 +0900 Message-ID: <20260401104611.3375330-1-hataegu0826@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" f_audio_complete() copies req->length bytes into a 4-byte stack variable: u32 data =3D 0; memcpy(&data, req->buf, req->length); req->length is derived from the host-controlled USB request path, which can lead to a stack out-of-bounds write. Validate req->actual against the expected payload size for the supported control selectors and decode only the expected amount of data. This avoids copying a host-influenced length into a fixed-size stack object. Signed-off-by: Taegu Ha --- drivers/usb/gadget/function/f_uac1_legacy.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadg= et/function/f_uac1_legacy.c index a0c953a99727..6d6fe5db99f5 100644 --- a/drivers/usb/gadget/function/f_uac1_legacy.c +++ b/drivers/usb/gadget/function/f_uac1_legacy.c @@ -11,6 +11,7 @@ #include #include #include +#include =20 #include "u_uac1_legacy.h" =20 @@ -370,9 +371,21 @@ static void f_audio_complete(struct usb_ep *ep, struct= usb_request *req) if (ep =3D=3D out_ep) f_audio_out_ep_complete(ep, req); else if (audio->set_con) { - memcpy(&data, req->buf, req->length); - audio->set_con->set(audio->set_con, audio->set_cmd, - le16_to_cpu(data)); + struct usb_audio_control *con =3D audio->set_con; + + if ((con->type =3D=3D UAC_FU_MUTE && req->actual !=3D sizeof(u8)) || + (con->type =3D=3D UAC_FU_VOLUME && req->actual !=3D sizeof(__le16)) || + (con->type !=3D UAC_FU_MUTE && con->type !=3D UAC_FU_VOLUME)) { + usb_ep_set_halt(ep); + audio->set_con =3D NULL; + break; + } + + if (con->type =3D=3D UAC_FU_MUTE) + data =3D *(u8 *)req->buf; + else + data =3D get_unaligned_le16(req->buf); + con->set(con, audio->set_cmd, data); audio->set_con =3D NULL; } break; --=20 2.43.0