From nobody Wed Apr 1 23:51:48 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011029.outbound.protection.outlook.com [40.107.208.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD4723F2111; Wed, 1 Apr 2026 10:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775039157; cv=fail; b=sOQBgpbjsxA2VgjXy6jOeFTt2cKCcFOpXEtElUNXd/nMQKXYETKQ+XziSH1DSDsLm3cFAEffGVB+gvbnO4kA2iWugtq114iUCe3K+RiEYNG/vyIJtDJT/fUXf2Nt2uqdYnhOyRtONlfDhq660fACmrtvb0PI3Ro7wSPADL+PkQA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775039157; c=relaxed/simple; bh=eMYNowOFUhuRcDDp73Hi3cFIYgTd17uUvVPQt5dokHU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K7zl+UiV7zS3hPMWiCHqrNn/KSagSv06Bm22nTtC/IQJUgNZcriLlnoy+rMwlSje1chrDL8oTTjQkmD/HYTrPunqeaUmymrEzAULqifB5oS3b0P+w3hA4reQCWrgxu9aNXNw/R0NsfDCkNEF1e0Zjv1SO1PdeA18HszrcPbWLUE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=frBARuNw; arc=fail smtp.client-ip=40.107.208.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="frBARuNw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D2DN7S++DQrXkEqeH01xuI/DqhKpugf87sPgrwMjitLO58ySAN0xljslYKTuwzrNLD0645erpkJDpi2Vd85V7Us/T2uaE9OBufGpi6+k7OnkuKnMU1KwnDptTkna5rJ0KuMZwYwqwkj7lbj9fgiEkSFNkhN1I0RVRanQSCgfapYlGq0rykELAlu8VZMbaUZiz5PJ63Ue1LXQz69xF0bWnTdK9yCo+8ygtaBHmkdRFCXtjPsDRetMjxsrwUiKolbdqz8ipgH3w4iZF8Oj7X2nGjszlrhGaNmemJf095pm0ZopmIrg4O5S8N0Wu/zvSO2hLEes6EBV3QL4MNLiVw8esA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yMe7Azw7JSxyTgI/jHxFnhhmL0JukzyPj2qiasOI90w=; b=toWed/BjhhXT1bi4rXbfOO9feU7DjDT/0LpIx7hhsIhukIeP6xWKZHUWUkgt2R1Qt8JRqpjWIqKHY+ZGHqwOQNOJn35vnB1BMBNAalkxVW5OL5BeX6vDw2x+znrOvYru5CUqEiYT3zPS7wG7dSuvepK9itdt/ws79RifuQHk5JSNgDkjrEdWhF9DiYDtK9taJB/e0g6NG95jk2auql6dxVNxgAzAqo4+wJ31+dpv5OoB1WZ/NvPoRuDIhLxNp1qLx7TWxUkxOQV8ySduIMJj2xn/VsF+gVo8+ArtxB0UJm4HwZfp0DLD1KPV51PEGjGrwFgTHct/8ynW/DhWQdTSJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ziepe.ca smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yMe7Azw7JSxyTgI/jHxFnhhmL0JukzyPj2qiasOI90w=; b=frBARuNwoalReaCcGyejVs7+IMBHRwJEw0W1xaw+yatlm5JODB2sciHYcywjTsb08Wzl6fOS/hpsfjN9uPW2KStAT1svGN+N8trGVfL4A5iwCWbEYblK13H8xeY8PQ4oCiosb5uhoAF8gZ6kAznbKOlElVlcynIfz83G+VEowk4= Received: from DM6PR03CA0073.namprd03.prod.outlook.com (2603:10b6:5:333::6) by SAWPR12MB999142.namprd12.prod.outlook.com (2603:10b6:806:4e1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 1 Apr 2026 10:25:51 +0000 Received: from DS3PEPF000099E0.namprd04.prod.outlook.com (2603:10b6:5:333:cafe::be) by DM6PR03CA0073.outlook.office365.com (2603:10b6:5:333::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.30 via Frontend Transport; Wed, 1 Apr 2026 10:25:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by DS3PEPF000099E0.mail.protection.outlook.com (10.167.17.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Wed, 1 Apr 2026 10:25:50 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 1 Apr 2026 05:25:49 -0500 Received: from xhdipdslab46.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 1 Apr 2026 05:25:46 -0500 From: Abhijit Gangurde To: , , , , , , , CC: , , , , , Abhijit Gangurde Subject: [PATCH 4/4] RDMA/ionic: add completion timestamp to CQE format Date: Wed, 1 Apr 2026 15:55:01 +0530 Message-ID: <20260401102501.3395305-5-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260401102501.3395305-1-abhijit.gangurde@amd.com> References: <20260401102501.3395305-1-abhijit.gangurde@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E0:EE_|SAWPR12MB999142:EE_ X-MS-Office365-Filtering-Correlation-Id: 6884ffcd-c2cd-4afc-dc53-08de8fd90bfd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700016|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: I4kDUpiUVez6sgvKdYIG2nhx6n/nrKUiuG6DBnLdVju9zgFKGUlTJVqYk868zremDbViTG7VXGpkmgxjANuOL1B2mKmVrz3c7GVDmMmt8SoUmhbHiFpMMN25nP9mWcMjaXbmrSkWot9/jTyse+tVM8r37xg5J2nWg/mGIARKxD8CuxU2YaaMtpF+5rVp7I0bT5yzjGcTHGgveOjNTnmHhWfgBBVYhMHQf9EbspjyrPjU9gKuBc7wron6TiU4NIVCaif375HLp7VOxgHml+YyWCJSPVpFM0abslpFgEZLQJqkhUCOwMQWHZbYkCr//p767OKQwUjFmpRFl5DYEuB/LaEaWC3HAaVBr+JPqxOHoSeGMlR7pTd+PbV2rh6TtOmol89WUODP0k4AveRHxa+im0o98B05/ZGWYTMFUU12+Buj8/d2NaW9dU1YJSOkau26zUREOnjcbJv4Z1CC65MfVREvP1q0EAmrBMDmd40YJD4BdIz7WBuLk58nrweoC4o0wXk9Lr72cK5Xgwil5SzF3FgZc0lxltqYV82RPSfPvuox9jSn9u7eDCsFrCMXNvUbfWgUHwIfDkReuEdwSCeA4y9R7IAklBG1tJc+K2TFpWN7gioXlhrjWE/tZzDStg9vT+AADWiCdW5RX2p3PnnjxOOPSGx0BNsD2Lx+2mVDJ221ekkL0uBO0y8N2rtIkOsBx1+MKTpL/QR8NGLYQAIAaQhFkp82/u3NcUq3swCe7q2XEOvdVXvKhoKnBZQdu/jZZiTWpcjy5OTjhHqS1dIRaQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700016)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZVSPEImS2QiqFg3W0cHxDHcZuxa6VvwTlqJuavfwne8JsiJIjpU5Vq83pEy3Kw+UAV9kYkGceGwpppOdv9+GFaUP+I5Jr+a8TEf0bMjarz8Kz8t45F7eBZreJ/z/MwLYKfdpb92p7w/7pXqgqY07yno3gajzMlfj1NgHnC3u0zcBPf0kAIro/C9tBf+Y0n4tTidK/jiXamG0pVSNyR7QrQiIO0CRvtxzzBF1m5iInLyRZGTGYKhcz0vON/Z+3IcVqAmNAxTE/Q8KeWXIViuEDkNlhpq3rosqJqKrh+GKzJl1/1NCty7jSGF4M4NeyTXXYRkttE5Ps+doCIs4nntyJJJTsvvu8kfjv4n9pUjJ+rzOqeGXrbTIIULL6nLq6BGBWjurV6yoiV9p34N5avsKC/RReypgDJD1YVFj4e9q496Q0AX6Q6wh/Az6qa+06mfH X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 10:25:50.4282 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6884ffcd-c2cd-4afc-dc53-08de8fd90bfd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E0.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR12MB999142 Content-Type: text/plain; charset="utf-8" Update the CQE structure to include hardware timestamp. When firmware supports RDMA completion timestamps, the hardware populates the timestamp field. Co-developed-by: Allen Hubbe Signed-off-by: Allen Hubbe Signed-off-by: Abhijit Gangurde --- drivers/infiniband/hw/ionic/ionic_datapath.c | 43 ++++++++++---------- drivers/infiniband/hw/ionic/ionic_fw.h | 12 ++++-- 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/drivers/infiniband/hw/ionic/ionic_datapath.c b/drivers/infinib= and/hw/ionic/ionic_datapath.c index aa2944887f23..3e2300f7ea10 100644 --- a/drivers/infiniband/hw/ionic/ionic_datapath.c +++ b/drivers/infiniband/hw/ionic/ionic_datapath.c @@ -32,6 +32,7 @@ static int ionic_flush_recv(struct ionic_qp *qp, struct i= b_wc *wc) { struct ionic_rq_meta *meta; struct ionic_v1_wqe *wqe; + u64 wqe_idx; =20 if (!qp->rq_flush) return 0; @@ -40,21 +41,22 @@ static int ionic_flush_recv(struct ionic_qp *qp, struct= ib_wc *wc) return 0; =20 wqe =3D ionic_queue_at_cons(&qp->rq); + wqe_idx =3D le64_to_cpu(wqe->base.wqe_idx); =20 - /* wqe_id must be a valid queue index */ - if (unlikely(wqe->base.wqe_id >> qp->rq.depth_log2)) { + /* wqe_idx must be a valid queue index */ + if (unlikely(wqe_idx >> qp->rq.depth_log2)) { ibdev_warn(qp->ibqp.device, "flush qp %u recv index %llu invalid\n", - qp->qpid, (unsigned long long)wqe->base.wqe_id); + qp->qpid, (unsigned long long)wqe_idx); return -EIO; } =20 - /* wqe_id must indicate a request that is outstanding */ - meta =3D &qp->rq_meta[wqe->base.wqe_id]; + /* wqe_idx must indicate a request that is outstanding */ + meta =3D &qp->rq_meta[wqe_idx]; if (unlikely(meta->next !=3D IONIC_META_POSTED)) { ibdev_warn(qp->ibqp.device, "flush qp %u recv index %llu not posted\n", - qp->qpid, (unsigned long long)wqe->base.wqe_id); + qp->qpid, (unsigned long long)wqe_idx); return -EIO; } =20 @@ -133,8 +135,8 @@ static int ionic_poll_recv(struct ionic_ibdev *dev, str= uct ionic_cq *cq, { struct ionic_qp *qp =3D NULL; struct ionic_rq_meta *meta; + u16 vlan_tag, wqe_idx; u32 src_qpn, st_len; - u16 vlan_tag; u8 op; =20 if (cqe_qp->rq_flush) @@ -144,7 +146,7 @@ static int ionic_poll_recv(struct ionic_ibdev *dev, str= uct ionic_cq *cq, =20 st_len =3D be32_to_cpu(cqe->status_length); =20 - /* ignore wqe_id in case of flush error */ + /* ignore wqe_idx in case of flush error */ if (ionic_v1_cqe_error(cqe) && st_len =3D=3D IONIC_STS_WQE_FLUSHED_ERR) { cqe_qp->rq_flush =3D true; cq->flush =3D true; @@ -160,20 +162,19 @@ static int ionic_poll_recv(struct ionic_ibdev *dev, s= truct ionic_cq *cq, return -EIO; } =20 - /* wqe_id must be a valid queue index */ - if (unlikely(cqe->recv.wqe_id >> qp->rq.depth_log2)) { + wqe_idx =3D le64_to_cpu(cqe->recv.wqe_idx_timestamp) & IONIC_V1_CQE_WQE_I= DX_MASK; + /* wqe_idx must be a valid queue index */ + if (unlikely(wqe_idx >> qp->rq.depth_log2)) { ibdev_warn(&dev->ibdev, - "qp %u recv index %llu invalid\n", - qp->qpid, (unsigned long long)cqe->recv.wqe_id); + "qp %u recv index %u invalid\n", qp->qpid, wqe_idx); return -EIO; } =20 - /* wqe_id must indicate a request that is outstanding */ - meta =3D &qp->rq_meta[cqe->recv.wqe_id]; + /* wqe_idx must indicate a request that is outstanding */ + meta =3D &qp->rq_meta[wqe_idx]; if (unlikely(meta->next !=3D IONIC_META_POSTED)) { ibdev_warn(&dev->ibdev, - "qp %u recv index %llu not posted\n", - qp->qpid, (unsigned long long)cqe->recv.wqe_id); + "qp %u recv index %u not posted\n", qp->qpid, wqe_idx); return -EIO; } =20 @@ -408,7 +409,7 @@ static int ionic_comp_msn(struct ionic_qp *qp, struct i= onic_v1_cqe *cqe) static int ionic_comp_npg(struct ionic_qp *qp, struct ionic_v1_cqe *cqe) { struct ionic_sq_meta *meta; - u16 cqe_idx; + u16 wqe_idx; u32 st_len; =20 if (qp->sq_flush) @@ -430,8 +431,8 @@ static int ionic_comp_npg(struct ionic_qp *qp, struct i= onic_v1_cqe *cqe) return 0; } =20 - cqe_idx =3D cqe->send.npg_wqe_id & qp->sq.mask; - meta =3D &qp->sq_meta[cqe_idx]; + wqe_idx =3D le64_to_cpu(cqe->send.npg_wqe_idx_timestamp) & qp->sq.mask; + meta =3D &qp->sq_meta[wqe_idx]; meta->local_comp =3D true; =20 if (ionic_v1_cqe_error(cqe)) { @@ -811,7 +812,7 @@ static void ionic_prep_base(struct ionic_qp *qp, meta->signal =3D false; meta->local_comp =3D false; =20 - wqe->base.wqe_id =3D qp->sq.prod; + wqe->base.wqe_idx =3D cpu_to_le64(qp->sq.prod); =20 if (wr->send_flags & IB_SEND_FENCE) wqe->base.flags |=3D cpu_to_be16(IONIC_V1_FLAG_FENCE); @@ -1205,7 +1206,7 @@ static int ionic_prep_recv(struct ionic_qp *qp, =20 meta->wrid =3D wr->wr_id; =20 - wqe->base.wqe_id =3D meta - qp->rq_meta; + wqe->base.wqe_idx =3D cpu_to_le64(meta - qp->rq_meta); wqe->base.num_sge_key =3D wr->num_sge; =20 /* total length for recv goes in base imm_data_key */ diff --git a/drivers/infiniband/hw/ionic/ionic_fw.h b/drivers/infiniband/hw= /ionic/ionic_fw.h index adfbb89d856c..ee23062a1762 100644 --- a/drivers/infiniband/hw/ionic/ionic_fw.h +++ b/drivers/infiniband/hw/ionic/ionic_fw.h @@ -332,7 +332,7 @@ struct ionic_v1_cqe { __le16 old_rq_cq_cindex; } admin; struct { - __u64 wqe_id; + __le64 wqe_idx_timestamp; __be32 src_qpn_op; __u8 src_mac[6]; __be16 vlan_tag; @@ -342,13 +342,19 @@ struct ionic_v1_cqe { __u8 rsvd[4]; __be32 msg_msn; __u8 rsvd2[8]; - __u64 npg_wqe_id; + __le64 npg_wqe_idx_timestamp; } send; }; __be32 status_length; __be32 qid_type_flags; }; =20 +/* bits for cqe wqe_idx and timestamp */ +enum ionic_v1_cqe_wqe_idx_timestamp_bits { + IONIC_V1_CQE_WQE_IDX_MASK =3D 0xffff, + IONIC_V1_CQE_TIMESTAMP_SHIFT =3D 16, +}; + /* bits for cqe recv */ enum ionic_v1_cqe_src_qpn_bits { IONIC_V1_CQE_RECV_QPN_MASK =3D 0xffffff, @@ -423,7 +429,7 @@ static inline u32 ionic_v1_cqe_qtf_qid(u32 qtf) =20 /* v1 base wqe header */ struct ionic_v1_base_hdr { - __u64 wqe_id; + __le64 wqe_idx; __u8 op; __u8 num_sge_key; __be16 flags; --=20 2.43.0