From nobody Wed Apr 1 22:13:35 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A29F3C870F for ; Wed, 1 Apr 2026 09:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775037363; cv=none; b=LJQajixL3oMrNW75Ml9Z9NYAQKvY2R0/xNy/iuU93oO7QhF3F43bd8SyDXygoa+/SO67ynskmy4tSkQKgxkIt4JH5bkb0Lg15Amxb1akW0pJr9WMFI8NBX3tf3Wfb1bKA7xF/BWezb/pvadH1goFEMfUeqBuh7sLrsm+C8ZHkjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775037363; c=relaxed/simple; bh=tiYTYzp9bW7B7jkM2WWdELXBTZhuAa0UTOdmZoqjm7A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bmq8adMmo+tIl+4TflypB1xjGFYewkn+EGTSuD+7JrTrG1Zhw7RETTWrAVf1xtZ2+60YLy4GXmk3/BG5vqFssWwBK/V+JcQj5nKieLaPcAj5stOtouAsWA0x+1spcssXUrt1hdJIQ2c6bjdaY3wwW0b1a931SczHycLt00Jkr+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aPWy/hSB; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aPWy/hSB" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35d99bae2ebso3522716a91.3 for ; Wed, 01 Apr 2026 02:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775037359; x=1775642159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E/70nvkTwJH8CKcaLaRMPuxVj7zvjvKJvMDTD6/tTM8=; b=aPWy/hSBBp6i4Pup7F3KM3Ak/cHBvNXhowwfhV/xdD6hTpa/tjrwCB45R8swiKJTDT W2qvPUdkLUBLLGNFRxoSyyGPdKWg9WCOEl9Q+8VKq1e5Y1nBwIkHe8CfD9IFenMlnfCC aIZIVOE3DUaY8LCc6NIP9By4L5cTYSM2fIoKr+NVaNJYETARJjE2YZ4Pz/G1St8HU4RE H1zjGiY0l5OB6rtm9Xh/hhK/Sv5C/dcMutMCU+RTBBW3J9bYy02lG/jTIiMeHBI6Cp4Z Tsu2gNHaF3b4EVhNHDCm3CZHurw96v6bCttV6creSgLudz7wO5eFLRJ1zcH0fcnJQ8oD 1bCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775037359; x=1775642159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E/70nvkTwJH8CKcaLaRMPuxVj7zvjvKJvMDTD6/tTM8=; b=IG5vjqAfk6QM4qmz23ODyTkbUxEt22loeD4nnMMj5PmgWAEj+nNhJm5QXKWqkJMF5C i82gLTBFYsdJ1Ag5MZit1M8bv+VLo1w0auK0aBVNiVUoyhJBcZvhXOCm45oGmAUe+Cbu glbdcD3lL17Pq/+34Emii80nmYRBry0h5BfoOE6ea8W05/14FG9wByx7FQj/GQqh4mJ5 JzSvZrFOgg26gZUz5Gt4NGHZdI7qNXsMPjrESl2cmJTqpph67bzMKnXqJqnIqTSzotdg A/Jz0oSg7oZkrwDpaGjAfz3Ld5JzbZHHcOj3lPKzkrU8CxTqWV80IIaq71dHGeTAcy2Z sVdA== X-Forwarded-Encrypted: i=1; AJvYcCXweAUsiBBrtN1oEOD7ojAXjMwxDJ820a/mcvSbmdVPBhEPlCv6PQGxHe7mxCQJ0RXusWxmo18IK78NfKw=@vger.kernel.org X-Gm-Message-State: AOJu0YxaUvJngRbfbqeMMVBovUEKEvM3oIMUg2vYqPMk8+j5Bc09H8qc /kNynUFzXIx59BlAFMVDx03b2TQx+xK3wOCsBE/Ju4d415yly9DbvuPh X-Gm-Gg: ATEYQzwmLBeKnEmYbb+X9oWnNBnXOVpS5KfDQ+GYdOkSxH/Mt/6s4WkNHa7K3tmZF9y C5Jm9uqLzDYqNpHgq/vJetzWd0tY9Bm6J290J+MM01ogWs7vKvVZdEZw2z9/ngV+wQuXac5qQE6 4bnd08Wh6TCKuA0cW8acVdyMPLZB6J9g2sBr41oT8HBqex+ub+1Gm3l8rcV0OSa33cghN1veXYL atAVddMbyMdj5FH6xk3ngBB9B19yQUXzOVq0QeZRAfRpVYjzSm+9XTqPdkAe3ky/lNvjGRkfuhf ClAvgdlhtLlW+UHfs/soRLtkQvmLDpi5qxpzcy9IQmRWzh9ABhczTy8kbJB57PxIGuXB2UFB0iP toRahDeDRIljPCZCUzZXpfsfk2rhBsB3SIGBzCRi0yR18admeIdOJaKEcN2RKOro3RxIRv5r5fg mnakMCQvmSFixtqXJPLfm8O1uWwHFswQltxA== X-Received: by 2002:a17:90b:4ccc:b0:35c:30a8:319 with SMTP id 98e67ed59e1d1-35dc6d2edfemr3116870a91.0.1775037359400; Wed, 01 Apr 2026 02:55:59 -0700 (PDT) Received: from aadarsh.. ([2401:4900:88eb:1866:2f80:3df2:d843:38a7]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-35dbe5e5127sm5774380a91.1.2026.04.01.02.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 02:55:59 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com, Aadarsh Mandal Subject: [PATCH v9] staging: rtl8723bs: remove commented-out code Date: Wed, 1 Apr 2026 15:25:50 +0530 Message-ID: <20260401095550.33943-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318021005.6346-1-aadarshmandal9354@gmail.com> References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove code that is not used anywhere in driver. Signed-off-by: Aadarsh Mandal --- v8: - Restore the formatting of non-commented code. v7: - Change in commit style. v6: - Change in commit style. v5: - Change in commit style. v4: - Remove extra space insertion. - Delete remaining commented-out code. v3: - Add the extra space that count as insertion. - Remove unwanted addition. v2: - Restore braces for standalone code blocks {}. - Delete reindented commented-out code and extra space. v1: - Reindented commented-out code;extra space remained. --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 29 -------------------- 1 file changed, 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index f2f73c65a636..1281aaf0515f 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -46,8 +46,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) u16 value16; u32 value32; u8 ret; -/* u8 bMacPwrCtrlOn; */ - =20 /* all of these MUST be configured before power on */ =20 @@ -69,10 +67,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) value16 |=3D EnPDN; /* Enable HW power down and RF on */ rtw_write16(padapter, REG_APS_FSMCO, value16); =20 - /* Enable CMD53 R/W Operation */ -/* bMacPwrCtrlOn =3D true; */ -/* rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */ - rtw_write8(padapter, REG_CR, 0x00); /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ value16 =3D rtw_read16(padapter, REG_CR); @@ -359,7 +353,6 @@ static void _InitNetworkType(struct adapter *padapter) value32 =3D rtw_read32(padapter, REG_CR); =20 /* TODO: use the other function to set network type */ -/* value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AD_HOC); */ value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AP); =20 rtw_write32(padapter, REG_CR, value32); @@ -410,9 +403,6 @@ static void _InitAdaptiveCtrl(struct adapter *padapter) value32 |=3D RATE_RRSR_CCK_ONLY_1M; rtw_write32(padapter, REG_RRSR, value32); =20 - /* CF-END Threshold */ - /* m_spIoBase->rtw_write8(REG_CFEND_TH, 0x1); */ - /* SIFS (used in NAV) */ value16 =3D _SPEC_SIFS_CCK(0x10) | _SPEC_SIFS_OFDM(0x10); rtw_write16(padapter, REG_SPEC_SIFS, value16); @@ -486,9 +476,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); =20 @@ -640,9 +627,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } =20 - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -661,8 +645,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 rtl8723b_InitializeFirmwareVars(padapter); =20 -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; =20 @@ -704,8 +686,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->RfRegChnlVal[1] =3D PHY_QueryRFReg(padapter, (enum rf_path)1, RF_CHNLBW, bRFRegOffsetMask); =20 - - /* if (!pHalData->bMACFuncEnable) { */ _InitQueueReservedPage(padapter); _InitTxBufferBoundary(padapter); =20 @@ -745,11 +725,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET= _DONT_CARE); =20 - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx= ; */ - rtl8723b_InitAntenna_Selection(padapter); =20 /* */ @@ -791,8 +766,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TX= Q_CTRL) | BIT(12)); =20 -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HR= PWM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; =20 @@ -1080,8 +1053,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; =20 -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEP= ROM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } =20 --=20 2.43.0