From nobody Wed Apr 1 22:35:53 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5608E40DFCA for ; Wed, 1 Apr 2026 09:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775036464; cv=none; b=d+axvgTmcpSsLXUef7IrlIETOvfwEakCc5soy0tkBhCHXW6wPu8KUAEottLZ3caqJ4M7K3fC4K1M5c8QTn2eC8OcrHRvCFUG+bsMRKgStg6j45bvV1TJ0zFFH0qWGdrP8ip7NR4lTiokSoSQQuRRCBEPPYMylmnO4Q/J/RKvF9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775036464; c=relaxed/simple; bh=OYYUWkgCxAQGpQCSIvAQ1bkD3r6IuE5Qn3pidaElBqg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YaxTvvZ8AtgK6oQubaaEWdHB5N70ggNtILGIPr0tb7tlraiY+Q3RDFhEDAqARVjfGG+eGD0QQPhYWhG3vRVe+T74j/JxNuK296EijsCngV/E/Gw57f0RyoOy07bF2dHeEKdYaByRxQ23yZmgvtFtxVtxFUmHS6/Soo0eWGa7vrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ss2mXuD4; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ss2mXuD4" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b25cf1b5f0so16466345ad.3 for ; Wed, 01 Apr 2026 02:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775036461; x=1775641261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RO4ZhYSZqYOFn/guHJmRqbXOWS6aNnS9NZJLkKz5OII=; b=Ss2mXuD4qD61P+GugJKl1FNimk0k84zHilguKNwscc0FoGm+EOH6VFaKhQSibXg4wC ZXf1B7oDno1nvem7exL0sJ7N6YW7GO2nd/HdpOB/Ks5sx/rbcgqoS5j7qfwcrMAg9PsD dBxRLQwAfZM9KMB8f3JuxE7QHZyhHEsbBRnf4UhgU24rV+chWFhZPVeaMo8to4z/ny0E NP4VPUgX4fCuHHwjGdaoYrJCxi61aTZnJ4+vCgVB4cMUEBrXI914UWybIHpqDoFbVvTA zun2hy/eYeGtStOTnmdinAvHeCiHmzOsp32zflyAiuBOPkTciwbTI/wtR1hF7frtqBBk TrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775036461; x=1775641261; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RO4ZhYSZqYOFn/guHJmRqbXOWS6aNnS9NZJLkKz5OII=; b=YPrhb7OYOb2ofY8V8sMN1FPStKo7vnEPUD55sLbwQoCSi/RSDx1yJzmf8k6makluhY op3dnXGZyGA3B5ps29zPuYQeeFOE/bfaQiqmP59GwodP6ZHYuTfpznXz80rppiAp8FkV NbmH20aiIbZHV5vlBJCLwQ7uumYIZJIqO4qhdGlsHvRpIDMmCw7iD1ph6pb9XlPJ6XwO 8JSdKgLqNhc7Vx+Rl48H9EzbU77Arbsup24O3K6ykF3C5eIJRMrm8NHi4JeuWKZ4hz+W szjM+CeuW3LeSMKU6z9u+5AQdNlpf5+yxsi1hgqYvOkk9ULHYYb5GyQy1NdOtlTif5rW 8otA== X-Forwarded-Encrypted: i=1; AJvYcCX/sDm9wpzQj6+tyHbSSVp9f8Y/i0ZFPDzUyEO+sP2Z1ePr0hIWR/MlELrTBEt9SgOC+YN3WXF+Sgpepjs=@vger.kernel.org X-Gm-Message-State: AOJu0YxSMKzy1RbW2Bo5VreQlRkmMSQ9GdJ27/hOQy2SYtmprB/ehFYK TrNAaOjonY/4v7ZVEKN9ta+MgJkZVv+mXPO5Fub9Y0KA/0uuHhCNTJ6i X-Gm-Gg: ATEYQzzgMJ5JLg1gH02Yq6z+jyf/bdRrw4YYNULzQxu/jh8BZgjN00uKemiVON5d9Jq gZ2Ku7qpA6NzoGJGvtwgQsYbZmUERmsHJep7zNsYVXIawHWjZ4H0nMu+M0VTz8nhAtjoDjIUSub WE4zjPEA8katdimyJ4RDWJGh/1SyCaB9snRNvdLVrFf9dkrIwZ69JJl1riMLaM86yenrxWGwcsA zFT92ODnDNL1UH++O6jd240alsv12x5Ea65DhPTd5bSJs0qDROn7s56eCzgzFSBrIEWdBAoox5X E5QMrKXpOy3niwphiKxGV90VMqNv9oBYVbuAGwsICW2vxZccV44IIIYAKrlZtpiEScWC5AeydT8 RKHJm+71/xeaPPq8aIXn5saYsnZeg4lJ1GbL0CvIhZtpuzUeXowi6dWonmtQdvsj721p7dcBunq vo9dluMXrVY1q2Z/EZC7RM X-Received: by 2002:a17:902:7610:b0:2b0:6365:21a9 with SMTP id d9443c01a7336-2b269c3f058mr21308135ad.31.1775036461375; Wed, 01 Apr 2026 02:41:01 -0700 (PDT) Received: from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642913sm140147225ad.10.2026.04.01.02.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 02:41:01 -0700 (PDT) From: Guangshuo Li To: Vinicius Costa Gomes , Dave Jiang , Vinod Koul , Shuai Xue , Fenghua Yu , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] dmaengine: idxd: fix double free in idxd_alloc() error path Date: Wed, 1 Apr 2026 17:40:03 +0800 Message-ID: <20260401094003.1482794-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When dev_set_name() fails after device_initialize(), idxd_alloc() calls put_device(conf_dev). For these devices, conf_dev->type is set from idxd->data->dev_type, which resolves to dsa_device_type or iax_device_type, and both use idxd_conf_device_release() as their release callback. That release callback frees idxd, idxd->opcap_bmap, and releases idxd->id, but the current error path then frees those resources again directly, causing a double free. Keep the cleanup in idxd_conf_device_release() after put_device() and avoid freeing idxd-managed resources again in idxd_alloc(). Fixes: 46a5cca76c76 ("dmaengine: idxd: fix memory leak in error handling pa= th of idxd_alloc") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/dma/idxd/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index 4eff74182225..94ce52565e7a 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -635,7 +635,7 @@ static struct idxd_device *idxd_alloc(struct pci_dev *p= dev, struct idxd_driver_d =20 err_name: put_device(conf_dev); - bitmap_free(idxd->opcap_bmap); + return NULL; err_opcap: ida_free(&idxd_ida, idxd->id); err_ida: --=20 2.43.0