From nobody Wed Apr 1 22:13:35 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B8F3321A1 for ; Wed, 1 Apr 2026 09:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035323; cv=none; b=YgyVh4Pae3fXetTEAumhlFjJzvS85vNcCbUoFQiPfkOojNfX1Azdnv9AAaO6/2sZsEYg5sRbKz/dh4b8mQR8QUogBkWtj1dGjD9/tPhBABGbq1ri28HYv1eLfcDLxdEZgq4dxy2Rvgo3J1gXZRfIABwPakZAPmcf/h8rgFuvrVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035323; c=relaxed/simple; bh=5n2wUfF38eHe2KG7fl6sKQK4heAIadpsxH8OnzLRvl0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UChcXEhxrKvajNrx9J5vEVg9oC1iT6YaC/kjXFflLmf1B3oYsFc039cv31rlf1RAbm9ng/hTIqTn92kWBI3AKxA0a/85p8LjfqJhroqooHo/rtAgQxdLjXhDH/V+inoagICdGED3v/c7s4NAzqNbT5ZRbHydfSauXrpxWeTa0gQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MqrFnAio; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XvCfjZD9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MqrFnAio"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XvCfjZD9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775035319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5Q6ei+ntkpvDAF7nzvhz0eKbU/9b0wmVLzSpYnM4X8M=; b=MqrFnAioSDDUKu3PzYH22sB2SXC2aXr16eAs/6nRp5iToF/K06cpsyt3IaCs2YpLHG2Bm0 Z3kYeGFvuBTXzteQ3qLi0PooSzypWL7P1twYhZThdPvWxbBKuDlQcAGYWpG9DMVrpv6qnW Mbf8c9xkWZM0dnC6C1EYKGtjseIBCqo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-u3CwTugfM2qTx7YwrJeybg-1; Wed, 01 Apr 2026 05:21:58 -0400 X-MC-Unique: u3CwTugfM2qTx7YwrJeybg-1 X-Mimecast-MFC-AGG-ID: u3CwTugfM2qTx7YwrJeybg_1775035317 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4853466655dso47316465e9.3 for ; Wed, 01 Apr 2026 02:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775035316; x=1775640116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Q6ei+ntkpvDAF7nzvhz0eKbU/9b0wmVLzSpYnM4X8M=; b=XvCfjZD98im5Td+m49bEcdvqtx8XSsjuOMZ/ILr5oxlcvQFhkXNJ4DDMRoATsKEE/Z q4wkF0RkVQYgFr6Cha0H+d+7vnRLFLqN7DhrcZtCrEtmlw8h9utlcTogYdlEh+i43Ijx aCEZuA5x1aSedInLSI0YjkhcSt5UJSrWkZIcOp32f201k/CcC09EM8fwm8g+DQfU1XbG QLeLtCY9RP2i5kzG/hWm9e4XQbVkRnMWorFc2PKdKJzr5EAE0BjNc/vNi1K6FIxoHBgs oY02k2ll+Bcp0iJojtEN4vk4TC+jjX8LJXbVbWO9hbL1goo64So6+a5ZgWLSV31wxJ/6 ml9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775035316; x=1775640116; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Q6ei+ntkpvDAF7nzvhz0eKbU/9b0wmVLzSpYnM4X8M=; b=h6yd5Bh5k7sst94QEdGroyY0XnBYmPF/dm00RK41d6hFyPQxqSTJSO8ugopTy/Wl7E x+mvzMT+T6KwVWjLJpyj4WLld041Z+2FbwJooxnN2gnEw/G9bRX3CXfhTgAw1UdDtnqg WOI6vaxQb8ZBT3T3r2q6vyzONrakqDIWEq74sZeMfbBPF0RvkoHb5j0g3DbX+ahCHeWh n5K8LftMSKQdnj3sEdEOLF7EgQlkbQKgDT2W27lQMU0DdfCjzKVu4dBHFQqG1t3mYsRk LqJMfarRIbV8nnbV4/Q8saWeBuxr3BRawcz1P1fJRSSw1HQH/3Nne2UW4o+6v1P/pOsY dfaA== X-Forwarded-Encrypted: i=1; AJvYcCVvDi0FRj8JyhuodkmXuftqx/TEt1snww+g4pTAZHAWE6Hrd5v0TyutbTmkd7tX21SijVYqr/rrV2zvYU4=@vger.kernel.org X-Gm-Message-State: AOJu0YyORRnj6GnMwDc8aQJ4vwUdrDCcTUpkdzEbWWDH1lGt1FczUb1E bqeyJM/5y0Id1bsruv2I8WOEUJ4OFZm3LwvsKFbkzLjy3xzo55Gzi3z6zcpwFcbZt1vGLSE6ICd 6ziY3QIl4LGcSsrbEoUEyi/LCChhItzr+m1+ttrSp9azEKgrh8N6FC/OkQ0itpYm48W3T01q3Yw == X-Gm-Gg: ATEYQzysR2Z4QCO/UV743FLClhMwylwMgE51rrDOCY5toQah3D7iFXGnp4HGEvo52UG Wwxi57lyK3ivHErMZIOlN41yvaEUH6YVFqF5yopEFmkh8g1RKgGsTklltKupsxJs+/4NrBd6aTR AKbXTX73b0uQbP5ZzWPT7pGDgmlO+SQLrgzjDI81YCUYsONAVIrD9nxlBp3B8j0pz/XFcd0d5Xn xgwgiAq0pNQ9Sij7DFFv275BUuYMiQ04xOMBYwLP/lTe6ZzfNqVvQWX9TcIcXXNPb03z+Fyiff6 YWyx51xrrmbbyS/GCyFUboCodNoVfY77H3/h3K6ifJYKxq9ezpErb2mgrkXinL5QX7sP6c+dFS1 WbmXKbvzlFjG14mqCDWaFJki69ZsoRJyvIh5qltb/rXuzVO6tHbAPiCSCI6T/JHs= X-Received: by 2002:a05:600c:3ba5:b0:471:700:f281 with SMTP id 5b1f17b1804b1-4888359db41mr42390905e9.25.1775035316240; Wed, 01 Apr 2026 02:21:56 -0700 (PDT) X-Received: by 2002:a05:600c:3ba5:b0:471:700:f281 with SMTP id 5b1f17b1804b1-4888359db41mr42390465e9.25.1775035315693; Wed, 01 Apr 2026 02:21:55 -0700 (PDT) Received: from stex1 (host-87-12-139-105.business.telecomitalia.it. [87.12.139.105]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887ad477f6sm38285485e9.7.2026.04.01.02.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 02:21:55 -0700 (PDT) From: Stefano Garzarella To: netdev@vger.kernel.org Cc: Stefano Garzarella , "David S. Miller" , linux-kernel@vger.kernel.org, Bobby Eshleman , Jakub Kicinski , Simon Horman , virtualization@lists.linux.dev, Eric Dumazet , Paolo Abeni , Jin Liu Subject: [PATCH net] vsock: initialize child_ns_mode_locked in vsock_net_init() Date: Wed, 1 Apr 2026 11:21:53 +0200 Message-ID: <20260401092153.28462-1-sgarzare@redhat.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefano Garzarella The `child_ns_mode_locked` field lives in `struct net`, which persists across vsock module reloads. When the module is unloaded and reloaded, `vsock_net_init()` resets `mode` and `child_ns_mode` back to their default values, but does not reset `child_ns_mode_locked`. The stale lock from the previous module load causes subsequent writes to `child_ns_mode` to silently fail: `vsock_net_set_child_mode()` sees the old lock, skips updating the actual value, and returns success when the requested mode matches the stale lock. The sysctl handler reports no error, but `child_ns_mode` remains unchanged. Steps to reproduce: $ modprobe vsock $ echo local > /proc/sys/net/vsock/child_ns_mode $ cat /proc/sys/net/vsock/child_ns_mode local $ modprobe -r vsock $ modprobe vsock $ echo local > /proc/sys/net/vsock/child_ns_mode $ cat /proc/sys/net/vsock/child_ns_mode global <--- expected "local" Fix this by initializing `child_ns_mode_locked` to 0 (unlocked) in `vsock_net_init()`, so the write-once mechanism works correctly after module reload. Fixes: 102eab95f025 ("vsock: lock down child_ns_mode as write-once") Cc: bobbyeshleman@meta.com Reported-by: Jin Liu Signed-off-by: Stefano Garzarella Reviewed-by: Bobby Eshleman --- net/vmw_vsock/af_vsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 2f7d94d682cb..d912ed2f012a 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -2928,6 +2928,7 @@ static void vsock_net_init(struct net *net) net->vsock.mode =3D vsock_net_child_mode(current->nsproxy->net_ns); =20 net->vsock.child_ns_mode =3D net->vsock.mode; + net->vsock.child_ns_mode_locked =3D 0; } =20 static __net_init int vsock_sysctl_init_net(struct net *net) --=20 2.53.0