From nobody Wed Apr 1 22:13:35 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD603A9DB2 for ; Wed, 1 Apr 2026 08:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032113; cv=none; b=HJsRem5NZN19f/VKgksetUW3o5MbuuTKhGFqT+EpZ9LlmWKqTPHDS9RBFzuj0x+/fbKZSmylANMdNcTdNd56/q2rb7blw1oZvX91Uxn1yRHd7emTJRX6KxcBDyCtuaQpxcKTHHCLXm0ni7++gt22MV00jlvEIfRex8+FTlrlH1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032113; c=relaxed/simple; bh=ounbH33bOU1BQC7yuGmEugk0/JkQPO45LQQsDJ7rJrQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U+xKbLZ/qL0RDocG0OR9GxqS3piJSC7+U6LgC4AokCAWTqmnNbvxgZw/Kn6kf7cN+Cfqmz/K2Xwh0+b9Vqh3CFmDunACMD5sm4sm5/6w/yNo2G9mMa2VaP34EPMn6zfoUhIWjn3p9MQvzwGYeZFnjbW/flx3uW1oN8dUWNCfHIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NR04UgLc; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NR04UgLc" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c742d4df00cso323829a12.1 for ; Wed, 01 Apr 2026 01:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775032111; x=1775636911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=28vGjQJuP/IrXjf94A1F7k0ukYbn2CRuElEMS9vJWh8=; b=NR04UgLcKou6rbLK71NfLxmjJG4zcgFVSPy0hDsF9HK+q962rGdkgon1ENq0tN1pV6 eE5e+Ataui+2HeD4uR5mLULftTmUp+JVlg2idlb4Y/p+OeqUHZUyNlfVs1RNsjKWLygS MSymckRXoG8gNLE5O1tAJDWJNmjlOGHy++LCMwpCrDr1BURrv/AI37Ib2wGQKebov3Mh aw7zqyb37hCYvRkdoRJNbujvYG372PZtvU0+r/02LxpikdbRV5yeAHYJrLT5V9NeXNox yDq3aPc67S7F3XejTkWVk1C0qTLdJQSfZBSVBaMxnsXyz93NTLfkN4z99HsqBmkzzNgz lgCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775032111; x=1775636911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=28vGjQJuP/IrXjf94A1F7k0ukYbn2CRuElEMS9vJWh8=; b=YVUrEj01rCYixMDsOdg1Om24CZ9xy4mmNrj8IqzwQ1/FoLIq6LctoHNRGte3wm2JxM aLvJb69Pa6MKv/Ebu2aCcmObYmHVj1MRkJTBeiEltHn8naVntMf3kS302FUqV3Be5kJk nNxrjW9FvuX0Bzw8DCRG3G8Q3ji7F9bp8440nE37S8iEPDmpEEWGit8qdI+tuaqwcLyl uWiRBHxtdgt0pTmMyjo5N7yzXTfGVnIVTwYl+W+vURJiEuIpkzkM31y5AyYaiwou21eY e43tgZakZ4Td3kCBxrPZhW4vQTiLgRmMld+m42CNlSN41LKOmsza9IxA/Yqstw8Rs2sE TNpw== X-Forwarded-Encrypted: i=1; AJvYcCVUHnuCZHe1bnQ1oZ2+xXjoJG5MOGZVUgx+dKax8WD9c7G2DGk16bULcOCNhYrkTTT3nnGzRBaA580GpeA=@vger.kernel.org X-Gm-Message-State: AOJu0YzypbDdv67Db1nB04LaTN5ECgnr1sZK+RBQm2JtjgzJ5q1dHKLm Dm0AQ9tQq8qh0wF0kTc7v3gV0R2ljwHQzgfsrrxtWQY3LiTUUvWF2gS5xKJpIOZk X-Gm-Gg: ATEYQzzl4j9O+EtpcpkMvRyPE/pDJvPbc3yS1AGA4f7g/sPO9HkPdKkoXeOrfaHge0U pZ5xx83wMnetoVXE6tUhe+xcdNd+wp2DsMkWulscqrLYp9UmiyigGot/9hkECA7k8BPTAYt/kji 4THOc68hjdbT5mAcPmi46NxzzTH9txxn/7UUpvts+M0dM3+kxLQlqMWmnR1LkNN7FLjvnZ+Azaw Gnp61+3Std2f5MJoJxzBooFuatEbHrfYd5XHq8yIO8LnYnDFw3F1iHHGpMa84zvs+9JXGn0r7QM QBMrhPwNBliq7CdccW8Dk1ntDPpdzfNFM0L2SAC6j6qQNzdKI5E1KW6j+Vm/Kfmr8+2MeLVbT6f q0Fz96LOahdb6F5G3ZTy4pAVmZut+1oTOkLio4SaOFQPQRpp5inmzYTUIebrF180l1o9kHaWkgI EMGqHIlFVtuRnYbKvnF1M/KKu7EUE= X-Received: by 2002:a17:90b:37cc:b0:35b:cc8b:1124 with SMTP id 98e67ed59e1d1-35db8e5570fmr6270562a91.5.1775032111314; Wed, 01 Apr 2026 01:28:31 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe5e519dsm4118561a91.2.2026.04.01.01.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 01:28:30 -0700 (PDT) From: Andrey Skvortsov To: Jean-Baptiste Maneyrol , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Marek , Brian Masney , Rob Herring Cc: Andrey Skvortsov Subject: [PATCH v2 1/3] iio: imu: inv_mpu6050: use devres-enabled version of pm_runtime_enable Date: Wed, 1 Apr 2026 11:27:35 +0300 Message-ID: <20260401082737.781018-2-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401082737.781018-1-andrej.skvortzov@gmail.com> References: <20260401082737.781018-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" That allows remove driver-specific action, that does the same as default action. Signed-off-by: Andrey Skvortsov --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/i= nv_mpu6050/inv_mpu_core.c index 5796896d54cd8..84eb0ee770086 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -1872,12 +1872,7 @@ static void inv_mpu_core_disable_regulator_action(vo= id *_data) inv_mpu_core_disable_regulator_vddio(st); } =20 -static void inv_mpu_pm_disable(void *data) -{ - struct device *dev =3D data; =20 - pm_runtime_disable(dev); -} =20 int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, int (*inv_mpu_bus_setup)(struct iio_dev *), int chip_type) @@ -2019,13 +2014,12 @@ int inv_mpu_core_probe(struct regmap *regmap, int i= rq, const char *name, if (result) goto error_power_off; pm_runtime_get_noresume(dev); - pm_runtime_enable(dev); + result =3D devm_pm_runtime_enable(dev); + if (result) + return result; pm_runtime_set_autosuspend_delay(dev, INV_MPU6050_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(dev); pm_runtime_put(dev); - result =3D devm_add_action_or_reset(dev, inv_mpu_pm_disable, dev); - if (result) - return result; =20 switch (chip_type) { case INV_MPU6000: --=20 2.51.0 From nobody Wed Apr 1 22:13:35 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6CFE3ACEF7 for ; Wed, 1 Apr 2026 08:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032130; cv=none; b=M7nZtRpf+w7g1Fe5rdVYVC/JT1h79OCRtH8UFmdKmM67Z/zit+lEXppiz7xqvjpvs21QenijgcGVoPlCHLyZphrd+YmlAESJbYfggDbF9Ai6RaUA8ygX1nin9+ZfFSFElf7fo9KjUderH/2S5y//ih7gru1OX4VAfSNCxCTd7Z8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032130; c=relaxed/simple; bh=R5fP4xTxZM/9up478ZlsTaU1nCoDtVH+kpDHEznHI48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TE/WwfuPYlAvcqt6nj6fqZGLKDbMQB76LDfRcqhbql2vKvLzWtEi3zxv61ZH8stZ5byrtRrSGlhepYYRjJSBzI116BSMc0mFASRH/Bg5F+YjDCIqZTp73xXIQAHrB4s6mwynu4l0egdSsdXw9z9oDxuuyDRDa6EaQl1aoosiQe8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AnCXonfV; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AnCXonfV" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35da1af3e10so3284369a91.3 for ; Wed, 01 Apr 2026 01:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775032128; x=1775636928; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uhhDNnRqqVXHXNROywoQo/qEmpe6kFmc1oHcpmB9pT0=; b=AnCXonfVoFd56jowLqK7JIYg5MnAtYnsbiX0B41rlV3BoOT8Cu1i8cZc9idEvYECW4 rwa+v4gCdyVvuCVqXmsmXoDdumROfapPQb0lmCG2YMPP3LXMnKaetOQKhGeyEwYsixyw S1FR73oTpC0/VJfMSd20PJe3ZWafqfQuZ8KCsQcX+WWZeHqTipw6IRLVjsY0ACobDtPV Z3Y0Cf/E5GgMKX97qHJlxTr36aY9OqUYi5Uo2ICMPTi4XRAy9p68eiWcNxrY5ez04VyW YWzsMf21wc23VSSS4vuu8mWe1cOz3CN+qiZGkHVgANVWWbSlQLPaelOPCckUgdG8qvWK 9M+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775032128; x=1775636928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uhhDNnRqqVXHXNROywoQo/qEmpe6kFmc1oHcpmB9pT0=; b=gvt5CBf8BxhsjadBoR7MTjiShFGgMJwhYyh7k0dQ48AXy+lRZYsoDGFtx/8HMbwv46 vfn7Y8c5pAgIG4FVpVIAOcUPCb14jqa5Fnp1DdPZ+Xpq9vnpdPQoJTREzGFVWJ5dkL+x 8PD9aZQtkHxIIVLX7kP/roOE9vMSq6L88kdX5ky+PEQAP2H27PeXfNVHEodSB3L3v/+k lOzB6QhRgmiWsayBacu7QRWt4BMMHB29z1nPNFQL6snNwrPOQy/Z5Rm+dWR6fTdsKYTn wnX8gmNPkI1nAr0hGm8tTzUkchlb8tixsEuT561XyKQ8iJoES0mDQsaNIZNeVlPDhYVZ jbRQ== X-Forwarded-Encrypted: i=1; AJvYcCUa0tGYVMmsEbUDTHHjzHmLG56/AcsDug/vmSOTSCQzz/x46AJRgsRR6ecwN0iUYimomajr25jqQXmg17U=@vger.kernel.org X-Gm-Message-State: AOJu0YyH147S3NmDrhjdQSjHuGCgWJ+lxvl6AxrYj43ZNf8R8IsmWaST vj5x+Rz9a8ym3Dzqx0wOyDRzFT+14lnqw9/At0eJiajQXONEjazdsDytlzD7oSo/ X-Gm-Gg: ATEYQzwlIgdU/dp+scKgtGYgMxqAOcoAF8F3ZjFNRKYREdEpEeCHcrqCdRcOIRobEq1 pwWLKWN1RVGlfw6WgiTISCtkQK56sd20PdsM/VnxyXziPyal/RlupxNYTqbvbAgeOSH9DvmVy7m i/U0dgJ9GvxJ7/8c2fbQttNFzdw6qJK5NSchJVGGF28zgwqW8O66LrjKnXh+pvbsKMWI9vqXBDr YYvz0Nfan6UPu178nOAOVeY+525ucCf62bkImbWJZWRa2Lhkn+Kp+BYyCHaAl5h3pslr8QnvGir pOWeyhdhSWY2h0o+pF/YwYWpjzf+cS0paa6lKkMViHkS0X+ypEuXoEe2ylOOLngx9wRvXuOokHw X/1oY0lkQNwRB2kz4e5QdpSuVKTE5w6BDPYMP+AMpz+sl0I9p4wTXzmv2AlqHEJiNwtdbYlGGHc FJvoAqO8wNDaEDKWa9E4qefhHilUCLhOhdmdK0Iw== X-Received: by 2002:a17:90b:4cc6:b0:35b:af3f:3618 with SMTP id 98e67ed59e1d1-35dc7030211mr2426907a91.28.1775032128151; Wed, 01 Apr 2026 01:28:48 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe5e519dsm4118561a91.2.2026.04.01.01.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 01:28:47 -0700 (PDT) From: Andrey Skvortsov To: Jean-Baptiste Maneyrol , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Marek , Brian Masney , Rob Herring Cc: Andrey Skvortsov Subject: [PATCH v2 2/3] iio: imu: inv_mpu6050: control vdd supply using devm-helpers Date: Wed, 1 Apr 2026 11:27:36 +0300 Message-ID: <20260401082737.781018-3-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401082737.781018-1-andrej.skvortzov@gmail.com> References: <20260401082737.781018-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vdd supply will be automatically disabled on error condition during a probe and on driver cleanup. Since the vdd handling is moved to devm-helpers, only vddio regulator has to be disabled in the driver-specific cleanup action. Signed-off-by: Andrey Skvortsov --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 28 ++++++---------------- drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 1 - 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/i= nv_mpu6050/inv_mpu_core.c index 84eb0ee770086..3a57a3f440526 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -1859,15 +1859,9 @@ static int inv_mpu_core_disable_regulator_vddio(stru= ct inv_mpu6050_state *st) return result; } =20 -static void inv_mpu_core_disable_regulator_action(void *_data) +static void inv_mpu_core_disable_regulator_vddio_action(void *_data) { struct inv_mpu6050_state *st =3D _data; - int result; - - result =3D regulator_disable(st->vdd_supply); - if (result) - dev_err(regmap_get_device(st->map), - "Failed to disable vdd regulator: %d\n", result); =20 inv_mpu_core_disable_regulator_vddio(st); } @@ -1948,30 +1942,22 @@ int inv_mpu_core_probe(struct regmap *regmap, int i= rq, const char *name, =20 device_set_wakeup_capable(dev, true); =20 - st->vdd_supply =3D devm_regulator_get(dev, "vdd"); - if (IS_ERR(st->vdd_supply)) - return dev_err_probe(dev, PTR_ERR(st->vdd_supply), - "Failed to get vdd regulator\n"); - st->vddio_supply =3D devm_regulator_get(dev, "vddio"); if (IS_ERR(st->vddio_supply)) return dev_err_probe(dev, PTR_ERR(st->vddio_supply), "Failed to get vddio regulator\n"); =20 - result =3D regulator_enable(st->vdd_supply); - if (result) { - dev_err(dev, "Failed to enable vdd regulator: %d\n", result); - return result; - } + result =3D devm_regulator_get_enable(dev, "vdd"); + if (result) + return dev_err_probe(dev, result, "Failed to enable vdd regulator\n"); + msleep(INV_MPU6050_POWER_UP_TIME); =20 result =3D inv_mpu_core_enable_regulator_vddio(st); - if (result) { - regulator_disable(st->vdd_supply); + if (result) return result; - } =20 - result =3D devm_add_action_or_reset(dev, inv_mpu_core_disable_regulator_a= ction, + result =3D devm_add_action_or_reset(dev, inv_mpu_core_disable_regulator_v= ddio_action, st); if (result) { dev_err(dev, "Failed to setup regulator cleanup action %d\n", diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/in= v_mpu6050/inv_mpu_iio.h index 6239b1a803f77..2c0cf53c9a627 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h @@ -206,7 +206,6 @@ struct inv_mpu6050_state { u8 irq_mask; unsigned skip_samples; struct inv_sensors_timestamp timestamp; - struct regulator *vdd_supply; struct regulator *vddio_supply; bool magn_disabled; s32 magn_raw_to_gauss[3]; --=20 2.51.0 From nobody Wed Apr 1 22:13:35 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00EC3803D3 for ; Wed, 1 Apr 2026 08:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032145; cv=none; b=u17Lgp5o3yYTKlz38WUbLnp823KRH4wJhgTQ2rTX7Syj20pFBHV5gKpjfaymbBgJGtxg8Gn4OUF1QOW1VBXFS66Xh8umnJMZ76o9R4LOhB8L3xWM/aPnlQA4LYfGw8mtc3yqn54a8ahcptSIjqMLPLdcWiwCXAMG96JrNSrJQms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032145; c=relaxed/simple; bh=QOMIzjNoG38g04AnGIDm8S21dxdqXer8FkrYDdTsXgk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RiNrl7MSQEokDigx/s+phoM00cqQOVPPd5bYNiGaioTts58wlGKObAZCJeHYBNz+9J0AUgbW8A/E4X2V1m5AQCXPhPxu83UGSJBCvaYox4+LQDAEcFjWTmmJ53OBuAqmOLAshUNOaX+82uAI+yfo2QFAtIsXHd2otcFWEgKFQlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sbkF0jtz; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sbkF0jtz" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35c206f0481so6185304a91.0 for ; Wed, 01 Apr 2026 01:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775032143; x=1775636943; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3tYVObevDqBuONwH6QGIZanP6IjHHjbyhFuTpehaXTI=; b=sbkF0jtzg9draY/4TAGdHQJbH7lQ0pN8CINp1s4CJYYFdur2/J51w7lVtfJ9JO6zrt mv4hUSQuxG/FEGqIcDgDsElq0G/6J0mi3u4bf0zRQhU7b8xr8VayYJZunKD5Uhl5JPzG rkXnwp3gpKFp9bY+/695zMOhoRVZ3Pwd+otCKL0DPlHJ9BnW/E+RKP+/UMaNXzqaBrp/ roASOaRfwEFkCXdWNlRPam/W7MGO00nTSode8jvngaqJPvtKiWN0/Dl0MHxAwqFEGAGx 189OINnHZzpyoePC0JD9DSpU5v9t8Rgy6Amf7PE0fU8I+eLO/EVhClsD+ANM147x49eU lkRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775032143; x=1775636943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3tYVObevDqBuONwH6QGIZanP6IjHHjbyhFuTpehaXTI=; b=CQdc0EBpLWZdUdE4zhxaPd+2Tj3xmzP7nxgquDgPUmtdNWQ94QuygZ8j10LrfwY7Zb 0gv31S5uPHKsssuDd0Kb5D0DgRzUSPuFkBqy2YfIdnX5CIC0vHQUBvQqjUczH5SV1wsK oUoLgNN4+gU9A4qPMkPJMzIeImWGfqYTW0AlGbp6+iJWHDEooIPUvAvT3p+D2MgIAJFh X3TVv1QrkJyS7g2QZkQ1MlJitmvQYuCFogwr17Qo4umvAIwn+S9kM+5f3ckfFtTPMGEz P994atDw3QW/02wJ+494jThPYYRq0PYGFwr4xYYoCTZYi8veJLfrMLNhEOPSbijdHf8d eRCQ== X-Forwarded-Encrypted: i=1; AJvYcCWEe8f80fAm97FeDB5eFRXQQRfHk2FbozbuvuwqNiz0A3j9kPfJdoMWkCIC0StKMeyV58QbbE8izhJv8bw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5ojSJ433Kz9jFSiBuhREr993L+qXR5ZoDSJN5odRVEq6Tnctw 6YnDtQoMnR8DsU3nnc4Pia8WYfeFDYRv0BOQZe2YYeH6pc/WMlD/dlWw X-Gm-Gg: ATEYQzyK3LozYZjre+QSKlsQEZdjQhVkD3+hgX2rmaaluZd7Dqz26nzWbXtgYukhpYo +BTy0HB2mBkF7rT5N5h8aaGkmPNPbk4CLc++zv9/5B6mTXp4EFC449tmwK/yaSg31CHpS6iQbe9 1ciM3gwWnSss4TPSeVAMTiOoLEtpm1bJiwNqKF1uzUTJO5BNsYE4sabx5KBUl2F0kaAvQ288JYj XtXKmGjmEUULTMqK2oR93meRfzTFllwstudddGoizjbVsZecb6JoEh8s1CGN3KiK1XLjDr75PkR J5ChL0OQs3PA8prwEHICtJX8DxAFAE2tIxhgjH2HUoqPvtRQnhu5f2QIUBRRluyzwcNhEr9CXXj 7IG0RdDsLRaOK1md+g3eSYWrHnXVhgdBrVR0kdMt2w0uwwTmJZsg9dh0OQWHd/i0+3LruIAU8bP 6mepUk6Y9dfHFr5nIi/2W6mQ/jDPs= X-Received: by 2002:a17:90b:4ccc:b0:35c:30a8:319 with SMTP id 98e67ed59e1d1-35dc6d2edfemr2859424a91.0.1775032143178; Wed, 01 Apr 2026 01:29:03 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe5e519dsm4118561a91.2.2026.04.01.01.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 01:29:02 -0700 (PDT) From: Andrey Skvortsov To: Jean-Baptiste Maneyrol , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Marek , Brian Masney , Rob Herring Cc: Andrey Skvortsov Subject: [PATCH v2 3/3] iio: imu: inv_mpu6050: fix unbalanced regulator_disable calls, when probe fails Date: Wed, 1 Apr 2026 11:27:37 +0300 Message-ID: <20260401082737.781018-4-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401082737.781018-1-andrej.skvortzov@gmail.com> References: <20260401082737.781018-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During a probe functions after all regulators are enabled, runtime pm is enabled. Before probe function finishes, runtime pm triggers and disables vddio regulator. When probe function fails after that, inv_mpu_core_disable_regulator_action tries to disable already disabled by runtime pm vddio regulator causing following backtrace: inv-mpu6050-i2c 1-0068: trigger probe fail -19 WARNING: drivers/regulator/core.c:3244 at _regulator_disable+0x2ac/0x600 Call trace: _regulator_disable+0x2ac/0x600 (P) regulator_disable+0xac/0x148 inv_mpu_core_disable_regulator_vddio_action+0x3c/0xb0 [inv_mpu6050] devm_action_release+0x4c/0x88 release_nodes+0xd8/0x178 devres_release_group+0x214/0x3c8 i2c_device_probe+0x6fc/0x9b0 ... inv-mpu6050-i2c 1-0068: Failed to disable vddio regulator: -5 Fix the issue by checking runtime suspend status, when vddio regulator is disabled. To handle this correctly pm_runtime active status has to be set early before vddio regulator setup. Signed-off-by: Andrey Skvortsov Fixes: 07c12b1c007c ("iio: imu: mpu6050: add support for regulator framewor= k") --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/i= nv_mpu6050/inv_mpu_core.c index 3a57a3f440526..86e4d42c4d3d1 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -1862,8 +1862,10 @@ static int inv_mpu_core_disable_regulator_vddio(stru= ct inv_mpu6050_state *st) static void inv_mpu_core_disable_regulator_vddio_action(void *_data) { struct inv_mpu6050_state *st =3D _data; + struct device *dev =3D regmap_get_device(st->map); =20 - inv_mpu_core_disable_regulator_vddio(st); + if (!pm_runtime_status_suspended(dev)) + inv_mpu_core_disable_regulator_vddio(st); } =20 =20 @@ -1953,6 +1955,11 @@ int inv_mpu_core_probe(struct regmap *regmap, int ir= q, const char *name, =20 msleep(INV_MPU6050_POWER_UP_TIME); =20 + /* set pm_runtime active early for disable vddio resource cleanup */ + result =3D pm_runtime_set_active(dev); + if (result) + return result; + result =3D inv_mpu_core_enable_regulator_vddio(st); if (result) return result; @@ -1996,9 +2003,6 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq= , const char *name, } =20 /* chip init is done, turning on runtime power management */ - result =3D pm_runtime_set_active(dev); - if (result) - goto error_power_off; pm_runtime_get_noresume(dev); result =3D devm_pm_runtime_enable(dev); if (result) --=20 2.51.0