From nobody Wed Apr 1 11:52:40 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02A23659E6 for ; Wed, 1 Apr 2026 07:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027283; cv=none; b=MAI0K4VNPPHequhN79Zm6behwAOP6TNYA1039Mcc0r660tGAN9OiDzUCzmFHIX+NDp6cb9dtRZeF0XL7hiyVyytWUlaO1dPhgQEnwXU2GembMGQB8yGElhUDr0xvfvQwdptzA0Memn31IBAGY4xhxD97hb4knJ8L/4bbF4H87UI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027283; c=relaxed/simple; bh=kRJsrOOhJwypsGQeh0t77eM4spvDtzgMI09Db6pLmhc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iIYd2T3rD1vRsrR73ML40EbR7qS49lr0FtzY9xYcjQpacpcrAwos4zM+BTr2BeTE4+1x0RELMkVTj0bH2dJwjO23SlcVD+PZLOoeTb7Mo55BaCPXDBhIEsWYHI556sVZVxR9ekkQ5At8HaJFByN6reaevP3BQKcjCtNcU9hWGas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EQjH692r; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EQjH692r" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488879b2e6aso938455e9.1 for ; Wed, 01 Apr 2026 00:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775027280; x=1775632080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jq5bYodbB5WenNka0ORppBTIQzpNw7WJ1K+vBmPhvzs=; b=EQjH692rxDyuj82HitC6JMRIM8afQoQVXKNYxJDD6C0Va0sd+pqIPjXjeuD0JoKpHv NzGiDAhiYcSuWtRHaAVnCRM2y28Qag1RBr/GDcTX9e40CIS/LFKkicSU0PylzK3YIZsI 355x+Ea4wjYpXoA/n0QObzpx5X2Zj/czaGqbxEZYacpilHLiQ6A7tk1D5WWJhaOAz8xN BDxWzxQDAv/NUA6bx9da35S/oFIGuJGM1QsS9/NMf405reLbOV6EY+kVtCnjmJ4u8S+1 zgbp5KPEjEC5FYBRS3yLqkofPh7s5kGHhyCKNwPtXN4GvqhZPdFaIgMgxte9RRx3srU2 PfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775027280; x=1775632080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Jq5bYodbB5WenNka0ORppBTIQzpNw7WJ1K+vBmPhvzs=; b=EBfYG+aaXvuokSc53NaZ2/I2dDu5yNyOMpvBe16bTDOocLxmcP7NPF1V6QUVcpeWrB 3yjtWtU5djIZQ+0SqoCGe1sDZh2FjlyJdHJetIlaqpuo6TmvbdrUyjWmVYGi5T/NVyet uryd4Y6FLsqpNfb2Zg0LsUvkXI4KkSbxVfP72SXO6bnC1vXmicTfU8I4Fa5Nel+bhYWU L92wFecC5iKbSwaga5WRZWIDUyxBeoEfBi8yv381PH0LGLBH+ejTNc8YFzgALKoe4yAd gvZZKxrydXoZQPzxE2zHaR6nnOwIoNqHfmhMdUagUBsEdkX4+HcPZr6a/TkdV853sDDI se7Q== X-Forwarded-Encrypted: i=1; AJvYcCXNCDRAqhvO6y3G5NR8G0NsvAOqAEMgysBbLpZABp6yy82FtIMP5J6ZzWm9d+Q1cEwXZ/iylTURU36rXi8=@vger.kernel.org X-Gm-Message-State: AOJu0YxXuL2FrLDPYz+ZY+p1vnSSj41NWmGtIIWVDG58Az6rHKTab5sm XSXM1KO6dsN9NQ2lfesHdHujI+sROoomSD/8o4Ad/X8DXBIa8ywX9gC8Qtg2IhtVf2k= X-Gm-Gg: ATEYQzzzoaRfhXaYIerFYmLozr5WBDGh5pwkg7DTU1gh5EpZHV9eV7ll94VrM8VqKeM s4VwPUMLdDoLoOBLbraxyE6v+r5h0MW/msZxkwnJjjcl3fkOt6hGsOdmr+ALLxtV5z/dJxCHaY3 15feiSHHhqHcIdeaB4k+fkjv6leWWiAcdcKRGifbe0ZLQkLv3nj3nbuF2BDZsU2qbbZNrgIyGBK bqqMuIdqEMEb1wQUCWjSVQeY71cy7dtcNnrVXF3nWW2krw/n9QyjUylCMMQEM+NbJ3ERymM23PA dCGhOEr1FclSnnFdfU/WqjTKFkuS5v2jPwmnvIcGeg5fde4U8rUQli274+exTEivN8sqW3PJrIp 6jbliPHQSegkKuSUSd+DeMcxLd77Mu526jqO/inZ6m0M0ijG/zQT+2RibKmJ2kJPOBPLPlsvQwo tCc9Ut/v3zWrFST55h7ERdn1k2GReWJ+S6yYLMzDbr//608dSdCDxYNARN X-Received: by 2002:a05:600c:4e4b:b0:485:439b:683f with SMTP id 5b1f17b1804b1-48883595da7mr42337065e9.20.1775027279770; Wed, 01 Apr 2026 00:07:59 -0700 (PDT) Received: from f16.suse.cz ([121.167.230.140]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d58a887e3sm15355778e0c.18.2026.04.01.00.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 00:07:59 -0700 (PDT) From: Hoyeon Lee To: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau Cc: Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan , Feng Yang , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v6 1/3] libbpf: use direct error codes for kprobe/uprobe attach Date: Wed, 1 Apr 2026 16:05:02 +0900 Message-ID: <20260401070738.122709-2-hoyeon.lee@suse.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260401070738.122709-1-hoyeon.lee@suse.com> References: <20260401070738.122709-1-hoyeon.lee@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" perf_event_open_probe() and perf_event_{k,u}probe_open_legacy() helpers are returning negative error codes directly on failure. This commit changes bpf_program__attach_{k,u}probe_opts() to use those return values directly instead of reading -errno again. Signed-off-by: Hoyeon Lee Acked-by: Jiri Olsa --- tools/lib/bpf/libbpf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 9ea41f40dc82..536c19c14d21 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -11835,7 +11835,7 @@ bpf_program__attach_kprobe_opts(const struct bpf_pr= ogram *prog, offset, -1 /* pid */); } if (pfd < 0) { - err =3D -errno; + err =3D pfd; pr_warn("prog '%s': failed to create %s '%s+0x%zx' perf event: %s\n", prog->name, retprobe ? "kretprobe" : "kprobe", func_name, offset, @@ -12825,7 +12825,7 @@ bpf_program__attach_uprobe_opts(const struct bpf_pr= ogram *prog, pid_t pid, binary_path, func_offset, pid); } if (pfd < 0) { - err =3D -errno; + err =3D pfd; pr_warn("prog '%s': failed to create %s '%s:0x%zx' perf event: %s\n", prog->name, retprobe ? "uretprobe" : "uprobe", binary_path, func_offset, --=20 2.52.0