From nobody Wed Apr 1 22:37:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2262C365A17 for ; Wed, 1 Apr 2026 07:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027275; cv=none; b=C5YUGKkxHtrKOEXn6Gl8MsdKgCgMKMEd/3o7i+Ub5KBQBpY6P5QsnO+jDm2ekXl4+K6vux7/WGhuLtkQArUjxws8gn7RtQgOEQyYdSUZMEC5r+j2bf4N8flPxQZ/JmbpeFO/uqGoJrutfGOw6aTfa5eLoNKiYLlKieZ5EFqoFsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027275; c=relaxed/simple; bh=T+IWKxfeCPkpA1AnDHhXeuS/tHjUqOlcH1i0llq8gp4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sQVMZfIMJ4RiMnum51P+7nDSJ1QEQcUjjqWYWLODBxw54KSb5yMm/Bhbc2Qt08kFFsM8OUkVC2i8nbfoTa5tP/mozLTXd+Qm931E8aQ5NqSzdxdM3nWvbOTxhNiqt5tidk089o+YaW12pqBBchPxu8YcOt04uk/42qSAx9TlCj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W5mzHLnK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bK2a5bS3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W5mzHLnK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bK2a5bS3" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6314OFts1562707 for ; Wed, 1 Apr 2026 07:07:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=o3ofgjDB/Fu qgWrFRH0SxfEDOyGzS/rdc4+8I6d2b2I=; b=W5mzHLnK4o5YZdk5oEXDbVUe9Hz heEeXKtoMp8rsi7hzoovX/6hdI+U0f3ubcjRMvUKatBi+OPF/Uu5WoP7kdD6ZX6E 2z4TVl08VMC/Oj+84lnAoo1jsQdbVdTEtu7L8PzrPLHrpFxx9EKGzRS9G4nkOFTb jzUQncKypB8NkwyVNSoi9k2HLHX/BSpGQaJRFOesdX1hCkqvEBKcofwKbCCBe8CT x8HfDV0dAcgd+GWsVJQOXjHuwQzcRedzQvwVYxR5FRKVhs7L+lBtIfFD4R1u4kmv JkYgvK5bHslndswUGYEXfizOr4T1Z22xEqDeI6H73Tb4wzS8mJlu7hKTv3Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8va3rkdy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 07:07:52 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3568090851aso20474874a91.1 for ; Wed, 01 Apr 2026 00:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775027272; x=1775632072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o3ofgjDB/FuqgWrFRH0SxfEDOyGzS/rdc4+8I6d2b2I=; b=bK2a5bS3uZseaP0N5j/IyN4hTCBl7dVRek7rSV7ptkahqv6PbtkCo/g1PP6H3GmRn6 vCEB4RndA6CD1ZWrzthwa8FnqAJEJYCPrDvrN8/SQ6etySb4W5GDlLL0ToNFNZvr1AYv SZBGWowNqEjTChkby+6/Q2pUJA7gDDdGzfhR9hmNeGa5PnvCl8Vo3q9O1lID5dqEz/qS B5P3nk4LpIc1nRAUzbP/3wliBTTbLSWThRJ/NJjukflkrI3GOqpzpXlXgpmkQCknPct2 L+WUz32s1npLyCledLtNf5qXW/s+aNFAgoxiC6/XVx/l06Z5GRRhYKjAdLByTaqiQi4n o6+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775027272; x=1775632072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o3ofgjDB/FuqgWrFRH0SxfEDOyGzS/rdc4+8I6d2b2I=; b=V1+nEeVI75p/PubZCDXY1doRjeWD5xIo9sKsWBqSTrtNTC1WpxJLBCjT+h3rjWZsx2 XlsgO14dT2XkBKYs0gvh5R0GK60IrkNoI4RcG+TE4GQRLw27lT3LddZ5LNo5zWzgrXBq 2pxrnp/t8Zg7nVU4epYCI1ZwOqfxlhg+WUgcvO0az72EK222Pm3/zz/R9KY4HVJlv8dD eJZRCc6vkB9qPY5Fwho46vXiUwahQPebfPaNlg6Q7lGInlYNpF2Ua79m96iPinLU85Ba ncR/tiPoUdvusMK3+vUh0DhwSY8pTK0CmUFMxQRYGFZwwo3KFrGo/+ZLOPSXUBu5CRa3 D5sg== X-Forwarded-Encrypted: i=1; AJvYcCVaGEl3y2BTaFgfD9kRNq5/8R0pAuOzCPItbgAUiQ0wR1Rlelkt3JINTYFwm6fn4q/z5Np51HFuH3bfMGI=@vger.kernel.org X-Gm-Message-State: AOJu0YxzZOB7Q94215IGM8uJVlT/d3s0niMwd/w1edJCjae6u2G7vyhQ W1jKW8jtHj+GV1cVi/f2c9rIwBgtLmBBJfuhTPuqdVYh2dOym0d3JMFpstlhW27wH2LjD002IMV tE/sQybkQiAfN7aS2a5BCghu7hRPrgKfKi02rEDydev6SjtqQ84rD6TchmOVNz0Va2XAG6SGE9W I= X-Gm-Gg: ATEYQzzTW6jmlVgClGfhgeMrNaygAYzEX6Xlfn/en+EKX+esdbnamkD4PO/CUn7VXDW +Qr6EgFtWf5zpWz60qA0LiqN55F1KzYBmVHY8C8BV5hZ/1sxGJc8v0gX+aD8V+dP6/n0XbWD1eQ R+sa7oN2N5Rv2sutRyarztsGQ3Kv+2oJLOmm27WVIaZb0eRn39bpFQGaiGlinHZvkulJwb7nd4c r9aHccsNSed+zoRRmG4X5nzA5lG/TdOWUSD2wxZVyP2tNpVLN9o9i2NDCSIJTJ9GwDu0dRNkui5 pfmuH3wYvXuQfGvgqg/EdqlGXx4KY+g0pvsDjC1l+Mpal2olWBTuQzFkoAU9MSqNcw0t/WdRkQ3 YJwLtDMeyvstjnf9jN9aKCpXcK1CV00WlDxGU X-Received: by 2002:a17:90b:268f:b0:35d:a9bb:1e33 with SMTP id 98e67ed59e1d1-35dc6eb9dd7mr2548383a91.11.1775027271493; Wed, 01 Apr 2026 00:07:51 -0700 (PDT) X-Received: by 2002:a17:90b:268f:b0:35d:a9bb:1e33 with SMTP id 98e67ed59e1d1-35dc6eb9dd7mr2548336a91.11.1775027270961; Wed, 01 Apr 2026 00:07:50 -0700 (PDT) Received: from work ([120.60.63.102]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe6e2fc9sm3956464a91.15.2026.04.01.00.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 00:07:50 -0700 (PDT) From: Manivannan Sadhasivam To: brgl@kernel.org, robh@kernel.org Cc: linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, mani@kernel.org, Manivannan Sadhasivam , kernel test robot Subject: [PATCH 1/3] serdev: Add missing stubs for serdev APIs when CONFIG_SERIAL_DEV_BUS is not selected Date: Wed, 1 Apr 2026 12:37:33 +0530 Message-ID: <20260401070735.107162-2-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401070735.107162-1-manivannan.sadhasivam@oss.qualcomm.com> References: <20260401070735.107162-1-manivannan.sadhasivam@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: gCD8qM_IlIb5qODUi3cyDLyH6TcOWF20 X-Proofpoint-ORIG-GUID: gCD8qM_IlIb5qODUi3cyDLyH6TcOWF20 X-Authority-Analysis: v=2.4 cv=B/C0EetM c=1 sm=1 tr=0 ts=69ccc448 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=zTATW481NYPnotdwU90osA==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=JxTtsak3BgR7EskHxGAA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA2MSBTYWx0ZWRfX+dAP+L+uuJwf CzFApD76GUGAldqHgB3m9RGFZITBu8AIDmM9ve0Kp3HX5gzSWPjlZBPdXY5N6ivDgyKFQdeUxXW LT9sTG9mQ+yirPo6g3BjXUpf0jAqcK1YCabfglRcrlQ7DfBksVuoTVXzQiA/yIHFK+D88xjfYbz EEG/zht4/s1Ela1v1REZA6DhUQSbjITnRbwiM84uLJfNQe/51Gdz4KMET+63qzwXwKWaS4fEBrv OOU4H3KQdWFgSUlF7Y9x+IeCxSiC3B4OxJmCJzEy8TODlvSU377zlyOoMZhhy9uX2W7AW6mVFFZ TCvh0YN+esxGW0xJ4560jKbt7V9o7DOEixltTvHGpEWx5qU4H6P9PE4ABc+qfktJP5W7j+j9OMz y3JYg5sI7oAHc74woHOuxyC6ljZ4sEkl92NXuSt3/iVu8yaSohFP0+tQ9tpl4RarmW4AelgjTaf 84iI7QAAMd5+m9e0w+g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_02,2026-03-31_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010061 Content-Type: text/plain; charset="utf-8" Some of the serdev APIs are not guarded by CONFIG_SERIAL_DEV_BUS and also missing the stubs when the symbol is not selected. This leads to the below build errors: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_pcie_m2_r= emove_serdev': >> pwrseq-pcie-m2.c:(.text+0x260): undefined reference to `serdev_device_re= move' powerpc64-linux-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in functi= on `pwrseq_m2_pcie_notify': >> powerpc64-linux-ld: pwrseq-pcie-m2.c:(.text+0x9c8): undefined reference = to `serdev_device_alloc' >> powerpc64-linux-ld: pwrseq-pcie-m2.c:(.text+0xc00): undefined reference = to `serdev_device_add' Fix these issues by adding the CONFIG_SERIAL_DEV_BUS guard to function prototypes and stubs when the symbol is not selected. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202604011226.KGNn5974-lkp@int= el.com/ Signed-off-by: Manivannan Sadhasivam --- include/linux/serdev.h | 42 ++++++++++++++++++++++++++++++++---------- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/include/linux/serdev.h b/include/linux/serdev.h index 188c0ba62d50..0de261a26284 100644 --- a/include/linux/serdev.h +++ b/include/linux/serdev.h @@ -156,16 +156,6 @@ static inline void serdev_controller_put(struct serdev= _controller *ctrl) put_device(&ctrl->dev); } =20 -struct serdev_device *serdev_device_alloc(struct serdev_controller *); -int serdev_device_add(struct serdev_device *); -void serdev_device_remove(struct serdev_device *); - -struct serdev_controller *serdev_controller_alloc(struct device *host, - struct device *parent, - size_t size); -int serdev_controller_add(struct serdev_controller *); -void serdev_controller_remove(struct serdev_controller *); - static inline void serdev_controller_write_wakeup(struct serdev_controller= *ctrl) { struct serdev_device *serdev =3D ctrl->serdev; @@ -204,6 +194,16 @@ void serdev_device_write_wakeup(struct serdev_device *= ); ssize_t serdev_device_write(struct serdev_device *, const u8 *, size_t, lo= ng); void serdev_device_write_flush(struct serdev_device *); =20 +struct serdev_device *serdev_device_alloc(struct serdev_controller *); +int serdev_device_add(struct serdev_device *); +void serdev_device_remove(struct serdev_device *); + +struct serdev_controller *serdev_controller_alloc(struct device *host, + struct device *parent, + size_t size); +int serdev_controller_add(struct serdev_controller *); +void serdev_controller_remove(struct serdev_controller *); + /* * serdev device driver functions */ @@ -264,6 +264,28 @@ static inline ssize_t serdev_device_write(struct serde= v_device *sdev, } static inline void serdev_device_write_flush(struct serdev_device *sdev) {} =20 +static inline struct serdev_device *serdev_device_alloc(struct serdev_cont= roller *) +{ + return NULL; +} +static inline int serdev_device_add(struct serdev_device *) +{ + return -ENODEV; +} +static inline void serdev_device_remove(struct serdev_device *) {} + +static inline struct serdev_controller *serdev_controller_alloc(struct dev= ice *host, + struct device *parent, + size_t size) +{ + return NULL; +} +static inline int serdev_controller_add(struct serdev_controller *) +{ + return -ENODEV; +} +static inline void serdev_controller_remove(struct serdev_controller *) {} + #define serdev_device_driver_register(x) #define serdev_device_driver_unregister(x) =20 --=20 2.51.0 From nobody Wed Apr 1 22:37:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4112336923B for ; Wed, 1 Apr 2026 07:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027281; cv=none; b=qGeWNz41fKdSMpdbuSyiQnHOgi766GehYI5OdsdrNheI/CpbEtghwSiONctc8EpJAXjJj8u7OV5ykGZWHkigfS24r0/BbNS6RDCTk8Nisas9T0HgAXEI8eJ3El35hDCO2TXpTnsAN1yBvH9mrSY6cDFnzAnO8xzDKTm3/S+V1wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027281; c=relaxed/simple; bh=BSCNS1UNMXIGtFM+QUX7Rbto0UCstaR3LYY/zZnmgvg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JJ1OJbzTngdUT9oyrJNsRkw6ZDu+N5E0IHpqLNbBXJeMKajvlKAXqL0BTaAnzJXnFOG+e+TECUJQgg02DD6oDmdtMEwFVwGxQodbuG0uouZ2ZUaMNuiKklyuFbQdViELoHtfux0lZOguT+IpSvK6stpqjNZMM1eVTnHC1GkZCcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hxtuUiMV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NSLy9ZUT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hxtuUiMV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NSLy9ZUT" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6314NSKO3363269 for ; Wed, 1 Apr 2026 07:07:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=h6zxdLf6xUW szA6KhrhvifDZ0ndILcCybaBSzNjg60A=; b=hxtuUiMVdgvrUovJ6tJEdaYYz9E I2c7cYpZD2KHUFZrCBe3rEYROwp8345L6XyV8WUcqrW3BKAkG5kgGVhaJ0idN3s1 khGeKmX7CNeYmasPtVkAd78i0b3O28LAAWFVI7cN76Tis7sCTJV+BE0iEqeCq1lN eUeuXnNARsJHpZ3kX5balEu4P/VtLMa//K/A2zzaON9NLId0PHP7H3dPpFDfZ0rK pbORauWx783oDWG2QBZQ1iF5OkFUaH/8yDhcihIXylA6IEPkPoC23hqSa2GSFPS+ Ja8Qc0ZhgrXIbNyF+LnTe92F3jlJeGyFNgkBYtFRV2GWB5Ea6Forly4i6wg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8nddj4a6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 07:07:56 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35d9f68d00fso10771536a91.2 for ; Wed, 01 Apr 2026 00:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775027275; x=1775632075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h6zxdLf6xUWszA6KhrhvifDZ0ndILcCybaBSzNjg60A=; b=NSLy9ZUTLvHPPBqhpw5wPklQwgr+LJ6v/+Bvh71Oc2YPeRSgo0neI0TeILx4IaBz6K mjD1Cb6zC6GdHxjc5Hci2hrZxlH/7jtJiIAfzE55gpi4Rp7fi83hCqTJqlLnhcZ9C0Ej RSY8gGgeRaygT8atTpna6vsmoAPZQDLehhOs/fkOLaWGy96PF4I1wqHD0I9Q4Rd8DAnT c7f3pwQYcT9rBNq5Nfe0MSXEErJDesyuAZlhIHy33Lw8ywNpA5nn3CLAu7QzsltgwfF+ NaAbmkBSj3UPnbJsBh69r/BHog73R8igqJ88+RWhxAVytmwXni+jfJbntcdcIIEOl7oB 7z8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775027275; x=1775632075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h6zxdLf6xUWszA6KhrhvifDZ0ndILcCybaBSzNjg60A=; b=pPne+wTGzaO2dHT6jKnKVqWavDWOK9NT/d+27aB+DzsMFaCsADzkGA8zxrqdQhB/Lo GqKcWxk0XKnWPz1WIVJD52QdpMcURYOEuY9KBdzU9LFks+5YoJYhqAt93/MVB3NFb2dZ cXDM9fYQhIYp6hlX+8TpQBp42Kymd9xhS+xk5PPyuWRYsOOeT9n/CvOnycfEtAtK+TaB Qie0pu/6p5htfIRkKfE5ios+UgjYL8VQB9LukstuvbSoRzsoJYFexMJsVrrsO8Rk4hpW 2XXAovQHO1DXzSOuouDpbsNEgwi6WOK+TNMreqIMBlc6eEEO1F31S9ozl0er+lZDe45A 041Q== X-Forwarded-Encrypted: i=1; AJvYcCVtdhVCHnXJf+a3yNg4IG54DIrVSp6UqDec7OAxwG4GFoDUZcJNUkRZxfWUN8WNqcDrKIyiaGAHfwQ/kzQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ9aAejJmzsCEv3sp4zp3ilku54AYqponcp+0k7PI8wDlBxLy1 PJnHI/2JKG9ml4Jg+cdFBcfdwce/IvsYL5sDoy7TwmsmIbZX21GnIg/kgvwBlpvxLs338gO3MUp 8ah/xQRQHuLCK2zIGn6yY7RqK93gA8p34AkesHrMJ3leak132f1DujPX36HAH+PeyLKo= X-Gm-Gg: ATEYQzyRWf32lNikKiD50D9qVC5y3ztYjtREv1/uyvmb6GSl04VW6GAKAYhGxLvczQo +b2/ORYdnmTlf3kyJtIW2lKgWL/7bG5diaLPRENer3KribUnQOQDqbqrkuti+vLGxXPzYKnps2K 49yurhQ2TjDFCuXYGYmiFqXrg5oTGqWoqs9Q6cNe3RLi7ppQGRtYamk0fKIqdxHvrl8Yp1ML4mS qO0/WFrIvJxKkpdNRa77/x5oAaoCzcXOYStVvVro9vqJFnPeQU8P8ULV4olMASIMv093X8wQpb0 SR9rMHOx62MC3uHQnUQ4JfE7sTdLHVVU/PUZjbjMi3MwGDe7xF2UsfbfmEIRDCv4sHH1hPmw5Qc JruSaY7DDpW2zjIPDVHz4ywHfarhGaPFAuiej X-Received: by 2002:a17:90b:4b05:b0:35d:943e:3c2c with SMTP id 98e67ed59e1d1-35dc6e77ee9mr2279405a91.5.1775027275091; Wed, 01 Apr 2026 00:07:55 -0700 (PDT) X-Received: by 2002:a17:90b:4b05:b0:35d:943e:3c2c with SMTP id 98e67ed59e1d1-35dc6e77ee9mr2279369a91.5.1775027274518; Wed, 01 Apr 2026 00:07:54 -0700 (PDT) Received: from work ([120.60.63.102]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe6e2fc9sm3956464a91.15.2026.04.01.00.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 00:07:54 -0700 (PDT) From: Manivannan Sadhasivam To: brgl@kernel.org, robh@kernel.org Cc: linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, mani@kernel.org, Manivannan Sadhasivam , kernel test robot Subject: [PATCH 2/3] serdev: Add CONFIG_SERIAL_DEV_BUS guard for of_find_serdev_controller_by_node() API Date: Wed, 1 Apr 2026 12:37:34 +0530 Message-ID: <20260401070735.107162-3-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401070735.107162-1-manivannan.sadhasivam@oss.qualcomm.com> References: <20260401070735.107162-1-manivannan.sadhasivam@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ZfUQ98VA c=1 sm=1 tr=0 ts=69ccc44c cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=zTATW481NYPnotdwU90osA==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=b1-ATBUx8nBV-T_5hXwA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: v-ci0ORlek-XtLVnNjUdHcr5hIRTyvPR X-Proofpoint-ORIG-GUID: v-ci0ORlek-XtLVnNjUdHcr5hIRTyvPR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA2MSBTYWx0ZWRfX/iPi1Lq+5fcp DhShnBP4v6U7j1LlxZGIsZsXY4fCC5mSzvJrJVIANQCMHmLLdczMS+G3RuAvhSpZdteGDFMGWkK lNDw701Qewo31CDUGaVV0l7G/DePCZPA9xPE/Z23839UPGE34wBARi5rJ4kccCMl+YRSHWFJEWG sBmZ+sSBai6Daq0HFByqs8GOZ889tBNHWlnQvFO/+JEBNS3Z3s8dYJ809BydYAkJ6o0P1VKOdrY FHj2rE0S/ObFUkG9SnJCEOTEpM3fxuqvn60UBP4lFaSvS0KkAqHcH3WLefkp+70MY+ZGfIeQ1qf wWw+DUAt1ZP0WbYEw6beDGyf1jbB0NqYsYn+34SF2XmOhVKI4riBH1JmX1DcNGjc/0EcRF5+v3a ldHVaaenx2c/k7eQx6QMnJOR2qEtoZe4Um+0qQmWyPfcBiIZ/Uxnh1LfpwGrUkaba5+Ql8mqbME DiZ9HimgXTd9FhAK63g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_02,2026-03-31_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010061 Content-Type: text/plain; charset="utf-8" Currently, this API is only guarded by CONFIG_OF. But the function definition is guarded by CONFIG_SERIAL_DEV_BUS symbol in the .c file. This causes below build error if CONFIG_SERIAL_DEV_BUS is not selected but only CONFIG_OF: pwrseq-pcie-m2.c:(.text+0x924): undefined reference to `of_find_serdev_cont= roller_by_node' Fix this issue by adding the CONFIG_SERIAL_DEV_BUS guard to the function prototype. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202604011226.KGNn5974-lkp@int= el.com/ Fixes: a2b4814190af ("serdev: Add an API to find the serdev controller asso= ciated with the devicetree node") Signed-off-by: Manivannan Sadhasivam --- include/linux/serdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/serdev.h b/include/linux/serdev.h index 0de261a26284..58f000534bdb 100644 --- a/include/linux/serdev.h +++ b/include/linux/serdev.h @@ -356,13 +356,13 @@ static inline bool serdev_acpi_get_uart_resource(stru= ct acpi_resource *ares, } #endif /* CONFIG_ACPI */ =20 -#ifdef CONFIG_OF +#if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_SERIAL_DEV_BUS) struct serdev_controller *of_find_serdev_controller_by_node(struct device_= node *node); #else static inline struct serdev_controller *of_find_serdev_controller_by_node(= struct device_node *node) { return NULL; } -#endif /* CONFIG_OF */ +#endif /* CONFIG_OF && CONFIG_SERIAL_DEV_BUS */ =20 #endif /*_LINUX_SERDEV_H */ --=20 2.51.0 From nobody Wed Apr 1 22:37:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520AE367F23 for ; Wed, 1 Apr 2026 07:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027283; cv=none; b=jP2QrNRpdxsGfsbHsphq5sqUUh3LTLKof+lkRkv9c+eakrnV9AZ9vtE699TFnEE9VTvfTzk+zRIvtdy555ET5ZlcOf16l5eWUf5buzKAyL/rFttmwzQqLx5FMdDrbpgwomW2B7YOgzeABwcccYlzJh5/w/MwMrxrFgLQjBJRLHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027283; c=relaxed/simple; bh=A4Fd2p2oaC0i/0aWJ0+24PUGDksjG/LlVj8xldlFxco=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kku4SYqvoOiT0FHdanrclVNV627bivpraF/cbXN6piOVxk+i2jXd/3lrHlngRWKW2x7wcUB7cQMBmHn7eNfFDnP6qP97tR4UaiX5gjFdsYK0Ku9rvjFmgXXnR8WmVrcS1tKQqhHqrpRT9HN2QvRdBR8FH6gPvie5oAMK4hBRwRo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n6PjEbyq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jbFJP9CY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n6PjEbyq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jbFJP9CY" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6312rDth718548 for ; Wed, 1 Apr 2026 07:08:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Q4pa+MYOLwL +Bi1Cvs+VaLt6dnCZxkjrvO8p8dS1PfM=; b=n6PjEbyq5Cyef+TBt3tPvEIlnnK +427v3NTuwh2F7xKSowCGnPyg4tgxMgReq8ha3fjxUYZa1J8XTbP9zcSyNY4yccz ltiEJmitb+tjuHAIeHzjvzWx6jyUeGvmI4OemV0UH3NFhzlGehPu2fu4vdzRHq4I 5scBGqH1RVGkzfQ0ZQmF6fz8HWFnwHv2B6WPh8Le5Uv96Lfr88Vllj3Q0Y+lEZPA 4Ku7o7YSqp0k16787gGFVz6/ACdbWE7994vgqcdPJVmieTFSTU73ZVyGLOKHypjw NnYqEebhK++qRyDdf0u5O8VkvaAg7/dycAm2IGkYptz7LGN7iN1INHYbwUw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8kcstr6r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 07:07:59 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35d9f68d00fso10771629a91.2 for ; Wed, 01 Apr 2026 00:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775027279; x=1775632079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q4pa+MYOLwL+Bi1Cvs+VaLt6dnCZxkjrvO8p8dS1PfM=; b=jbFJP9CYJU+TpnStcgJCI6bp0sRjKX+Y7wIHNHvXINgoJgefcx6/RTMRqAHPYAdFqM DiaiSU6xLWQIEuq47HOZAnhr52N4Xd9se/KjmfDyTSKXTl6zDYdprDNgm8mDfeAUm9ta enj8SPADBMQ9EcsEqxbKa7BPYi3wDt755JLaf7H5RtXgMKmdV9iO5DDykJh6tirr2gPI +xVIEoJL03CPNDs2N4TXQxZO1PykDKottWCrcfccsPag8CA7XppA8wcayCI2wndv/tX8 llclxjhLruv4RCECUe54yX+5biYZOKlT8DoZxySaDPfCk5T94HZpe6GpptwJ7wY22Ug8 nk7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775027279; x=1775632079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q4pa+MYOLwL+Bi1Cvs+VaLt6dnCZxkjrvO8p8dS1PfM=; b=I7/M/xaa68lF+SeKKsFwaIel59HYS3uxAQMSus5Q+8QX2pMNvaGZQHjQGFrntFl2TP za8yxc27IG1sCZjaPfBzIHirmfmB04qqAaFlXctQBiBUWpFen9+HS+cQUMJwh+c7zwdH A5EuEGM+gXZk9SYOhp31oJBBMteymmq+n5qxk7nqrerfA9NjkGVYbfy3Zy15WSovixgU iV1kCFVOrEIx11hBRwP/SjjbKExEzHkmiTJZH/gv+ocdASgO80Ybq3REgEQOzA3bLW62 f6yQzqNK7dqML1no8qQqBbo9sJhpCDvgzdz3eRu/m3zD+v/ncFzwJky/og7gN7K0u+CL CCMQ== X-Forwarded-Encrypted: i=1; AJvYcCWcxcvFuna4NNX5BBdz0d9QqE5Z3HThqgBkV7dSlhqduRUpvs/+4Lsv7dkC8uDx4vjf1AtRvJ0c2e5DhPk=@vger.kernel.org X-Gm-Message-State: AOJu0YxKe0zq7LEV7DXBJ/tlkWdKNRCDBmZ/Cyr4T1zzEfbai/Bo6nYo AdHmQyHiW+lkwqsb/4k6LLfDQyFiOJS66uj4FBdj/4MK6Sj59IGmYHPPga0mhnttRcXXL+JnE6D UPdnpSHFDsIsG3yaWmoCIdxDs8JfgUwGmZSGWO+xvmDnFgTeNnXY565ESj3z1x9jyK3Y= X-Gm-Gg: ATEYQzwBJ8CwPaUYNQ9GFFT+dXC1orgjrm7D43p9AnXJFWHZcAjGa6FWCk2PBh/l6P1 ndAfTx/3eImrM481xBVXCSUnQjAFNcOUSUoiXKv7iYSF1ZkTIRHtj8mkW9KnDge/I/Na2Wo1Cmw A4sDZi489JQuF8ey1xaGWdPnbkuPxfJpBkeKMTH7pV1ptPFW7GPXt55TwOfOWFajraEOwXU4oum adOM9yikjAonrGboXeD+XLmN2hOJoOKg/nvuhRQ08cMU6pUmTWX5xCaMSlOZjKU2SuN1PjNS01V sCeIK+MmKkBRNR+tDvMJJLZ8uoDbd9XbuMGAYunOrnLRZKTlxLekeh4ozyyeKP1h41NOdkZ+0EY GC2+G8IFEz2m4SIOxH14IHTIBcM5XSRoWZpbZ X-Received: by 2002:a17:90b:384e:b0:35b:9b77:d7c with SMTP id 98e67ed59e1d1-35dc6f61432mr2270933a91.14.1775027278597; Wed, 01 Apr 2026 00:07:58 -0700 (PDT) X-Received: by 2002:a17:90b:384e:b0:35b:9b77:d7c with SMTP id 98e67ed59e1d1-35dc6f61432mr2270901a91.14.1775027278100; Wed, 01 Apr 2026 00:07:58 -0700 (PDT) Received: from work ([120.60.63.102]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe6e2fc9sm3956464a91.15.2026.04.01.00.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 00:07:57 -0700 (PDT) From: Manivannan Sadhasivam To: brgl@kernel.org, robh@kernel.org Cc: linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, mani@kernel.org, Manivannan Sadhasivam , kernel test robot Subject: [PATCH 3/3] power: sequencing: pcie-m2: Guard the helper functions making use of PCI bus notifier Date: Wed, 1 Apr 2026 12:37:35 +0530 Message-ID: <20260401070735.107162-4-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401070735.107162-1-manivannan.sadhasivam@oss.qualcomm.com> References: <20260401070735.107162-1-manivannan.sadhasivam@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA2MSBTYWx0ZWRfXyaWUwKXlUEID nEhi8nmzEdUGjO8crdHteYYa08vJYkrMrWG/PJSdNDDE1N51YmREWlWriVwpzUOwDyVpzPvEYHu e2H7936JmZ7ibelJh1ll4PEz3AQ4C7ENyyLWdJF1gRtp8NgR/8YUQJcRUCwPPrvhQXuLCZxfPGC jm/nuGo3AgfwWBfcYhC0Vy4zMl1N1YoD3Sd2UzADSoQYvn23OXQURZBBFXp1nO5g1vgJlQne/zE +t4vQtISEFRP/MQNXpMFh9mna2JEb1nD7CM1undm7SnG8pg6aDdSkwNhWPs8OZ2x/AkH6uI2tE8 b3aS+wZ1sufptBVNsFuMoXRuMxNfGZJDS4fzB6aCcqPQ9jwN6a1Ci32k6TIBdIrsj7HnkmYeiM6 +zHVKL4eXltsS78cqUMfhnv8hnazFGLQxtRvYkXvit82YRQQyuMl4rThGmFk/kGl/2ZDXsgSpDb JmI4YiyyomBuImTMOcA== X-Authority-Analysis: v=2.4 cv=KNlXzVFo c=1 sm=1 tr=0 ts=69ccc44f cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=zTATW481NYPnotdwU90osA==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=7-A4b6ptinYaPxXeEqIA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: Hr3IiZO1DnZcHaVhg0ibfVm7dBE4Z4Er X-Proofpoint-GUID: Hr3IiZO1DnZcHaVhg0ibfVm7dBE4Z4Er X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_02,2026-03-31_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010061 Content-Type: text/plain; charset="utf-8" The PCI bus notifier is only visible if CONFIG_PCI symbol is selected in Kconfig. But this driver can be built without CONFIG_PCI due to CONFIG_COMPILE_TEST, leading to below build error: drivers/power/sequencing/pwrseq-pcie-m2.c: In function 'pwrseq_pcie_m2_f= ree_resources': >> drivers/power/sequencing/pwrseq-pcie-m2.c:185:34: error: 'pci_bus_type' = undeclared (first use in this function); did you mean 'pci_pcie_type'? 185 | bus_unregister_notifier(&pci_bus_type, &ctx->nb); | ^~~~~~~~~~~~ | pci_pcie_type drivers/power/sequencing/pwrseq-pcie-m2.c:185:34: note: each undeclared = identifier is reported only once for each function it appears in drivers/power/sequencing/pwrseq-pcie-m2.c: In function 'pwrseq_pcie_m2_r= egister_notifier': drivers/power/sequencing/pwrseq-pcie-m2.c:340:54: error: 'pci_bus_type' = undeclared (first use in this function); did you mean 'pci_pcie_type'? 340 | ret =3D bus_register_notifier(&pci_bus_t= ype, &ctx->nb); | ^~~~~~~~~~~~ | pci_pcie_ty= pe So add guards to make sure that all these helper functions making use of the PCI bus notifier are only compiled if CONFIG_PCI is selected. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603180609.ucspJefN-lkp@int= el.com Fixes: 3f736aecbdc8 ("power: sequencing: pcie-m2: Create serdev device for = WCN7850 bluetooth") Signed-off-by: Manivannan Sadhasivam --- drivers/power/sequencing/pwrseq-pcie-m2.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequ= encing/pwrseq-pcie-m2.c index a75ca4fda2eb..d3102fea8d93 100644 --- a/drivers/power/sequencing/pwrseq-pcie-m2.c +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c @@ -177,6 +177,7 @@ static int pwrseq_pcie_m2_match(struct pwrseq_device *p= wrseq, return PWRSEQ_NO_MATCH; } =20 +#if IS_ENABLED(CONFIG_PCI) static int pwrseq_m2_pcie_create_bt_node(struct pwrseq_pcie_m2_ctx *ctx, struct device_node *parent) { @@ -374,6 +375,12 @@ static int pwrseq_pcie_m2_register_notifier(struct pwr= seq_pcie_m2_ctx *ctx, stru =20 return 0; } +#else +static int pwrseq_pcie_m2_register_notifier(struct pwrseq_pcie_m2_ctx *ctx= , struct device *dev) +{ + return 0; +} +#endif /* CONFIG_PCI */ =20 static int pwrseq_pcie_m2_probe(struct platform_device *pdev) { @@ -452,8 +459,10 @@ static void pwrseq_pcie_m2_remove(struct platform_devi= ce *pdev) { struct pwrseq_pcie_m2_ctx *ctx =3D platform_get_drvdata(pdev); =20 +#if IS_ENABLED(CONFIG_PCI) bus_unregister_notifier(&pci_bus_type, &ctx->nb); pwrseq_pcie_m2_remove_serdev(ctx); +#endif =20 regulator_bulk_free(ctx->num_vregs, ctx->regs); } --=20 2.51.0