From nobody Thu Apr 2 00:12:47 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72EB632C92D for ; Wed, 1 Apr 2026 05:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775022742; cv=none; b=awxS2WrkpQNOaWyErlq1GorZxey1PVCfd4mUq1BdyinVuzOe/8Lt2aQDYoyWrRjVCIirBfaZH5/ubm/ua1YLuz6xWMLCp0FB4UzIMyO6zOwHzOT05zR3k9rSx8kS8OxBIQY5lK7Kk9mdl3ZT7CgJZSF9uyZQit39ne1sbBGsMzA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775022742; c=relaxed/simple; bh=YXtKPFZbWWZBopwp0wtvWhgawI8Cv5FypUVRsO7wl+U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=C565o6TKmDuHpa2XjDjAqk5uOmXoXjo7mkzVPEAOhXAYzyL0+JF78qloy7q3/B/3rbjIs/a7kYGI+broFp1pNcuN0sJRNz+v/H6/i6SqIu0D5GFGSoUp7Hk7seAKAa+K45mj7g8ZQkl/bc19/A1o4A81mfwz0nYVUQSoCKVf3OA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=azhWjiRj; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="azhWjiRj" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2c4cfe08c9dso15528489eec.1 for ; Tue, 31 Mar 2026 22:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775022740; x=1775627540; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mXhmCfoDGbEzRy0vkOhlRcCB2RW/wzuPXoAXA+lWSZE=; b=azhWjiRjmMxSccVizr1Yw8vvLrtsyG8oSTEmryhfzLVcfMCwcdX/O53Z4l2F2YU0T2 SDzymC63U5hqReW61+MQCB5oFxLaJ1gUTOZzC3q9+kflKygcCK4s0nguoD40ns1CpQ9Q bsHHF1LMqoHQBiC8hzGy2LPYOV2v9Aa3CyRYuKe1p3sve1VuGNj5N1rmXlxgE694o5Gm po0f52nRIPFhM8b+0+X7IvYQ3j2Flzm9mvIVfWWX9ngFNBv0hjp/i+NXb1bpFNpEyK1U hbMp3IBwct8Ol3WnjT8QAsbVkW3NPbVLbpHhLHcBXj1e3Gr35htjycEk/IezlUC3D8tz RA6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775022740; x=1775627540; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mXhmCfoDGbEzRy0vkOhlRcCB2RW/wzuPXoAXA+lWSZE=; b=Hww9McPUGay8jQUGzhv0UbSXlm8GTNzsA9u6d8kkLB8uVuaYa8XJ/vnGTu1FrNq5V9 Uus8PrIo2kXZjezH6AXRCLQjU0kLbvgLYh+HZzCUlvAnuVEjcceJU/mj+do5VFD2a/07 3YN3CyiXDxR0rCGEhXb4suhPhTfbzAm5QHrjcQP/is/1VUmwbdhOZYEPeNxGuTMr0jhk ACys6t5DUe1BMgHJXnPfn0FydkfDR0FMTGrwjcGxczubMui+vi3cVt0iKI0tvNfmM97z DxSp6IS+c/X1m7J3ZW8MEATA0xlWAjqUc56WhEuSFSvdtazbja0ywX79AtwmZ4rQZUlm J7Fg== X-Forwarded-Encrypted: i=1; AJvYcCUZA++0lQG/tlKXAtYCs5SPWmW9Hop3zvV+zfe8WLwi9XLjQeJlG8J8lUL/bj4uY8OqzXEY4M/PEckwL2U=@vger.kernel.org X-Gm-Message-State: AOJu0YxOwT8rnOuP+JzvpCho326pRwXAYgNrimmCj9zx0mv0icRQ4RdB 6BdPAiQiqfVQWlnxqu4gvm3JrCgVhE89A1P/vfuah5j9U2a9D+wLrdHp3xPdmCYghu2YJaFg5Rz sJrI8rqUOgA== X-Received: from dybnl19.prod.google.com ([2002:a05:7300:cf93:b0:2c8:8349:e96a]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:2213:b0:2c7:2cac:815b with SMTP id 5a478bee46e88-2c930986704mr1304509eec.6.1775022739450; Tue, 31 Mar 2026 22:52:19 -0700 (PDT) Date: Tue, 31 Mar 2026 22:52:04 -0700 In-Reply-To: <20260401055206.43187-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260228065953.3226283-1-irogers@google.com> <20260401055206.43187-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.1118.gaef5881109-goog Message-ID: <20260401055206.43187-6-irogers@google.com> Subject: [PATCH v3 5/7] perf ordered-events: Event processing consistency with the regular reader From: Ian Rogers To: acme@kernel.org, namhyung@kernel.org Cc: irogers@google.com, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, ashelat@redhat.com, ctshao@google.com, derek.foreman@collabora.com, howardchu95@gmail.com, hrishikesh123s@gmail.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, swapnil.sapkal@amd.com, thomas.falcon@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some event processing functions like perf_event__process_tracing_data return a zero or positive value on success. Ordered event processing handles any non-zero value as an error, which is inconsistent with reader__process_events and reader__read_event that only treat negative values as errors. Make the ordered events error handling consistent with that of the events reader. Signed-off-by: Ian Rogers --- tools/perf/util/ordered-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-eve= nts.c index 8c62611f10aa..a5857f9f5af2 100644 --- a/tools/perf/util/ordered-events.c +++ b/tools/perf/util/ordered-events.c @@ -243,7 +243,7 @@ static int do_flush(struct ordered_events *oe, bool sho= w_progress) if (iter->timestamp > limit) break; ret =3D oe->deliver(oe, iter); - if (ret) + if (ret < 0) return ret; =20 ordered_events__delete(oe, iter); --=20 2.53.0.1118.gaef5881109-goog