From nobody Thu Apr 2 00:12:48 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94AD732A3C9 for ; Wed, 1 Apr 2026 05:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775022737; cv=none; b=STlcM7qCslnTwjG1W0J6g/xLxheffGHf86wb7AeR1nWRb3EJTsdsH8v+w6tyd+0YvfwdVZ272Zb3TUR8mughGaLym0t08iL88/rS/UnDcYOag4TbjvoIpF6xezM6yQm4j1JXVfh9p5Sm2Y5OiWotQNNLDqsrF094tNs6z9kZq2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775022737; c=relaxed/simple; bh=etWLpPUbAL9PbGn2PsAzD1vzOgdSqQ+V+536k9PjEfA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=aPhQR5EEmsLA0Z5uqCNRHsEt2jBsXr76ejNhbqdbnyfIu1qk2j/KOBnzagPmCdYHdKCM/AFKINOt0bFCCzKLIy+cCUzx2HttDUWRlPw4ik74hgUrO39nQy4KACG1p+k22qio0kVlET6Cf7sM1V225NfPzhAZb6gb45CHvCZ1gdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fguTCcAR; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fguTCcAR" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-127337c8e52so11418443c88.1 for ; Tue, 31 Mar 2026 22:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775022736; x=1775627536; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WMSD5CIynbKr+BJ31meFhjj49c+zZqPVABuWE4dY/sQ=; b=fguTCcARQzzg7D5v4oX3OL9t0cGqUNMKHPWvYPqnpE7ng9CO5r9kzBc9Pv6jKCGoSm r1SruYbYTvcyvgH5HwsAc18OLrtHsxXcxgyXjPUGM68sKPzKDUrUHethZarYTVKavwoM DvMjLcbwQ1CYz6wF+yrM8pW53m5oZs1idi0ZLu5k8eEZK96iRrrpGoi5ECBkJt+ADOM1 Qab+A7VoW5EuCopYxlsQu7iudq1f86ULCHwpXYAD4p4KvAWJNcP0LaQwLt45NwX8Ef/z F5762UmqjsU66XhMetv4vNddTBEYMw00LQ0YYnH269kCQ9K44fpURsccGkAugDimKO5j GTjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775022736; x=1775627536; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WMSD5CIynbKr+BJ31meFhjj49c+zZqPVABuWE4dY/sQ=; b=S3TzIG1WM9NbrPqWKWJ3aRLtoHudloqjCeMVd3acj112WJt/Nz/iaRNBt/mQzP49Zx vVj1o8gZ9HWHG7PVkrAMNGDVb07ntcEXCDEfxRIijqXaFjgQXYDXiMV5mgKBPnQ59PQq k8a7E7zTF8Kvz10P3WmGOXhJFquSJB/JrCD4WqeC0LLG1PfXDgmf3FLLUOz6nX+ObGMi wI439qMKI4Cr64mSEs6V9pqGfkxWwUPsEhu15FTD2qUFLOj+EzHMI/Yb1S9lY2cIkHC/ mox8bA+Lf/I0D2AwTQ4itwjnssbqsS9fFICnmjE7GVWcOBeCO38K+F7rXZYJr2AotmOO c4dQ== X-Forwarded-Encrypted: i=1; AJvYcCV1wBtmIHPRY8vSWA3Kydd/ZvTwEZauYGkLhW+LP/TwxctOxbmMc8myfSmOfpvSsshk/wvN1wYlROwUStA=@vger.kernel.org X-Gm-Message-State: AOJu0YwINL/xiXyZuTyISTzAiy22BsvE9VIPTp29QM0pcJGTmSWRc2m/ 8SQHTj+IqGUeala3eG2rFnw/7nzzYr1E4N++m9CNZLTh5fxMKNn+uGlLboht5eCWNoQ9ybdsY4i G1hSIqcPVhw== X-Received: from dlbvv5.prod.google.com ([2002:a05:7022:5f05:b0:12a:6a54:c33e]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:2220:b0:128:d438:cad with SMTP id a92af1059eb24-12be65577b5mr1511311c88.18.1775022735419; Tue, 31 Mar 2026 22:52:15 -0700 (PDT) Date: Tue, 31 Mar 2026 22:52:02 -0700 In-Reply-To: <20260401055206.43187-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260228065953.3226283-1-irogers@google.com> <20260401055206.43187-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.1118.gaef5881109-goog Message-ID: <20260401055206.43187-4-irogers@google.com> Subject: [PATCH v3 3/7] perf session: Extra logging for failed to process events From: Ian Rogers To: acme@kernel.org, namhyung@kernel.org Cc: irogers@google.com, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, ashelat@redhat.com, ctshao@google.com, derek.foreman@collabora.com, howardchu95@gmail.com, hrishikesh123s@gmail.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, swapnil.sapkal@amd.com, thomas.falcon@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Print log information in ordered event processing so that the cause of finished round failing is clearer. Print the event name along with its number when an event isn't processed. Add extra detail about where the failure happened. The following log lines come from running `perf data convert`. Before: 0xa250 [0x10]: failed to process type: 80 After: 0xa250 [0x10]: piped event processing failed for event of type: FEATURE (= 80) Signed-off-by: Ian Rogers --- tools/perf/util/session.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 4b465abfa36c..492515789d3d 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -131,10 +131,17 @@ static int ordered_events__deliver_event(struct order= ed_events *oe, { struct perf_session *session =3D container_of(oe, struct perf_session, ordered_events); + int ret =3D perf_session__deliver_event(session, event->event, + session->tool, event->file_offset, + event->file_path); =20 - return perf_session__deliver_event(session, event->event, - session->tool, event->file_offset, - event->file_path); + if (ret) { + pr_err("%#" PRIx64 " [%#x]: ordered event processing failed (%d) for eve= nt of type: %s (%d)\n", + event->file_offset, event->event->header.size, ret, + perf_event__name(event->event->header.type), + event->event->header.type); + } + return ret; } =20 struct perf_session *__perf_session__new(struct perf_data *data, @@ -2110,8 +2117,10 @@ static int __perf_session__process_pipe_events(struc= t perf_session *session) } =20 if ((skip =3D perf_session__process_event(session, event, head, "pipe")) = < 0) { - pr_err("%#" PRIx64 " [%#x]: failed to process type: %d\n", - head, event->header.size, event->header.type); + pr_err("%#" PRIx64 " [%#x]: piped event processing failed for event of t= ype: %s (%d)\n", + head, event->header.size, + perf_event__name(event->header.type), + event->header.type); err =3D -EINVAL; goto out_err; } @@ -2225,8 +2234,10 @@ static int __perf_session__process_decomp_events(str= uct perf_session *session) if (size < sizeof(struct perf_event_header) || (skip =3D perf_session__process_event(session, event, decomp->file_p= os, decomp->file_path)) < 0) { - pr_err("%#" PRIx64 " [%#x]: failed to process type: %d\n", - decomp->file_pos + decomp->head, event->header.size, event->header.typ= e); + pr_err("%#" PRIx64 " [%#x]: decompress event processing failed for even= t of type: %s (%d)\n", + decomp->file_pos + decomp->head, event->header.size, + perf_event__name(event->header.type), + event->header.type); return -EINVAL; } =20 @@ -2382,8 +2393,9 @@ reader__read_event(struct reader *rd, struct perf_ses= sion *session, if (size < sizeof(struct perf_event_header) || (skip =3D rd->process(session, event, rd->file_pos, rd->path)) < 0) { errno =3D -skip; - pr_err("%#" PRIx64 " [%#x]: failed to process type: %d [%m]\n", + pr_err("%#" PRIx64 " [%#x]: processing failed for event of type: %s (%d)= [%m]\n", rd->file_offset + rd->head, event->header.size, + perf_event__name(event->header.type), event->header.type); err =3D skip; goto out; --=20 2.53.0.1118.gaef5881109-goog