From nobody Wed Apr 1 08:38:29 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6D8D3009F6 for ; Wed, 1 Apr 2026 03:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775014845; cv=none; b=XdCUHcJEF7hAAnXtLM7yKvJrZZe6ozR1b8J2lvVPs2m2FdgAX1O/fXeRDFNT42KTaIpKBVms/99rBBruE/sVgUjeCDFlgAKDWcqbhQ7WMG7XcDIw2SSCA0ysWRwTTwVIiFhs7gI10Rv0oN+gxE+4yKStV2N+UmZ9XD6GPha6/4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775014845; c=relaxed/simple; bh=ONt+NLYwBfQsWKrB7SVz0tjFHaNo2vk8LWO78PzsWOM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AR0Ql2Gjb+RfZQ9cTbDPqVC/yvxJOsuYQhnwZwEFHGNFSDAtiAUwMmNlerEvJOIyZIpnpzSH/jVZ3L7J/n9DcoXaz9e61x9qv5koULCcqJhfUVZu+Zr/yKFPikYcXp4q+4TDjIhqUNaNcqst9fIUKn8c0BYKM4BDhXplj0kfciA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D6Lx3deD; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D6Lx3deD" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so3804134a91.0 for ; Tue, 31 Mar 2026 20:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775014842; x=1775619642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vc5pDezw6rbZBqfkyYlJJ2XpaK+6r4fOQMnx2LPA6Vs=; b=D6Lx3deDmtzESukF3bmkFb8sL+5t5uDzwMU/SHfELWShUcOhT6CTeX5LYkG+MEpsvH DK3n11KrlUYiNNoI1W8wqjV4Kp8fTlLpRwd3gyFu79cMVTCDvB1CFfNp+YZ82Uohn+4d iJxs4ldytNdku78HVDDzLt7F2D7CaFeeN+KNcuAwVFa7Ze9M1Gsdv/cLj8sKTdPpd1kR qdKlTKTZ+Q6zzj3383wKoVNgl451jFsbIUOlK6z657LTcOK4pl6KvIh4dA66etx5W6IW /fO8+W2k2B76AT//+sgquBnY5BkNTy8QLYKr+laH2zkl1pgwUKTcsvB0w2kD2D8Y2K1k qYQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775014842; x=1775619642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vc5pDezw6rbZBqfkyYlJJ2XpaK+6r4fOQMnx2LPA6Vs=; b=TmJ6L0Rh6H1nH1DDTGmKKYdPPvpLlQUP7ox82e/Mw2OklaRVcKiavxYQPw/RIP+YKX sARkh8SF7pGfv3eByBGbskJONeT3MwR3eb1p8douW7fUMhxsM+pezY/ft5yRmaWOEQ5B 9n7Tg8of4rTn04iwAhingE+jzMw3eiciZHVgTqJlB0wHjhEfVRIV1Q4JS8EJClzGIs3C AVQE+8QGvdYCJD2rycVP0345q9Qg+h1pUhNSXTRS5KL2y6w9YfT0fbqWOi14cmx6fOJE bWFGE0SoYWupMV5ACCXhWflgWWKMfjbRv8VK/NU/Gh76rGCZlDQAmxE1/7fFI+TPqeXx B/pA== X-Forwarded-Encrypted: i=1; AJvYcCU6NNASOj0wRgW3J3UyX6Lp+DW4NVTbZQ7fhj9Q2LMxDZvyU+46IAa3aHFYjPXQ2oG6RBgg+ialItcWy/c=@vger.kernel.org X-Gm-Message-State: AOJu0YwgERotXpDMxuc+FkVgAfSxdbAlqgu2r9WoVhbgKtGEea4mzXbA Oa6KCLQJYsHIsGYQ09inXr2xNudfP6iui7VYgK7egImkoH4YPEuqEL5h X-Gm-Gg: ATEYQzxWR9oY6qa0weHQVHMh7h5Jp2lN6FnDCxnCOMgiIKJHgIqjU7lX8KLXbQcMcnk cZjFaB9wzIVQu431YQLP+qfyxfvQZ9wl9OSubJMk0F45weCg0MdLAPqB48xNyT9hQQ4sufMR0pI Ffa4zyFT8qAZpaAdHSQtvISSjtdAbMnTpnI1CSp5pWP93fTeedBtXYwZdkd9tWo+Ol4WbAvAhbY F1oU6y7vEmmQyPGbZUzCQJQBJEC6wau9c3PouV3Z7VPHH8pZFgC78W+jsvqHqMGn01X+caI5CEo 0LAbndrb8uR1q87u2Kg6KHWIpGMUyAHJJj5Qty7FvPA/VCs4rx0vlmE925GDI1oY2Jm9EiqGFbq KN1DCeNPmtSPCzscz8kAPdC9Zb3ggO6xfKlcHAqHyg4YHu7ew9Pe2pOmmf7kf+kDFz/vX9wfQU0 foTcQsdJuExF3jPoqU8yWw4w== X-Received: by 2002:a17:90b:1d4c:b0:35d:9cda:ba08 with SMTP id 98e67ed59e1d1-35dc6fc9f4dmr1828798a91.31.1775014841924; Tue, 31 Mar 2026 20:40:41 -0700 (PDT) Received: from lgs.. ([2408:8417:e10:5f85:653:6a84:ffc9:685c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe637250sm3192267a91.6.2026.03.31.20.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 20:40:41 -0700 (PDT) From: Guangshuo Li To: Vinicius Costa Gomes , Dave Jiang , Vinod Koul , Fenghua Yu , Shuai Xue , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] dmaengine: idxd: fix double free in idxd_setup_engines() error path Date: Wed, 1 Apr 2026 11:40:29 +0800 Message-ID: <20260401034029.1457489-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When an error happens after device_initialize(), idxd_setup_engines() calls put_device(conf_dev). The device release callback idxd_conf_engine_release() frees engine, but the current error paths then call kfree(engine) again, causing a double free. Keep the cleanup in idxd_conf_engine_release() after put_device() and avoid freeing engine again in idxd_setup_engines(). Fixes: 817bced19d1d ("dmaengine: idxd: fix memory leak in error handling pa= th of idxd_setup_engines") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/dma/idxd/init.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index d9a9d56dd277..4eff74182225 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -310,7 +310,7 @@ static int idxd_setup_engines(struct idxd_device *idxd) rc =3D dev_set_name(conf_dev, "engine%d.%d", idxd->id, engine->id); if (rc < 0) { put_device(conf_dev); - kfree(engine); + goto err; } =20 @@ -324,7 +324,7 @@ static int idxd_setup_engines(struct idxd_device *idxd) engine =3D idxd->engines[i]; conf_dev =3D engine_confdev(engine); put_device(conf_dev); - kfree(engine); + } kfree(idxd->engines); =20 @@ -374,7 +374,6 @@ static int idxd_setup_groups(struct idxd_device *idxd) rc =3D dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id); if (rc < 0) { put_device(conf_dev); - goto err; } =20 @@ -399,7 +398,6 @@ static int idxd_setup_groups(struct idxd_device *idxd) while (--i >=3D 0) { group =3D idxd->groups[i]; put_device(group_confdev(group)); - } kfree(idxd->groups); =20 --=20 2.43.0