From nobody Fri Apr 3 08:39:29 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297FF358399 for ; Wed, 1 Apr 2026 03:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775014596; cv=none; b=g4B6CzWq5l4RhosZOodHvp1PalbiBtwn3Ap26BHBRoVGbDO+Fh4PaBG2H65sUjtrIWREMfEqTZo4BsQWK0SAfDb9EoZ5t5BiZuRo+H2MEn9US7PQ1ZO6g4myatovDX0Vp68YgUMTVLNWJvoDnJctemHbm7cpHQmCEpp8Q4ZVW2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775014596; c=relaxed/simple; bh=cnZj4Tq75TU+m9MvB0/TuXcjxJ0PZXub5lCKx9Ude6U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R3zYLTeHAbSVTowh1UV+gtJzpQv2gkUEC9T4bADeFyRfShtFoMNFyNowBoVRU412qYRWiv/VT1Gqy4rB1RNJdGv5JFXU8KMAOTAXqzl2ws/IHAGG1VH7qKX76gaOct3XIQEJAtJO0bg51IFgwSQZIuk5b8QvLlAyaXcYvVDnOeM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Npa5lCQX; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Npa5lCQX" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35d971fbcddso331844a91.1 for ; Tue, 31 Mar 2026 20:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775014594; x=1775619394; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R2TCQh4xS6cid2Jzw04r6Vvh+yYWLSOE9opB+QSqdXM=; b=Npa5lCQXtkB3b88W8jYPKdAKXO9om4AvUabEihu3j4N7Ol+k7Dzh7hbmATUqJmQ8Ac bTrGJ3E7X744/0tJIoxXZjKuXhI7hHJU80LNH3Ojok0GOrNifY0NzFwWSG/O9kxT8UqK 8gm17FIEsrQNXt1q0/RO2fKP/oeli+ZUJ0tDut7sZs41aZNc8uzPE5DW1biED65bjfHh weaqGbA7sfarPm9fzLw+CeNTBu6o2FUfNfkCBVl4vYJMjfwvRQ4NUo4cbklNwhBpl760 Vlbk/4wHtruBK/E9iHEHnDYUNdouUf11/L/FG9VLKNVNhZzeuuQMbqpNbRV0be/5DXe9 mI9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775014594; x=1775619394; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R2TCQh4xS6cid2Jzw04r6Vvh+yYWLSOE9opB+QSqdXM=; b=RCS3GvCrs22DmbINwpOpk6DVHsFKyZEUVqIzHSRKMaLwfnx6oCg+DdQjbdTrprmUaw vZ2bSuZZQtiUjZTJedBdJi8+NDlsZxa5v9BIMnK8hWCidk7PCAa6t6z2/sWQnQOKQgnQ cJ2zt6+k2k+06oF6oVMMEq2y733Vlr5ikVQhuk9c4VqHT/pVPJj8DiGfl62rr2zXUcCu b1pCEgMzlisDgo6x8GXL7RGvHgffAyBbX4ackZrAoUnUQtpfGUAPyhSYzdUwIc2CFAoI vC+B+aXcN7jD9WIawpvzLWM4Uxr9nXbmO4eZ798gbJcG0qG6j93kaTSu5vMEhinddaBZ 3DFQ== X-Forwarded-Encrypted: i=1; AJvYcCWqQCwWY4EL38fTL6AWFHWF0x7ZBT0xW+em6HSNongLC/QWCp9GzQPzPAvPpvWhowz76fkAJbOt7EdS1gc=@vger.kernel.org X-Gm-Message-State: AOJu0YyJxu0OvDx/QlabYRlTYb/IxCVhqidvXT1vp+WOo3rfvmiYw1Qo KicW4shQThKYKpxj40dA0DbPZXTHHZaFDJuws9H5078CHB9VaH2nFsmo+X3fRUVuVUeisg== X-Gm-Gg: ATEYQzxESwiUu+v6uaZYydf9011XQLoYdSL3P925WAecbQuI5WIm6ccPhCrvL5zB1V+ v4qV4fjklF3+pn5TjKV/seW7vw2vHNuQ3uiRKeAFGgIss0AFOWXU6scN76OIZahC51NL6ipX/NR A0uZEhkHe4nENcjqqKfv9kHwklGS0wumtseMRyCOPiwo/hU8S5KNCzypGw/NfFEq54xnCTY/qpU wBCY0YHeCGN9Hrcz0tcyzVsQIOt9XWz3LDgYg9v53URL+UXaNht0dZBkmx1jQOfbsBKGIvhuTTA 6L7An4OBNFDbcFMVAnmrHFO0vt9EvoZraWWP9VhvONkUCxdIjkbgqnDA52faWM6RZkG0XDJ/Sse Sk0qGcJ80TZ0Hz13ecF/Sa3FEncspTByrPcS1DY2uzzaSxaAPjMXiZnYKnu0hinDPVH1G4C/G93 BKQLQZCFQl2YaKSlT42/Jhlg== X-Received: by 2002:a17:90b:518e:b0:35c:10e8:1a72 with SMTP id 98e67ed59e1d1-35db8e58d67mr5963651a91.7.1775014594402; Tue, 31 Mar 2026 20:36:34 -0700 (PDT) Received: from lgs.. ([2408:8417:e10:5f85:653:6a84:ffc9:685c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76916cce42sm10470716a12.9.2026.03.31.20.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 20:36:34 -0700 (PDT) From: Guangshuo Li To: Vinicius Costa Gomes , Dave Jiang , Vinod Koul , Fenghua Yu , Shuai Xue , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] dmaengine: idxd: fix double free in idxd_setup_groups() error path Date: Wed, 1 Apr 2026 11:36:22 +0800 Message-ID: <20260401033622.1446904-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When an error happens after device_initialize(), idxd_setup_groups() calls put_device(conf_dev). The device release callback idxd_conf_group_release() frees group, but the current error paths then call kfree(group) again, causing a double free. Keep the cleanup in idxd_conf_group_release() after put_device() and avoid freeing group again in idxd_setup_groups(). Fixes: aa6f4f945b10 ("dmaengine: idxd: fix memory leak in error handling pa= th of idxd_setup_groups") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Shuai Xue --- drivers/dma/idxd/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index b782eb3c191d..d9a9d56dd277 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -374,7 +374,7 @@ static int idxd_setup_groups(struct idxd_device *idxd) rc =3D dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id); if (rc < 0) { put_device(conf_dev); - kfree(group); + goto err; } =20 @@ -399,7 +399,7 @@ static int idxd_setup_groups(struct idxd_device *idxd) while (--i >=3D 0) { group =3D idxd->groups[i]; put_device(group_confdev(group)); - kfree(group); + } kfree(idxd->groups); =20 --=20 2.43.0