From nobody Wed Apr 1 08:41:16 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E172F32E141 for ; Wed, 1 Apr 2026 03:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775013233; cv=none; b=ItuoVqNmiD3UAebqSQiG7TROwOcEUOlzgj5BDgZM+dYZ2pkcu6jJaesIFFtW78yVcvGuIVMW8Oew0m4Uh6b2mxREIjzvFRV/RG9j2qNDyIaPbirz8+YU/wAerfiunvXcaWRMW4eZodpjwK3Os+fa0susBNY0N5Xd/T9bvpiOQ0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775013233; c=relaxed/simple; bh=3qmKi+7NGTPmsMSzwTSl7l4uTJjqFPzwWq1vjBmZtio=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PIC7T0GeD0YJRgQXguOIZq0aIXD+G2QGo7zM4lJOSBQ0uFg04D25m0Z9IMM7p44b6c4XrwBerdi+ioYWnmJ9QcvZ+teGI8OX3ZnhgmUmbCE7mUoqWBznSGrIHi+0F4QGHt/ALcYIA5TOpwxQzSvUUFHl4ygUncUzmKjJ0r46B4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UwecOi1B; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UwecOi1B" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35d9923eec5so2470196a91.2 for ; Tue, 31 Mar 2026 20:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775013230; x=1775618030; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BfmezofCFYRgZ5OFemKApUxmmUyvqX/ZDRNGUel5g18=; b=UwecOi1BkDsrv7hCzMJqB2BGQHO+1WvQqkufTt5CXODXslXsz+4WtnMUleRJzkh33Z +o2rjx5HR2qXZJRupu8+hD//e9iGbtwpwjQrH1w/7Rcryp1R1wZrY3NoYnLhmSsMUxmC COsVTUj3/ux6SLUPNOkd+dWm7b2TZTGNqhaOD/f3UTBsfJRIZzDceuBVZ5KaGOR+CWWq 52Ay+i5IvmSasj4cY+pS7hE4p6Y5dmdNsogDHiN+LUSljN0JAEH3JuPg5oP9teXPNOfe umlJU/02wF53yYY1PAeiac+75Kbh71QWNPSgIpAcO5LECd+Crscv3/YklLpH86neyaX3 seHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775013230; x=1775618030; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BfmezofCFYRgZ5OFemKApUxmmUyvqX/ZDRNGUel5g18=; b=AHliBuY1EvH/XCfAEA6JNdLOinFdL0p08bN9BpLhh5c5WFC/zGD7fJ1X87FXHT5HfT iQdnIJX2fPqrITZaKvox/AFP6OtKQA5UOoljNPhvWQqh6HFDH0POxNQJQX2bniA7A9m1 OiL8RRQQE3k2izk+IaTDygIZWoFaKanISE/gE7lRTFpSRrHM6j3YGDXJoCyHAW3k4AXm tqGfjUn5yRbHwGbWKgtYvwhz4NnSNjCE0uuMXPpgxmobCbyaZEA4B0ql/PdIf5qaSWtW JB17JOa9J7O1Ojqm2GkOjJwms5jyNHppk6XyXhVndgExfsQGxfKNObEUAFF+xowRMyuq neqg== X-Forwarded-Encrypted: i=1; AJvYcCX+BNl712gOhfqFjwYbtEntMxDTH2BWc6nR8jnPgl85/c8JTCWrT/209jwf5LXa9FS5K5agUNAu0Tz/pAU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywpy9D3eBAnR78WTrF9mt3MA3KWM/687MOL1Xiimu4ZsnjXJylK 4Nfom1EkQR5Y8M/H1ZZ8vz2BR42utWDP7U38x0Nm3MlGFZr5fmCXuY2y X-Gm-Gg: ATEYQzwI8Z2tCmPle3cW9TVfmS5DeZ2tvSwvQgSmgnf7nXpES7C8uprV9T3AQ66Ry7D BDYk1WPeW0XRTSLEXmQMTMitwDJYKEwWrH0ZN5Mdj0bSODYzBOhTcox3R1jp6NMG+J8fJoeVhsV KrFO7zvriz0c5G4QEOCnVDCULjaoRD91DPhFPqsy4JhLi8MzPAfYgscritZQWj4PJaM05OC8y+7 GnPULmJWxHMlGbpL5c/KEFEUVhLd3M0PUnF1N2fNYThdWHRRB4pPWptAEfK4wuPYWN3Yk3ZQtt+ cOn9ydhwa0vRom3LQyIO7jB33LzC9EzpyngmpmrYYrlyT42ffay80fwpMcWCh0F0a6CxVgSK5wz ZSsI4JejeXiRh/uYMgjvp6VUJa5KwCdABv/n90lw3w3c/Hw+nzOA90FiCSGKkvMM8ubTLP0xCIy BsI0NBlGQuSbqxL64r2LQdrA== X-Received: by 2002:a17:90b:1350:b0:35c:b02:b5c1 with SMTP id 98e67ed59e1d1-35dc6e2d00dmr1661679a91.2.1775013229891; Tue, 31 Mar 2026 20:13:49 -0700 (PDT) Received: from lgs.. ([2408:8417:e10:5f85:653:6a84:ffc9:685c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76b986ec97sm1659337a12.30.2026.03.31.20.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 20:13:49 -0700 (PDT) From: Guangshuo Li To: Chris Mason , David Sterba , Jiasheng Jiang , Qu Wenruo , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] btrfs: fix double free in create_space_info() error path Date: Wed, 1 Apr 2026 11:13:39 +0800 Message-ID: <20260401031339.1418417-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When kobject_init_and_add() fails, btrfs_sysfs_add_space_info_type() calls kobject_put(&space_info->kobj). The kobject release callback space_info_release() frees space_info, but the current error path in create_space_info() then calls kfree(space_info) again, causing a double free. Keep the direct kfree(space_info) for the earlier failure path, but after btrfs_sysfs_add_space_info_type() has called kobject_put(), let the kobject release callback handle the cleanup. Fixes: a11224a016d6d ("btrfs: fix memory leaks in create_space_info() error= paths") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- fs/btrfs/space-info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c index 3f08e450f796..d7176eb2fcbf 100644 --- a/fs/btrfs/space-info.c +++ b/fs/btrfs/space-info.c @@ -311,7 +311,7 @@ static int create_space_info(struct btrfs_fs_info *info= , u64 flags) =20 ret =3D btrfs_sysfs_add_space_info_type(space_info); if (ret) - goto out_free; + return ret; =20 list_add(&space_info->list, &info->space_info); if (flags & BTRFS_BLOCK_GROUP_DATA) --=20 2.43.0