From nobody Wed Apr 1 08:41:16 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A190332EBD; Wed, 1 Apr 2026 03:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775012766; cv=none; b=TKe8F5DlteqijMR1foyEDs07SJgvl0p+VUnryDz5CMzdjaVxNrQyPKDP2JzLjZWthZxsAEoj4OHdoew0wIgAInSA/258FDzkP+D716cjdBpJKsYsXPccjOszxC1CUbN41jdWPZ3liqnNDAU9uaTw4fo1sKuuww+AuW5GR0slj70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775012766; c=relaxed/simple; bh=DjiK7EzfZhdc3S+MGj6w+XF+6SaKkrQ8W3X5357r+Vs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RPKRJ1DraWmHxcnheBQnsTL+9BaB+ELxAawDoHVvnr6eXTG4ZWCtQNX3kozTt0LGsLqJnWdJsL3xpIzzsPtZgeyeb5vd/C+cJWVL9mqjhbevoM9PdWVCaGYmgw8F7EuO4urqtUYJtY2ajsfZmN0CuFu2Vnqu6iGl8mWkcV/aXD8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowADndgqTi8xpnfoeDA--.51634S2; Wed, 01 Apr 2026 11:05:56 +0800 (CST) From: Haoxiang Li To: miriam.rachel.korenblit@intel.com, johannes.berg@intel.com Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Haoxiang Li Subject: [PATCH v2] iwlwifi: dvm: add missing cleaup for on error path Date: Wed, 1 Apr 2026 11:05:55 +0800 Message-Id: <20260401030555.541685-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowADndgqTi8xpnfoeDA--.51634S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GFyUZFy3Xw1xWFyUXw47Arb_yoWfKrcEkF 1Iq3Zag34YkrnYvrWDCaya9a4Yyw1qgw4xuFZ7trW3A3y7JrW8XrZ0vrn8A397urW0kas3 Jrn8CF97A3sxXjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Jr0_Gr 1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0 cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8Jw ACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_JF0_ Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUSNtxUUUUU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBgwEE2nMOMnwgQAAs4 Content-Type: text/plain; charset="utf-8" In iwlagn_tx_agg_start(), call iwlagn_dealloc_agg_txq() to clear bit on error path. Signed-off-by: Haoxiang Li --- Changes in v2: - remove an unnecessary error handling. Thanks, Miriam! --- drivers/net/wireless/intel/iwlwifi/dvm/tx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c b/drivers/net/wire= less/intel/iwlwifi/dvm/tx.c index a7806776a51e..1a0167f67c7b 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c @@ -604,8 +604,10 @@ int iwlagn_tx_agg_start(struct iwl_priv *priv, struct = ieee80211_vif *vif, } =20 ret =3D iwl_sta_tx_modify_enable_tid(priv, sta_id, tid); - if (ret) + if (ret) { + iwlagn_dealloc_agg_txq(priv, txq_id); return ret; + } =20 spin_lock_bh(&priv->sta_lock); tid_data =3D &priv->tid_data[sta_id][tid]; --=20 2.25.1