From nobody Wed Apr 1 08:38:25 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C225223B61B for ; Wed, 1 Apr 2026 02:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775011920; cv=none; b=BIjMhvKyPcb3O4FUnP8ZRJvXJVqsIQetLMSwl8FfAgeFT/SUmVBNrbo00rAMoTTJQwfS7Ej2VU0SEFIdQH1R++u5IHgEWbQZbJHnqxpNVDzjcofVtmzVuyjXYHgOJc9e6l7qUbuY2dMRx/Q25HE2kPX3tlBdmmPAuzjIHk9gkLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775011920; c=relaxed/simple; bh=WY3AvRAFc36q+7OWxrfFT7SCSKFS1B6X3GV2ZaPSSvQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jMSt7ObTwyObTOyn4p24kPORgu2/r8T2+2149SD5RH5TcPFMo7P6leErABmxYnWxDomGwcnlvcp7PgSo23vtwTHAa4x/Ws+wxsi7Vbi2p2FCQMlGQn0eOg1WW1raqvz3sl5IUN/K5NYtTvm3YXFVyFqhRGa/n648AkZ6ywRmTgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nriXyjdO; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nriXyjdO" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2aaed195901so27952795ad.0 for ; Tue, 31 Mar 2026 19:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775011913; x=1775616713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uAIzS9E7I8NyNd6SbCw+mU0sPZ4qTkkgpCBayASvU8Y=; b=nriXyjdOyxilMVnvirnMMvCkApwFsFZ+HaKJ1G6FTSxZtzCizBWS0ql/PCmrxspqFc GcV3QfsYAk0Xh9e/0YlQ8aQ5QD1aX9jU66WX/mJTSoE5B4aihmOASVDWM6P1Dy4dhnH4 zJPgdY0v0aL9PZqkxMpogTjXWkcrwa2N8Fru1mUfCeppITYRuHqlcgTehp9B/ECP0zyQ dC3bNXfng/5URt9dVgcszDDQ0MI/Skp4KUZBDLUzztCl+0Jp4f22wdeYpmGiqlIJPYon 6dyg3AlA/sly+Dz8bjruChM0WtDZfVl9d9zrYS0j56TwK+VND9+8RFyPTB5P7Lzq218h +vkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775011913; x=1775616713; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uAIzS9E7I8NyNd6SbCw+mU0sPZ4qTkkgpCBayASvU8Y=; b=rzVj5wbmSyx+K2sYghzEzcZXB0LmG5t6NapoW0wxttvv0PCsaOfVaWWhUVxAnxEOWM 9zylLCTo09vpSnZ2Fxrn0PQ9FLvnFYEAsrjyvaGH/QXicehNM6X7n681/YLu8c75qXqo JiDMpRzspH7ZRAhoYjZ8W1f5AOEWY9wfsMz7aBiMRm0Ibh9Z3OW2FSquDewvBdkvBbum iq+4IJA8IKteZGzkleJPCFBw2L0tipX6S4XY65xV+haae5pDfVbwajrsuBPKSCOtf17L E5GvMGsaIONsikH2jZehzQmTmzB4Sfc/buNen13nYHd1HpsMRN4V+2VOqqtCBN/A0qzF nXLA== X-Forwarded-Encrypted: i=1; AJvYcCUeXr1tobrHoil1FtjBnymGVjhv6KHC5wdHI1muMn5FF0IXdj9wugoVj1PeeIg7dYrVCMa6i0ROSP4S9lE=@vger.kernel.org X-Gm-Message-State: AOJu0YzMJeBbgpLSgFXFVpMLKuEWDphCCrOkRev9k6JVmKtB4rfe47nd rcqqLPh65YCRrq/ngf0ALyzhJfAfXKbsXnAImKbFiKPzq/s7NYCpWMHr X-Gm-Gg: ATEYQzw+9GlMIzQafAtlSUgjIpHCpMqasjQtIt3FLZhNBWkx3WurqFf3jAzgiIBLgDe SQRpBkc6lzezyTdJfnkOwaphmz9ImzIrVhJQjjnxj72xSzZ3bvpGGKKC/oD9rHaA66YOMskP6hS CKzs7fiZdyZASPumaHIEfkDC6IWII/on5dzFP/SWjJE5zrgyRWM/ynwTGW8Yzi8PcwsS3hNqDhr cSCcm8mAQQMxGtyedHt+k54IebzBmmLzNT74bPexAxE0garfy2xNMiroLgbaHCXCJIuut6/Ubrv hiPGWJamcR/y9ZT8ShhSCbIkvfW9la8tH0qTqW34khfw0YdeXE/aaLF9li1RLjqroYPyRU1c8vw x/8/3sLalbS0JvcCDUAjc3hQp1Z/FTUFO7yeMko+bomucb5oNH/gvwkEfNEtQZ7+mXT2ExsgUse 1uLBWGDEnzLmDwbQ== X-Received: by 2002:a17:903:2c04:b0:2b0:5d60:7f3f with SMTP id d9443c01a7336-2b269ab37d4mr14882825ad.16.1775011912933; Tue, 31 Mar 2026 19:51:52 -0700 (PDT) Received: from lgs.. ([101.32.189.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2427660c7sm127730725ad.44.2026.03.31.19.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 19:51:52 -0700 (PDT) From: Guangshuo Li To: Heikki Krogerus , Greg Kroah-Hartman , David Cohen , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] usb: ulpi: fix double free in ulpi_register_interface() error path Date: Wed, 1 Apr 2026 10:51:42 +0800 Message-ID: <20260401025142.1398996-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When device_register() fails, ulpi_register() calls put_device() on ulpi->dev. The device release callback ulpi_dev_release() drops the OF node reference and frees ulpi, but the current error path in ulpi_register_interface() then calls kfree(ulpi) again, causing a double free. Let put_device() handle the cleanup through ulpi_dev_release() and avoid freeing ulpi again in ulpi_register_interface(). Fixes: 289fcff4bcdb1 ("usb: add bus type for USB ULPI") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/usb/common/ulpi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 4a2ee447b213..d895cf6532a2 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -331,10 +331,9 @@ struct ulpi *ulpi_register_interface(struct device *de= v, ulpi->ops =3D ops; =20 ret =3D ulpi_register(dev, ulpi); - if (ret) { - kfree(ulpi); + if (ret) return ERR_PTR(ret); - } + =20 return ulpi; } --=20 2.43.0