From nobody Fri Apr 3 10:18:21 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC71435F5FA for ; Wed, 1 Apr 2026 02:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775011558; cv=none; b=hf9rKX46Oz/oCoLadv1Fzrjd6bJ/wShLlreXJzkqHF9zpP6IRZf51SMxUwSvPL9HKxw1+rD+v6mYKpWLAmT5XNurLsSCSYBF06tt08VBciSIRRXl63sIEakxO+d7gisl9w+Mu0XrUDgai5WrSfMEWpe36j+WJVANGq4D0vav9iE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775011558; c=relaxed/simple; bh=5rqZFu4m0DhI2LCQIRiD6LzWwdcNiXgBJGJBIxfmWzc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MDPbu8tjk9MZR2I0UuADqvXFi4er87bIQ19C37dAhwLj9n5+qbiLdVqH1qM3klCX4YWMbja10CRebNO3/RencS+Esd3wL/8jO56ZYqwMJqUW7vMF18QRqckl1zFGj5SUj0KBCxZfo2hbYnzH9OqgdX8Hj2MjTpZ7VH5cWs5Ilh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NbDlBhbU; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NbDlBhbU" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35da9692ec3so2391198a91.1 for ; Tue, 31 Mar 2026 19:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775011546; x=1775616346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k0AMRHVKUvntR7Icz/Ehum0LT86VVv3YWOGS3oQyg8k=; b=NbDlBhbUmm7ubGPH3omzSFJPvC1KYng04JkvHBvP3dHNAkq7Nuy1IumMShbzu+cJ5C E571R/G6mSuSyy1rPwBDiTP+dGaUJ3NhWV6MjSGqP7z9tUOgi+4Sqk6BvHFUahB8wfrH LH6iW3GdFEzzaDhZneuE+SuWoHBzr0wE6h8cbSd6iDr0XzUNbd/feqdu9B67xgFY/aQ7 PE3x7umuOQHgx1ZfODfuDFGpNdh3Qir9Wx7rR8Kjajzlwh4jkv/k6dC9oYynWYcQBSC0 xBHpSXjzd7LPf/2pN8xDi9K1qSD+IPtt+5pZpzpNgE93kTJD5kE9GXn7mP19W3J1Ewbh ygOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775011546; x=1775616346; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k0AMRHVKUvntR7Icz/Ehum0LT86VVv3YWOGS3oQyg8k=; b=M8iJcfQSvkY5iG2cYQTXBGjIWQJsjkrrec3y6rxh9oJ2gU9JqVo9W/VdNbkr+0q+b+ Tnr8zLX8/4nyBOuuETxp2y6D+uosASGtUtRuVTO7dpX01CQaVehsSe+v5WhJHeI6hXNZ CV6RZK7gkX1EZZoppgk4PrR7jWPPvtvDKDMScOxpfwroatf0uqGpgBzbZf119j5V4cNC I4yptGfEN2Cg7nIbnVRHf6QPW63NkWrwdGHx4JMhKdrYLZ8fb/J9AeWMmCJtJGZ27BGm gEg11aYZ+mD1L9K3IDwPgGZkKN0cJFjtwTNPWyDoSGUJNH79YSRlcZby/9+EklDMT7ti 5XZQ== X-Forwarded-Encrypted: i=1; AJvYcCV5XbQQ7wNn3uoLdgoJC2Lj9T0stMXEBCuWkQRU29xa4RsiAISCvCuuOjhUZ4ix/jOUCZEIXjJSuBHRAJo=@vger.kernel.org X-Gm-Message-State: AOJu0YzwQz90hPSxC4E96KLuE7d+ofml6kmv+jj1cIDKLzXuFkKQNgSF k66n7CN9IWyHvEXv7Pmy4QON2E0eR6aRHnXFhEiGNgxLRPWRg/btfTWq X-Gm-Gg: ATEYQzx14DQTUohqbZhKYINRK7blWtTOmGB6049EkBiIDxKhw0h10JqSw2SogxWGrFB v+iNhthKogiorxdQHngm+Qdn7tPDRfI7hs3z3N7c2zT2wsVy8ZqMMGwrLOz7BcxfT8KlilcJdPf ZEMTzFlXR4YmM223L5UwsUdsyOPr8JMo/M6jeCXMTkb07Xh4vdlKeNJcoKqrqmjOFl7gg7/70P7 b48cfOvw6O52+k28Vt9gXY54SF+Tn54HcZP3Nl8xRp5voNBV4wP7fArpoy4VCT5L56OETjfG4PA H6yQWfDvGEKhhX9heVrPSE2kIHUcmrW3yg0R5ZeCewyR04BuAR/VU0A6ggatcEYpS5r+Ep9rpVh WIawav4IbsKYVwqdr4EqF4qtBkWrVf2qhJ3r5NBItMQz5eIK28AubppKEyPoL5CDJWcK+obvjxR 66f873HkF0Wf8psK0= X-Received: by 2002:a17:90b:3f8f:b0:359:fe72:3559 with SMTP id 98e67ed59e1d1-35dc6f7feacmr1597549a91.21.1775011546230; Tue, 31 Mar 2026 19:45:46 -0700 (PDT) Received: from lgs.. ([199.182.234.55]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dba590d49sm1572450a91.2.2026.03.31.19.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 19:45:45 -0700 (PDT) From: Guangshuo Li To: "Rafael J. Wysocki" , Viresh Kumar , "Tobin C. Harding" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] cpufreq: governor: fix double free in cpufreq_dbs_governor_init() error path Date: Wed, 1 Apr 2026 10:45:35 +0800 Message-ID: <20260401024535.1395801-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When kobject_init_and_add() fails, cpufreq_dbs_governor_init() calls kobject_put(&dbs_data->attr_set.kobj). The kobject release callback cpufreq_dbs_data_release() calls gov->exit(dbs_data) and kfree(dbs_data), but the current error path then calls gov->exit(dbs_data) and kfree(dbs_data) again, causing a double free. Keep the direct kfree(dbs_data) for the gov->init() failure path, but after kobject_init_and_add() has been called, let kobject_put() handle the cleanup through cpufreq_dbs_data_release(). Fixes: 4ebe36c94aed ("cpufreq: Fix kobject memleak") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Acked-by: Viresh Kumar Reviewed-by: Zhongqiu Han --- drivers/cpufreq/cpufreq_governor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_g= overnor.c index 1a7fcaf39cc9..3ad51a986781 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -468,13 +468,13 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *= policy) /* Failure, so roll back. */ pr_err("initialization failed (dbs_data kobject init error %d)\n", ret); =20 - kobject_put(&dbs_data->attr_set.kobj); - policy->governor_data =3D NULL; =20 if (!have_governor_per_policy()) gov->gdbs_data =3D NULL; - gov->exit(dbs_data); + + kobject_put(&dbs_data->attr_set.kobj); + goto free_policy_dbs_info; =20 free_dbs_data: kfree(dbs_data); --=20 2.43.0