From nobody Wed Apr 1 09:43:22 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C015F1F419A for ; Wed, 1 Apr 2026 00:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775004004; cv=none; b=ddUCUwdyCN2m8wC3HMU+Bhl8boFMkex3iX3OjB5RRciEUQ/udeZybTleYn0bampUFajiqTBEhpsOyJ9NmXHhGzUt8QkyL0SFYLjRYtLsnY7CWhnjLg17qgIlOr6A4OzJhxrZAmVQLd++x1snuJXc068As8SotDn2u3YLHoukKYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775004004; c=relaxed/simple; bh=O8J4cCiJQN4pCcpGiVvJPEHETj3ho4rG4I/ncHah1Mg=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=uY5Fp2zxXi7PqQZEYMF28SSwA2uPvyxBWBmBRh2Ls5XaovdiwBUARmHsR2dNVpOJDIQmUP6ZTupHxA1uDfA8MES27gQ8NRCfF647S39tzj2OIAFEl+l3Epl8kEAAHVTv1IDDeDsA/hifThu1gkdMoAz6uDlTNCWrxUZXzMmJffg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cQNzSnE1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cQNzSnE1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63034C2BCB4; Wed, 1 Apr 2026 00:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775004004; bh=O8J4cCiJQN4pCcpGiVvJPEHETj3ho4rG4I/ncHah1Mg=; h=Date:From:To:Cc:Subject:References:From; b=cQNzSnE1GuW/bC5ZEFdT7RWpxSYLIU/iX3k1276nEfUus5ErvJt2MT80iQ6Zu6X+m 6H4MvEMMsoWzEHl4x22wi2MlDAkHTUkvbBRKHiIWHVKfSp45zJph/gly7ljb+BZque ZnVmHLsWlI6B2ajbkhB+ACFcnI5bEL+vcdP5OQk0N2goKOd3cVcVZFld8xL73iahcj WSX61Wg2HOIoakC2iw+mCX34qlfnMOVKSYzqzoUvAN/rL9wL0UiiKCBHy3P7dnFlzX LsFtduXjVJXydfJtVpyWCfYRWKii3f4tljVxXngyU5ZJ3diMr6CpqmvPI81YM9PfL4 yEtTk7OgEpJww== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w7jdn-0000000HGft-39aD; Tue, 31 Mar 2026 20:41:03 -0400 Message-ID: <20260401004103.620199187@kernel.org> User-Agent: quilt/0.69 Date: Tue, 31 Mar 2026 20:40:50 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , kernel test robot Subject: [for-next][PATCH 3/3] tracing: Remove duplicate latency_fsnotify() stub References: <20260401004047.963302108@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the SNAPSHOT is defined but FSNOTIFY is not the latency_fsnotify() function is turned into a static inline stub. But this stub was defined in both trace.h and trace_snapshot.c causing a error in build when CONFIG_SNAPSHOT is defined but FSNOTIFY is not. The stub is not needed in trace_snapshot.c as it will be defined in trace.h, remove it from the C file. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260330205859.24c0aae3@gandalf.local.home Fixes: bade44fe5462 ("tracing: Move snapshot code out of trace.c and into t= race_snapshot.c") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603310604.lGE9LDBK-lkp@int= el.com/ Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.h | 2 +- kernel/trace/trace_snapshot.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 0904fd356634..90d67f4432f5 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -845,13 +845,13 @@ void update_max_tr_single(struct trace_array *tr, #if defined(CONFIG_TRACER_MAX_TRACE) && defined(CONFIG_FSNOTIFY) # define LATENCY_FS_NOTIFY #endif +#endif /* CONFIG_TRACER_SNAPSHOT */ =20 #ifdef LATENCY_FS_NOTIFY void latency_fsnotify(struct trace_array *tr); #else static inline void latency_fsnotify(struct trace_array *tr) { } #endif -#endif /* CONFIG_TRACER_SNAPSHOT */ =20 #ifdef CONFIG_STACKTRACE void __trace_stack(struct trace_array *tr, unsigned int trace_ctx, int ski= p); diff --git a/kernel/trace/trace_snapshot.c b/kernel/trace/trace_snapshot.c index 8865b2ef2264..07b43c9863a2 100644 --- a/kernel/trace/trace_snapshot.c +++ b/kernel/trace/trace_snapshot.c @@ -391,9 +391,8 @@ void latency_fsnotify(struct trace_array *tr) */ irq_work_queue(&tr->fsnotify_irqwork); } -#else -static inline void latency_fsnotify(struct trace_array *tr) { } #endif /* LATENCY_FS_NOTIFY */ + static const struct file_operations tracing_max_lat_fops; =20 void trace_create_maxlat_file(struct trace_array *tr, --=20 2.51.0