From nobody Wed Apr 1 22:15:19 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE62466B6A for ; Wed, 1 Apr 2026 14:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053587; cv=none; b=mxiIAKZVjf6lr0t3ldw37qjbrdqTXODW0Daz9gvtDmKasprWKcocgCGoYb2kzZg/nEDduKMJSVL6ymjviRO+SXiL5VuTDTwt0yBu+esyvPdMRhMrC1EqnaMSX72QyEqZX7fZZJiSpJ+gcaN4Y4fuTR2DLeKV0tzUEqr4nqi1TAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053587; c=relaxed/simple; bh=Eooq+5bKb0xsDs+PjIdIUDN4p8LZJFeXS5YmCx+E18M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NQqGL2otYNxnN3TZsoIazU0NJutOcclyj5Rt15BJbYIv9i8StHAQ+lN9LZFZFBP3bZJCSB+hrZfx1eQE52y/suGqqE4ImxHSlOAhedrMZSPyf2HsAhjKLyJH3isq0LfDRjpIF9UykySkkouRUXXn/nTufL0t1tPqHAzVEz7O4II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Gu+bk6Jr; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gu+bk6Jr" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-486b9675d36so57263655e9.0 for ; Wed, 01 Apr 2026 07:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775053584; x=1775658384; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=osWrxEAqmZXiuVvpI8iKF9LeT8juwh9RdnQ1+Y4xO5c=; b=Gu+bk6JrQsscwepLcFfJpxRJaoSPVaCz1YJwlpYeQbMxTAHxJA+jBAm9Icjeg8Y6N5 AAH+QdP60mE1SCB+cvZ7tL16TSDBl5CrieRxz8CcwTKAqO+12hRsc9oGlH2AhfsbMJ3f +t9PhkKUjzxYYpntIMI7zdPXEEhL2cw3cxcD13hVvRY4dm6ZWn/b0TlxxVaTgMpqOkxD GSzD1g96ySPWp9/f3aI28IL4/Fos0GUQgnleI3xxISGMmN3DVavyScE/wU+MBCjh98D3 2GqeMj29FEogZpCCqKpwAAu+9AwDGNdGnyogdWDHW9Gkw01d8AJgk77IQNFwfTiW+ylQ PQAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775053584; x=1775658384; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=osWrxEAqmZXiuVvpI8iKF9LeT8juwh9RdnQ1+Y4xO5c=; b=sDUdlBMLh3kZrT6qaPmhiqeT1lzlLrcXiqsnW5bk7kmPrjZBp5bIpbis8yF7DKvqct SNdZwOHpnWwXF5uLFwvpL+3CatHYl1X5cyw6HcOPCy0YmhwDEklrDSiZOdIjF5KWXubd 4lhMTWx1VaUHOzh1s/rIXKo7RyqKhH9iBHkdrny7BtHEdmHmNs9gHo2AYP3zUY73ZNV/ oSw1rJ3CpPXpWpC+KgQJFP3fs+sTqjwTdrQSaWk4/VKLIxsa+tk6Enq9Oq/Td946sGS1 otNFWlxuKMRenUeKxIQjdckxfwpNkKnvtL1i3t3g/xx2b9T8xd5HhtfuVwuOUxfGSszg FTwA== X-Forwarded-Encrypted: i=1; AJvYcCWFoIh7XYmJIzeJ0U6TKirOUBxePkdtHaM9T2tfqG0z2gU6nDdQayWz+/6cB2c3t9e1B/mUwxhMncVVKAs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw63W5gg9yO9Sxso/GWSKf5CwEZi0JX7IZodIXbhgViAPIv3HC1 YYKunj/Tmj1Suwt3GY+2/fJZ9tUD+BFjBDRlGakqlwaTiuYfNWxdG8AzbKhc/IpMPPk= X-Gm-Gg: ATEYQzyR39jNGuUBoYHFKWiUDrpt9By4Lz8DtbLvZXSRnpV9DE/n8rnkstADn/MnIEB VYx6oi6bhyMRJMTQCR33Ob9o2uoES2E9kZ5ii6sUvxuPRE5Ru49Nuw15wMZ6d6QfUHOsoLfb3hS Xtsuok7D3eFKN6Am/cRcGoxbqA1dkCAiY1xJ7nQkCGmhFhdavhIY+dScsSULWU6yoXlAYIe8g0X sd28VAu7trw4ETpEiS90QdbIRvL71y5CNI/GDsDTL6Uq3B42yx3oKld6T3n+FZAkPfAn+6+NU5u aqyuHse2J89VHFV3diyIF3CFdcZS4Ch8BnZAUxs0DeqeVwVDY8r5ee+GxY5qXYImZAJbrWaichs Cf2BwfsgT+RYbrX0S0LayxgMS5ZeHM81myTYw7ZPRUQbdsrq7k9b5pC8oJ4RYkwQut+7b2WGJwS lr/xvEOvAbIvOsAQx7Gg4m5Pccw89RcBdY X-Received: by 2002:a05:600c:4508:b0:485:3949:e5c6 with SMTP id 5b1f17b1804b1-4888355ec76mr66836565e9.3.1775053584032; Wed, 01 Apr 2026 07:26:24 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4888a63c9b1sm2305595e9.5.2026.04.01.07.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 07:26:23 -0700 (PDT) From: James Clark Date: Wed, 01 Apr 2026 15:25:51 +0100 Subject: [PATCH 3/4] perf arm_spe: Decode Arm N1 IMPDEF events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260401-james-spe-impdef-decode-v1-3-ad0d372c220c@linaro.org> References: <20260401-james-spe-impdef-decode-v1-0-ad0d372c220c@linaro.org> In-Reply-To: <20260401-james-spe-impdef-decode-v1-0-ad0d372c220c@linaro.org> To: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Al Grant Cc: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 From the TRM [1], N1 has one IMPDEF event which isn't covered by the common list. Add a framework so that more cores can be added in the future and that the N1 IMPDEF event can be decoded. Also increase the size of the buffer because we're adding more strings and if it gets truncated it falls back to a hex dump only. [1]: https://developer.arm.com/documentation/100616/0401/Statistical-Profil= ing-Extension/implementation-defined-features-of-SPE Suggested-by: Al Grant Signed-off-by: James Clark --- tools/perf/util/arm-spe-decoder/Build | 2 + .../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 45 ++++++++++++++++++= ++-- .../util/arm-spe-decoder/arm-spe-pkt-decoder.h | 5 ++- tools/perf/util/arm-spe.c | 13 ++++--- 4 files changed, 54 insertions(+), 11 deletions(-) diff --git a/tools/perf/util/arm-spe-decoder/Build b/tools/perf/util/arm-sp= e-decoder/Build index ab500e0efe24..97a298d1e279 100644 --- a/tools/perf/util/arm-spe-decoder/Build +++ b/tools/perf/util/arm-spe-decoder/Build @@ -1 +1,3 @@ perf-util-y +=3D arm-spe-pkt-decoder.o arm-spe-decoder.o + +CFLAGS_arm-spe-pkt-decoder.o +=3D -I$(srctree)/tools/arch/arm64/include/ -= I$(OUTPUT)arch/arm64/include/generated/ diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/= perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c index c880b0dec3a1..42a7501d4dfe 100644 --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c @@ -15,6 +15,8 @@ =20 #include "arm-spe-pkt-decoder.h" =20 +#include "../../arm64/include/asm/cputype.h" + static const char * const arm_spe_packet_name[] =3D { [ARM_SPE_PAD] =3D "PAD", [ARM_SPE_END] =3D "END", @@ -307,6 +309,11 @@ static const struct ev_string common_ev_strings[] =3D { { .event =3D 0, .desc =3D NULL }, }; =20 +static const struct ev_string n1_event_strings[] =3D { + { .event =3D 12, .desc =3D "LATE-PREFETCH" }, + { .event =3D 0, .desc =3D NULL }, +}; + static u64 print_event_list(int *err, char **buf, size_t *buf_len, const struct ev_string *ev_strings, u64 payload) { @@ -318,14 +325,44 @@ static u64 print_event_list(int *err, char **buf, siz= e_t *buf_len, return payload; } =20 +struct event_print_handle { + const struct midr_range *midr_ranges; + const struct ev_string *ev_strings; +}; + +#define EV_PRINT(range, strings) \ + { \ + .midr_ranges =3D range, \ + .ev_strings =3D strings, \ + } + +static const struct midr_range n1_event_encoding_cpus[] =3D { + MIDR_ALL_VERSIONS(MIDR_NEOVERSE_N1), + {}, +}; + +static const struct event_print_handle event_print_handles[] =3D { + EV_PRINT(n1_event_encoding_cpus, n1_event_strings), +}; + static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet, - char *buf, size_t buf_len) + char *buf, size_t buf_len, u64 midr) { u64 payload =3D packet->payload; int err =3D 0; =20 arm_spe_pkt_out_string(&err, &buf, &buf_len, "EV"); - print_event_list(&err, &buf, &buf_len, common_ev_strings, payload); + payload =3D print_event_list(&err, &buf, &buf_len, common_ev_strings, + payload); + + /* Try to decode IMPDEF bits for known CPUs */ + for (unsigned int i =3D 0; i < ARRAY_SIZE(event_print_handles); i++) { + if (is_midr_in_range_list(midr, + event_print_handles[i].midr_ranges)) + payload =3D print_event_list(&err, &buf, &buf_len, + event_print_handles[i].ev_strings, + payload); + } =20 return err; } @@ -506,7 +543,7 @@ static int arm_spe_pkt_desc_counter(const struct arm_sp= e_pkt *packet, } =20 int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, - size_t buf_len) + size_t buf_len, u64 midr) { int idx =3D packet->index; unsigned long long payload =3D packet->payload; @@ -522,7 +559,7 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, = char *buf, arm_spe_pkt_out_string(&err, &buf, &blen, "%s", name); break; case ARM_SPE_EVENTS: - err =3D arm_spe_pkt_desc_event(packet, buf, buf_len); + err =3D arm_spe_pkt_desc_event(packet, buf, buf_len, midr); break; case ARM_SPE_OP_TYPE: err =3D arm_spe_pkt_desc_op_type(packet, buf, buf_len); diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h b/tools/= perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h index adf4cde320aa..17b067fe3c87 100644 --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h @@ -11,7 +11,7 @@ #include #include =20 -#define ARM_SPE_PKT_DESC_MAX 256 +#define ARM_SPE_PKT_DESC_MAX 512 =20 #define ARM_SPE_NEED_MORE_BYTES -1 #define ARM_SPE_BAD_PACKET -2 @@ -186,5 +186,6 @@ const char *arm_spe_pkt_name(enum arm_spe_pkt_type); int arm_spe_get_packet(const unsigned char *buf, size_t len, struct arm_spe_pkt *packet); =20 -int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, size_t l= en); +int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, size_t l= en, + u64 midr); #endif diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index 7447b000f9cd..46f0309c092b 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -135,7 +135,7 @@ struct data_source_handle { } =20 static void arm_spe_dump(struct arm_spe *spe __maybe_unused, - unsigned char *buf, size_t len) + unsigned char *buf, size_t len, u64 midr) { struct arm_spe_pkt packet; size_t pos =3D 0; @@ -161,7 +161,7 @@ static void arm_spe_dump(struct arm_spe *spe __maybe_un= used, color_fprintf(stdout, color, " "); if (ret > 0) { ret =3D arm_spe_pkt_desc(&packet, desc, - ARM_SPE_PKT_DESC_MAX); + ARM_SPE_PKT_DESC_MAX, midr); if (!ret) color_fprintf(stdout, color, " %s\n", desc); } else { @@ -174,10 +174,10 @@ static void arm_spe_dump(struct arm_spe *spe __maybe_= unused, } =20 static void arm_spe_dump_event(struct arm_spe *spe, unsigned char *buf, - size_t len) + size_t len, u64 midr) { printf(".\n"); - arm_spe_dump(spe, buf, len); + arm_spe_dump(spe, buf, len, midr); } =20 static int arm_spe_get_trace(struct arm_spe_buffer *b, void *data) @@ -1469,8 +1469,11 @@ static int arm_spe_process_auxtrace_event(struct per= f_session *session, /* Dump here now we have copied a piped trace out of the pipe */ if (dump_trace) { if (auxtrace_buffer__get_data(buffer, fd)) { + u64 midr =3D 0; + + arm_spe__get_midr(spe, buffer->cpu.cpu, &midr); arm_spe_dump_event(spe, buffer->data, - buffer->size); + buffer->size, midr); auxtrace_buffer__put_data(buffer); } } --=20 2.34.1