From nobody Thu Apr 2 00:15:08 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 937713DF002 for ; Wed, 1 Apr 2026 09:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775036510; cv=none; b=SD0E9GrppNgRuwqb9rIAqCO5o1DjhlBSafpyKmXlVTne0UFsPl6Bq4RIwY+3rOcEokoyz7q6b9oF6+JJ2LTD7dSpTwiF/grYweBbaPwjI2EPYbVCkNFtNzsDqc1cwoeEFbkz2mQziOkYRxARtIt0jVrQ1Wd+RhC3j7GYMBA/cfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775036510; c=relaxed/simple; bh=8e1wrGwtOt6jYX3+6GLgmMDaN6TklWOqHQL7+SqwExQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SCRXxZUY4193NJ4XnXxFnnzmDJ4EizsFFAdiw6K/epUytK+W6YA65s0Mq3ZvGaY9t0IoOzv88SfeJP5mWa+5AzaE18oYETnKngY1BUGjIxVO4zNs0b3yvVgo8YP3RGiuqkYCZfhsqKbt5v1GFrp2qcrjJPCOqP2p5H9u/eGGaG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aJcLUXKl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UP6Jf5Iy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aJcLUXKl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UP6Jf5Iy" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317gGJ61578248 for ; Wed, 1 Apr 2026 09:41:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3PqUADJMJJoP0wu59C9aNUAlbK4WpxvtmmPet8NmdNA=; b=aJcLUXKlwLsN0HZE pX+wH8xspIs9wmQlSUgay25eMrhg3ZTkBXVEpWvAW9tLifey0Rgm+WkJj26Osuri epoYli5Xdxf1hfju/m6+ekiLDOYMdZkIYd8ky7pClXLpYqy7tqVWx/QAED8zNhXN qaxtGAwchogJx0uhpqXYVAFd+oP7vIGZ0VyOUy0xugQd7ONaICRHh9un7pX86EMf oxNcm1KTIwIoJuqJfecNwBIM/62Gxl01G8ulHnnLLJ/O7zchanC0pu4qb17AzMpt WKs4JNoOUKmvG/TPvrr/yTsnZRsVBCbhc5AvHZPYShnmM7li3iVmUgPf9dIJI5u4 fbjhhg== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8k6kud8d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 09:41:47 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-12711ec96fbso13508352c88.0 for ; Wed, 01 Apr 2026 02:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775036506; x=1775641306; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3PqUADJMJJoP0wu59C9aNUAlbK4WpxvtmmPet8NmdNA=; b=UP6Jf5Iyk52wr1/QXNN5qfYpclS8dUFqi2Q32ElRyQqAhdlX3reBPM8DZq7IQZUyMi OPqBVP3CptOcxRS2kRV8FQUkfc4WX2FWddWmQGwrzoDY1v0hXTEqYj/FSs7/RDf3WsRR GnL8c21Vsvio26MENiclt6RHd3zr6fZ8RbC9YioWnbymm5g0DmfTX7MhOkZfZX1QM9Vc uLjV232dVo8gLOxA3xPYdltjuAoD8DQKVnCcRCep6/mw+00JxK6MQvpvZvCGbqDSxFao qmkpcD0G9lqGbdqeiQBBKbpoMxMuPPN8oBKw9xR8U0+GCj8yUQJgba2Nxp3/l0rQ+Ggm 9lTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775036506; x=1775641306; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3PqUADJMJJoP0wu59C9aNUAlbK4WpxvtmmPet8NmdNA=; b=bG1rNjY+cpKmI9mIrkh8kLNMr1fZ5AVGvgKFn70KfsZAL7foecDFOv+8GqvDxuly19 bpPtEcy/GIDcpqIFyEONedW4OePvr2L3BbEx7K5LgHLpkEubApAefcRGUhBtwPzdKqtw sPTcHQBEtxKkpFLL06ca8eq/HP3n/JHblXk6DOyNh9IcK7ruYk1u8vM53ch8EneWpXfK NUAXcGxcZig7pV+XMl4QF5xvrZqHf3mtJL3hzRtYSewqMaKxzogInxaKvv62clPAZ4bL +MX+nli6HZQTm03NpdcaAQmK+kzT7c7++HCuDZ6mH4wR5mtmpJXT/xx6IsQO/zBSXMKj oevg== X-Forwarded-Encrypted: i=1; AJvYcCWfwk7OOROgHK7tZy72DrdoCIPAeCW1SMtrQjCZjildT1wYIcSdstRdbAxAaDsfZXxG42gAsbouvyT143A=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8TDLD7X75JzB3kPSW/d94mL2i4iYQ46gNbQL0ZfkHS7v5OpVp IoPuh7vpLyXM3hN79F/222uAmCd9ADLQ6fv1w5xsoyT7IecHSDfseDR6OOJgd2djE1rM8vETx1K tXMA7Sa6gBdc+hNvM4GZLoEHRoVEiXFGiKL17zdL2tyt9ZwuIoaq+fBkb6oDq1cmppTM= X-Gm-Gg: ATEYQzymYQEN80Sm2whzu0cfdQJeP/0/MmBe5DBXIXAZ5NYaRjdk9Cgychwh0PcKJ1p +rwkBw4yvK/PKtCpHnhaXJ7vrMc3H70ddjhU6dd00C5XiX1qgkziM2oNGVGD1UiOjcG/tN+gwhE iXS5zcPJP/Wkhdur+bQaVciTYrqRk937ghE0hw0wLG5Mvpx51K6vQNP/Vf1X4XiIHLqey7e2dS+ bHFZ+pzUmhpRfW5v51W1RhSt35cr5J5NPTPti3IEmMvwDHrJH6A8mDftA+Vvy4eXtNtXSsl6doE jIu0i7KgsZUXTSmTAU3RHFldKDItoFpi4Q6NLkTENo3DK0eQNGXJt2dub5hlkElYqiaW7CdlkAh DxN/1RwT9CV9ZDG6MBVavv61UcDQMXnLV/14Wl0yex4nMoib+rlYyPNwBBJP7SzoFSaFHtCgJ0A == X-Received: by 2002:a05:7022:ea26:b0:11a:e426:911a with SMTP id a92af1059eb24-12be643816cmr2043499c88.15.1775036506487; Wed, 01 Apr 2026 02:41:46 -0700 (PDT) X-Received: by 2002:a05:7022:ea26:b0:11a:e426:911a with SMTP id a92af1059eb24-12be643816cmr2043475c88.15.1775036505863; Wed, 01 Apr 2026 02:41:45 -0700 (PDT) Received: from hu-fenglinw-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab983f9f3sm18982647c88.10.2026.04.01.02.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 02:41:45 -0700 (PDT) From: Fenglin Wu Date: Wed, 01 Apr 2026 02:41:24 -0700 Subject: [PATCH 2/2] spmi: spmi-pmic-arb: add support for PMIC arbiter v8.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260401-hawi-spmi-v1-2-c40963041078@oss.qualcomm.com> References: <20260401-hawi-spmi-v1-0-c40963041078@oss.qualcomm.com> In-Reply-To: <20260401-hawi-spmi-v1-0-c40963041078@oss.qualcomm.com> To: Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@oss.qualcomm.com, Fenglin Wu X-Mailer: b4 0.16-dev-17187 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775036501; l=4497; i=fenglin.wu@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=8e1wrGwtOt6jYX3+6GLgmMDaN6TklWOqHQL7+SqwExQ=; b=1S0erltnTVdBmiiXN1oRavSHh/OWi0nN1ROWxzEQU+EG0gukJXRmGAxiNvRiZbuk8n3Df3Vlc xkHOOk+yzm8BFM5XWSftFdT14eg4FqJNEn8Hia+J4U0+1nm/eOoYfAB X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=hJdt3E7o54lql+miD2GaxwF74cDyhgNwMbmFOZ46bRU= X-Authority-Analysis: v=2.4 cv=bfJmkePB c=1 sm=1 tr=0 ts=69cce85b cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=qQkTAZUf_KvMCO389TYA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA4NyBTYWx0ZWRfX/TruEmDAQR6o MfYpka+ubWIZkKQyC5/TUks4z301b5j1rgZ0eKcvtO/4avMqhE6ZIoYeok9AUuG1rkR5WWUKcyO Tj+HFa24bocBuGweS8THC3WgkFCH31vEqYeR2obUPKQ2C2z4nkNpEy+GNQfUtUVhmyHVqkXfLH9 cbU0gnWl9vCf78GrTN/K7jWDuiDr8gYV9+JDumZoADbMMUIpPS/ym+XLprAvrGz2jLqHr+TPIzI IIYU7yGzPmLWHxe5k951/b8S4XPGIcxKPuI46Jr0HsvvAJ3dCt/eiXMMdHH60dLFUX/LWh8YR4q on3NVrqZVtSHTWL4PAXkIfuYOVJLCup/jH4YzWBLOljXr4MFAyKlpxxvrT/B44wcxC7E9NbI6Ha Q78g56bMufGag+sFhbIHOMzgQvzLMeftijdfVYQHz/wH/3CrEVKAAPzlyQWqgJNzdv4uuYyoR8Z 5QgL/l9Mkcq0oAtXfEA== X-Proofpoint-GUID: 6iGcrYOTzam8pRlGP0zOBm93s9GCmuzB X-Proofpoint-ORIG-GUID: 6iGcrYOTzam8pRlGP0zOBm93s9GCmuzB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010087 PMIC arbiter v8.5 is an extension of PMIC arbiter v8 that updated the definition of the channel status register bit fields. Add support to handle this difference. Signed-off-by: Fenglin Wu Reviewed-by: Konrad Dybcio --- drivers/spmi/spmi-pmic-arb.c | 69 ++++++++++++++++++++++++++++++++++++++--= ---- 1 file changed, 60 insertions(+), 9 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 69f8d456324a..deeaa39bb647 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -28,6 +28,7 @@ #define PMIC_ARB_VERSION_V5_MIN 0x50000000 #define PMIC_ARB_VERSION_V7_MIN 0x70000000 #define PMIC_ARB_VERSION_V8_MIN 0x80000000 +#define PMIC_ARB_VERSION_V8P5_MIN 0x80050000 #define PMIC_ARB_INT_EN 0x0004 =20 #define PMIC_ARB_FEATURES 0x0004 @@ -63,11 +64,34 @@ #define SPMI_OWNERSHIP_PERIPH2OWNER(X) ((X) & 0x7) =20 /* Channel Status fields */ -enum pmic_arb_chnl_status { - PMIC_ARB_STATUS_DONE =3D BIT(0), - PMIC_ARB_STATUS_FAILURE =3D BIT(1), - PMIC_ARB_STATUS_DENIED =3D BIT(2), - PMIC_ARB_STATUS_DROPPED =3D BIT(3), +struct pmic_arb_chnl_status_mask { + u8 done; + u8 failure; + u8 crc; + u8 parity; + u8 nack; + u8 denied; + u8 dropped; +}; + +static const struct pmic_arb_chnl_status_mask chnl_status_mask =3D { + .done =3D BIT(0), + .failure =3D BIT(1), + .crc =3D 0, + .parity =3D 0, + .nack =3D 0, + .denied =3D BIT(2), + .dropped =3D BIT(3), +}; + +static const struct pmic_arb_chnl_status_mask chnl_status_mask_v8p5 =3D { + .done =3D BIT(0), + .failure =3D BIT(1), + .crc =3D BIT(2), + .parity =3D BIT(3), + .nack =3D BIT(4), + .denied =3D BIT(5), + .dropped =3D BIT(6), }; =20 /* Command register fields */ @@ -201,6 +225,7 @@ struct spmi_pmic_arb_bus { * @max_periphs: Number of elements in apid_data[] * @buses: per arbiter buses instances * @buses_available: number of buses registered + * @chnl_status_mask: Bit masks of channel status fields */ struct spmi_pmic_arb { void __iomem *rd_base; @@ -214,6 +239,7 @@ struct spmi_pmic_arb { int max_periphs; struct spmi_pmic_arb_bus *buses[PMIC_ARB_MAX_BUSES]; int buses_available; + const struct pmic_arb_chnl_status_mask *chnl_status_mask; }; =20 /** @@ -312,6 +338,7 @@ static int pmic_arb_wait_for_done(struct spmi_controlle= r *ctrl, { struct spmi_pmic_arb_bus *bus =3D spmi_controller_get_drvdata(ctrl); struct spmi_pmic_arb *pmic_arb =3D bus->pmic_arb; + const struct pmic_arb_chnl_status_mask *mask; u32 status =3D 0; u32 timeout =3D PMIC_ARB_TIMEOUT_US; u32 offset; @@ -323,30 +350,49 @@ static int pmic_arb_wait_for_done(struct spmi_control= ler *ctrl, =20 offset =3D rc; offset +=3D PMIC_ARB_STATUS; + mask =3D pmic_arb->chnl_status_mask; =20 while (timeout--) { status =3D readl_relaxed(base + offset); =20 - if (status & PMIC_ARB_STATUS_DONE) { - if (status & PMIC_ARB_STATUS_DENIED) { + if (status & mask->done) { + if (status & mask->denied) { dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n", __func__, sid, addr, status); return -EPERM; } =20 - if (status & PMIC_ARB_STATUS_FAILURE) { + if (status & mask->failure) { dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x) reg: 0x%x\n= ", __func__, sid, addr, status, offset); WARN_ON(1); return -EIO; } =20 - if (status & PMIC_ARB_STATUS_DROPPED) { + if (status & mask->dropped) { dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n", __func__, sid, addr, status); return -EIO; } =20 + if (status & mask->crc) { + dev_err(&ctrl->dev, "%s: %#x %#x: CRC error (%#x)\n", + __func__, sid, addr, status); + return -EIO; + } + + if (status & mask->parity) { + dev_err(&ctrl->dev, "%s: %#x %#x: parity error (%#x)\n", + __func__, sid, addr, status); + return -EIO; + } + + if (status & mask->nack) { + dev_err(&ctrl->dev, "%s: %#x %#x: NACK error (%#x)\n", + __func__, sid, addr, status); + return -EIO; + } + return 0; } udelay(1); @@ -2033,6 +2079,11 @@ static int spmi_pmic_arb_probe(struct platform_devic= e *pdev) else pmic_arb->ver_ops =3D &pmic_arb_v8; =20 + if (hw_ver < PMIC_ARB_VERSION_V8P5_MIN) + pmic_arb->chnl_status_mask =3D &chnl_status_mask; + else + pmic_arb->chnl_status_mask =3D &chnl_status_mask_v8p5; + err =3D pmic_arb->ver_ops->get_core_resources(pdev, core); if (err) return err; --=20 2.43.0