From nobody Thu Apr 2 00:12:56 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E170E3E717A; Wed, 1 Apr 2026 10:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775038864; cv=none; b=Pk2R9wfyXlJa3VAYpdruUXeMBLAYRZRtWm8yNjAufHIaVGvux2jW/vYKOd1Rw00/OzHp9ahddz9NovsHs+AaesZqU0GNVx3VjpUe7s9hBGMjJ5GalZzx7sv1dzf6V1Ab7qBaMwYrEFuooMBPnwlGJb9cHZU7UlnbxxnFLGOkEVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775038864; c=relaxed/simple; bh=72n4ASX5eaNmVdZ+CEHm9wE4m78J2lQVzaizY8QTxgo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=PPrnfk37YoBS3ZES5Ww9OuiwkNLeMyLcGqMJdIqqRjvWgS9t3wzdgCdK6e6WHLg5zgWtcyQ4zTRc3yxh9VO2JRHUqLAhq0jEk8ohPyoLG5Aoij/sk4yLwYm2PdNBbZa8Cd5pTPs816x4ks8AuCcuhzkBrfoLIJJXHOB9HD5Z5eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=HjV1yiRm; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="HjV1yiRm" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6319RRvn1912339; Wed, 1 Apr 2026 06:20:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=9CJVU CkLREFQw2a8F4MKZP5S4rvjLtnmEiE6wsbBNic=; b=HjV1yiRmLiRgkVgwxlXWt 0kM50Cg3M0JO6fTtDsprMoR7dHrjWRqZmVn6mN/o5xqGFhT2Vwzl7ou/VNau62VH rLotry7Zac8XZiCcRQN8K8mENpCP403wwWcyaArEvaBbjNyna/Qv+rNRfXjpjms3 6ISyQ4usH6A9rizkG+kBHqpem7NydGlyX5O4vhuGKXQXhRw/VrVrWICY1dpTCG2U /cBTsZtgk0ZcxIBTeALujEqh2o+b2FuyjzFDLV5nxhtSeWUf/MdOk9u5HyAZbH5u kVJzCT2ej2BNL6q31VBYIYAscOhBESaE2zcjJ3N0Oa6GW6TnLdMC6bmLVGUJ+2Bl Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4d90re867v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Apr 2026 06:20:39 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 631AKc4k058796 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 1 Apr 2026 06:20:38 -0400 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 1 Apr 2026 06:20:37 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 1 Apr 2026 06:20:37 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 1 Apr 2026 06:20:37 -0400 Received: from ATORRENO-L02.ad.analog.com ([10.66.6.190]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 631AKFre007322; Wed, 1 Apr 2026 06:20:30 -0400 From: Alexis Czezar Torreno Date: Wed, 1 Apr 2026 18:20:04 +0800 Subject: [PATCH v4 2/2] iio: dac: ad5706r: Add support for AD5706R DAC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260401-dev_ad5706r-v4-2-a785184a8d53@analog.com> References: <20260401-dev_ad5706r-v4-0-a785184a8d53@analog.com> In-Reply-To: <20260401-dev_ad5706r-v4-0-a785184a8d53@analog.com> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , , Alexis Czezar Torreno X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775038815; l=9466; i=alexisczezar.torreno@analog.com; s=20250213; h=from:subject:message-id; bh=72n4ASX5eaNmVdZ+CEHm9wE4m78J2lQVzaizY8QTxgo=; b=md1XQ7FfxZzG8to+04KziLBKh1wVpryo36VXGSLz1FhQN4bIwqOXS9jBPPrr+fhfsLdpAlKRo LznZGpBA1FUAyPW10n9NGuDFtL79VKwtM05O0CoNjMsu69MOTQsH6VC X-Developer-Key: i=alexisczezar.torreno@analog.com; a=ed25519; pk=XpXmJnRjnsKdDil6YpOlj9+44S+XYXVFnxvkbmaZ+10= X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=VqQuwu2n c=1 sm=1 tr=0 ts=69ccf177 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=VwQbUJbxAAAA:8 a=DeXsowbpyCK6ASS6rOAA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA5NCBTYWx0ZWRfXzAtFVq25QGww 3wM6HicdjWz3hEBA5dYNlFoCHhjmPEuuhd0uQdcEGFUZ7vGPnvTSoS38v340O1+VdOD+yJk0cLF x8mNRo/4Vtmi3nNqsVqSsAI5LEUnSSlKR9Rh2QtjaNoD3MCUf/EdYVLKAh0CPStm3XLVtd5DK0n ahgcS759XpFSG2MkT83yXBPcS5bGE/hUM6JP6fLif7KBhFUZ5x6sffAygAADKikGfCoCHhSPqOO 1jBvmuXw9uNo51eTB/DY734DH/us2W4xSkycHdiuOT6+uNNHrAqshWMaQOmvL6UJnAIRAtzUNZp gK0eGF03eyXA2+6qrLWwu7khbfzvTXlWWv04EogwYbc02CF70BvEGS/Rrj7ldwKwTWk6q4xJzTW NQJzKvsGkik3YwiQ8WxlcLY8HSO5SHBs+UD+xxVgHGhOGvVQf6TjCkX/2cyb1dOm7gsBVMDUkJf tdAkP1XldGctMRmul9w== X-Proofpoint-GUID: mjAnynj4BY_UuC05eQ0IWjOGKHkgOKB1 X-Proofpoint-ORIG-GUID: mjAnynj4BY_UuC05eQ0IWjOGKHkgOKB1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010094 Add support for the Analog Devices AD5706R, a 4-channel 16-bit current output digital-to-analog converter with SPI interface. Features: - 4 independent DAC channels - Hardware and software LDAC trigger - Configurable output range - PWM-based LDAC control - Dither and toggle modes - Dynamically configurable SPI speed Signed-off-by: Alexis Czezar Torreno --- Changes since v1: - Removed PWM, GPIO, clock generator, debugfs, regmap, IIO_BUFFER - Removed all custom ext_info sysfs attributes - Simplified to basic raw read/write and read-only scale - SPI read/write can handle multibyte registers --- --- MAINTAINERS | 1 + drivers/iio/dac/Kconfig | 10 ++ drivers/iio/dac/Makefile | 1 + drivers/iio/dac/ad5706r.c | 244 ++++++++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 256 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 17a3d2d45fccb9cd3c93fd35666fb85d17d53cde..3d7bd98b4d1b55836e40687a9a3= ac9f4935a8acb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1502,6 +1502,7 @@ L: linux-iio@vger.kernel.org S: Supported W: https://ez.analog.com/linux-software-drivers F: Documentation/devicetree/bindings/iio/dac/adi,ad5706r.yaml +F: drivers/iio/dac/ad5706r.c =20 ANALOG DEVICES INC AD7091R DRIVER M: Marcelo Schmitt diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index db9f5c711b3df90641f017652fbbef594cc1627d..8ccbdf6dfbca8640a47bf05b4af= c6b4bf90a7e26 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -178,6 +178,16 @@ config AD5624R_SPI Say yes here to build support for Analog Devices AD5624R, AD5644R and AD5664R converters (DAC). This driver uses the common SPI interface. =20 +config AD5706R + tristate "Analog Devices AD5706R DAC driver" + depends on SPI + help + Say yes here to build support for Analog Devices AD5706R 4-channel, + 16-bit current output DAC. + + To compile this driver as a module, choose M here: the + module will be called ad5706r. + config AD9739A tristate "Analog Devices AD9739A RF DAC spi driver" depends on SPI diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile index 2a80bbf4e80ad557da79ed916027cedff286984b..0034317984985035f7987a74489= 9924bfd4612e3 100644 --- a/drivers/iio/dac/Makefile +++ b/drivers/iio/dac/Makefile @@ -21,6 +21,7 @@ obj-$(CONFIG_AD5449) +=3D ad5449.o obj-$(CONFIG_AD5592R_BASE) +=3D ad5592r-base.o obj-$(CONFIG_AD5592R) +=3D ad5592r.o obj-$(CONFIG_AD5593R) +=3D ad5593r.o +obj-$(CONFIG_AD5706R) +=3D ad5706r.o obj-$(CONFIG_AD5755) +=3D ad5755.o obj-$(CONFIG_AD5758) +=3D ad5758.o obj-$(CONFIG_AD5761) +=3D ad5761.o diff --git a/drivers/iio/dac/ad5706r.c b/drivers/iio/dac/ad5706r.c new file mode 100644 index 0000000000000000000000000000000000000000..c8c7b7b966dcfef90ecbcbe9117= 0bf84ca609179 --- /dev/null +++ b/drivers/iio/dac/ad5706r.c @@ -0,0 +1,244 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * AD5706R 16-bit Current Output Digital to Analog Converter + * + * Copyright 2026 Analog Devices Inc. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* SPI frame layout */ +#define AD5706R_RD_MASK BIT(15) +#define AD5706R_ADDR_MASK GENMASK(11, 0) + +/* Registers */ +#define AD5706R_REG_DAC_INPUT_A_CH(x) (0x60 + ((x) * 2)) +#define AD5706R_REG_DAC_DATA_READBACK_CH(x) (0x68 + ((x) * 2)) + +#define AD5706R_DAC_RESOLUTION 16 +#define AD5706R_DAC_MAX_CODE BIT(16) +#define AD5706R_MULTIBYTE_REG_START 0x14 +#define AD5706R_MULTIBYTE_REG_END 0x71 +#define AD5706R_MAX_REG 0x77 +#define AD5706R_SINGLE_BYTE_LEN 1 +#define AD5706R_DOUBLE_BYTE_LEN 2 + +struct ad5706r_state { + struct spi_device *spi; + struct regmap *regmap; + + u8 tx_buf[4] __aligned(ARCH_DMA_MINALIGN); + u8 rx_buf[4]; +}; + +static int ad5706r_reg_len(unsigned int reg) +{ + if (reg >=3D AD5706R_MULTIBYTE_REG_START && reg <=3D AD5706R_MULTIBYTE_RE= G_END) + return AD5706R_DOUBLE_BYTE_LEN; + + return AD5706R_SINGLE_BYTE_LEN; +} + +static int ad5706r_regmap_write(void *context, const void *data, size_t co= unt) +{ + struct ad5706r_state *st =3D context; + unsigned int num_bytes; + u16 reg; + + reg =3D get_unaligned_be16(data); + num_bytes =3D ad5706r_reg_len(reg); + + struct spi_transfer xfer =3D { + .tx_buf =3D st->tx_buf, + .len =3D num_bytes + 2, + }; + + memcpy(st->tx_buf, data, count); + + /* For single byte, copy the data to the correct position */ + if (num_bytes =3D=3D AD5706R_SINGLE_BYTE_LEN) + st->tx_buf[2] =3D st->tx_buf[3]; + + return spi_sync_transfer(st->spi, &xfer, 1); +} + +static int ad5706r_regmap_read(void *context, const void *reg_buf, + size_t reg_size, void *val_buf, size_t val_size) +{ + struct ad5706r_state *st =3D context; + unsigned int num_bytes; + u16 reg, cmd; + int ret; + + reg =3D get_unaligned_be16(reg_buf); + num_bytes =3D ad5706r_reg_len(reg); + + /* Full duplex, device responds immediately after command */ + struct spi_transfer xfer =3D { + .tx_buf =3D st->tx_buf, + .rx_buf =3D st->rx_buf, + .len =3D 2 + num_bytes, + }; + + cmd =3D AD5706R_RD_MASK | (reg & AD5706R_ADDR_MASK); + put_unaligned_be16(cmd, st->tx_buf); + memset(st->tx_buf + 2, 0, num_bytes); + + ret =3D spi_sync_transfer(st->spi, &xfer, 1); + if (ret) + return ret; + + /* Ignore the first two bytes (echo during command) */ + if (num_bytes =3D=3D AD5706R_SINGLE_BYTE_LEN) + put_unaligned_be16(st->rx_buf[2], val_buf); + else + memcpy(val_buf, st->rx_buf + 2, num_bytes); + + return 0; +} + +static int ad5706r_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, int *val, + int *val2, long mask) +{ + struct ad5706r_state *st =3D iio_priv(indio_dev); + unsigned int reg, reg_val; + int ret; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + reg =3D AD5706R_REG_DAC_DATA_READBACK_CH(chan->channel); + ret =3D regmap_read(st->regmap, reg, ®_val); + if (ret) + return ret; + + *val =3D reg_val; + return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: + *val =3D 50; + *val2 =3D AD5706R_DAC_RESOLUTION; + return IIO_VAL_FRACTIONAL_LOG2; + default: + return -EINVAL; + } +} + +static int ad5706r_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, int val, + int val2, long mask) +{ + struct ad5706r_state *st =3D iio_priv(indio_dev); + unsigned int reg; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + if (!in_range(val, 0, AD5706R_DAC_MAX_CODE)) + return -EINVAL; + + reg =3D AD5706R_REG_DAC_INPUT_A_CH(chan->channel); + return regmap_write(st->regmap, reg, val); + default: + return -EINVAL; + } +} + +static const struct regmap_bus ad5706r_regmap_bus =3D { + .write =3D ad5706r_regmap_write, + .read =3D ad5706r_regmap_read, + .reg_format_endian_default =3D REGMAP_ENDIAN_BIG, + .val_format_endian_default =3D REGMAP_ENDIAN_BIG, +}; + +static const struct regmap_config ad5706r_regmap_config =3D { + .reg_bits =3D 16, + .val_bits =3D 16, + .max_register =3D AD5706R_MAX_REG, +}; + +static const struct iio_info ad5706r_info =3D { + .read_raw =3D ad5706r_read_raw, + .write_raw =3D ad5706r_write_raw, +}; + +#define AD5706R_CHAN(_channel) { \ + .type =3D IIO_CURRENT, \ + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | \ + BIT(IIO_CHAN_INFO_SCALE), \ + .output =3D 1, \ + .indexed =3D 1, \ + .channel =3D _channel, \ +} + +static const struct iio_chan_spec ad5706r_channels[] =3D { + AD5706R_CHAN(0), + AD5706R_CHAN(1), + AD5706R_CHAN(2), + AD5706R_CHAN(3), +}; + +static int ad5706r_probe(struct spi_device *spi) +{ + struct iio_dev *indio_dev; + struct ad5706r_state *st; + + indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + if (!indio_dev) + return -ENOMEM; + + st =3D iio_priv(indio_dev); + st->spi =3D spi; + + st->regmap =3D devm_regmap_init(&spi->dev, &ad5706r_regmap_bus, + st, &ad5706r_regmap_config); + if (IS_ERR(st->regmap)) + return dev_err_probe(&spi->dev, PTR_ERR(st->regmap), + "Failed to init regmap"); + + indio_dev->name =3D "ad5706r"; + indio_dev->info =3D &ad5706r_info; + indio_dev->modes =3D INDIO_DIRECT_MODE; + indio_dev->channels =3D ad5706r_channels; + indio_dev->num_channels =3D ARRAY_SIZE(ad5706r_channels); + + return devm_iio_device_register(&spi->dev, indio_dev); +} + +static const struct of_device_id ad5706r_of_match[] =3D { + { .compatible =3D "adi,ad5706r" }, + { } +}; +MODULE_DEVICE_TABLE(of, ad5706r_of_match); + +static const struct spi_device_id ad5706r_id[] =3D { + { "ad5706r" }, + { } +}; +MODULE_DEVICE_TABLE(spi, ad5706r_id); + +static struct spi_driver ad5706r_driver =3D { + .driver =3D { + .name =3D "ad5706r", + .of_match_table =3D ad5706r_of_match, + }, + .probe =3D ad5706r_probe, + .id_table =3D ad5706r_id, +}; +module_spi_driver(ad5706r_driver); + +MODULE_AUTHOR("Alexis Czezar Torreno "); +MODULE_DESCRIPTION("AD5706R 16-bit Current Output DAC driver"); +MODULE_LICENSE("GPL"); --=20 2.34.1