From nobody Wed Apr 1 20:38:02 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011018.outbound.protection.outlook.com [52.101.57.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D268B2264A9; Wed, 1 Apr 2026 14:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.18 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053807; cv=fail; b=KPa/CKqbt/nruln95FGw3qoDb1ewHKpS6waUaQFa4g8vqxny1Tbye9RNtiElIg4MNmGJpJCMVmhrEgHFQecWeXTxRfq6yt4NGkH1HzO3cld10b/MbKiSr334iKIkc4LiHUn6+kHCHPtN2CeYueaeilXg71B1qmyh8giRaBVpocs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053807; c=relaxed/simple; bh=bUxxIEHGfRNSJ1FUP4EhF6N/M2CLlRG06OuWRuIeB9k=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qRv/arsfQ42gl2M6FLJAH8furCcKW1luMOAlMMOND56ieQguQtadHMbVie7+jVbSH+R14F96w7Hn7+bnM2SZFLKKBeVmhxzdKzmwwaRR4szXzAzzR1BJ68mHywLn7zZOixrFOnho1gvo4ZLiJdNstgumVt3sioHItsOfaBWdWlM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IYgTz4DG; arc=fail smtp.client-ip=52.101.57.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IYgTz4DG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XHnJKmmYVf8F2lgtNCAL4Uti2d5TmNUSLJ7TlLB8/z21jIfNKik2LgcDfyGiioorciFWHJtP/HLfChwVR60p9s0EFqupm95DJQujhzl3OALkkLmVDcNLD6y4FRnWK13DjKkcCUrcFNiiR1ObrUlbCti/xlwh+fgB12OL7WardA1sPfZzg2lYJnaN+GbW+rMaxVrMHt8X96j5UG4Sq75pcpO52ZTxHRI3Yh2x7Q96aROWPUFD+1s8XSunFwlXS0UW6ToxQsQtV+LnO8cdeOTWS+hgUn0yHnhfjGFU+8wByX/r/I4OEyDJbXtL80zQKebC4nt2Z9JaKTt2zzSL5gffuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JCHy4pystE32tJ78s97oMmIQ5CUqgpNhSi/BgnX77Y=; b=tJvvYxuxDEG9a/kzE0IBW6YboMLPkHzhv/2LXJIRLp036rjKQSr7hny1Bg/4XbDz3shhLNacAZVJuTJSKkuKMihPnHEPyCIrG5Lg+wW58l4HSLWUxLySHTUuMe4aFy/CAYvEucP2hq3gon7r8JCvQuNYMGrNtlnv3S3kwaFGVJX4ClHW1TzHPo8/6Dlp5OHEQ4UxXF1Xb+TRkVGulc7V6tJGYoMhvokkgnTauvb8PGEeew+IsmyTnBlhHI+hu0vVuul/oggIKajCyozjHESTyeDyp2NDjhHAvqC+rdFF+JXinsZlvrB6TznM8zdaV0ORDvz2k46FsbrQ+C0QcKkoyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2JCHy4pystE32tJ78s97oMmIQ5CUqgpNhSi/BgnX77Y=; b=IYgTz4DGSQsxeEJQL+5UAIwcUwe3j2Mvbs3x8LYCGmcTX/w7Ugl5jZ4h+iU5EqPNTaiJayehNXpuBdJlzCcnxGfuHK4HAtT1gWaS6LdZlUlYDkeYTAW01MzdfOlmIMwAr5tYSO7Ayw2aaNOmdCZsiwHvkMFHyeYhgzoPgz7SD8fNDwghdG2XBtIjaqyCDVU0qJYBwrRvQ+ugDPm2+ajaYCuttLb622zieSJdtP+/8mnNYnpT73bGM+os9vfe8cLS9aJQezJDGwSdYJlXOAAvZfbCLkoVqaCjAsyosWD+2HZjmcnCS+FfKjMEo2bFJqNKkwKbRiJaV+45zAR54ie7fA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS1PR12MB999188.namprd12.prod.outlook.com (2603:10b6:8:495::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.18; Wed, 1 Apr 2026 14:30:03 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.016; Wed, 1 Apr 2026 14:30:02 +0000 From: Alexandre Courbot Date: Wed, 01 Apr 2026 23:29:50 +0900 Subject: [PATCH v4 1/2] gpu: nova-core: gsp: inline methods providing queue range invariants Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260401-cmdq-ub-fix-v4-1-a9a9cf982485@nvidia.com> References: <20260401-cmdq-ub-fix-v4-0-a9a9cf982485@nvidia.com> In-Reply-To: <20260401-cmdq-ub-fix-v4-0-a9a9cf982485@nvidia.com> To: Danilo Krummrich , Gary Guo , Alice Ryhl , David Airlie , Simona Vetter , Alistair Popple Cc: John Hubbard , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , rust-for-linux@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TY4P286CA0057.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:371::18) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS1PR12MB999188:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a7ffaf8-4d40-4f18-9a06-08de8ffb2962 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|10070799003|1800799024|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: YbYxmlNfODABterfFavHuATjXG2ezF9y3TpxktfzIgwd1u7pXYfiTXo+zzckK4fKrFju7ZFAgHyLzVlZmzs07VkOzzQI56ye7wirqBDYZQP8Fg97pYFC720ygjGdkq32oRTo66OlqUTPEjwAbLJm7bN0Ztqrm8Q/KLrdxTt6vhpl2smYaI/EZcGs6TmIsVjK2T06rl811YeXOsYA84RMUv7YaSh+vMaTkkdqBIk/5nd3ybL5tv4dqUzSooogtfcyolJDIQnRIyHi3hxoWthh4pHH2nO8aMwINGd8JDPlKfgygUd4gmwWufWy7qxMwGVzCpkAq3Uz6ezqAfcFgQO/YUE7N+GQaDLyoVy73PCnO+VmPcSmcCByduLbe4dTXptupVmjDbVbbDoeCyNM+Nfx19CuXgwCvICJZH0czKs12HBDDhlgc+D5uq9HUwbzzqVshFAhnT4Q9ORFvxCBvwrZmWjyLjQqPeLCKw80W1DlDzMueIF/fHl+MncWp5pML0kO9z6p9+BTCqCtHhDG+Oq6cmPaaSdh+/XavM6h17GafhASOgu+6CACVvQ8g3fSoJFX65Csa6zX/y0Y7I3PL3eHXn4A9HVG9oVgG1+ZnJjLuuFk1KHHernId7EvCEknzo6J54M7aeBKXMl1KLPc65EE0X/zXnufNbhmFv/H2+TyJP6YPvdCbISUVhgxrraTHZXgJu/Ot4jGofiMVXgTKT9y+m6VGhCVdc0vAJs05ORVNI8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(10070799003)(1800799024)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXM4N3NIRHFycEJxSGdPSWxFQlVETEs3N2ZDNFJtem55L1lhUHQ5elVzbFZL?= =?utf-8?B?Rk1nV2JURnBsNmRnOGFPamZmTWdEQnJmYTdLaE9iSGtGOHNwVzMzcnArclYv?= =?utf-8?B?bHpOcE1UNStwRGZ6aTBSWjdVbzJCSGhOMmFzcWtsajBmTHhlVjJteUQ0R2lX?= =?utf-8?B?bi8vV3h0cXVPb1g1OVRnKzcxZk9UVnNLTzF2bzBSOE0xcWFMd1VwT1gwN0lT?= =?utf-8?B?WTczbmxrSW4ySW5UV1habzJwczRTc1BGbzQvMVlSVFd2NG9GTXhWNnZ3RFFU?= =?utf-8?B?aHk3NHdLTWlrK3U4MzdrSFhpdVpUdFN3b2JIdk45ZVZmYXVSMDdRWXFyWEVo?= =?utf-8?B?Z2xZZVZmMFNZOWRkWUJ5Nzd0Z0dmNi9QMmZzSmdyTnV0NVZGOTJyK3FjY2p2?= =?utf-8?B?cHBmQnYrbHRjbkxRbnBEM3VoUk9lb0ZyOTFXdTBLRlJBdERMOGtWQ2xyVTdx?= =?utf-8?B?bERvbTdJeXlSOWVxTFhiNnpPZzNKekpxZnVyM05UQXl5SVliSjF6d0ZZMGRJ?= =?utf-8?B?WHJDdkRuMllnUi9DYVhFTHA2clZHZ21VT3krM1RQdFo3UWwySm5YYXJhNnF6?= =?utf-8?B?UzNVUWFCNjM5c2FkNlZoS0xvckVHQ3lnTHJhTTh6SFJWY1RkRkJ1aHlaVHNH?= =?utf-8?B?L3JxeGdKb2Qzd1VBdHd5NDcrVHNFYVUzZlFGN050bklrZkZKRitOSjJBY2J3?= =?utf-8?B?YkhId21ENTQ5YXliSnRQZDhJRm0vaTRvRXFRYUlIUng5dDgvWXcrZm9hRDN6?= =?utf-8?B?YTdyaGpxWXVTMHFlY3JMNmI5ZWVpMVBJQWl0RHJmcytmUmpUY3k4VTJUMlcw?= =?utf-8?B?TThxNHF5K0pxL1JLNUp0SFMxT25mQzlWQVloVER4Z2V2KzZPMGIzMkpMUFZy?= =?utf-8?B?NlpaL3RtUFdaOEtLVnFDKytsckc0MWV3YlFXVWIzVGpnYkIvUWJ4L0tRUHhH?= =?utf-8?B?a3k3YXcwOEgvNUdyMlowY0UyOTQ0WnhvV3B3QnVvVEd0ZkFMM2F2VU84OUJz?= =?utf-8?B?WnJxQXpNN2ZDdW9BbUhnT25SbzVPeDR5V0M0dTFlbS8vS2VzWDlEd2RZcmti?= =?utf-8?B?Vk0xcm5GenBBQ2ZLZzd1S1FPcExOdTEzamduNk5lUEg0WERvTzVZLzl5TENI?= =?utf-8?B?dEN1ZFFVcW0zZ3hnQWFQYW1OQTVIQXk5UDU1RkR5TGxwOE1lSyt3NE9mU1Np?= =?utf-8?B?VEM2WHNPS01RdjBaUUJHbHNmK2YwaWlISE9LVjlvYXNXcFhXL1ZJOEVMSzVs?= =?utf-8?B?cHQ3V1VFckdrK1lERzdiUFRoUU16U0xRRzVDNUhyMEd4RDNwT3U0M01jb01H?= =?utf-8?B?WjYwdXdNR05Yd2hFWVVvSGtNTFMzWUk4VFp5enlZb0E5SEFSUVQ5b253Mmxo?= =?utf-8?B?dENsNUJqWnQvc1Rzb2ZrbDBMQWxlZXhObU5kaHFpcytENDl2bFBsRGJPYXVj?= =?utf-8?B?SnoxaElLVXB3bDhIeDVBKytjZjdiVmZ4TkdkeDI4Wng0VkdDdlB3SmtIOFd2?= =?utf-8?B?N2psLzRhTUFLV0h0Q1dmbUpoVElxRU1sZHM0bUZNM0Nub2hZMWxpUThidkV3?= =?utf-8?B?LzUyN3VjcytIN1VJMGcxckE3dUtJZCtrL3Q2cFVwUkdIUjJTd1c1TitWMDcz?= =?utf-8?B?bDloWjk2R0VlM0MyN29tN1VaUFM0MGhmdEd5TXh6cEF3VzNHYlFYbGhEaGZl?= =?utf-8?B?dkZoRG14SVowYmJCOGZuSnI5bHJQZHVKZlhmQmlQSUFmaVZCWDZrb25TZDkv?= =?utf-8?B?SVVVNVpBZ2F3VEsvaXFxWEU0TDVGMk53WEVGQ1ZrQ2hQZzVxWGVSQ0VxYTVJ?= =?utf-8?B?S09sckdpdjhIMGZZdk9VK0lHaE1qdjhaNndBOU5JT3Jpd25qamlXMFRwSCtV?= =?utf-8?B?MURYVFRYVnNkaFNpY1lxVWY3KzczREtXajlNUFNyR3BsVmp0Q2FoRlh6enh1?= =?utf-8?B?ZXBOblpCQlNLQW9jOXNBS2VITnhvQ1pFTGM1ZUFEQVQrRCtDVlYvajRPanMr?= =?utf-8?B?WkthQjFva2lnVE1KOWpHRm93VStidzdFNHhCL2k0WG56MUhveWsyVmxTN3ZL?= =?utf-8?B?N2ZCOGtJMlhmUTlGUWI4QkQ4YkNBamc0N2RpNGV5ZDVDOTJxKzJCRjJ6RFhS?= =?utf-8?B?Y2tIR0hCY3k0Zi95OC9aZDVXSjRtZWoyRlNJQWQ3ZTkwd2MyU1RXWEdTM2RD?= =?utf-8?B?Y3lSWFV3anEvRFh6QklMYjRMMmtpaEZDQmJoK3RJMnZoRE8raEtyM3ZRak5p?= =?utf-8?B?ZmZ2QTZMamtGNGtRdS9HQzYybnYvV0pTNVB2Qi9ZR3EzcGJnNDRuZzNMMk5N?= =?utf-8?B?ZzVwN01MV1ZLWFRpWDJXdjY1cDRvZkRXa0lqSFBYYngrRlVMYmQ1cktobmwr?= =?utf-8?Q?2ixblwl/ipkNYijLUepM+/Pt3wQITHTBeGJTbB3cqrXoT?= X-MS-Exchange-AntiSpam-MessageData-1: o6YsJ24Saz24Ow== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a7ffaf8-4d40-4f18-9a06-08de8ffb2962 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 14:30:02.8312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 87PwDmV6blw+RGqWavcM/OXCbnaO1XUCtGr7NUQvJ7eI9iw75l8lJzQYK/SqeIZrmp3V6LoQSms5rdp4zOTasA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS1PR12MB999188 These methods hold a range invariant for the read/write pointers (namely, that the pointers are always in the `0..MSGQ_NUM_PAGES` range). The calling code depends on these invariants to build properly, so make them `#[inline(always)]` to ensure that they are propagated where they need to be. Signed-off-by: Alexandre Courbot Reviewed-by: Gary Guo --- drivers/gpu/nova-core/gsp/cmdq.rs | 4 ++++ drivers/gpu/nova-core/gsp/fw.rs | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 2224896ccc89..72e9b79619eb 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -384,6 +384,7 @@ fn allocate_command(&mut self, size: usize, timeout: De= lta) -> Result u32 { super::fw::gsp_mem::gsp_write_ptr(&self.0) } @@ -393,6 +394,7 @@ fn gsp_write_ptr(&self) -> u32 { // # Invariants // // - The returned value is within `0..MSGQ_NUM_PAGES`. + #[inline(always)] fn gsp_read_ptr(&self) -> u32 { super::fw::gsp_mem::gsp_read_ptr(&self.0) } @@ -402,6 +404,7 @@ fn gsp_read_ptr(&self) -> u32 { // # Invariants // // - The returned value is within `0..MSGQ_NUM_PAGES`. + #[inline(always)] fn cpu_read_ptr(&self) -> u32 { super::fw::gsp_mem::cpu_read_ptr(&self.0) } @@ -416,6 +419,7 @@ fn advance_cpu_read_ptr(&mut self, elem_count: u32) { // # Invariants // // - The returned value is within `0..MSGQ_NUM_PAGES`. + #[inline(always)] fn cpu_write_ptr(&self) -> u32 { super::fw::gsp_mem::cpu_write_ptr(&self.0) } diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 0c8a74f0e8ac..e2c0e9bf310e 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -58,14 +58,17 @@ pub(super) mod gsp_mem { MSGQ_NUM_PAGES, // }; =20 + #[inline(always)] pub(in crate::gsp) fn gsp_write_ptr(qs: &Coherent) -> u32 { dma_read!(qs, .gspq.tx.0.writePtr) % MSGQ_NUM_PAGES } =20 + #[inline(always)] pub(in crate::gsp) fn gsp_read_ptr(qs: &Coherent) -> u32 { dma_read!(qs, .gspq.rx.0.readPtr) % MSGQ_NUM_PAGES } =20 + #[inline(always)] pub(in crate::gsp) fn cpu_read_ptr(qs: &Coherent) -> u32 { dma_read!(qs, .cpuq.rx.0.readPtr) % MSGQ_NUM_PAGES } @@ -79,6 +82,7 @@ pub(in crate::gsp) fn advance_cpu_read_ptr(qs: &Coherent<= GspMem>, count: u32) { dma_write!(qs, .cpuq.rx.0.readPtr, rptr); } =20 + #[inline(always)] pub(in crate::gsp) fn cpu_write_ptr(qs: &Coherent) -> u32 { dma_read!(qs, .cpuq.tx.0.writePtr) % MSGQ_NUM_PAGES } --=20 2.53.0 From nobody Wed Apr 1 20:38:02 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010019.outbound.protection.outlook.com [52.101.46.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DD32C0296; Wed, 1 Apr 2026 14:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053811; cv=fail; b=b/B/HUhaSOwVyhe6F+dTFQdwqNjjMdEsJ707Y4p9D8PggPRIfEWL9wFnSZsVV+kf3xsOfno7M2bSB+abJB1jpWwd20QV2TNkbKjQ9Gu0s5H2fb7S6oVjrGjY0TAMhxmEN8u6qsdF/TsBGmbrewnt18pwfeKQd7GnWa8O69oT6hg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775053811; c=relaxed/simple; bh=OVjsq0p6u2/4aUd+DUYnmsOUViYVj59xxB3VakbBKNs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Y8T3QUHlohDL4zaqkAxri2fARYayLpPGn0GxhI5M8iQdjVXwuVcCQxhmOxa6813xaj2s6c1KZqpsKD5TzIyUn6Uk8xRYSNlzHC9qFZO/jXmOAf8k4qMiy2FRCIJ1oCidiaF7BtegbXQRgQhs1DYVJjkAdamx+FdvNrBNBSfb6VU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fOP/oOu9; arc=fail smtp.client-ip=52.101.46.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fOP/oOu9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UvRbkcCDVPFnaxUZApinNylvwtjFqjXisvjZlT9mNnZm9gmA97qQsjc6r9RF+qYFbJKmHU/3FuVypfJIwawnm+i3uiKQWYSyvj5+Rxw/ERpf5p4LZF2ReJfBWvEHlC9Fs01OA6x4rTKQcIvgtoggc395O0tTbi5ktqpjHFVwk1RU9EJCx+RFRvB4kbBumw0pt+LgAPhJRJmekAnMKpMKPuRta91iOVhmZT+uOCyEOgb1u6dgR8FYrdTAsgwdBR/8/cLv7V7niVbdA9jOn6bkpjbgLFuqxtH3a86hb4oUW5CXljXLZqNSE8wVlxSunh3jXyCSl45cQjORJz65dYK6/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kjfB3y/Ru5XELhK3MQHlxkRUcIg3hSC40b6tlkaiqO4=; b=UXfqaYjjxffX5ibZpDOVEM2GhIwqeM2kYJI8/kyjsm4FSjrXNuP2WmOJn19Kll09nwYRi1laDYpyGQiRfEiKRdGECYFJLD8DaVIKKel66ZXbtp7fA9STOjyXa+pOTrE2cCt/WuJFbXpIDfn8ikyw72k9NHwPj9sfpNuPS2XbUlGnN0CTKzz96k04AkMcI+2Ej6BxCxQl1K/zCYKthloECUWWbVfsTUgY+uD/Cp5ys6dcr/+c9u4IAHOqlSgVYT5NzvKZc8IIvm+oFHnlXsr846HjxFHhoHRqEgMl0PT/clredRk28AdPEoYRvbH9xazBB1KelQGrPG6mB8QPj2LNZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kjfB3y/Ru5XELhK3MQHlxkRUcIg3hSC40b6tlkaiqO4=; b=fOP/oOu9u7NGubdxgPd7pudq2cfxKbvAvIrVWn1E1/XpN2imBSgnFC872AVUy5KpYAMKlmsSUUbrJILVgdxjMY5gL8mpztMD/zQ4Ak8I1bjHnFeF6heAE9jd+OcyRKWrNkJXnylwlrthexzxgbNpzFbSPuBs2RxGWZEsYVsp/8F8Txbfhspdigocw646v0m0qC3LJDlVI5CZqPr0GkBDF/akgAEZwXHtty3i2GYMCCkE2plPEliCt2Ja451dk5TOqi0v8dOOJvSgn1IdSwDqfHKIfoVMFeH/5Il1YfRmw3DCKZMj/5SYt7QR+g7+5J1usZkWqgiSyUomXNmujcQk/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS1PR12MB999188.namprd12.prod.outlook.com (2603:10b6:8:495::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.18; Wed, 1 Apr 2026 14:30:06 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.016; Wed, 1 Apr 2026 14:30:06 +0000 From: Alexandre Courbot Date: Wed, 01 Apr 2026 23:29:51 +0900 Subject: [PATCH v4 2/2] gpu: nova-core: gsp: fix undefined behavior in command queue code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260401-cmdq-ub-fix-v4-2-a9a9cf982485@nvidia.com> References: <20260401-cmdq-ub-fix-v4-0-a9a9cf982485@nvidia.com> In-Reply-To: <20260401-cmdq-ub-fix-v4-0-a9a9cf982485@nvidia.com> To: Danilo Krummrich , Gary Guo , Alice Ryhl , David Airlie , Simona Vetter , Alistair Popple Cc: John Hubbard , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , rust-for-linux@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TYCP301CA0063.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:7d::8) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS1PR12MB999188:EE_ X-MS-Office365-Filtering-Correlation-Id: d875a02b-fbf2-415d-ac3b-08de8ffb2b86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|10070799003|1800799024|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: uu9v4Z2qX8h26ZWXg1XbMw+Nmy4OWw+/p/HwZR51bEbkhhF2w1N/jK3gPLO6V2FGSJK9zXRwHlDzHE6lbR2PYJMHynGZNYjh1vojHXEStqHO1GFcbWcVRTnCV5EkKoj9dtm6WQx+c4UgTkPcun/wcsZw8QHQw0z19rKkFFw72HoJqAqS36NvYXFjP/2S5oCUWwl5vPziOlFrje9DmY3YXc9zl0stpCmVxjyoUcnjsnjU8Jy59BLru65fr+TiFn8xV2kJyLq1qtjfVngCtXhaVZb5+oJ3pN1fK6jF3IL1vYB06pkNJB0lIRjCveR3QKuaaw9oDNPZb9gjJGj4a2lvStXirIiXnpd3ujtiwfrTcFMYigamGnnsWnMM5N1aJxVs1XiNZrL4RJEmmK/qAoyPG2VQV6GpQR2dButuseN0QDu6s7EATHAxGM/3sOOuZRFEOUxbWKsJFR9+mIhEmJzso7pZpvLdy6cHozP9R5+n/2ltX1BpGbgrHbk2QZuTGhLhfQ02wv/PbcmjYZCl7JmqzAs37kopmMkwCMy7wJeouxJAR+Z03zjQIGszco3kVscNvQde9Qi9F6nLr1tmqEWOHeDDPlcVMnsjJ2O69DkeRaKi9lMOskximX1tSVA1c+zC/VKNsbl7P3KgVXmAZxbX9Dq+fWOxFd+kuOyyw3xz3VIo63jGOznv7/Ew63W/6dzN0KysVEIn2UC2ygfS2+XZF6LUvQQsOY17Z9Bu+zty/WU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(10070799003)(1800799024)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGxoemd1S3ZTZkN5MnNXRFk2Uk0xL3BkeDJYRk1Qdk8wa0h4ZTlGUE9lYmN5?= =?utf-8?B?akRrSlp4MDlnVXVpdHlaQVZlMXhOWCtxTTJMeU5PSWJRQy8vbU94cGlRbDQ3?= =?utf-8?B?TEVWUWVNNmpNMmpod0x6eXJqbnVEeVF0Zk5UOXg1UXhaL2lGdFAzdERzUnRR?= =?utf-8?B?OXZSWVRDNkwrZXg5ditacnFtZHB2Sm56WTRzeUpMbGJ0dzhNTWpQRTk4T2o3?= =?utf-8?B?M3lOYXFvczRSU3RQMTQwMFFSZ2pkVVRpSlBYNWNpbE9RMkt6bDk1VUdhTkFn?= =?utf-8?B?dDRjK0xFZERhbWNKSzNOZVpWU3Nib040bW9TWlFSem1nWGM0bDRNNFQ4L2Nz?= =?utf-8?B?NUNFYjFoRjhPQ2pJRE1NODFsYjJSMGR0OU9vUEZCSGxNZUNZaDVXb0VxZ09a?= =?utf-8?B?WjliWHdHc29jb1E3TnFkeHUzWFBtRHAyZHdBZkdBdDg0NDZ5aGZwdW9hWW5w?= =?utf-8?B?K212ZHl5aGFsRGxZbXoyUWpnODU3UEc2NHB3cjRpZ2U1clVYZUI0Z3NrZWVS?= =?utf-8?B?UmNUcm40NTFQS0cxUmd0eDRxTGhpWTJLZCtNUEptZ2NJNTUzTzB6V1YwWnpi?= =?utf-8?B?UExsb1RycGhpRGxNenlXdTdNcFdISXAxeWhtYmxFSWhxbW11dlFoNWc2cTV4?= =?utf-8?B?bUNYNldSV0VWTnNWcUI0NE84UFBnUkpRN0J0TDRqVEhqeVlUQStlVTJlTFB0?= =?utf-8?B?NTBzd0h6WWN0ZU42UVJqZTh1elJlYyt3aGdLSkNlV0FIYzY5dDdZcWZuUDU2?= =?utf-8?B?Uldza3g2UGFLVkt3dEFZaGdGUExHN1ZFKzd4bUNTWlduR200T0g0UDgwQWVG?= =?utf-8?B?ckRiT2pjSjgzUTJpR3A3aWtxaVk5UzBWeW4relJoZS9aUGNGelFKbW5ZS1E0?= =?utf-8?B?SFpjVEpiZDVSa1BRakluZTlpc1JSUEY4WHJ3QmlrQkN6TUdxeDZrbGltVGRN?= =?utf-8?B?OUI1dTlYNmc4WUg5b3RvVnpYbVRHMjdLbFNBc2ZHTkJyZ3Vha0xlY3hZclVD?= =?utf-8?B?OGNCRzRvSUIrMFd2V0FGaW5yWG1jUmVPZktaZ1R4SktFMWN5SFNSQS9OeUlx?= =?utf-8?B?L3lpN3VNeHl3WVpxNTVzMklPYnhSNjdiNzNYYkphdHJwU0o4cmJiTGFiRU41?= =?utf-8?B?YlJGeVZFUFJXR1UxYkRwNHFBWlFQQ09KYy8yRG5tS2tTOEczOGFiSWcrQ1Jj?= =?utf-8?B?VW8xcEFaeFNmc3dTQWF6RFgrVnNOTGtLMEhhS24yc0k2ZWxSdEl3NjlKeDZs?= =?utf-8?B?RXhhMk96TFhxb1YrVFBGajhvenA1ZHc3QitaampKcVBLaTZjRVB3WHRGaWlx?= =?utf-8?B?MHlxUTdtTjArWGVVa1BmQnVMN0t1eWdhY3ArN25hMitGQm1PaENGaFJOQ3B1?= =?utf-8?B?QUR5VDRFdFg0SlEzRHRIZDh4MzFyWW1aV2I5QUI0SEU2RlRRT29zeit3UzdF?= =?utf-8?B?M05lbGRRL1RSRDFpeXRvc0hOOWFWczZMK3lUNkZnb2p6VUpBR1V3c29IYVNy?= =?utf-8?B?OEM1cFUrNk50RWkrQ08wbWtPVWkyWnFoQVQrN3pnbGFSUEgwN2VwVFU2VUhF?= =?utf-8?B?OW5WRFZsclRBaElENjJRZEhjUjNsN3h6eTRWNzFPUzNiaWdldEFtL3RzYk1h?= =?utf-8?B?WEJubDlLRElPOTZJY0pTa1VmUzh3R250bHpmVXBMUjNaRE5vRkNWWVNIMWdu?= =?utf-8?B?R2JrNzd2UlFwWEVoYmNBSVVEVnMxTXpJOTY2MktzUXJHTWduYnYrRENXMWdK?= =?utf-8?B?RS9Zd0J2aDNaNGs5RFdhYzc4SU0rcUVxSWxMcmo4a1crUitBTURXRXVlZXJV?= =?utf-8?B?SWVlV2RQdWp1Y253UUJCdGJHOVNjSlVRVnpMRmtpd3VkOXV6SG5uWnJzYVpk?= =?utf-8?B?c1BPOC9CVlg3QnNDU0RaQjZDdE5qYXE1bnZTMitWZHFiT1JKbk5nVXh3L2Ra?= =?utf-8?B?OGZFbzNkNjhwUE1NRHNkMmh3NS80ZnpvUHRONDUzR3VEV3g0SUxudnhHNmZw?= =?utf-8?B?RnhRTUlGemEwY3FqeWhFdU45bDlSbmNzMXVzd1BJbUNCcTgyQi9yUkFqY2JN?= =?utf-8?B?Yk96eWNXOE44d3VVcFNscFlOdDNCRyttOFA5SmtyTklmcDdRSXpwNEZDb2h1?= =?utf-8?B?bVo5enlDdHhYWGk5RE9xWnVxYWl6R0haSUQvUzkrUENrNHhyOFBDWDYxR01X?= =?utf-8?B?Q3A2b1lxOGlDSTlFS1g1ZUd5YTVJaXpKZnhIVkNreC9wY0trK1FpY2hRYXBW?= =?utf-8?B?WHdyKzFobUp0YWhxMjIzODlJbDFmTWNWMXY1R0lZcmlwMnJaWGVvVG9sYzBq?= =?utf-8?B?WFp1SmRVeUptRXAxak53RG5sRVN4SXFwdzQ0M291UmZqUFI0c1RLb3k1dm9l?= =?utf-8?Q?z299LRDfCWsMCyqknTjJXBaCdFK/s80stmK2K6NWkWLzY?= X-MS-Exchange-AntiSpam-MessageData-1: /N41OxC6dPCsOA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d875a02b-fbf2-415d-ac3b-08de8ffb2b86 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 14:30:06.4528 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N5ykD1NKhilM0u79fJCUhOqMyn5oNKoArpylhmW31ddW/xOFnagfLbiq4bTmBMhZdUqeM4LaKRlnX7QFIdbRZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS1PR12MB999188 `driver_read_area` and `driver_write_area` are internal methods that return slices containing the area of the command queue buffer that the driver has exclusive read or write access, respectively. While their returned value is correct and safe to use, internally they temporarily create a reference to the whole command-buffer slice, including GSP-owned regions. These regions can change without notice, and thus creating a slice to them, even if never accessed, is undefined behavior. Fix this by rewriting these methods to use pointer projections in order to create slices to valid regions only. It should eventually be replaced by `IoView` and `IoSlice` once they land. Fixes: 75f6b1de8133 ("gpu: nova-core: gsp: Add GSP command queue bindings a= nd handling") Reported-by: Danilo Krummrich Closes: https://lore.kernel.org/all/DH47AVPEKN06.3BERUSJIB4M1R@kernel.org/ Reviewed-by: Gary Guo Reviewed-by: Danilo Krummrich Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/cmdq.rs | 114 ++++++++++++++++++++++------------= ---- 1 file changed, 65 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 72e9b79619eb..485d0c0f2a4b 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -17,6 +17,7 @@ }, new_mutex, prelude::*, + ptr, sync::{ aref::ARef, Mutex, // @@ -255,38 +256,52 @@ fn new(dev: &device::Device) -> Result= { /// As the message queue is a circular buffer, the region may be disco= ntiguous in memory. In /// that case the second slice will have a non-zero length. fn driver_write_area(&mut self) -> (&mut [[u8; GSP_PAGE_SIZE]], &mut [= [u8; GSP_PAGE_SIZE]]) { - let tx =3D self.cpu_write_ptr() as usize; - let rx =3D self.gsp_read_ptr() as usize; + let tx =3D num::u32_as_usize(self.cpu_write_ptr()); + let rx =3D num::u32_as_usize(self.gsp_read_ptr()); + + // Command queue data. + let data =3D ptr::project!(mut self.0.as_mut_ptr(), .cpuq.msgq.dat= a); + + let (tail_slice, wrap_slice) =3D if rx =3D=3D 0 { + // The write area is non-wrapping, and stops at the second-to-= last entry of the command + // queue (to leave the last one empty). + ( + ptr::project!(mut data, [tx..num::u32_as_usize(MSGQ_NUM_PA= GES) - 1]), + ptr::project!(mut data, [..0]), + ) + } else { + // Leave an empty slot before `rx`. + let end =3D rx - 1; + + if rx <=3D tx { + // The write area wraps and continues until `end`. + ( + ptr::project!(mut data, [tx..]), + ptr::project!(mut data, [..end]), + ) + } else { + // The write area doesn't wrap and stops at `end`. + ( + ptr::project!(mut data, [tx..end]), + ptr::project!(mut data, [..0]), + ) + } + }; =20 // SAFETY: - // - We will only access the driver-owned part of the shared memor= y. - // - Per the safety statement of the function, no concurrent acces= s will be performed. - let gsp_mem =3D unsafe { &mut *self.0.as_mut() }; - // PANIC: per the invariant of `cpu_write_ptr`, `tx` is `< MSGQ_NU= M_PAGES`. - let (before_tx, after_tx) =3D gsp_mem.cpuq.msgq.data.split_at_mut(= tx); - - // The area starting at `tx` and ending at `rx - 2` modulo MSGQ_NU= M_PAGES, inclusive, - // belongs to the driver for writing. - - if rx =3D=3D 0 { - // Since `rx` is zero, leave an empty slot at end of the buffe= r. - let last =3D after_tx.len() - 1; - (&mut after_tx[..last], &mut []) - } else if rx <=3D tx { - // The area is discontiguous and we leave an empty slot before= `rx`. - // PANIC: - // - The index `rx - 1` is non-negative because `rx !=3D 0` in= this branch. - // - The index does not exceed `before_tx.len()` (which equals= `tx`) because - // `rx <=3D tx` in this branch. - (after_tx, &mut before_tx[..(rx - 1)]) - } else { - // The area is contiguous and we leave an empty slot before `r= x`. - // PANIC: - // - The index `rx - tx - 1` is non-negative because `rx > tx`= in this branch. - // - The index does not exceed `after_tx.len()` (which is `MSG= Q_NUM_PAGES - tx`) - // because `rx < MSGQ_NUM_PAGES` by the `gsp_read_ptr` invar= iant. - (&mut after_tx[..(rx - tx - 1)], &mut []) - } + // - Since `data` was created from a valid pointer, both `tail_sli= ce` and `wrap_slice` are + // pointers to valid arrays. + // - The area starting at `tx` and ending at `rx - 2` modulo `MSGQ= _NUM_PAGES`, + // inclusive, belongs to the driver for writing and is not acces= sed concurrently by + // the GSP. + // - The caller holds a reference to `self` for as long as the ret= urned slices are live, + // meaning the CPU write pointer cannot be advanced and thus tha= t the returned area + // remains exclusive to the CPU for the duration of the slices. + // - `tail_slice` and `wrap_slice` point to non-overlapping sub-ra= nges of `data` in all + // branches (in the `rx <=3D tx` case, `wrap_slice` ends at `rx = - 1` which is strictly less + // than `tx` where `tail_slice` starts; in the other cases `wrap= _slice` is empty), so + // creating two `&mut` references from them does not violate ali= asing rules. + (unsafe { &mut *tail_slice }, unsafe { &mut *wrap_slice }) } =20 /// Returns the size of the region of the CPU message queue that the d= river is currently allowed @@ -308,27 +323,28 @@ fn driver_write_area_size(&self) -> usize { /// As the message queue is a circular buffer, the region may be disco= ntiguous in memory. In /// that case the second slice will have a non-zero length. fn driver_read_area(&self) -> (&[[u8; GSP_PAGE_SIZE]], &[[u8; GSP_PAGE= _SIZE]]) { - let tx =3D self.gsp_write_ptr() as usize; - let rx =3D self.cpu_read_ptr() as usize; + let tx =3D num::u32_as_usize(self.gsp_write_ptr()); + let rx =3D num::u32_as_usize(self.cpu_read_ptr()); + + // Message queue data. + let data =3D ptr::project!(self.0.as_ptr(), .gspq.msgq.data); + + let (tail_slice, wrap_slice) =3D if rx <=3D tx { + (ptr::project!(data, [rx..tx]), ptr::project!(data, [..0])) + } else { + (ptr::project!(data, [rx..]), ptr::project!(data, [..tx])) + }; =20 // SAFETY: - // - We will only access the driver-owned part of the shared memor= y. - // - Per the safety statement of the function, no concurrent acces= s will be performed. - let gsp_mem =3D unsafe { &*self.0.as_ptr() }; - let data =3D &gsp_mem.gspq.msgq.data; - - // The area starting at `rx` and ending at `tx - 1` modulo MSGQ_NU= M_PAGES, inclusive, - // belongs to the driver for reading. - // PANIC: - // - per the invariant of `cpu_read_ptr`, `rx < MSGQ_NUM_PAGES` - // - per the invariant of `gsp_write_ptr`, `tx < MSGQ_NUM_PAGES` - if rx <=3D tx { - // The area is contiguous. - (&data[rx..tx], &[]) - } else { - // The area is discontiguous. - (&data[rx..], &data[..tx]) - } + // - Since `data` was created from a valid pointer, both `tail_sli= ce` and `wrap_slice` are + // pointers to valid arrays. + // - The area starting at `rx` and ending at `tx - 1` modulo `MSGQ= _NUM_PAGES`, + // inclusive, belongs to the driver for reading and is not acces= sed concurrently by + // the GSP. + // - The caller holds a reference to `self` for as long as the ret= urned slices are live, + // meaning the CPU read pointer cannot be advanced and thus that= the returned area + // remains exclusive to the CPU for the duration of the slices. + (unsafe { &*tail_slice }, unsafe { &*wrap_slice }) } =20 /// Allocates a region on the command queue that is large enough to se= nd a command of `size` --=20 2.53.0