From nobody Sun Apr 5 13:31:02 2026 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E0443D517 for ; Tue, 31 Mar 2026 18:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774980740; cv=none; b=fAvAGHNdPi6bsEurARJOz57VZBXrbdLrLau0QOeZaIAoizditvEPNUkufvq5ZTiEyhaPm6V26VGD2yCphLhPYv7xjjPjmSzQ5Ix8yLVgj/LbX0aLmHxpN5cEukVq38OBPIuyU9etzxlt0jTydCfEPvi4/3WEOaKpz2iwZ+zWTKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774980740; c=relaxed/simple; bh=rG0RQv2MuPbBhBFZtR5wdNoasAYFvFw7xH1qvGGsPyk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WUprR1TxEWoQr/D9fDDFVaGSfphmfgSPLl83NUnwTprNIpKo3rlz+u4tliWjNUX+1MkhsxWWlfSKNbp0wWuK07gBN6GFoyDApWTFOwfWHEadEDGLHOq7gghxcx2vqbQM3ERf8maq3DyhHtPsEOoo1SW81iJU4ZaJxAf26sQbhzs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=adm9+2HZ; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="adm9+2HZ" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-12a74039dc6so4834050c88.0 for ; Tue, 31 Mar 2026 11:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774980735; x=1775585535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lnQ8hDDXDr6abxthuWEWU6YIYcBA9dlKD0mrsjPgMY4=; b=adm9+2HZMXbJ1AXq8LgFteWfqCe4CeQSDMJSMfKgi2x5a3IMZeN5I73kkRT8g3BePJ UF7M/5kHSSsRUTitE0U9HpPAl+4RpZbYnWLijA05a9jRX0tVAv7jA9FKxYzCe/Agu8gP lA1uIhifRFESyOEBqC9H+CI0fYX65YMkZ++oAKjCPGxpcM4msqhHLM0I5dgQ34T4jp9k saC10fver18GcV9I4DkSCujK+t7ADc71diiBAwLieLIhCmN65V1EiBSGgpyBsxzc+KCo eed8Pz4GOeHMv/N/owlisy7S9Knf1uFuNER5+5AalxJ3yCsrxKUWPL7m1HnV2gOAw6WI ikPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774980735; x=1775585535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lnQ8hDDXDr6abxthuWEWU6YIYcBA9dlKD0mrsjPgMY4=; b=K+qcdZDwP/D6xnRumvQ/GLEaqj31pLGYJwniJYF2iB+TwHUq4VHVe0J2REe/I3rwPk 5W1lSG3Mv2xRaV2lX9jSOzLf9438Q+Yd4m+wSpc9+S0yN3qU2sW2Exwb6YNfaMgt1lMQ 53WnR+CzrIg5KBwbt9y3MgV0GhDaPS1umEOpSYa2kMDMmQgjTiqs6pmzGA0BHL8gujCg AkmjGz80bDfOoTjCuVv631pExt8KfdEYi1B9+uoBSu2hokKt08amVGQtDag96/AY8ZHz gz0eKEpSSR91lFHU+C+SPCHXTlU2GVk5TShyEyFSlpqJl41pJjA+GHg3mM2XD0hznYty YO0A== X-Forwarded-Encrypted: i=1; AJvYcCWTlZtsqZzjJvzSjKveNwARLz9pZgj2o25gt0TBKdjEBEdkVnFdR04fTVSuGk8k0wfEVXjXUUxN4hFch4U=@vger.kernel.org X-Gm-Message-State: AOJu0YwhwYiboKDLeufQrLETcZDULOZ3BUk+UJR8Zp1wEXeDksDqYpdU uJX4ebp4hZJn/R1LALM/jyh9U4nbnt/Sj2skZdrAf51e3rps5vwI3sBE X-Gm-Gg: ATEYQzxHhEQarkKSQ1qOom5LRDnGSthY9sjgceATEUhHgTCdVPS4I4MqllqdOSAfYWi dwcYeJI3FX1myE4Sio8WwEFESLup6CJtuZTqZpXJYNXERQZfxIDXAwg7aRDzN+6LTUGHD/vIZAV PH7eDCzVGzsvyVHQAFk6gDuv+ChaUZ+IqRwXWTLDYDiHpkAcMAItVvN3G4RL3adAtkrD0eVQTUX dt5a6ZUVNxZXej/qvYCkrp5FKI5SI/00YjCoangz137Elp4vmX/k2413cH3eHwPKatgWKcQQl/a Rp24Tj9BL3QD0HZ3H1iqpvLscegPTZ0L5J779OQisyWPyewPzhjdRApRticE4d5IQ/iWXIamRmm 2nTrvgo8dJZk+WTqj1FpJAjRJIUTq2rDpdd+0eamARKaRuhs30SvIHX4x5Vjpg20vcOK2FRvZ6O CiugI9YgVedtiONmXtE3ZQ2A86SkQHrnHPKxAu8h2L1QY2VMv8XT7VTzefzSkIRuhQb8vj8ZtLP /uF X-Received: by 2002:a05:7022:6288:b0:128:ca83:5aa3 with SMTP id a92af1059eb24-12be64552fbmr301829c88.1.1774980734977; Tue, 31 Mar 2026 11:12:14 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12abbe21787sm10769272c88.11.2026.03.31.11.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 11:12:14 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 03/13] platform/x86: lenovo-wmi-other: Zero initialize WMI arguments Date: Tue, 31 Mar 2026 18:11:58 +0000 Message-ID: <20260331181208.421552-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331181208.421552-1-derekjohn.clark@gmail.com> References: <20260331181208.421552-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds explicit initialization of wmi_method_args_32 declarations with zero values to prevent uninitialized data from being sent to the WMI device when passed. Suggested-by: Rong Zhang Signed-off-by: Derek J. Clark Reviewed-by: Rong Zhang Tested-by: Rong Zhang --- drivers/platform/x86/lenovo/wmi-other.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86= /lenovo/wmi-other.c index c1728c7c2957..c3614bc4f90c 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -166,7 +166,7 @@ MODULE_PARM_DESC(relax_fan_constraint, */ static int lwmi_om_fan_get_set(struct lwmi_om_priv *priv, int channel, u32= *val, bool set) { - struct wmi_method_args_32 args; + struct wmi_method_args_32 args =3D { 0x0, 0x0 }; u32 method_id, retval; int err; =20 @@ -772,7 +772,7 @@ static ssize_t attr_current_value_store(struct kobject = *kobj, struct tunable_attr_01 *tunable_attr) { struct lwmi_om_priv *priv =3D dev_get_drvdata(tunable_attr->dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args =3D { 0x0, 0x0 }; struct capdata01 capdata; enum thermal_mode mode; u32 attribute_id; @@ -835,7 +835,7 @@ static ssize_t attr_current_value_show(struct kobject *= kobj, struct tunable_attr_01 *tunable_attr) { struct lwmi_om_priv *priv =3D dev_get_drvdata(tunable_attr->dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args =3D { 0x0, 0x0 }; enum thermal_mode mode; u32 attribute_id; int retval; --=20 2.53.0