From nobody Wed Apr 1 09:59:06 2026 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3666144103E for ; Tue, 31 Mar 2026 18:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774980741; cv=none; b=u2OikLYpBkA8gLMc53S1YVfm/ssKZXE0FbKdvDdfLK789iXNPT/+DFhuZeYJ8rPQyMxWvlVNr8yUAXoU3473cmp8CkVFcGbLEzm5QH61ys5HLGwer+muXCpTNLFa6ZGnldcKeD3CVfogNJpmqJqyxgCRxrIEpXjvWyK8SAyhEkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774980741; c=relaxed/simple; bh=J2zxJ7C+GNkXVIUXkPrHuyFtscPSA93mW9aVv7nagRc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gUV5JmlvuJ9orwWwc209bhWyM26dMjFFTMfB2XWjhtOUgIiVkQuATCDCAIIIZ8g+3Siom5BeEDBqcrQdJdG9CX+wH02m4/YnQ4XyVzri414lKykNYQ7Q3++w5AqpEB3o4yFCs11RFnJBzVGG6oF3aF4T0UpTCsYrifsnQIhsDSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J7AuMC8G; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J7AuMC8G" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1273349c56bso7547630c88.0 for ; Tue, 31 Mar 2026 11:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774980734; x=1775585534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P3641lkktESWwCBSxjQBD8OEf5aGYYIhQ0zHdhHKYoI=; b=J7AuMC8Glh+4yNJWxX/p8vLrJ2l20Kr6mLQb2cEDi7B7x9CPprME5jQSy6jM0VlGlv JMcmC4Vfn8WIyyBMRbv8z872EOFZcBO1x1AZOD49wCm/mioh31lXBbz2IaZYu1r51b4s nO71NxPBS8WCIYueHHVzw6qGj3g0gmwas22/X56w0JyS0Md+ARm6MCGtl4I8KsgXNZaT TNm75af6fZ0cojRWUahUTO6MR1BnxgLbDzB2l9mYE9hx/YsPagkPVDCK///zKJcjRUDe tPFFK64JXhfjmoXijo7WhPMoGM6DcS0gl5doFItI0cw09H4tvo/MZW8IHflJrNRgbTV6 QTgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774980734; x=1775585534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P3641lkktESWwCBSxjQBD8OEf5aGYYIhQ0zHdhHKYoI=; b=M4wbKo5h0JTZzfKA54QHA9s9bKBzNJzbIulrmtnRUdlRmyOIdqus+4674xE/MtTFJK up6GChtZk1UlMN6oUlWWLAAxrwjkJb9dAJImUsIi+PfZq18Ilf63QMKWrjndmQzl5edl oyu3vrgXX2U/6V+x6XrvRp/W4qgYyypn853LejdpAfO9sxDlEuQ/oHCTYTuKQG47qlXb +OHxZ4ASInntfGMMrokSAm7dS3eEWdA4AeOh3T7TrPmu7mW4pNuVuKfFqoN18QH+xnvZ gU/T6HDeQtQVXMQAPbAnhOWNTj88haZTovRPdVGQPqQ//AKXvwR2icMEwUBRxTK6QaLS aN/g== X-Forwarded-Encrypted: i=1; AJvYcCXbZRaFBSBJYYPq0jCH+Lcl9G0WlIBtINrfzm/wMinAYTOHUjlELOTAmraeH67bZeMuYzG+lOzFwtMjj34=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4a5Di069LzeOPXv1DKivVGxtV7HCL5LYPAvsP5yWFK4OUZ7vs vsdtEe+WxuUOm6nagwg0TmB+yYunCoiPV5tu4zClZbUHhBOCQXU84gKg X-Gm-Gg: ATEYQzwpnIEliBI6Vx4WNLpQmUsgu+EdGapvYpv04etxetEoBmnDgntX+dADqT6k5ZZ 7gtKTbMJHQZHbC6WFX3dUzFOi1Gttmxr9MAPw7A/9UEmKK+wAU6oa/0fRTG+EeHVjZH7qnG4M9x wEQYX4Vsu/vgMBIQJypUcccXE8jbUc6zW/wLchnTHTErJoYTTpP6PfFNF+mXP3cWaKHrHSH2Wgb wpPu3H56IOfDR33/S4x4sSva9xrIM0BFyNef0f2CY/2RbjF/QL3ophxFBs71VNhi8iV6ZwRG+4w gy/cJ3mT9hAI45S2XK9iMncNPwKJVQjTrbmdXTMs/vO2pQEG+RKYQG5SxoSg+EJcJKKxYvJt033 M32LGR+50F0oxmQqgUbROfEdtADNKohDSeQvb5g9c/ZyuL+LpI9fmrmK2cJukM8LJCIx7FY/NHs i8sHUpaKn025fI6LyTxcVassqvnRebmkaeTfO21IKmBt8CLpAqTBmPbzQfUEMKrS6RHzivRG3LG VXw X-Received: by 2002:a05:7022:684:b0:128:d1c9:3633 with SMTP id a92af1059eb24-12be6438028mr305733c88.13.1774980734014; Tue, 31 Mar 2026 11:12:14 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12abbe21787sm10769272c88.11.2026.03.31.11.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 11:12:13 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 02/13] platform/x86: lenovo-wmi-other: Fix tunable_attr_01 struct members Date: Tue, 31 Mar 2026 18:11:57 +0000 Message-ID: <20260331181208.421552-3-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331181208.421552-1-derekjohn.clark@gmail.com> References: <20260331181208.421552-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In struct tunable_attr_01 the capdata pointer is unused and the size of the id members is u32 when it should be u8. Fix these prior to adding additional members. Reviewed-by: Rong Zhang Tested-by: Rong Zhang Signed-off-by: Derek J. Clark --- drivers/platform/x86/lenovo/wmi-other.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86= /lenovo/wmi-other.c index caf360b76fc5..c1728c7c2957 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -546,11 +546,10 @@ static void lwmi_om_fan_info_collect_cd_fan(struct de= vice *dev, struct cd_list * /* =3D=3D=3D=3D=3D=3D=3D=3D fw_attributes (component: lenovo-wmi-capdata 0= 1) =3D=3D=3D=3D=3D=3D=3D=3D */ =20 struct tunable_attr_01 { - struct capdata01 *capdata; struct device *dev; - u32 feature_id; - u32 device_id; - u32 type_id; + u8 feature_id; + u8 device_id; + u8 type_id; }; =20 static struct tunable_attr_01 ppt_pl1_spl =3D { --=20 2.53.0