From nobody Wed Apr 1 08:16:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5A943CEE6 for ; Tue, 31 Mar 2026 17:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774979010; cv=none; b=ugia1QM2WbWXbmbcehiQ3cKR7qTV4BtRUSLrF6iimJnuoM16u6ZfQ+8LDQXqKDLCsXC538iYfXUqh1FJQVQ4cxU5VqvR7J5kDpBkeRtKk/Vx+Ey5uo80/wruWKr1iPljImpZzM1Bw8JZ5L/ELsKZ0p77vMZfGXAPRIwablaZGyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774979010; c=relaxed/simple; bh=V3Kzji++uDxbHo+Mh/THHG8NP7IgwKgSw/J14/pRC8o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LN39OSeyHlX0+bhVwoAbxELwlx9DQbqpVedURHl05I4nyk426TCD9QyWeopC9x4noMKVBIpcnKW+LfzkLibKabB2lH1SVWAH7NdMnuC3zXbw6xGqoBVQRh+K8veNEDp4iAiwtyIGLD1h2MMIpL5yqMYQk+02syuRDjpvU+jz6Nc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O/dFHC0P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O/dFHC0P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A6C0C19424; Tue, 31 Mar 2026 17:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774979009; bh=V3Kzji++uDxbHo+Mh/THHG8NP7IgwKgSw/J14/pRC8o=; h=From:To:Cc:Subject:Date:From; b=O/dFHC0PGh9/xb6tDzuJOmw+SCtS5QfCR+HxPHK5BydWr4D8ryUAAlHXX47BxNrKz +Hlkkm2YDNBvbW+bjia/6jKzVTpQEdgQW7u0mohJkOoMLv08qKWtidITBUcLRFgWpO fz1PWwMSJ6zAsSIEtJ4g5LgqBnhL5B08EvCimW01y657ko07OxSdvuT4/Et5895E6X /9cEgdSGouQ8g1qNKjLCHdXiP2AejaDS3GWJOASgzJDD+m63Un0o2uEJTdv5nC9vz8 Ihl+oA7vujf7rROzsCQSvk2UlNKrtJ3mzBmFbP2x7DDV74IFuEMBnx4/YZvul5eaR+ HFkw82b9T5MjA== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: allow empty mount string for Opt_usr|grp|projjquota Date: Tue, 31 Mar 2026 17:43:26 +0000 Message-ID: <20260331174326.231867-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.53.0.1118.gaef5881109-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fsparam_string_empty() gives an error when mounting without string, sin= ce its type is set to fsparam_flag in VFS. So, let's allow the flag as well. This addresses xfstests/f2fs/015 and f2fs/021. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 5330ef981340..aab4345f3ee7 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -337,9 +337,12 @@ static const struct fs_parameter_spec f2fs_param_specs= [] =3D { fsparam_flag("usrquota", Opt_usrquota), fsparam_flag("grpquota", Opt_grpquota), fsparam_flag("prjquota", Opt_prjquota), - fsparam_string_empty("usrjquota", Opt_usrjquota), - fsparam_string_empty("grpjquota", Opt_grpjquota), - fsparam_string_empty("prjjquota", Opt_prjjquota), + fsparam_string("usrjquota", Opt_usrjquota), + fsparam_flag("usrjquota", Opt_usrjquota), + fsparam_string("grpjquota", Opt_grpjquota), + fsparam_flag("grpjquota", Opt_grpjquota), + fsparam_string("prjjquota", Opt_prjjquota), + fsparam_flag("prjjquota", Opt_prjjquota), fsparam_flag("nat_bits", Opt_nat_bits), fsparam_enum("jqfmt", Opt_jqfmt, f2fs_param_jqfmt), fsparam_enum("alloc_mode", Opt_alloc, f2fs_param_alloc_mode), @@ -980,26 +983,26 @@ static int f2fs_parse_param(struct fs_context *fc, st= ruct fs_parameter *param) ctx_set_opt(ctx, F2FS_MOUNT_PRJQUOTA); break; case Opt_usrjquota: - if (!*param->string) - ret =3D f2fs_unnote_qf_name(fc, USRQUOTA); - else + if (param->type =3D=3D fs_value_is_string && *param->string) ret =3D f2fs_note_qf_name(fc, USRQUOTA, param); + else + ret =3D f2fs_unnote_qf_name(fc, USRQUOTA); if (ret) return ret; break; case Opt_grpjquota: - if (!*param->string) - ret =3D f2fs_unnote_qf_name(fc, GRPQUOTA); - else + if (param->type =3D=3D fs_value_is_string && *param->string) ret =3D f2fs_note_qf_name(fc, GRPQUOTA, param); + else + ret =3D f2fs_unnote_qf_name(fc, GRPQUOTA); if (ret) return ret; break; case Opt_prjjquota: - if (!*param->string) - ret =3D f2fs_unnote_qf_name(fc, PRJQUOTA); - else + if (param->type =3D=3D fs_value_is_string && *param->string) ret =3D f2fs_note_qf_name(fc, PRJQUOTA, param); + else + ret =3D f2fs_unnote_qf_name(fc, PRJQUOTA); if (ret) return ret; break; --=20 2.53.0.1118.gaef5881109-goog