From nobody Wed Apr 1 09:00:06 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E88841C861A for ; Tue, 31 Mar 2026 16:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975489; cv=none; b=tbQ1ft6ZrQlYphPYv6678De3lYB2f7sp9mxpMEg2bRZpVJnX3HAYFSlfQMIfIZNOs+szAAk4rjfSMGrOZca0YWN5YGO3gzq65o4wo82rFuOr2eYnTypXI2i+Csb7hRGnel0Ld1bzncaktkFxTKOLlISCN1Ils1EdSikLW+C0h1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975489; c=relaxed/simple; bh=wAAzvbppSXnpSZR9uf6b5wtnBW+eH8zJbzPykDmGAW4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Q8zQ6BLdwSFr8vq8P6zAymmoGlPOqYrChT2PxV/A5eRnG/C9z3aZO2bISUcg/Ul2Xo5Z00Ow37deKcevdqrvemMTk87K/arHLps43hpN9Kdr5BGSJvIJczULsUePVBS8LjDBk6Dwc6pqfR824mbm4qPho6dDFcnvGYFBHfXr3a4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V3xJkoCT; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V3xJkoCT" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4887d4c6234so10839315e9.1 for ; Tue, 31 Mar 2026 09:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975486; x=1775580286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QX2plK9fWTBnAWrRTur6TjhAEBGR23mNVxFAED1Ph6c=; b=V3xJkoCTnHXEsWQiUWnnXkW6dHP7ghNz6AavIArH74UbRIEn+E/qQDYMBM9Sa9SS9p gpUrfW1aQGisvOKjSgeR4fOM0p/7OHp72D/nRlz/xPMBrXqnLPPw1Hg7fy03NGFcYqKq 4WxpAiQLZi0c5w5dy39m4//XxfIpMX61A3LxFngS2L4OGNbvSuijc2AmZvkvqiNDIPW/ iaerKPgNKpeqhwnlFZ+Ump5d/6yjJ6VvKb/Cynl4swQgcViASml+qlB0mJEPyth50j2s l0BQWrXynSMm0cBFKQdJW3gE93oAOQ/dsmTp87gL6olDE3SsuzkqAZ5TL09edPJU7RWU BVhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975486; x=1775580286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QX2plK9fWTBnAWrRTur6TjhAEBGR23mNVxFAED1Ph6c=; b=jWWgg/rTv07L4CdSIAgB9hSFFcqBHL0GMzg5qvVEn8d2+ICQn04C6gOG2S7znAjuxh 7TiIP7fawsyB3VG98Cfyyvn7fLwa7JhDWVs5M5Eni9bcaL8nirHXngHkmQ/+ZgSGNVfn OLZ/9A+grDVGztLVgoYydZzHVCr+h24TGonHVwOb/WKq2u3D6bxi37fA75L6sYH8cA/A N52PFZum1/H8ejIt/E/SRoJP2na8imr8T/iScXGTbTgjBdi8j3WIjJI0n+iT6dQlH88q oEXfPgj8ZmQ1baIwxBSkZ7JvTZvjcafweEqB7QxTxLBbozI/MFnhxCvkK3ZbUyAoiRA2 6//Q== X-Forwarded-Encrypted: i=1; AJvYcCVY5WSVfKZOAiWZjhXKuqj/HmCZRPLYHDQaISQi0XB8NA8MQikM7qEd8ypfVr1nTbnbHpH+5E7oNjC10hc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm+4EqlnUiHPF9VzROFo3uqCcWYf7XTWOEaZ52RA0kmFVRsprv pnLd/iErcm84TqpLdTZ0Wn3pMcgPGNih8FbK8DSmyx2SR3CjmJ3y7CaZ X-Gm-Gg: ATEYQzzaOyiM5pinAqYoaClMCipofHNCkZKDKl/Mm+FsReiuJWJbjbTumqrkfEg0rCI ecn6yXjvolHCkVE5t7erow4fk9X+vKMp3j743qyV2BAEcTLrfJj0CXSWBlYWDZNkW3nVBrZZjQw eGqkdVKFBZQd5lImwbrh87kRyZRUMDzLkwA68QqX7HST/01DWYNG0pds37rAE3x0aR8sqY9DZfC a2BLgMhVSo/lXjvTuhT8MK6T7vWF3YfgHcguCKB/oxNQ2ycRKIt+VsKkAvZnHiHnWdCNmcYqpVy CZKy5tH/CAMN5NtrFcwksr0pAwdwweESAwRuvJhz7H5CkmfJD9OHnXru+jEZEFidF+Hv/6Uy8vx okzaia9Dyy4rehpXVkYhGQTZrGl2wV7T7IrSGxXzt3h+Lv2oo02QXlvx1SK1v4MZ1/+LjdEjr7z TMQOE+Ya9G0olqSOKMC2JkPX7AQYyl50lyoZljLQiF3Kvdtf8W8pgk X-Received: by 2002:a05:600c:45c5:b0:483:6d42:25c6 with SMTP id 5b1f17b1804b1-48883592213mr855675e9.23.1774975485885; Tue, 31 Mar 2026 09:44:45 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:7962:f026:60f9:dfb3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822227sm53110625e9.4.2026.03.31.09.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:44:45 -0700 (PDT) From: grondon@gmail.com To: gregkh@linuxfoundation.org Cc: error27@gmail.com, christian.gromm@microchip.com, parthiban.veerasooran@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH] staging: most: dim2: remove unnecessary NULL check in service_done_flag() Date: Tue, 31 Mar 2026 17:44:42 +0100 Message-Id: <20260331164443.47682-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Remove the !hdm_ch check. hdm_ch is derived from dev->hch + ch_idx (pointer arithmetic on a struct member), so it can never be NULL. Keep only the !hdm_ch->is_initialized check. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/acuoL4DRi0pmsQY1@stanley.mountain Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 7953d4626..f5bd7d44f 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -271,7 +271,7 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) unsigned long flags; u8 *data; =20 - if (!hdm_ch || !hdm_ch->is_initialized) + if (!hdm_ch->is_initialized) return; =20 spin_lock_irqsave(&dim_lock, flags); --=20 2.33.0