From nobody Wed Apr 1 09:46:29 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 294B7425CC6 for ; Tue, 31 Mar 2026 16:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975027; cv=none; b=u/6uuy/NYsrAmYaA7myJ3nfISisjq6DWd0JY7t/GewYMSef8PF8vrIBOx9cFbO3IBO//V+N3PUk4pRBeopTiMT7mrY+a2kkBy4M+i9dtuz7MOmdOPAXm9+ht93Rk7280fuKjVf66csCvBwE4IxKoKtlZvAmkVgeZF8tJeACf9/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975027; c=relaxed/simple; bh=PHs3f/gaFyYReQoQxx1imm6pw7yPcVpOTvcve/so69k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pKL/+KbVe2qkD1Zb3DqWU+TTZMDOJOzRA72ZjDaJbyR+wl5hdhtE2DesJKP+A7EeHymaSwkFtJpu2yQMH0RoH39xYc3iWrg50X3J3uDF2Ms3GKNPZ9zHoKSH0RQzGPhp2Qnuq75Flah5Z/8HzKvnlFKA9tmTSD2WVI6AEWrWCN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VN/C+NPh; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VN/C+NPh" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35c124d2613so3796255a91.2 for ; Tue, 31 Mar 2026 09:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975025; x=1775579825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/w11NnTydmVHrODXF8dcnWWEar8WU1lyFFID+3qgjWY=; b=VN/C+NPhP50wiRdw7USUtakUrAOv9Vbzsr5hsZDpZ9rc0Yay+nEzmFkO4ATHz+wXkV 1dt6JxS05KjpLlTsKQCbfCnQSgPVGyY+WDTMaXrnye+IKbmjOVJzNTrF2mjld1+EvrNe qftcTd/ojITUB8myW6QtHchPbEx4NhGEEJcV8/HXgS21emp4pAaEZBx4vRLdQDNvFkaU 9E7uVKDWC12pIuANpM7JNz1RsOF7oquqxuBV2G0NblP1ugL1xwa+68vJLIR9BdhPNHDj /5yUVkveTDdoT+90+smCHZhch7237gMBMgP/TJRO6wAUu8xBmUV62cAIkiq2GKrPe/1A 2Ffw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975025; x=1775579825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/w11NnTydmVHrODXF8dcnWWEar8WU1lyFFID+3qgjWY=; b=AM/0i/uj2S3/IV3VeH1Jv7xDnPpff/uJ0MVJrUKNy4fXc3xbpqAkLD5CuB8Wa3vx0x s5lSCAyg3SbwSxLkHb+ABcJaEOuHaWRBOxtyPyJc/55EOvjTncEW6+J3JDxC99yv9RSn NkYRGmfrqNQ2EVvxwdzYFXq26Qk8ySaY97ZRv/pWmHZbdic+wfaB2ryT2sGLU4n0nOv9 VzxSkiyoPxxXI5eGC+hSkgQvuW/eKw5ohAv8Y55H74FkIlZh6ukRHCb+ofUzw+e6zA97 AFLjZ6CZbgUmaNzxNQaboxztVtbfBZFSpdJfsS34XzPZKrYe05cBX6qvBGahCJWXyF5A 50wg== X-Forwarded-Encrypted: i=1; AJvYcCXTz9Vvct76BLL6Oz4b+6QWhktVF43t01mRB/wnBQZmRAmj4Ox7M46lgZcMlW9SG4yNdq1k/aEGcKI+q5I=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy2liR4KqwoiSOmMTEk+hoahAGIZufzQ/RuAAIy0vnGWUwiqkx CeNHAuqOXtjBWFA9JrTHnZI0fKvjr8cHMwyA+tZKJbYCfwt0X9CJw9eR X-Gm-Gg: ATEYQzzIi7EdFySifsLgPFH1FkwgipAYjAjYSGmAf/q75sqRGO9uzD2HRREL1FpdX/S STCBFYtzogdjAyV4Ye+TYSrcKRw+AVQE8Akh+LR5hvb1zmHtWjySw3KfLXRpI6YBrgDCXBDhph4 Se5A+RAC7eRQHFcKx4Hs32YMGEMXIXqom15VwqqGAwhwelwHq2Kj8UGSNlauAgTFxQ8BCoA+53M J37Xg6CO9AuVf2ZNaV8VAaE0pKhhUd8MIu56R7N9XKzjIumenAmih0CQMqOycNTdeZjiZLOKZu4 aHm4pktHEnxzKRAbMwCePrJdex+P+zdYbbKjP2AJ0J9aoQ0QMphVtNfB1AjBT/LtkH3SAhh1imJ AuW4pXdJihpZqC7wReGwUYElFhIs7i6WHi7/+8QrdpdY16qNCxatAnectj9lLMBcl7XBPiXjgim srSDYOBJ0cvwuG4wiqyz84gwFRxK6t9cnFZqqvig2f4lk5TJ/4 X-Received: by 2002:a17:902:e885:b0:2b0:663f:6b53 with SMTP id d9443c01a7336-2b0cdc9b555mr175094965ad.13.1774975025211; Tue, 31 Mar 2026 09:37:05 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:37:04 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 4/4] ASoC: Intel: boards: Log error code in MCLK configuration failure Date: Tue, 31 Mar 2026 12:36:35 -0400 Message-ID: <20260331163636.15238-5-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The dev_err() calls in platform_clock_control() for the three Intel ASoC board drivers do not log the return code when clk_prepare_enable() fails, making it harder to diagnose failures. Add the error code to the log message. Reviewed-by: Cezary Rojewski Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index cd611c0da4e1..a934b3684347 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,7 +285,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index e2f59a008b29..3c5082034f5c 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 0c2435edbd08..016732a57278 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state: %d\n", ret); return ret; } } --=20 2.47.3