From nobody Fri Apr 3 08:25:42 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0C73E559E for ; Tue, 31 Mar 2026 16:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975022; cv=none; b=BWQrWzdDS6KrZgykkxIe7ghn0GLI4bHgh6caBXy7u/O7I5qSiuVOGD+XNnqGSJEVkZ/Ha0cEobcBYJ02kF4OGxZzljbrjx0bYLQ62OX0Js80mQCPIL5azYmh8PRuz57Ku++fmXh8CD/kqbWld/n7B5z2VNCt8JrblQQkA2d9TbE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975022; c=relaxed/simple; bh=kvDk84lLFYP8LAteXHHmJ4uqJy7hd+l5iP9Lmix/xm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IYStEkOFARQQKCYu4/ciCCSyp9b8wfz3+gb3qGtOJEYNgzJOUVY78vnYuXGvFaVw4ptku00KcJQJ05l22rWIiLVMOVfWpE9c8ZM+s9F1uaw59NkACANiEiPMst09Hq15p4CnjLSoILLM5vJeQnzNpLHbX7TumNk2bjHr151H/7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UE/5pMRl; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UE/5pMRl" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so57294675ad.2 for ; Tue, 31 Mar 2026 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975021; x=1775579821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NVf9jSL3Fmxnja4LNdILqrHoUghzjihR7HFJHimyh3c=; b=UE/5pMRlLfbos+qgHW+xTNWkWrLG3e2O/7rDGYfUIxtD4j+pTULvs/BFZo6DizZKd3 AaMxTMHDVWlxieN9pNhItdjc+ezKoRga725L/zQk1YeciR+DdO6IqIoivOnUAWLCWLoa jkrjIPyZBPDb7/YvrPH28xFearFpLBNcbXuYGUzuYPgXWpHwVuKqor6TBeL3qH1Yoc04 g0n6bT/BjZDEocbrxP5LZ8HsMdaHv7D5zjnj/VzD5smWPKGvkGZhXFKs2Ujy6RlBJoVr SZGgAFZ/Wc2g8M/C+n6hP1bzNibuGb39aYCb3a1KDOhJXTXlXyFhlJDiaW4c7QO34S7/ VR4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975021; x=1775579821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NVf9jSL3Fmxnja4LNdILqrHoUghzjihR7HFJHimyh3c=; b=OP/fc5uC54F6ljMdlAugpTfhW5ULFxzvILPXHPRkEn0R9FJHIy8LTI1L5I09tPRYQK FWq8M6oLS++0lJqeloT3mN42kQqYTuRdPeHAvG200CE8YXHyZt4Hq1UJiR/egTdegqii KTMAApI+gJQpvfn60qHMQVnhcSSrKlbXk5wzWmU9YCYfKyt6tcQDaLSzYNPdxdALFye1 5RH1A1MhxCHz71n7Jr2dC3uYD0D2YcqQ5vH51PJHvBUEgS0XKNG9MkyeRmbEFlOBDm6+ o1Ht0mAUuUMpCKMqVxWdX+VoVCcp3OjtcHvxDPX0D0Xkw3fCqPGLDSBkr88qCG3nIYML x1LA== X-Forwarded-Encrypted: i=1; AJvYcCV//e/MJ0Z08SRJ2iBSmdHC0binPS3J/BljYavojEfShIt9bc+IuhCQaqAw+CZZaTXpNe+NoLyCVp3Y9xM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2+hwrpk5s9aFoKfQAjb2qzia6HQ9p55uOtrneiMIW6Gf8brDo H1mwtUZ8w0eVRoxWyLKpxvzpQUFEAXRVjmBBtSvYQ2kiUJXdmA/Z+ANB X-Gm-Gg: ATEYQzyTEuWSEKCLBtGbLVCaDcUruV8TAdh6ZCuIP48zRw7Cs2wr6i9YPyz/1yTheRL an5j+EWnSTFMzSA/zsdEeeQyKw1j1soBWVewdGWZreyJ735jGY9hNqeQeyU/qT/Q8BslVe3xNmX cmNqHif5ND0zOKAFgxgWigtfGcvUUX/NLL2UYoSUfLm0zI695NBvWrs2ts+vhMbfNe/2q1u50B5 KG9PJrX/UusYV+inLSucrWQs+ktydViuvL/0HBPKCTkcwaxKW3Fd7OH9r4aomlhk5O3mcdVDC/V Qg23NPUKzwyZ+RnNXfWr/BXYXzbNgVOiHrSTCxUwE5VVxyc0zjkBaHHzSRk0eGuqfMxWkXfgcGw +r/KnT1WlPPe2QYsJH+kuD39vK+D+5TgGEjeq9R9e47ITOqLPuifwc6kCICM2jQ7T8s3iY1HGgx xV4KaENjmU96KoLkXNEFn63GWdxzw8GYxzQsCSDKGAsQdlmHd4 X-Received: by 2002:a17:902:ebc5:b0:2b2:549f:7d2b with SMTP id d9443c01a7336-2b2549f7f50mr82756595ad.11.1774975020649; Tue, 31 Mar 2026 09:37:00 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:37:00 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 3/4] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Tue, 31 Mar 2026 12:36:34 -0400 Message-ID: <20260331163636.15238-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Reviewed-by: Cezary Rojewski Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..0c2435edbd08 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3