From nobody Wed Apr 1 09:46:29 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E8023E559E for ; Tue, 31 Mar 2026 16:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975017; cv=none; b=OuNrVaSqkziffYOTFuY4R0HUJGkomqmBCLycwGOibOACQN82AI+1Jlrgz1JH4/wQyKDT1GKhIiMzNPk8OeD76r5NECXQgW7D0JJrKS7MX/rzrkvuTpHmmlNX8tPiWSP5+q8/3Q2k+FW3u5dOrcgeB8MwXBzUhpBV747hDVinpKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975017; c=relaxed/simple; bh=cbJ9/tet7CzfKxXA0yxXN6cHWGj8TOdzJxeRIK+7mCk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q02N6GcL2Z5baeVkeg6XCYw0e59WCkGfkDJzUcjx3ll18+h9kFKE058daev5BEBNL25rGCiia4eh4859kEzX68uerIdEmsusmwDay68loejocd79yhEdOKGQ26iFEt5wiMtd6B2mFvq9CgSkWgMIgAud3fG6ZuZoSQIHiOOVoaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g/pB2b9u; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g/pB2b9u" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a9296b3926so38470205ad.1 for ; Tue, 31 Mar 2026 09:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975016; x=1775579816; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SD839RbG5ZBrMZ9bhOhi1yt6xxK+tKautdFVEVaG3C0=; b=g/pB2b9uzk0xRVqlBaxNTloaEEKxaAQzzxrB+mQoplArwy2jE3OKOpQY7HkupqBGQy 6UfIPDaTlFLPdiPU8b/A16Ndt0b/tincxD0F/w85XlMRispdrQjOzeZasE5BqeEYGhPk VDgjr2i7OetNCxkwVekE5w434pr7jCvydXffQLP3z3md/EZ8Bb916Q6eMrA2bIFXJ3Su U4dKjWjlPtfWDE2enn7Jm10vher7MErMgbSy5msUfnE5XzftQNFqBL9ygHXQc2epydy3 eC38fd/qTBNSyA3o4zhoL64pz4AswPjVkEHUNgXL5tskOL2Bh5inikcJcbR+obkMSZBv HpBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975016; x=1775579816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SD839RbG5ZBrMZ9bhOhi1yt6xxK+tKautdFVEVaG3C0=; b=CB7Etc6jBFrAkbrC26OjzJiQ6m1DbIDGBOxnNuAVuvgu/utOj8Yteg8UYReOOKjele 9mIeigDidFuJGqgGAecVvC//vuUP0DcdplDtnVutPwA31SrzFJGgyi/YMvp8bQhjDk8u 6vjhmzv+oVudjtlyaM8OBlJzFI4l6n0DWYaXf9akWkgQnPu+fvqs99OWM/MJ917WnNpg 0RwmnbvQ6O7K0DGe3yQZi2pKPl/E0n6Qji58KcVJ0GLvKB0OKDVhKsrMbRlcr17jqQEH X0RMy8C7mcaSlEnOOhk5vMWGc0NqoU4PKttKuca5EticpMYa+rc3yewOb1zKxzo5fl7v sRVQ== X-Forwarded-Encrypted: i=1; AJvYcCWW9j8P3M4gonvZ/2Ddm6RVntEqxy60eGG9Ei0BNidIHgryyvXSGeUNh0pH3UBYitN9JzC8EMCLcUHjYBY=@vger.kernel.org X-Gm-Message-State: AOJu0YyRb9FnxzxFggRxbM/bcDU3IPB42iqnGcCz3xmREg6Mu4ubbIg9 j0F8GLb2wurTLqa22j4M1wBn3P3sdgP8kutorcqZAwpg5sB64pVaob9a X-Gm-Gg: ATEYQzzvrWIRdLvRgzg/QK1+RZtdrAcKwdkt0mx9VyuFJQLkMdRQ15dn6VLq8Pt+Hed 1hpnZHiypv2ss972tGLmfcz6OOs/gGFWEJ4emR48xcMLwekTXrqDMwe2RN6C1Qu3KLycd1bhK3E L27n/chThe6Cz2jaVdYuxmQacSm88IaqH4BDVqGgXHTA+oVzkCGbF5mB5YPJTxsoxlHXf5oa2Qy DBBFCk86rpsNzkJ0kBcOIqJz4dWg9IbW9r5+F0TDqyC1I4GE6KrFjSrZw17LzwGlo23bM2IEL9R Qdb1tFaHDctkxI+x6CewS/lFF+9h4vQ3KdrLJI0JJK1oJZ6lOOflvMEYrZN//XB7d7eR0osgytS O9J6mzGW8zNGSoGZzzBSJpwecacf20RpiEXB2qnb+Og85cIlZdRHesSjMKCcQO3hVFN4mBUFEyK NII44s2H5KmlxlWMKKVu26z2Q5G17NC6o6QuFZ1Ld6QcQ4cowy X-Received: by 2002:a17:902:d4c1:b0:2b0:71da:4ed7 with SMTP id d9443c01a7336-2b0cdd3ed57mr171864535ad.25.1774975015959; Tue, 31 Mar 2026 09:36:55 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:36:55 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 2/4] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Tue, 31 Mar 2026 12:36:33 -0400 Message-ID: <20260331163636.15238-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..e2f59a008b29 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -209,6 +209,9 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); + if (ret < 0) { + clk_disable_unprepare(priv->mclk); + } } else { /* * Set codec clock source to internal clock before --=20 2.47.3