From nobody Wed Apr 1 09:45:45 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF582425CC1 for ; Tue, 31 Mar 2026 16:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975012; cv=none; b=P/IdQPEengpWeUHWMMr74nIKRns67SNbpHlcObWoB+CoftSBofpNWzywo/u1vIOrVwiRSVa2jToxpOSQPV5izJkz9LxBoP/V0ziJUeqmTv/SMuV2qPAkNAtiZPsgT5D6sHjuAduUEU5D2h710Qql3LQ/jVDL2CT23MBePtRqBjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975012; c=relaxed/simple; bh=unhbzcpYk597C2G00Db/mvN00cDQeTpFowiN+h3Rrww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i48Vex8g2PuNHMA0bskpybKTJjAqkvpj8byXMKe/FC9ZMlBcBPvVIaZSlsEhRMGQtl84TriOQXpoCb9Pb5IOCIoNX2ui8+eKIRBgLnuvGJbSco1occiSyRI3KUyh7U35RCxtd4Jpy6cQquEJxPj19ZWq9JJfWECdJ5wc7VHk7FA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D2/hPJlb; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D2/hPJlb" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35d8e548a05so3983141a91.1 for ; Tue, 31 Mar 2026 09:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975011; x=1775579811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3zYgkKc0haN8z/URfP0RW5IhHtINqX0yhqpPrwSnH5c=; b=D2/hPJlbUydAJdlkAadR8+YRYxOHANX6aOswYqgBlJUrtDC5v+rUklG8BlaOzEMERD whSr+b/EWHOyGv6KfgcRiJ7Qkq8ArpGiHE5z6+esxnlWp1vvFAhM3D4mjGeC9jQMZHsi QA2WhlOFy7StDfBm9bmcHQYuHCgAxCpCc0pbDOwlbTb+CxGA3w+zv/QKhoeCNz4u70ix UuA/LDOHtEsfXEcLvkGNWrKx4Me5oTVkKVYUXGWSpvvJ3bLKkGw21hWZftw4+BhvdGoT JAx+m2+Qxp9UZcge/Lf4CE9o6hbWZSq1NyhG661IMZUhcBmcluZFEwxp79axxsb60555 sPIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975011; x=1775579811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3zYgkKc0haN8z/URfP0RW5IhHtINqX0yhqpPrwSnH5c=; b=UOY5W6S9sARZhZViVKz3IWR+Vq4vr0P3Sww94skKdB4uISwglfHowF939d8K3KXEtY Oi0O55nfaF1U/ffGKjmh46ViJcVinqxGJQONBLPHMETcJDgzDaY62EpQOQ99B3K4N9kv KOfmt8m/xOzp2U6xbHV5A+iCmmqL1CfSkzbohj4BQ0TP9647x2PvZc+n8tA6XTnPCJVY pga96glWn9O0N3ZJBWJnRl62dGaxbIy2YrMwzHZXYu/+y3NNm7/oHacM0I5fDh9guxly PPaJl2LBYmhLYhx5AzXc670IYyv5yr5JGDbDUU2spi/fu5vbOiZxCD8Knao9t65wrcvF Vs9A== X-Forwarded-Encrypted: i=1; AJvYcCXCzsUyeX52f0CZlDPa3tLfhALomC0pItP8y1n1aXIO0WAPzKlBbE3Kb1CA2l6/B7H0QxMOHlr5yH8ddIU=@vger.kernel.org X-Gm-Message-State: AOJu0YxW4Qr9BEdmixIhbT2AacfH7HnqO2dyYX+Y/lYkdCkGib0jmvY2 rSQZRpuy70B+MfppIPseeBfszvHu6qANtOy1F7m6btjikVHhk2eZelIAyo7yFeBR X-Gm-Gg: ATEYQzwKN/Uz5La726kcP+8FWAG62r2pOPPhKOfRD+2hjKO94MQtNyCBH+g/gGV3dd4 XdGljSNiPn/9xaW4zNtd6Tt71wminshXPZmDBnaPdg5nWPRRp/rQYSoBVyZP1N2b8PsVi/e24jY CILX3ik0McrcU/VHR2VKNok/Mvd9PTibjz4CiG1IxaTOjkxugTeKnTIz4CLmtY+L2choWtR9mrz jEf2hqqP97U31uJG6T8i08clqrbXRK803xLVVbrjgYbG+G7ayXYcPF//ZTz0UKHG8dV8/BXB1HF I/k/ia0phshjUonx1QRwdV7xW1MQghxmcyCZWI9AW4TjooLv9VwZUvxDnCrOtyPp3L+KA/kmzb1 7KNnykN0YCu85uNygwuE3GfkblZOBprR5wTIRQCV/fJsC2AP+70rUYt4oyAo5d78xxDKAMNO5z3 JJNpWBTKvrRlqgcvGHdPeV735Axru6wQcN6uRyI/gN+iiyB9q8 X-Received: by 2002:a17:90b:268f:b0:35d:a9bb:1e33 with SMTP id 98e67ed59e1d1-35dc6eb9dd7mr26447a91.11.1774975011066; Tue, 31 Mar 2026 09:36:51 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:36:50 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 1/4] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Tue, 31 Mar 2026 12:36:32 -0400 Message-ID: <20260331163636.15238-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..cd611c0da4e1 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,10 +285,12 @@ static int platform_clock_control(struct snd_soc_dapm= _widget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state"); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); + if (ret < 0) + clk_disable_unprepare(priv->mclk); } else { /* * Set codec clock source to internal clock before @@ -303,7 +305,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, } =20 if (ret < 0) { - dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + dev_err(card->dev, "can't set codec sysclk"); return ret; } =20 --=20 2.47.3