From nobody Wed Apr 1 08:15:50 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF582425CC1 for ; Tue, 31 Mar 2026 16:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975012; cv=none; b=P/IdQPEengpWeUHWMMr74nIKRns67SNbpHlcObWoB+CoftSBofpNWzywo/u1vIOrVwiRSVa2jToxpOSQPV5izJkz9LxBoP/V0ziJUeqmTv/SMuV2qPAkNAtiZPsgT5D6sHjuAduUEU5D2h710Qql3LQ/jVDL2CT23MBePtRqBjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975012; c=relaxed/simple; bh=unhbzcpYk597C2G00Db/mvN00cDQeTpFowiN+h3Rrww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i48Vex8g2PuNHMA0bskpybKTJjAqkvpj8byXMKe/FC9ZMlBcBPvVIaZSlsEhRMGQtl84TriOQXpoCb9Pb5IOCIoNX2ui8+eKIRBgLnuvGJbSco1occiSyRI3KUyh7U35RCxtd4Jpy6cQquEJxPj19ZWq9JJfWECdJ5wc7VHk7FA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D2/hPJlb; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D2/hPJlb" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35d8e548a05so3983141a91.1 for ; Tue, 31 Mar 2026 09:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975011; x=1775579811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3zYgkKc0haN8z/URfP0RW5IhHtINqX0yhqpPrwSnH5c=; b=D2/hPJlbUydAJdlkAadR8+YRYxOHANX6aOswYqgBlJUrtDC5v+rUklG8BlaOzEMERD whSr+b/EWHOyGv6KfgcRiJ7Qkq8ArpGiHE5z6+esxnlWp1vvFAhM3D4mjGeC9jQMZHsi QA2WhlOFy7StDfBm9bmcHQYuHCgAxCpCc0pbDOwlbTb+CxGA3w+zv/QKhoeCNz4u70ix UuA/LDOHtEsfXEcLvkGNWrKx4Me5oTVkKVYUXGWSpvvJ3bLKkGw21hWZftw4+BhvdGoT JAx+m2+Qxp9UZcge/Lf4CE9o6hbWZSq1NyhG661IMZUhcBmcluZFEwxp79axxsb60555 sPIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975011; x=1775579811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3zYgkKc0haN8z/URfP0RW5IhHtINqX0yhqpPrwSnH5c=; b=UOY5W6S9sARZhZViVKz3IWR+Vq4vr0P3Sww94skKdB4uISwglfHowF939d8K3KXEtY Oi0O55nfaF1U/ffGKjmh46ViJcVinqxGJQONBLPHMETcJDgzDaY62EpQOQ99B3K4N9kv KOfmt8m/xOzp2U6xbHV5A+iCmmqL1CfSkzbohj4BQ0TP9647x2PvZc+n8tA6XTnPCJVY pga96glWn9O0N3ZJBWJnRl62dGaxbIy2YrMwzHZXYu/+y3NNm7/oHacM0I5fDh9guxly PPaJl2LBYmhLYhx5AzXc670IYyv5yr5JGDbDUU2spi/fu5vbOiZxCD8Knao9t65wrcvF Vs9A== X-Forwarded-Encrypted: i=1; AJvYcCXCzsUyeX52f0CZlDPa3tLfhALomC0pItP8y1n1aXIO0WAPzKlBbE3Kb1CA2l6/B7H0QxMOHlr5yH8ddIU=@vger.kernel.org X-Gm-Message-State: AOJu0YxW4Qr9BEdmixIhbT2AacfH7HnqO2dyYX+Y/lYkdCkGib0jmvY2 rSQZRpuy70B+MfppIPseeBfszvHu6qANtOy1F7m6btjikVHhk2eZelIAyo7yFeBR X-Gm-Gg: ATEYQzwKN/Uz5La726kcP+8FWAG62r2pOPPhKOfRD+2hjKO94MQtNyCBH+g/gGV3dd4 XdGljSNiPn/9xaW4zNtd6Tt71wminshXPZmDBnaPdg5nWPRRp/rQYSoBVyZP1N2b8PsVi/e24jY CILX3ik0McrcU/VHR2VKNok/Mvd9PTibjz4CiG1IxaTOjkxugTeKnTIz4CLmtY+L2choWtR9mrz jEf2hqqP97U31uJG6T8i08clqrbXRK803xLVVbrjgYbG+G7ayXYcPF//ZTz0UKHG8dV8/BXB1HF I/k/ia0phshjUonx1QRwdV7xW1MQghxmcyCZWI9AW4TjooLv9VwZUvxDnCrOtyPp3L+KA/kmzb1 7KNnykN0YCu85uNygwuE3GfkblZOBprR5wTIRQCV/fJsC2AP+70rUYt4oyAo5d78xxDKAMNO5z3 JJNpWBTKvrRlqgcvGHdPeV735Axru6wQcN6uRyI/gN+iiyB9q8 X-Received: by 2002:a17:90b:268f:b0:35d:a9bb:1e33 with SMTP id 98e67ed59e1d1-35dc6eb9dd7mr26447a91.11.1774975011066; Tue, 31 Mar 2026 09:36:51 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:36:50 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 1/4] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Tue, 31 Mar 2026 12:36:32 -0400 Message-ID: <20260331163636.15238-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..cd611c0da4e1 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,10 +285,12 @@ static int platform_clock_control(struct snd_soc_dapm= _widget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state"); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); + if (ret < 0) + clk_disable_unprepare(priv->mclk); } else { /* * Set codec clock source to internal clock before @@ -303,7 +305,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, } =20 if (ret < 0) { - dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + dev_err(card->dev, "can't set codec sysclk"); return ret; } =20 --=20 2.47.3 From nobody Wed Apr 1 08:15:50 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E8023E559E for ; Tue, 31 Mar 2026 16:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975017; cv=none; b=OuNrVaSqkziffYOTFuY4R0HUJGkomqmBCLycwGOibOACQN82AI+1Jlrgz1JH4/wQyKDT1GKhIiMzNPk8OeD76r5NECXQgW7D0JJrKS7MX/rzrkvuTpHmmlNX8tPiWSP5+q8/3Q2k+FW3u5dOrcgeB8MwXBzUhpBV747hDVinpKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975017; c=relaxed/simple; bh=cbJ9/tet7CzfKxXA0yxXN6cHWGj8TOdzJxeRIK+7mCk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q02N6GcL2Z5baeVkeg6XCYw0e59WCkGfkDJzUcjx3ll18+h9kFKE058daev5BEBNL25rGCiia4eh4859kEzX68uerIdEmsusmwDay68loejocd79yhEdOKGQ26iFEt5wiMtd6B2mFvq9CgSkWgMIgAud3fG6ZuZoSQIHiOOVoaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g/pB2b9u; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g/pB2b9u" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a9296b3926so38470205ad.1 for ; Tue, 31 Mar 2026 09:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975016; x=1775579816; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SD839RbG5ZBrMZ9bhOhi1yt6xxK+tKautdFVEVaG3C0=; b=g/pB2b9uzk0xRVqlBaxNTloaEEKxaAQzzxrB+mQoplArwy2jE3OKOpQY7HkupqBGQy 6UfIPDaTlFLPdiPU8b/A16Ndt0b/tincxD0F/w85XlMRispdrQjOzeZasE5BqeEYGhPk VDgjr2i7OetNCxkwVekE5w434pr7jCvydXffQLP3z3md/EZ8Bb916Q6eMrA2bIFXJ3Su U4dKjWjlPtfWDE2enn7Jm10vher7MErMgbSy5msUfnE5XzftQNFqBL9ygHXQc2epydy3 eC38fd/qTBNSyA3o4zhoL64pz4AswPjVkEHUNgXL5tskOL2Bh5inikcJcbR+obkMSZBv HpBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975016; x=1775579816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SD839RbG5ZBrMZ9bhOhi1yt6xxK+tKautdFVEVaG3C0=; b=CB7Etc6jBFrAkbrC26OjzJiQ6m1DbIDGBOxnNuAVuvgu/utOj8Yteg8UYReOOKjele 9mIeigDidFuJGqgGAecVvC//vuUP0DcdplDtnVutPwA31SrzFJGgyi/YMvp8bQhjDk8u 6vjhmzv+oVudjtlyaM8OBlJzFI4l6n0DWYaXf9akWkgQnPu+fvqs99OWM/MJ917WnNpg 0RwmnbvQ6O7K0DGe3yQZi2pKPl/E0n6Qji58KcVJ0GLvKB0OKDVhKsrMbRlcr17jqQEH X0RMy8C7mcaSlEnOOhk5vMWGc0NqoU4PKttKuca5EticpMYa+rc3yewOb1zKxzo5fl7v sRVQ== X-Forwarded-Encrypted: i=1; AJvYcCWW9j8P3M4gonvZ/2Ddm6RVntEqxy60eGG9Ei0BNidIHgryyvXSGeUNh0pH3UBYitN9JzC8EMCLcUHjYBY=@vger.kernel.org X-Gm-Message-State: AOJu0YyRb9FnxzxFggRxbM/bcDU3IPB42iqnGcCz3xmREg6Mu4ubbIg9 j0F8GLb2wurTLqa22j4M1wBn3P3sdgP8kutorcqZAwpg5sB64pVaob9a X-Gm-Gg: ATEYQzzvrWIRdLvRgzg/QK1+RZtdrAcKwdkt0mx9VyuFJQLkMdRQ15dn6VLq8Pt+Hed 1hpnZHiypv2ss972tGLmfcz6OOs/gGFWEJ4emR48xcMLwekTXrqDMwe2RN6C1Qu3KLycd1bhK3E L27n/chThe6Cz2jaVdYuxmQacSm88IaqH4BDVqGgXHTA+oVzkCGbF5mB5YPJTxsoxlHXf5oa2Qy DBBFCk86rpsNzkJ0kBcOIqJz4dWg9IbW9r5+F0TDqyC1I4GE6KrFjSrZw17LzwGlo23bM2IEL9R Qdb1tFaHDctkxI+x6CewS/lFF+9h4vQ3KdrLJI0JJK1oJZ6lOOflvMEYrZN//XB7d7eR0osgytS O9J6mzGW8zNGSoGZzzBSJpwecacf20RpiEXB2qnb+Og85cIlZdRHesSjMKCcQO3hVFN4mBUFEyK NII44s2H5KmlxlWMKKVu26z2Q5G17NC6o6QuFZ1Ld6QcQ4cowy X-Received: by 2002:a17:902:d4c1:b0:2b0:71da:4ed7 with SMTP id d9443c01a7336-2b0cdd3ed57mr171864535ad.25.1774975015959; Tue, 31 Mar 2026 09:36:55 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:36:55 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 2/4] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Tue, 31 Mar 2026 12:36:33 -0400 Message-ID: <20260331163636.15238-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..e2f59a008b29 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -209,6 +209,9 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); + if (ret < 0) { + clk_disable_unprepare(priv->mclk); + } } else { /* * Set codec clock source to internal clock before --=20 2.47.3 From nobody Wed Apr 1 08:15:50 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0C73E559E for ; Tue, 31 Mar 2026 16:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975022; cv=none; b=BWQrWzdDS6KrZgykkxIe7ghn0GLI4bHgh6caBXy7u/O7I5qSiuVOGD+XNnqGSJEVkZ/Ha0cEobcBYJ02kF4OGxZzljbrjx0bYLQ62OX0Js80mQCPIL5azYmh8PRuz57Ku++fmXh8CD/kqbWld/n7B5z2VNCt8JrblQQkA2d9TbE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975022; c=relaxed/simple; bh=kvDk84lLFYP8LAteXHHmJ4uqJy7hd+l5iP9Lmix/xm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IYStEkOFARQQKCYu4/ciCCSyp9b8wfz3+gb3qGtOJEYNgzJOUVY78vnYuXGvFaVw4ptku00KcJQJ05l22rWIiLVMOVfWpE9c8ZM+s9F1uaw59NkACANiEiPMst09Hq15p4CnjLSoILLM5vJeQnzNpLHbX7TumNk2bjHr151H/7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UE/5pMRl; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UE/5pMRl" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so57294675ad.2 for ; Tue, 31 Mar 2026 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975021; x=1775579821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NVf9jSL3Fmxnja4LNdILqrHoUghzjihR7HFJHimyh3c=; b=UE/5pMRlLfbos+qgHW+xTNWkWrLG3e2O/7rDGYfUIxtD4j+pTULvs/BFZo6DizZKd3 AaMxTMHDVWlxieN9pNhItdjc+ezKoRga725L/zQk1YeciR+DdO6IqIoivOnUAWLCWLoa jkrjIPyZBPDb7/YvrPH28xFearFpLBNcbXuYGUzuYPgXWpHwVuKqor6TBeL3qH1Yoc04 g0n6bT/BjZDEocbrxP5LZ8HsMdaHv7D5zjnj/VzD5smWPKGvkGZhXFKs2Ujy6RlBJoVr SZGgAFZ/Wc2g8M/C+n6hP1bzNibuGb39aYCb3a1KDOhJXTXlXyFhlJDiaW4c7QO34S7/ VR4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975021; x=1775579821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NVf9jSL3Fmxnja4LNdILqrHoUghzjihR7HFJHimyh3c=; b=OP/fc5uC54F6ljMdlAugpTfhW5ULFxzvILPXHPRkEn0R9FJHIy8LTI1L5I09tPRYQK FWq8M6oLS++0lJqeloT3mN42kQqYTuRdPeHAvG200CE8YXHyZt4Hq1UJiR/egTdegqii KTMAApI+gJQpvfn60qHMQVnhcSSrKlbXk5wzWmU9YCYfKyt6tcQDaLSzYNPdxdALFye1 5RH1A1MhxCHz71n7Jr2dC3uYD0D2YcqQ5vH51PJHvBUEgS0XKNG9MkyeRmbEFlOBDm6+ o1Ht0mAUuUMpCKMqVxWdX+VoVCcp3OjtcHvxDPX0D0Xkw3fCqPGLDSBkr88qCG3nIYML x1LA== X-Forwarded-Encrypted: i=1; AJvYcCV//e/MJ0Z08SRJ2iBSmdHC0binPS3J/BljYavojEfShIt9bc+IuhCQaqAw+CZZaTXpNe+NoLyCVp3Y9xM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2+hwrpk5s9aFoKfQAjb2qzia6HQ9p55uOtrneiMIW6Gf8brDo H1mwtUZ8w0eVRoxWyLKpxvzpQUFEAXRVjmBBtSvYQ2kiUJXdmA/Z+ANB X-Gm-Gg: ATEYQzyTEuWSEKCLBtGbLVCaDcUruV8TAdh6ZCuIP48zRw7Cs2wr6i9YPyz/1yTheRL an5j+EWnSTFMzSA/zsdEeeQyKw1j1soBWVewdGWZreyJ735jGY9hNqeQeyU/qT/Q8BslVe3xNmX cmNqHif5ND0zOKAFgxgWigtfGcvUUX/NLL2UYoSUfLm0zI695NBvWrs2ts+vhMbfNe/2q1u50B5 KG9PJrX/UusYV+inLSucrWQs+ktydViuvL/0HBPKCTkcwaxKW3Fd7OH9r4aomlhk5O3mcdVDC/V Qg23NPUKzwyZ+RnNXfWr/BXYXzbNgVOiHrSTCxUwE5VVxyc0zjkBaHHzSRk0eGuqfMxWkXfgcGw +r/KnT1WlPPe2QYsJH+kuD39vK+D+5TgGEjeq9R9e47ITOqLPuifwc6kCICM2jQ7T8s3iY1HGgx xV4KaENjmU96KoLkXNEFn63GWdxzw8GYxzQsCSDKGAsQdlmHd4 X-Received: by 2002:a17:902:ebc5:b0:2b2:549f:7d2b with SMTP id d9443c01a7336-2b2549f7f50mr82756595ad.11.1774975020649; Tue, 31 Mar 2026 09:37:00 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:37:00 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 3/4] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Tue, 31 Mar 2026 12:36:34 -0400 Message-ID: <20260331163636.15238-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Reviewed-by: Cezary Rojewski Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..0c2435edbd08 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3 From nobody Wed Apr 1 08:15:50 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 294B7425CC6 for ; Tue, 31 Mar 2026 16:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975027; cv=none; b=u/6uuy/NYsrAmYaA7myJ3nfISisjq6DWd0JY7t/GewYMSef8PF8vrIBOx9cFbO3IBO//V+N3PUk4pRBeopTiMT7mrY+a2kkBy4M+i9dtuz7MOmdOPAXm9+ht93Rk7280fuKjVf66csCvBwE4IxKoKtlZvAmkVgeZF8tJeACf9/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975027; c=relaxed/simple; bh=PHs3f/gaFyYReQoQxx1imm6pw7yPcVpOTvcve/so69k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pKL/+KbVe2qkD1Zb3DqWU+TTZMDOJOzRA72ZjDaJbyR+wl5hdhtE2DesJKP+A7EeHymaSwkFtJpu2yQMH0RoH39xYc3iWrg50X3J3uDF2Ms3GKNPZ9zHoKSH0RQzGPhp2Qnuq75Flah5Z/8HzKvnlFKA9tmTSD2WVI6AEWrWCN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VN/C+NPh; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VN/C+NPh" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35c124d2613so3796255a91.2 for ; Tue, 31 Mar 2026 09:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975025; x=1775579825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/w11NnTydmVHrODXF8dcnWWEar8WU1lyFFID+3qgjWY=; b=VN/C+NPhP50wiRdw7USUtakUrAOv9Vbzsr5hsZDpZ9rc0Yay+nEzmFkO4ATHz+wXkV 1dt6JxS05KjpLlTsKQCbfCnQSgPVGyY+WDTMaXrnye+IKbmjOVJzNTrF2mjld1+EvrNe qftcTd/ojITUB8myW6QtHchPbEx4NhGEEJcV8/HXgS21emp4pAaEZBx4vRLdQDNvFkaU 9E7uVKDWC12pIuANpM7JNz1RsOF7oquqxuBV2G0NblP1ugL1xwa+68vJLIR9BdhPNHDj /5yUVkveTDdoT+90+smCHZhch7237gMBMgP/TJRO6wAUu8xBmUV62cAIkiq2GKrPe/1A 2Ffw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975025; x=1775579825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/w11NnTydmVHrODXF8dcnWWEar8WU1lyFFID+3qgjWY=; b=AM/0i/uj2S3/IV3VeH1Jv7xDnPpff/uJ0MVJrUKNy4fXc3xbpqAkLD5CuB8Wa3vx0x s5lSCAyg3SbwSxLkHb+ABcJaEOuHaWRBOxtyPyJc/55EOvjTncEW6+J3JDxC99yv9RSn NkYRGmfrqNQ2EVvxwdzYFXq26Qk8ySaY97ZRv/pWmHZbdic+wfaB2ryT2sGLU4n0nOv9 VzxSkiyoPxxXI5eGC+hSkgQvuW/eKw5ohAv8Y55H74FkIlZh6ukRHCb+ofUzw+e6zA97 AFLjZ6CZbgUmaNzxNQaboxztVtbfBZFSpdJfsS34XzPZKrYe05cBX6qvBGahCJWXyF5A 50wg== X-Forwarded-Encrypted: i=1; AJvYcCXTz9Vvct76BLL6Oz4b+6QWhktVF43t01mRB/wnBQZmRAmj4Ox7M46lgZcMlW9SG4yNdq1k/aEGcKI+q5I=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy2liR4KqwoiSOmMTEk+hoahAGIZufzQ/RuAAIy0vnGWUwiqkx CeNHAuqOXtjBWFA9JrTHnZI0fKvjr8cHMwyA+tZKJbYCfwt0X9CJw9eR X-Gm-Gg: ATEYQzzIi7EdFySifsLgPFH1FkwgipAYjAjYSGmAf/q75sqRGO9uzD2HRREL1FpdX/S STCBFYtzogdjAyV4Ye+TYSrcKRw+AVQE8Akh+LR5hvb1zmHtWjySw3KfLXRpI6YBrgDCXBDhph4 Se5A+RAC7eRQHFcKx4Hs32YMGEMXIXqom15VwqqGAwhwelwHq2Kj8UGSNlauAgTFxQ8BCoA+53M J37Xg6CO9AuVf2ZNaV8VAaE0pKhhUd8MIu56R7N9XKzjIumenAmih0CQMqOycNTdeZjiZLOKZu4 aHm4pktHEnxzKRAbMwCePrJdex+P+zdYbbKjP2AJ0J9aoQ0QMphVtNfB1AjBT/LtkH3SAhh1imJ AuW4pXdJihpZqC7wReGwUYElFhIs7i6WHi7/+8QrdpdY16qNCxatAnectj9lLMBcl7XBPiXjgim srSDYOBJ0cvwuG4wiqyz84gwFRxK6t9cnFZqqvig2f4lk5TJ/4 X-Received: by 2002:a17:902:e885:b0:2b0:663f:6b53 with SMTP id d9443c01a7336-2b0cdc9b555mr175094965ad.13.1774975025211; Tue, 31 Mar 2026 09:37:05 -0700 (PDT) Received: from debian.killsync.com ([152.59.222.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm116069255ad.65.2026.03.31.09.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:37:04 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org Cc: cezary.rojewski@intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v5 4/4] ASoC: Intel: boards: Log error code in MCLK configuration failure Date: Tue, 31 Mar 2026 12:36:35 -0400 Message-ID: <20260331163636.15238-5-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331163636.15238-1-aravindanilraj0702@gmail.com> References: <20260331163636.15238-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The dev_err() calls in platform_clock_control() for the three Intel ASoC board drivers do not log the return code when clk_prepare_enable() fails, making it harder to diagnose failures. Add the error code to the log message. Reviewed-by: Cezary Rojewski Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index cd611c0da4e1..a934b3684347 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,7 +285,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index e2f59a008b29..3c5082034f5c 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 0c2435edbd08..016732a57278 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state: %d\n", ret); return ret; } } --=20 2.47.3