From nobody Wed Apr 1 11:11:04 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37FEA410D2F for ; Tue, 31 Mar 2026 15:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971202; cv=none; b=XQMmxPT+x8rNdFD5W43fPZHjIdF4HA1IfvQcuvn1GmbjJj8V5f6bpRrQa9zaHx0HzJY7NcNtVjrtjIowC5Q7qnBiRWyFoAbhMQ7pWWi0zgTkfvxlb5+adc/C2cegvThNdQwnDQ73RvEYeD7cMd8JsNK6FT3wXZAKYi2ZTv1NsRk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971202; c=relaxed/simple; bh=qp2cnGIOvfGUlyVb7lBhxDQjhsF0kpQ/NLBt7h4yYU0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tqlLWSdFMPuKWsrTR4IcsH/LT2A7jlfICNzLZyM1dpOYiJgLhL3Vqed/KxRmsY/TViV82KSkbLq+Gq5w4WbpI3i9WANrT2s4I/vsCpeY+pPnpacy68+V0dmmvFPctalHsDkC//xjtBh4KGJr49Q0sysASxX6uvz4ev039b6q6qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sW9etXYw; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sW9etXYw" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483487335c2so62942945e9.2 for ; Tue, 31 Mar 2026 08:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774971188; x=1775575988; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wp8quepZFqze/sjFZFLCxsK6j2aXBhvO/wnQp/VrWjE=; b=sW9etXYwt+0MQgvKYN8tJIf/nVMXmVfBuMg1yc0T0PqHrhirv0poHa6iXi3aqGlRva /BvUm57kWh93AaRTAh9b14t/j7AIURZwueil0L2A/wjErDWkvNSbYcJXvY3beYTZ2CfZ +u/aDjPITRM4nPmd1dpYsxmBHQgOZO0cUvdzy+5Ub+swmQS6pgW8FPMmJ1K+8kJRz88A t0txIZcHVHJV3Ue1fbCdN8senPGJhn1GNiKI+WocJN+2/HuvWO1R6E4Xm/2ju/V2OPUx K0bNVHFGiRSQD/rQ6CxEd5v6czb9V0GP3GT2YBAJ9eXukgyW4dG45f4zGzQISqAaI77o h53Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971188; x=1775575988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wp8quepZFqze/sjFZFLCxsK6j2aXBhvO/wnQp/VrWjE=; b=BZmttvLogZLty3ej9ZfXbipR9XQhR1tEDKp8QCALJjDLrx30GVN8ABnOhGU4/UGRq4 YWFXBQz8qMv9SUt86Q0njB2ODbDHa274ZC3T19AqM6sz7j3i9jwZ7vRk1+0S9GUxk0P0 PtAbd34LvQaOknbCUMIL+mp0m5o1Grk0SbDUvnlqaLB/oaSpKiSxDau5/Yuy02d8x3UD 9arC3U35gajWskHjm9dQB9usNu+kJoktSGqkJ+xbHU3pwqYZu2shsmB/5fnuiR9BD14C HVrcaCs/ClGv51hKZrHgIhr6Ng4KPd+R/GbZ6SrxIX9lfd/LRLoo1ImGSMeZ0CIJ5BDR aX5g== X-Forwarded-Encrypted: i=1; AJvYcCVBwK73mU3laA1ayfhEoBnCgiuZzoz/q1+8+v+UEnMSIqgvH2RFv/Rfqt0AQEbBjuQ/RW3kNBO6rrpmrN0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Z8J718xZuAemdFVP/4J0yle5W9kjxEZslAYtumif4MjYCuzQ 4rz6sDsNCjWWREiryFviIJasyQsONBr6/lxW9tF9EGkbmAi02M/tmSi6 X-Gm-Gg: ATEYQzwsxuQcLYx3hxukFm6UKigLRbgQ1ZMiyLG652PJ6EIFwV93J6v2XHLuyvdQvKg 6oDm2GelamNBPASUTeisgC8KvqFHgGViKJxuHRSdl0aEPexxCyiWhYklpwbXs9udYEXWUWu8qJU Mo5qdzIX/v1umFAztgCSrh7JFY22E1fQio/IP2DPC6LslgZ0VFsZMC/4Skz3AIowCDlNkeXPoBe 8WjOmft8/oKhW5XgLmuPh2URAD6Xn0pwPlvX5r5EnNVLGdeG6SgvRmE3boopAJyrBY6xZH23eW2 tb0Hz1QUSNuTGCgdEux1EO53ZgpCOebqMyi/6BneqNssVIXQfiXiwNFTODx67B2GMYsA5QFJ/L7 HFYmDaSQZeYRD4MHN8taNztZNHjEWFxCi/VzkhoN/LcFsZvdHim85qV2UvMIzvasthXCQ7zKehm 3uC27/iFaGAmld3MUNqOcObzSihW90ZLCX X-Received: by 2002:a05:600c:4e0e:b0:485:2a85:e5ec with SMTP id 5b1f17b1804b1-48727ef5508mr286870345e9.2.1774971187771; Tue, 31 Mar 2026 08:33:07 -0700 (PDT) Received: from potato ([31.176.162.65]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887aceb230sm21653485e9.4.2026.03.31.08.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:33:07 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH 4/5] staging: rtl8723bs: replace function with error handling alternative Date: Tue, 31 Mar 2026 17:32:53 +0200 Message-ID: <20260331153255.22764-5-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260331153255.22764-1-omer.e.idrissi@gmail.com> References: <20260331153255.22764-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the use of rtw_set_hal_ops with rtw_hal_data_init in rtw_sdio_if1_init , which actually returns error or success and not void. rtw_set_hal_ops literally only calls rtw_hal_data_init and just ignores the possibility of errors. This is the only place this function is used, so remove it's unnecessary definitions in include/sdio_hal.h as a prototype and os_dep/sdio_intf.c as a function. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/include/sdio_hal.h | 1 - drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 11 +++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/sdio_hal.h b/drivers/staging= /rtl8723bs/include/sdio_hal.h index 6538253765f1..4ad145d5d33f 100644 --- a/drivers/staging/rtl8723bs/include/sdio_hal.h +++ b/drivers/staging/rtl8723bs/include/sdio_hal.h @@ -9,6 +9,5 @@ =20 u8 sd_int_isr(struct adapter *padapter); void sd_int_dpc(struct adapter *padapter); -void rtw_set_hal_ops(struct adapter *padapter); =20 #endif /* __SDIO_HAL_H__ */ diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 34ef40a86153..aea9b4e19874 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -197,12 +197,6 @@ static void sdio_dvobj_deinit(struct sdio_func *func) } } =20 -void rtw_set_hal_ops(struct adapter *padapter) -{ - /* alloc memory for HAL DATA */ - rtw_hal_data_init(padapter); -} - static void sd_intf_start(struct adapter *padapter) { if (!padapter) @@ -250,8 +244,9 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_p= riv *dvobj, const struct /* 3 3. init driver special setting, interface, OS and hardware relative = */ =20 /* 4 3.1 set hardware operation functions */ - rtw_set_hal_ops(padapter); - + /* allocates padapter->HalData */ + if (rtw_hal_data_init(padapter)) + goto free_adapter; =20 /* 3 5. initialize Chip version */ padapter->intf_start =3D &sd_intf_start; --=20 2.51.0