From nobody Wed Apr 1 11:06:50 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F30F41C31D for ; Tue, 31 Mar 2026 15:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971197; cv=none; b=b2JPgLY7jc1JNYWyIHsBZzVZFKsSkCu6dddG3rqd+yMuMXWxepdHRnzfI2RMdoE8j7MkuEda8zpuX/YK1SXEvlEGGmfo6A6QPIGas0uzAOjLBdkBYpCVlLS0JWS37qLZqhAZZnEYqQSK9VGr8fhXbJlWEPTKewA0rGaJBtpNUdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971197; c=relaxed/simple; bh=TtQ2GqKrVJlkDKD9m04qBC10J5egInIEBw71Ss4M2QM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mo0WQiZrSHi/etwaDeo+P3S9jImPTOJHuIatqSYFKohRCc+WKB5fcxPsidr4IzCMEHSSj4uGKd6qM7t3YhOVSNqnXt1Ji4w5GjHT2NkLnD8p/rMGBhSImk4He/CT9HAnbNG4s9eUvRfKJEmUIX0bm7tUy0G0UUbNcoxueTOfHdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fWZFBOLU; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fWZFBOLU" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-486fe36cfabso35569445e9.1 for ; Tue, 31 Mar 2026 08:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774971184; x=1775575984; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AFyRFKei9suLL4OspDT72haNVF/dIBE9vkd1iIbltuA=; b=fWZFBOLUM3XIsqpVZKY9B2zaOUMFNLr8ZIMNHPfk1bAJAIk3O/CxkQhaEnAszA2HEX o7daUIJXuQWJN9mzeW6TXnYMiV0JDoa1pYpZeokHGPp+dnHjyfjl82GwT9S6GRcqcSPE O1qSxdaj57HXwSU0oVUqEtZ3hZaAr62c/+yceZs8R/bggNYIo+7ejpQQOwtWGhwA4Sky B5eiCYJ+wpP2B1Vp2bWSpiofwq7UXlbB7OBwu1Gf7hsFobnj+LE38gyVnRnJ/kEMyGel tIk3AhCeUm0BwN86Sk7J3fSOf/a5nlo0wH+7B5Kn9TcQP5FlAz7OBEdwmXjsb6s4hQUq SOTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971184; x=1775575984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AFyRFKei9suLL4OspDT72haNVF/dIBE9vkd1iIbltuA=; b=V1GFKhW0AW2oGC7fZ73Q6M0l8XdZmh9KrW2JTfrGqDXLEVtVmOqsw2x6IXp4uFsXvy ZBkj6OWpAPT5CIWPlLsTgoKbl7AR6U68lt8Lz+vXHBSMzGsHHfrlnBprwB+DPBI/ixNo HH1CRQ1WLPFOqjYYK+Yj/b3bu6VGnmNxnWVrrs1ZU0emEu/2+9nIevedkDqd0CIE7nGO mtVZhJwC8BTPd8KUhpNPTVGDEkaDnnaz8ZKR7ZcTFLl6+EMmBYy8IJ8FOw5sLDiHWE8R RO8MpcNamw8g1LjhxsNBLgLyLsBhYR3hXC6p6wChRL8S7vrxRJiTd/g5xnGwMpyttHn2 gFkQ== X-Forwarded-Encrypted: i=1; AJvYcCUYVY5EbspmdSp5H80TwCABKbYXLlIRSILCBWez+prbhBONkjeB4d5rtdtZ4NMRux9KsqxWewl83CRbU6c=@vger.kernel.org X-Gm-Message-State: AOJu0YzTMdR14FniZb0vqVRgW1z213whS0nSFOht5bYbp/znj0nDnisF mE7iY7aHVoVNJn+JbMV38rpE/E16a3GQkXi+LuBffH9w4yrV3fDv8OWr X-Gm-Gg: ATEYQzw9jKRdhZnB6ytai4QP/sCjBVsIPKTp6VG71ctWOIM6kXdHFWeOHrESDxrgxls N3ZM9n2hr+Jc7m95cea5skYeBrU7rUIhMzyiu1sLfoYncm7oO3uMAMwawwpmnsPO2jE10PaBLuO QNQQjFz4r3qPGbcoH55cD80HBvsSuJQke8X4Akuv5F1BrUTkp6zx9rxJiEh8Yoat81DDg6qTCFX df+WtfBwb4sabr9eNXIm5ntDkWLRFQQxiwreRDfdAkoiaDrLLTw7sQCW7cgmnfi0XKJV62bILqS 3ywIZwxKQcMLhMFsafxDPwQtGlzd9mfIrCIcdYJSec/FkJU03HEHI9jqB5Mec1nCSG2h0UZw8tD ukeTBPJ2Ep7IIxsK4XY/+ifIVyIRezZHricAJuEAL4UytzPQhGLivM4xmcx7B0Df3KEkrAUYjVG 3W6/x3U78NEZVyOn2M6acYgw== X-Received: by 2002:a05:600c:83c3:b0:485:3428:774c with SMTP id 5b1f17b1804b1-48878281a4cmr70175035e9.4.1774971184157; Tue, 31 Mar 2026 08:33:04 -0700 (PDT) Received: from potato ([31.176.162.65]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887aceb230sm21653485e9.4.2026.03.31.08.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:33:03 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH 1/5] staging: rtl8723bs: use direct returns in rtw_sdio_if1_init Date: Tue, 31 Mar 2026 17:32:50 +0200 Message-ID: <20260331153255.22764-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260331153255.22764-1-omer.e.idrissi@gmail.com> References: <20260331153255.22764-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clean up rtw_sdio_if1_init to use direct returns for the sake of readability. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 29 ++++++++------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..64618632ee78 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -224,14 +224,13 @@ static void sd_intf_stop(struct adapter *padapter) =20 static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const s= truct sdio_device_id *pdid) { - int status =3D _FAIL; struct net_device *pnetdev; struct adapter *padapter =3D NULL; struct sdio_data *psdio =3D &dvobj->intf_data; =20 padapter =3D vzalloc(sizeof(*padapter)); if (!padapter) - goto exit; + return NULL; =20 padapter->dvobj =3D dvobj; dvobj->if1 =3D padapter; @@ -289,27 +288,21 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj= _priv *dvobj, const struct =20 rtw_hal_disable_interrupt(padapter); =20 - status =3D _SUCCESS; + return padapter; =20 free_hal_data: - if (status !=3D _SUCCESS && padapter->HalData) - kfree(padapter->HalData); + kfree(padapter->HalData); =20 - if (status !=3D _SUCCESS) { - rtw_wdev_unregister(padapter->rtw_wdev); - rtw_wdev_free(padapter->rtw_wdev); - } + rtw_wdev_unregister(padapter->rtw_wdev); + rtw_wdev_free(padapter->rtw_wdev); =20 free_adapter: - if (status !=3D _SUCCESS) { - if (pnetdev) - rtw_free_netdev(pnetdev); - else - vfree((u8 *)padapter); - padapter =3D NULL; - } -exit: - return padapter; + if (pnetdev) + rtw_free_netdev(pnetdev); + else + vfree((u8 *)padapter); + + return NULL; } =20 static void rtw_sdio_if1_deinit(struct adapter *if1) --=20 2.51.0