From nobody Wed Apr 1 09:43:46 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0390A413229 for ; Tue, 31 Mar 2026 15:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971183; cv=none; b=nPxupFwuR7hLM9UqmhydoV5Cz4omuZz5S3cDNCPoDxIGcqCZRImdcSV69xeKOCNqiOW1Ip+AXLwpNlToej6KepxnIcTB2vNwVjFIMz5Kvoy+dUtIfu3HD98AkRUWU8sMrC7IGsxQezwKcY+6pdz8DNoxI/aveqaEGEGj5rR54hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971183; c=relaxed/simple; bh=sq6xb1uQpPCxAKf1n02HR0j56fcBej+bOep9xHO9y90=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UuQTop2RfWZC1F0fapeH+lAKM4Yd3GE2Mm5+UpF2R9HiZLa01+0dU9XMIKATSBWcZ+eQjE5I1mrkNTf/1wzOSFUZKROdWoK2nkHIKfovkwTLqCak9a8wcQWsauYS2z/YA0+d6B5Ymb1oBO84b9U9yTDfYuxHeJORnpCCxYCFOhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YM6e041D; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YM6e041D" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48374014a77so69756235e9.3 for ; Tue, 31 Mar 2026 08:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774971166; x=1775575966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FwR2mxqLujSdr9bI9JYKZsbivVm2a+2JAgTiRA8SLEY=; b=YM6e041DX/x3aGnUHEZb6REb6VQLiLuyvjnmD1UtNbB/QwfmURMbyScTo/ehcm5VAH jHMO2IDt95mSfCuObQReB3uNDNF6nMexi17XcOjFCRaUOfq3Kw0v081BCAeGCPghLD6r XE1/kBs7NyuUPn6cGEpoYyezdFYwNXnScxomiyVtUDkhTxZaDPhbrsXiL/0/qkF8c1LY brM4LersWeNvHLlWzqf8S8xHGzSMMA+a86KdJF5g3AJGLWaIL1ZuiuxscRlcDJfvP3x1 KL3IvM9fkfJLFN6tpE20Z+ylf7YOtDzhSvmRF5yFRTBLMH0puuomJaCtkeZCDklpg1lw mKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971166; x=1775575966; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FwR2mxqLujSdr9bI9JYKZsbivVm2a+2JAgTiRA8SLEY=; b=l7NOd0AAHsze9ivqgZ5o9tnic/B78uxbGTPJnJhC5VwMK+XvbCQlPkGNqE3thmv2+L XMa6I6Myy5ModJigcuRZ/g5PhX979bqiL5ZCHL2dSe8xCvFAbp+zPhO5joGUY7MJYGFd 3kvmP4G1qPQzvuAqHWcfXZ9OLeNsYdl88Rs8CUxXErClgcbuV8x0UTbZQj6wetWGEJpc 6p8ROrWCHaXDg1jqbwsmeJHsW/ElT+IVZu/0grlCuTwLurOMICiSJsbHEk6OGKPcfTGP b8KTIItc+W2FoKZcaTTR2AcLZq/4J628c00kfndoPUB4GU49q0wBeDIETavXkjREJ9ef NtZg== X-Forwarded-Encrypted: i=1; AJvYcCW42sbFGfvd8laU0YSF2lKSfpZ9CUbrLRxCWdEHcyffDedV2y1uTj3TNrYjCuPj0vTeQGApdI2qEzC+auI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0H8C12+XSSsfTQggKgGhpwXQb4CYrDthlJK07VZU5S8I8fLhR kYvyCfzyFt45KcsTCIjiYTJfCpBMKcrypW40EqoUVADiRlCIHy81E7MF X-Gm-Gg: ATEYQzz3OnBAZFmxK2Lb1NR1xb7iTZjsYAgt11IjPpNrHzOuU7Xq8zyEPmGWgQjqLEd Zo4c2eXR65bR2Sp1MLHhDGnWPh4o5RJknkQTlQF6hFJLhetTvDsItwHo3hVV3GIoZ22RXF6kkHl 7a2at6r/LcKYnV7p0jjLztTFNyegHMR9/Sm3Yvhyrki0e/Bg2VhaZzp7twrwQjzulx+6wuUWW1i V8Qf9Rmn/jAWOD14mzmFaHnFf+k3+EtNFgf/rzK5M/zyUVDu901b//3NRKGfio28ZhnqqAKWF0d pVsd3DJ+UX7MWfUvIY3Ws8tPYI8TQpliBkSn8EoiGsDr1rhDvxiTU0gw8SH+W43Ap1bGquoawJF MeH0vBFayxRbQfSWXyf/XaFLfNRck0o2JsQeDdobwt1gmKDwqSLdkkaYCeULJDKNr8JRYphvjcE +GwhN+eCM7X/Ng0bZbl8BLLDkg5sn85nWHgun5ityzmIG1NbUkgRLuZBj30pX+ANvx+lQGdpf00 wUVuF9ZeHrYiJ4tRrhZqQpMGEjQUc8qKeZjPjGjtbXQi2mi X-Received: by 2002:a05:600c:5303:b0:487:2439:6266 with SMTP id 5b1f17b1804b1-48727ee5445mr282184885e9.30.1774971165955; Tue, 31 Mar 2026 08:32:45 -0700 (PDT) Received: from DESKTOP-NQ2T5I7.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c769841sm23908335e9.7.2026.03.31.08.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:32:45 -0700 (PDT) From: Prathamesh Deshpande To: Saeed Mahameed , Leon Romanovsky , Tariq Toukan Cc: Mark Bloch , Richard Cochran , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Prathamesh Deshpande Subject: [PATCH] net/mlx5: Fix potential NULL dereference in PTP event handling Date: Tue, 31 Mar 2026 16:31:51 +0100 Message-ID: <20260331153152.16766-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mlx5_ptp_pps_event(), a TODO comment correctly identified that clock->ptp can be NULL if ptp_clock_register() fails. However, the code proceeded to call ptp_clock_event() with that NULL pointer, leading to a potential kernel panic. Fix this by adding a NULL check for clock->ptp before calling ptp_clock_event(), ensuring the driver handles failed registration gracefully. Fixes: 7c39afb394c7 ("net/mlx5: PTP code migration to driver core section") Signed-off-by: Prathamesh Deshpande --- drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/= net/ethernet/mellanox/mlx5/core/lib/clock.c index bd4e042077af..9e9f844935b4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c @@ -1185,8 +1185,8 @@ static int mlx5_pps_event(struct notifier_block *nb, } else { ptp_event.type =3D PTP_CLOCK_EXTTS; } - /* TODOL clock->ptp can be NULL if ptp_clock_register fails */ - ptp_clock_event(clock->ptp, &ptp_event); + if (clock->ptp) + ptp_clock_event(clock->ptp, &ptp_event); break; case PTP_PF_PEROUT: if (clock->shared) { --=20 2.43.0