From nobody Wed Apr 1 09:46:28 2026 Received: from outbound.baidu.com (jpmx.baidu.com [119.63.196.201]) by smtp.subspace.kernel.org (Postfix) with SMTP id 1D1A43E0C77; Tue, 31 Mar 2026 12:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=119.63.196.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774959986; cv=none; b=Cnmh9sfew1m7/JsCBkApotl6CWalSMF/9c+etbdziarubyCsnrTIcW31OCgCKZ3MA2hTj6D854oCo8Q4P8fQXSUFx8ANnSP1sF1B9nAW+qGdsE2YsBa2Kb6lBlSRDI/rXkAau4hEizz91fCUVdbe0AAoulQ0VVyER78/KFnDax4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774959986; c=relaxed/simple; bh=pCJYj+yIsvTQfbdDJAagLaKC2zgC2vgl8J602FoyfD8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=u5lzNNVprq1Mp66CAmDUFaaEWCZCsoqmDCIpxVRddGW2Ad8JiCoqmDUExOa1zwiDtW1CdUjVgcRZamrx3Z0er+29VzRi7djXeRUvPcwQFJ7Tfa9BagtUTaUxMJzXkD0X29K17kMbNAkIjlRLMZzYpo67bpwtKpXKmCox6sBJ8nA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com; spf=pass smtp.mailfrom=baidu.com; dkim=pass (2048-bit key) header.d=baidu.com header.i=@baidu.com header.b=cz/Qtj9y; arc=none smtp.client-ip=119.63.196.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baidu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baidu.com header.i=@baidu.com header.b="cz/Qtj9y" X-MD-Sfrom: lirongqing@baidu.com X-MD-SrcIP: 172.31.50.47 From: lirongqing To: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Li RongQing , , , Subject: [PATCH][net-next] net/mlx5: Move command entry freeing outside of spinlock Date: Tue, 31 Mar 2026 08:26:04 -0400 Message-ID: <20260331122604.1933-1-lirongqing@baidu.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: bjhj-exc3.internal.baidu.com (172.31.3.13) To bjkjy-exc3.internal.baidu.com (172.31.50.47) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baidu.com; s=selector1; t=1774959976; bh=ecjXzqLRA55slfTGCO4Yrp8OrmKK3TGwSqxDk6NDAvs=; h=From:To:Subject:Date:Message-ID:Content-Type; b=cz/Qtj9yCU/Rr0n+t7AprtHKdLgZq5YgoiAhxeRJAZa5IyVZNXK2jmHyN5oNounS7 XN4Ux5p6GhkvE2eCm4a8APzLBsn/H56/3QtSkK7nnpvrirJZsBCyJr3Kik5RAhj75Q frf0411NGiW+guVzWf8qUmTavUS6LXy51ckDytkY2QdluOzgGjFsz03rQafynfgdiT 8m6gQppRWE5yRSofbq8XHK2vwSth2ekR1SNvIVPwJAM6YX1n7AwJN2RM2sk+RgbP4C oIy9aIwnjjBIGEyK5ct1mMY3mYasNgtZudvEmkOahZMsTqSHjKepL5/OxV3bHcvFrI 3hbNlx/zTp4Wg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li RongQing Move the kfree() call outside the critical section to reduce lock holding time. This aligns with the general principle of minimizing work under locks. Signed-off-by: Li RongQing Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/et= hernet/mellanox/mlx5/core/cmd.c index 6c99c7f..c89417c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c @@ -196,17 +196,18 @@ static void cmd_ent_put(struct mlx5_cmd_work_ent *ent) unsigned long flags; =20 spin_lock_irqsave(&cmd->alloc_lock, flags); - if (!refcount_dec_and_test(&ent->refcnt)) - goto out; + if (!refcount_dec_and_test(&ent->refcnt)) { + spin_unlock_irqrestore(&cmd->alloc_lock, flags); + return; + } =20 if (ent->idx >=3D 0) { cmd_free_index(cmd, ent->idx); up(ent->page_queue ? &cmd->vars.pages_sem : &cmd->vars.sem); } + spin_unlock_irqrestore(&cmd->alloc_lock, flags); =20 cmd_free_ent(ent); -out: - spin_unlock_irqrestore(&cmd->alloc_lock, flags); } =20 static struct mlx5_cmd_layout *get_inst(struct mlx5_cmd *cmd, int idx) --=20 2.9.4