From nobody Wed Apr 1 14:05:22 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010069.outbound.protection.outlook.com [52.101.84.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7205F3E0C43; Tue, 31 Mar 2026 10:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952009; cv=fail; b=jlHVO2WO/b0eJuSJ2DHsTKF5nZWYprvyvUL1rhlim+lfah4zia1QuHKIFMsltTOLRpfFAYZN0OIXq8LO1EbCt3NwRkqWW1xK7SDKA7tGS7gxu7gs1EVv0Lo53zfwM/azX3tHtCBCuKtKuoJw6bvqHUJnByhR+0M8/6D9PFTL934= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952009; c=relaxed/simple; bh=apIxWAWC0KTfgYM7w9hf3hXW6t/0ExJf53OSLAI9DNE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Sf7DbIX8P12onth3qsbo2+b0C2JarO05YFASU2/vUdPUgsh6jQt6wRu/V75ItrrnuVtb92TjxGyD9NL13f3M1X5eKqsvPRT1Yo4J2qAtmkLYr6GAi9osjOyD9bt4qkGVuvRuFhk+13Yd8Z7nE9wELxnjPZ3wRhS4ANYf+CnH4+g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=dhHYCxTW; arc=fail smtp.client-ip=52.101.84.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="dhHYCxTW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M3cDjOkqpwvgX+N9e9leAo326ySdUIf1i8X+ycCTaNvflY/H7p+xJxIgl8XhtOa0OMqD/kaHWzautULKmlru9zEjrBd08NSWSZDbbmU+XTfv/EUCjNVPPNp5nS1u+hS2ZwmuKlig0tiUTkYXMa/kwkw3W8XxzCkD6NF9bxdU+iOqLGfbY4l+LC2W8QAh+ZYq/kprHuw4xu4LyoMHrYGDVWEOZ22FMZ/jOiBJhXKMmfwm/Edlhp5cz+usxJrQhodnVdEb9u9GTVQ4hVpQh+0cqtBeSySf0GCUfWMxQeBzEHRsWAd/Bfhx/fiOHJ+ivOnVgV2Y1Hf6WkvV/RGRL3Rqig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VDil+NYsv1aPjJjs8ClD+KDA4JkaiZ0WwI+0mI+BaZw=; b=UAZkkwDY+521Kh2ad/5UC4dSxTIYB8CQU7iZhgwFKYRXPsaZ53EQUk8/LDCYmptTgd/Y5EBX+2PrF9xH77BDDwkJCcvARqlRGqVQ+9kRhR5yYprwLsExIfWW5+XqphNuyOTMVojbVmidW3jn1WSrx1idAI349z52G0HgtWItiqJdpZZitu3IFlwln2P6CG5XQSrjNR5J2gICBLw2qaoiLF3aI8r7D/oDrdruW6H1YYDJ1QNwwHhJR1x4pawD73gWlesJGUKqwY281iS1hCalGM1/2D3EvUQsfPpjrtsFlRnM/y9CBZAvxRPPQRbPEQmA3gDjTAMZHuSq5CDJ7tLwrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDil+NYsv1aPjJjs8ClD+KDA4JkaiZ0WwI+0mI+BaZw=; b=dhHYCxTWaaDNC+bKyrIO1BYUn0HfaT8tY1mT+BNHZhHQaymsLwpVli8IunaFMHZgjDVTmlalNUfXkQzQ7U6NmTu+LoFU8j5istFJdEFdDA0x8HutaRRHFdfOkQgf0gWlxP4gQ/6OyGGAr/R0Bv8Cunz1TmjYe3q9D5MUIrkMs3gSOhIVZRaZYH72ec3laBwMC+3gfCHh4I1AmVDNa3y2V1H+TchUHYpbK7/Q9JcRaM0858itVJFY+QuAUKTF3TJcCTDordWNhzMaa1PPX/1h5B79wJO2s+8DeZYOz3MpGfpNNyTkKeHCz+QhT18HTzgxNV/JN8/P9Ts7dPncmjeZ/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PA4PR04MB7821.eurprd04.prod.outlook.com (2603:10a6:102:c5::5) by MRWPR04MB12354.eurprd04.prod.outlook.com (2603:10a6:501:81::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Tue, 31 Mar 2026 10:13:25 +0000 Received: from PA4PR04MB7821.eurprd04.prod.outlook.com ([fe80::67dc:4bd2:8552:9b50]) by PA4PR04MB7821.eurprd04.prod.outlook.com ([fe80::67dc:4bd2:8552:9b50%5]) with mapi id 15.20.9745.027; Tue, 31 Mar 2026 10:13:25 +0000 From: Robby Cai To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, festevam@gmail.com Cc: devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aisheng.dong@nxp.com Subject: [PATCH 2/2] reset: imx7: Fix handling of MIPI CSI resets on i.MX8MQ Date: Tue, 31 Mar 2026 18:13:31 +0800 Message-Id: <20260331101331.1405588-3-robby.cai@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260331101331.1405588-1-robby.cai@nxp.com> References: <20260331101331.1405588-1-robby.cai@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR03CA0094.apcprd03.prod.outlook.com (2603:1096:4:7c::22) To PA4PR04MB7821.eurprd04.prod.outlook.com (2603:10a6:102:c5::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR04MB7821:EE_|MRWPR04MB12354:EE_ X-MS-Office365-Filtering-Correlation-Id: d69ab4f3-00bc-4935-5957-08de8f0e2517 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|376014|7416014|52116014|38350700014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: gCwuVxHWGgQOcPjAWbWYS6oCtqbUZTTXSEpWDsO737BOMFoxORQWXjeXSKgjivpnJZdNLrO7WJvCiRzyH2nqmvlSAFb5RK63bgLCk5bICDW3lExPQf/9hKdagpLy5ACuTzCnshFp6OcOuR0V6cY2Xr9zYLt0Gt5sHK+6HSeUvyWWejUVohASJnq/bOs80JYXB80Ag4QmDZU6sgAZ7ldbYkJZdZuyYffYjT8pwag584Eeoqg9jh03O/YDoKuvE3cEWZqa4BbMrUl3arb8HNERaFKtWM+5TieEsF+AlClzhpin7xXKXJMPLXSM6Z5BmoK0a5ZG77lMnblxiO1IUazsTvGGbqoDpL2ZCEe7/vRnG++G3AlZGBDXtoK9NsDDSKjK0Yc4brjO0pCorpz382RlEiVj2/1FItrMUi5X8aSfdIbx7PZ7McBky1iQktEaUwLm6jTNMWmAOYI/3p2Uf8+MoLgcnqH8tosyFa0Ff+ICX50x6NoloW+ZefvlNnx/9zL9StT7VEF+17pGXyEsGZotKz1qRuFdMUAA6GRUGwO1GWRxRgYeTXKativN15E+FKjOCNRj3jEKclJRucTsDbuoXgZ3+aa6vSZ4cW52q1FIFG7kaZuc7YnrLd8iWKdVJki4byuYqM3iGocuqjx/XCZKnt1IOY86wIlcZWDrcDey3k1eg1qfB/vjZuCloX3n5EUoD0/WFQAGhccsH+BZorOT+1ifNYgzeUaglmuAnBRiyRTOJD/TkXtbmYak0m6xuYQfvrUKrQ8rtBOqDMcta2A3OeUkxSTGqZGQmBk+eK4U1qA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB7821.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(376014)(7416014)(52116014)(38350700014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qcPiXLbOL26GWcQncTEZJb0DoX1CBaBRTiy9wQV66yUEIHTTF6jSLMND7vNW?= =?us-ascii?Q?IrfL5KIUEdx2yykg3WeXv3JXHJlNQEeuxpEDd9OaRoLeVQcAHu7HxhFH3tEU?= =?us-ascii?Q?8mQIcu6ljM+l1P3l6w8YkslwbuXzhOhxtKBJUG9LFSHccX0b9kCtqbswxJYF?= =?us-ascii?Q?Z7R6/plFfx09a4OGPQt0u/+MQJIqTWvbRzWZcE2CjJZiExjcQ5wUpgj2UQUd?= =?us-ascii?Q?RAykpHkKT5ubXF0xUC6E+0TO4IIngtOXvtAUoSc9HO+OPX06Ys1B0QlqlkAU?= =?us-ascii?Q?xEMJAqfIDSLx5O5239J1MROfFaFk31q67Rc3XtrJgtf0cmUZyWqO5uHxzICL?= =?us-ascii?Q?MWss+eMi7r8/6XBWMG9cRDF+1HQ2KXmtXQJQEmV3T5HPji8urqK2GL9QS156?= =?us-ascii?Q?sy+qBgsJznN/bly107eG6AzKu+OjDQkq6gTRJRl6iz5Ro+oH7W0z0K4Le4xG?= =?us-ascii?Q?2PiqsXmk9VYeB4xA/pHprNOF1hH9plMydFSWiLm+1bwlYMiI2dtecglg0oGd?= =?us-ascii?Q?41mo//9Mjsb/H4/RqbZ1KWepZxVqD6eYscD5RVDlO8/1mJmaNdd6WatsgmOU?= =?us-ascii?Q?UGVBpYTEXSOuFHntmuxkj00DT9+6VRlShiFyTwHBf/uJLAEMmwJEmLtTYjJ9?= =?us-ascii?Q?hGiIyk9Rxbyiyc3A+EkXOat2t6qilhUlOiOxu4VNp0tEAcN50/6/3pZFeJ50?= =?us-ascii?Q?zFwcxWLiiNBSCce5B4AsOw+F0Uv35BfsENCxP/4Y8drXQNjFiv0TFMWW+Xx1?= =?us-ascii?Q?R2/cuQDIu4JVAyZNQ7w86/9YW42RdV3+7fSqjyz81z5acbNvV5s6RzaMFc7Z?= =?us-ascii?Q?5faF8AZDOKaVd9VU417oMtPZGodXvsCkgk5cc5UDVpaSKkfK6UjmIRbzh7MS?= =?us-ascii?Q?mIl646ZrM8/PYWy/MrEp1NgMGH2K9dXNV/oCXnAxBWYYw4H1IXsAnBnIMdFf?= =?us-ascii?Q?Willau2Wt12OIeK8/0d8fD15273HwVLkCG0NxoCquAOS8Ud68BYLP+yOtvtm?= =?us-ascii?Q?dJTzrWfhQcZhKKod8XpXwwgSzUyAWIOvwtEIicRxDZa07FSIa3KH2Bm9viGR?= =?us-ascii?Q?r/UjTm73sIphs+yejB/MItlVOPD85/r8N/yJqSJYtTSqhYYmNst7At0ps3Ds?= =?us-ascii?Q?MAPCSV6pw+ekGZ+a6Cj4FsimoDAF/WmaJTjgp98tY+2e97dyEPYNawtzAlUa?= =?us-ascii?Q?f5r+YWuUb/uZOKb3Y8Zf+gLHlhJX74TA6zQKi++gohmtr54L5+n1+5Iwkz7f?= =?us-ascii?Q?Ta/lFG+8XJbhjaQIYud4v6DOVRms5sdKvXyHKdUvahREY7Vm8tf3H0ZReBHS?= =?us-ascii?Q?Fb8+uz1tHSsCLDBAXCZqANjfYEoJtSXCFsQF1oncDvfkC2i+VuoVYuqoDseQ?= =?us-ascii?Q?H8XdIHID5XOrrQ4xRFN1YZNSRB3YQE4MVHpFECrNFbP7uPay/IajxzWAONzn?= =?us-ascii?Q?1B6fl0KNUjcEnAHHx+vfyVljjeDXV4X1ozrB+Mp9vOyJgEHScQJzXH8ByN0T?= =?us-ascii?Q?JIay1an715/jX6J1FLZdWWxTElNf7B0iBPiMoYKyDCqfg4MfOYSKA9ZKEbXg?= =?us-ascii?Q?LLaALfY+DKKVrmItZR+WhAvD0r+bsqoxq/MZPIVQkpDpwD/DXslf2PrzPF3x?= =?us-ascii?Q?e8ewVIEAzluGbAmP5x4f2kcIVS2z0+7vEeQ4Pg8ziKHrHXKPMIhfWGwhzvwU?= =?us-ascii?Q?579kTNixw7bL+8m+3LgOivuIKiUDHJpErn/ec8W9e5ZPzp1VziKl4BTMeYTQ?= =?us-ascii?Q?oZ2X+I5IJw=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d69ab4f3-00bc-4935-5957-08de8f0e2517 X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7821.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2026 10:13:24.9989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iiPkLY5q/UH52+cMMzIBiNEdr40b1rGHOGaCUso7HnYBQYfJOL/kKKmiIfJlKhfjYAonDq/e8CFdb0R7/AMNKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRWPR04MB12354 Content-Type: text/plain; charset="utf-8" The MIPI CSI reset signals on i.MX8MQ are active-low, but the reset controller driver previously treated them as active-high, resulting in incorrect assert/deassert behavior. Update the reset handling logic to correctly process these active-low reset lines. Signed-off-by: Robby Cai --- drivers/reset/reset-imx7.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index dd01fe11c5cb..b7048e1f10df 100644 --- a/drivers/reset/reset-imx7.c +++ b/drivers/reset/reset-imx7.c @@ -202,12 +202,12 @@ static const struct imx7_src_signal imx8mq_src_signal= s[IMX8MQ_RESET_NUM] =3D { [IMX8MQ_RESET_PCIEPHY2_PERST] =3D { SRC_PCIE2_RCR, BIT(3) }, [IMX8MQ_RESET_PCIE2_CTRL_APPS_EN] =3D { SRC_PCIE2_RCR, BIT(6) }, [IMX8MQ_RESET_PCIE2_CTRL_APPS_TURNOFF] =3D { SRC_PCIE2_RCR, BIT(11) }, - [IMX8MQ_RESET_MIPI_CSI1_CORE_RESET] =3D { SRC_MIPIPHY1_RCR, BIT(0) }, - [IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET] =3D { SRC_MIPIPHY1_RCR, BIT(1) }, - [IMX8MQ_RESET_MIPI_CSI1_ESC_RESET] =3D { SRC_MIPIPHY1_RCR, BIT(2) }, - [IMX8MQ_RESET_MIPI_CSI2_CORE_RESET] =3D { SRC_MIPIPHY2_RCR, BIT(0) }, - [IMX8MQ_RESET_MIPI_CSI2_PHY_REF_RESET] =3D { SRC_MIPIPHY2_RCR, BIT(1) }, - [IMX8MQ_RESET_MIPI_CSI2_ESC_RESET] =3D { SRC_MIPIPHY2_RCR, BIT(2) }, + [IMX8MQ_RESET_MIPI_CSI1_CORE_RESET_N] =3D { SRC_MIPIPHY1_RCR, BIT(0) }, + [IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET_N] =3D { SRC_MIPIPHY1_RCR, BIT(1) }, + [IMX8MQ_RESET_MIPI_CSI1_ESC_RESET_N] =3D { SRC_MIPIPHY1_RCR, BIT(2) }, + [IMX8MQ_RESET_MIPI_CSI2_CORE_RESET_N] =3D { SRC_MIPIPHY2_RCR, BIT(0) }, + [IMX8MQ_RESET_MIPI_CSI2_PHY_REF_RESET_N] =3D { SRC_MIPIPHY2_RCR, BIT(1) }, + [IMX8MQ_RESET_MIPI_CSI2_ESC_RESET_N] =3D { SRC_MIPIPHY2_RCR, BIT(2) }, [IMX8MQ_RESET_DDRC1_PRST] =3D { SRC_DDRC_RCR, BIT(0) }, [IMX8MQ_RESET_DDRC1_CORE_RESET] =3D { SRC_DDRC_RCR, BIT(1) }, [IMX8MQ_RESET_DDRC1_PHY_RESET] =3D { SRC_DDRC_RCR, BIT(2) }, @@ -236,6 +236,12 @@ static int imx8mq_reset_set(struct reset_controller_de= v *rcdev, =20 case IMX8MQ_RESET_PCIE_CTRL_APPS_EN: case IMX8MQ_RESET_PCIE2_CTRL_APPS_EN: + case IMX8MQ_RESET_MIPI_CSI1_CORE_RESET_N: + case IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET_N: + case IMX8MQ_RESET_MIPI_CSI1_ESC_RESET_N: + case IMX8MQ_RESET_MIPI_CSI2_CORE_RESET_N: + case IMX8MQ_RESET_MIPI_CSI2_PHY_REF_RESET_N: + case IMX8MQ_RESET_MIPI_CSI2_ESC_RESET_N: case IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N: case IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N: case IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N: --=20 2.37.1