From nobody Thu Apr 2 01:14:20 2026 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [160.30.148.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8689D29E10F for ; Tue, 31 Mar 2026 01:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=160.30.148.35 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774920673; cv=none; b=KLuoaeU1kHwiAeMLtiPKCCERugkITZGqMNZSFdgIaLTYTEI33P2iZjQ8TtNL1S2kEw9MkoiYdvnGfZwAHyDCBEC2hfvVoTIB66NBxFS6edzRI+t/LtMuX0+nEE5bEuQDZVB+1+wuVtBxfOE5Wyxri8iyBZ1qjuGimGZiI0F38gA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774920673; c=relaxed/simple; bh=HYhiM13tWaUR8e5IVUlaE/gNFaXZguuEWUvKVCHK+OE=; h=Message-ID:Date:Mime-Version:From:To:Cc:Subject:Content-Type; b=fv52H4byKxAUozPyceCuuNaV5SXB7ov6GTsv8ot94VnsYpPXfcJavb2r59xGaftPMRzlMdLct3MxMbZLvXHc+wE/eFyjqDjmfJIevUAmw7rKGHsLsosXNmW4if1t9jIR+9QY8/LWN64AGMOIbk+TPcnrMEaUqWDzmjk3SoAKRhA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=160.30.148.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mxct.zte.com.cn (unknown [192.168.251.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4fl9Yn0ByHz7QYRQ for ; Tue, 31 Mar 2026 09:31:09 +0800 (CST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4fl9Y82hzwz4xNv3; Tue, 31 Mar 2026 09:30:36 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.99.176]) by mse-fl1.zte.com.cn with SMTP id 62V1US0g037222; Tue, 31 Mar 2026 09:30:28 +0800 (+08) (envelope-from liu.xuemei1@zte.com.cn) Received: from mapi (xaxapp04[null]) by mapi (Zmail) with MAPI id mid32; Tue, 31 Mar 2026 09:30:29 +0800 (CST) X-Zmail-TransId: 2afb69cb23b5c32-faa93 X-Mailer: Zmail v1.0 Message-ID: <20260331093029749vRpdH-0qoEqjS0Wnn9M4x@zte.com.cn> Date: Tue, 31 Mar 2026 09:30:29 +0800 (CST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: , , , , , , , , Cc: , Subject: =?UTF-8?B?W1BBVENIXSBpcnFjaGlwL3Jpc2N2LWFwbGljOiBSZXN0cmljdCBnZW5wZCBub3RpZmllciB0byBkZXZpY2UgdHJlZSBvbmx5?= Content-Type: text/plain; charset="utf-8" X-MAIL: mse-fl1.zte.com.cn 62V1US0g037222 X-TLS: YES X-SPF-DOMAIN: zte.com.cn X-ENVELOPE-SENDER: liu.xuemei1@zte.com.cn X-SPF: None X-SOURCE-IP: 192.168.251.13 unknown Tue, 31 Mar 2026 09:31:09 +0800 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 69CB23DD.000/4fl9Yn0ByHz7QYRQ Content-Transfer-Encoding: quoted-printable From: Jessica Liu On ACPI systems, the aplic's pm_domain is set to acpi_general_pm_domain, which provides its own power management callbacks (e.g., runtime_suspend via acpi_subsys_runtime_suspend). The aplic_pm_add() unconditionally calls dev_pm_genpd_add_notifier() when dev->pm_domain is non=E2=80=91NULL, leading to a comparison between runtime_suspend and genpd_runtime_suspend. This results in the following errors when ACPI is enabled: [1.221416] riscv-aplic RSCV0002:00: failed to create APLIC context [1.221973] riscv-aplic RSCV0002:00: error -ENODEV: failed to setup APLIC in= MSI mode Fix this by adding a check for dev->of_node before adding or removing the genpd notifier, ensuring it is only used for device tree based systems. Fixes: 95a8ddde3660 ("irqchip/riscv-aplic: Preserve APLIC states across sus= pend/resume") Signed-off-by: Jessica Liu --- drivers/irqchip/irq-riscv-aplic-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-riscv-aplic-main.c b/drivers/irqchip/irq-r= iscv-aplic-main.c": index 9f53979b6962..d9afb6ae98cf 100644 --- a/drivers/irqchip/irq-riscv-aplic-main.c +++ b/drivers/irqchip/irq-riscv-aplic-main.c @@ -150,7 +150,7 @@ static void aplic_pm_remove(void *data) struct device *dev =3D priv->dev; list_del(&priv->head); - if (dev->pm_domain) + if (dev->pm_domain && dev->of_node) dev_pm_genpd_remove_notifier(dev); } @@ -165,7 +165,7 @@ static int aplic_pm_add(struct device *dev, struct apli= c_priv *priv) priv->saved_hw_regs.srcs =3D srcs; list_add(&priv->head, &aplics); - if (dev->pm_domain) { + if (dev->pm_domain && dev->of_node) { priv->genpd_nb.notifier_call =3D aplic_pm_notifier; ret =3D dev_pm_genpd_add_notifier(dev, &priv->genpd_nb); if (ret) --=20 2.27.0