From nobody Wed Apr 1 12:34:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C41373DD52E for ; Tue, 31 Mar 2026 08:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945215; cv=none; b=Kcmaym6ab7MoS5dRL53RMFQ5totqh14c1jp5CP4mfI6i4sgjlxntc9Halsx5mxb4uiA3JqMn4BRKaF6LEQAs7upBM8XtLNx7S+A4hYAqSQ0FQVkjnrQ12Yz6grVEX0VmV+8D6NV+CvgB1khjVQEXl97fZ4iDtQx+Ws4725mqqfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945215; c=relaxed/simple; bh=7HlX7K0rB6FHxEr7PW+FOibnF3f/ezyXYVU1a+d59NI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=QLRbOpXyNK019YoVDgLqoFmHRgookrZFswwFh3B67eZqATp+sdDUUWyYqmEQqq3CUqOIUsDLiIa7ziEFeO6Zy/ON/QKVBci+4hZWYX3HjMqvCVZnDSFhdiZoVQp3pyd7nhxE2AwI4Bbjf697FWeb9g8KK94msF76UGmt+3jdtcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gfkL9lU/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vi7NlksN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gfkL9lU/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vi7NlksN" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V3vgZ14053797 for ; Tue, 31 Mar 2026 08:20:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=q4UoNmtk4+lUy4YruyrWEo 06Vis3pSaL7lf3dCzvzRQ=; b=gfkL9lU/GHT2FkuWnXBIs8tCe9bhU1CzuZ9cuN /xBRy5/qQC5viW6tqGLxwr8W3cYErVFSXsRSAJ/pwYn9U5LBhYIzXxDNfItMJe+j tFwRlBPAoKej6s/aDiRpb6EGWEJfLOQI5SfUIqh0QGtxPh9DEVFcVvnXEAuh9KLF USd3kke8rmOICXPdCzsTPyTUxEQDOo0y5yVZlJ1zvRJTgAQ3MokwrUYLRHZaNMQB RMm6xVFjlIBOJ4oRi309FzdP1nMEv3IfAEDiv6fCXLysLznABelzJEc+FR+cCZmE llEvegNcUcpoG5MCSXfFZnw4EX4wrlLaVAeLeYwL7F5YmZJA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7xx3ajan-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 08:20:10 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b220c72bbso201345591cf.1 for ; Tue, 31 Mar 2026 01:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774945209; x=1775550009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q4UoNmtk4+lUy4YruyrWEo06Vis3pSaL7lf3dCzvzRQ=; b=Vi7NlksNVLRIA+e6IP5CFBiY4TubCw3QyfYBjSdYVcYlDlmBOQcZlImIznIh7t2Zb8 uyhhRw1xicfKLrPSiObDHZwhrc+VVZNUEsjnEycfOJJ4SHi/oKvbbGklr8RlT9BBnm3P 1DEwzw0aEsfqomqFy3J4qOXJreX5SYfgaOu5m7/2MDjDgPNkgGLbVBIErt9hwm7PU4yz aLgPWpfX8h2khBUiy50NWkGF1p84o/HO144NGtR27YNZbbqER/PuLcGqGmRufTmq3230 ofbAdMf0NrwVts0q1FmKTFNv3eWA+92XTZwy/bTDFklS2rrnonkXSoL0/Pa/hb/ZnNny IqOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774945209; x=1775550009; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q4UoNmtk4+lUy4YruyrWEo06Vis3pSaL7lf3dCzvzRQ=; b=NUVt4MCW6zwXJXjxbjU8WSIYKMQ8prcypECTDyeow6jFzuS45Jz/9Rp6/YCc1MrY4C daUFJ/mzYQyCSEFfcPuZ/OmtwgduYsr37wA79LLCS6eFaoTEjHIFjB3x+p3fKE4OC2bA 9+DPK0IHS8GnSnIKxF//lxBSOnOss5YF5BQWrTNAysmoDiGrpHssHqbfcI4e/V+rSTaz cVmpSq5/nbRefARXnReqCsKU3SeSV2k24pbts1b1yCwAYAM/k8SMfkTFvUGtROQuW73v m133JJoiv9LJxEVbG6xOdO0EhQ7I6qQqLh3vOPVie7rwDDzqmsw7Vcc1YmYne6PsDdYz 77fg== X-Gm-Message-State: AOJu0YygApcXZuG4Rr139WJZxlUjZUxSv2kQktOAZSL7vwXY/OEy05B7 ULbJUeNCQU/KMQR75ckVVuX3doCC+ny11+bU+kxg6Axx+JyDn8n1qz1/IUAqsXz22pMgScRdkBC 4htrXWMOP14cIWFanQ5XhwL4+ENvFr9/HTeESoM/yxf9+nCO8000J5EbU53FxztPyF6c= X-Gm-Gg: ATEYQzzcJtFdRydFXS/wHkLutR20e1+0gRyDF853tSSWDPyLCOfXgNKdbaEfclVe5YB 90EZDHHMnMm8DuS2GHP905VJ9tTN1FfbkO3Eag9QXAkmobWzW2zp7yimCDFjz7MStvwPexIuomG bJ8MqdEm5gYSUq499BhKWf5OWbOa12T/hd0nNNHwb7AW3ofkf+9yDA7qIi4rYzQhJe4FVqkGTz2 a3F3SrhNaXUYJ7UPI/WkuRT+ypw8tvDKWvcsVsHR4PzWsJTtds/LFrDVcOjgW356/fbYW5p8weq cKtyaQ4DsvXsstf35Nf9L3b7UNDK+/n9Oz9KKSwGli8zULQsFpaqTpzes/LH8IKM4rcX8Qhdjwe 4X/8lh+GmVSfSk+7Xz5DLYjw89UJ3E29joU8e5+6Ipu7ocryUpA== X-Received: by 2002:a05:622a:5c9b:b0:50b:483d:3669 with SMTP id d75a77b69052e-50ba39457acmr211447361cf.62.1774945209494; Tue, 31 Mar 2026 01:20:09 -0700 (PDT) X-Received: by 2002:a05:622a:5c9b:b0:50b:483d:3669 with SMTP id d75a77b69052e-50ba39457acmr211447211cf.62.1774945209099; Tue, 31 Mar 2026 01:20:09 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:29fb:516:a90f:8dda]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c536a7fsm20175995e9.1.2026.03.31.01.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 01:20:08 -0700 (PDT) From: Bartosz Golaszewski To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] tracing: always provide a prototype for tracing_alloc_snapshot() Date: Tue, 31 Mar 2026 10:20:01 +0200 Message-ID: <20260331082001.31345-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ErbfbCcA c=1 sm=1 tr=0 ts=69cb83ba cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=UYJXNk30lqNtw5BBiLEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: yY2VK6swxj6moyvCht7GUKHcIK-Hw6j_ X-Proofpoint-GUID: yY2VK6swxj6moyvCht7GUKHcIK-Hw6j_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA3OSBTYWx0ZWRfX9N8XkX8K3gDw 9i8MxwqDi/39wsq3cHO0qQjh5ps2DS8E2lAQuLpeymKhanjwhYQweDNiS00BmHTUq+a2g4h+ZnX oIedvkhp+fvqb1+L2KuGVfJesygBAiK7YkgqH2AH7HiK6rJE3EXP1GQmHHrGlK6a55DcITAJJY/ sDxCrBQ+1Qb+/lvniGEIy9eyuviWvWWyBL0mJ9mMnneC+lh/rJ4Ttvtfri9nqA49U6+Cb30Natb dk1yHzsrwPjhOzZiLFdKconNOqyTZOi91i3r0bLmC9iX/6SJ+uJynmKL3FnCRRR8ELQbn2GQv5o J1Rhd97TWzNMtqR0+0e8t/IHjyhmABYBklMiTnfZ+dy1UtwPhTn7votbcDEdASSgSLia14iAEqR wQ6sNl+GPeqpaztqHQBiy8wiHsKmxsD+41qfjxduURtBjmEPwkWbPWiOk/QAqSC0m7q6epLTGrq yr2NmoHWvoz6Vela0qA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310079 The tracing_alloc_snapshot() symbol is always exported even with !CONFIG_TRACER_SNAPSHOT so the prototype too must be always visible or we'll see the following warning: kernel/trace/trace.c:820:5: warning: no previous prototype for =E2=80=98tra= cing_alloc_snapshot=E2=80=99 [-Wmissing-prototypes] 820 | int tracing_alloc_snapshot(void) | ^~~~~~~~~~~~~~~~~~~~~~ Fixes: bade44fe5462 ("tracing: Move snapshot code out of trace.c and into t= race_snapshot.c") Signed-off-by: Bartosz Golaszewski Acked-by: Masami Hiramatsu (Google) --- kernel/trace/trace.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 6abd9e16ef21..e8612b8b0a34 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -2275,6 +2275,8 @@ static inline void __init trace_event_init(void) { } static inline void trace_event_update_all(struct trace_eval_map **map, int= len) { } #endif =20 +int tracing_alloc_snapshot(void); + #ifdef CONFIG_TRACER_SNAPSHOT extern const struct file_operations snapshot_fops; extern const struct file_operations snapshot_raw_fops; @@ -2282,7 +2284,6 @@ extern const struct file_operations snapshot_raw_fops; /* Used when creating instances */ int trace_allocate_snapshot(struct trace_array *tr, int size); =20 -int tracing_alloc_snapshot(void); void tracing_snapshot_cond(struct trace_array *tr, void *cond_data); int tracing_snapshot_cond_enable(struct trace_array *tr, void *cond_data, = cond_update_fn_t update); int tracing_snapshot_cond_disable(struct trace_array *tr); --=20 2.47.3