From nobody Wed Apr 1 11:16:22 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C1C3C3436 for ; Tue, 31 Mar 2026 07:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941947; cv=none; b=CZHNz3AwvrG4EjPYUtBswziaDO0q8TquEdPoA0mb9/NYAzIlwQXz7PLEXSE3YznyQkfaJVdNI5r56e74umPfCJTb+zhK1Jzv+srlG7mJNgq1ZhUuIpYDF54aJDBF5+s2igShhMWUfhxR6puC0nFcOvluYilOrS/iFcsJ9FPHG68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941947; c=relaxed/simple; bh=AaeubZhtz8ojYJt5zsFPfxtOPOpZylhKBuq2cPd6gUc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F07NgaNmybqlYrs5W3Ej9wd+0ykfGMY9VQSuKvDoGcJL3pgSpvgRmS2JCBtzDT7Wc6Oy6XhMBqAcLPmGcFasrBQbqH0cdYPMJvEWir2BtBa5IK2Wbztg/MqLZsPGGlKys+WSQ/VJE3GBYa2J1N9iV1gfggFpxMx+y1HphTgEcUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ISBDELZo; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ISBDELZo" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2b24fcc2b5dso13772285ad.1 for ; Tue, 31 Mar 2026 00:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774941945; x=1775546745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YdIxdgSG7WGFBTZ3ix+HECNRQzg5xB6W1qz3YgiFcVw=; b=ISBDELZoVA79l2qKRTz+OelldXMNPFQ/tLQah08s5Dg6mQmbNSvKfCpWQCeLBJ92ko d6NGoccBECucC48npR3iJsjbQWO//P5h3XhMLf7OSBxmsuFvP+tw+B6HxSRfb3xIB8tn SjxMikPTC/bpCcLBn+W95+Popxmj7zJMpnEb6A5bzEqPCGvpbLpTmRpi73IaDDjXBA87 mbWbHfw6b63JR5nghuD5tsQRI3RVFjFN9d4czdDqCtFY9LiqTjcn7RCz5ErMucQvF7cu LnIlEJL0cTwAr11mhrqABzq7/MV7KnThtAtfgFpffFyRfkt07rWFgBfX5uHuKIxC0DYP PqXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774941945; x=1775546745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YdIxdgSG7WGFBTZ3ix+HECNRQzg5xB6W1qz3YgiFcVw=; b=f1cfCzsIjdLBjGX/GjjpCU1D/8ItJdSmuzzGEXJQQ9UVIUcLRzYokfEfeBf3WcZyg+ Uej1ges5Gfq5/nxw3ZdqLeHben6Andc4K4U8PbealoiNZ6hIuYnTl3rcejfoSw2z+k1s JzGcxjmSfsMMjz8AmvZzpzWGoRlxK/4kBASXa/eYrxCdmlUfDB490cxSOT4Q5zZ28ZB4 5RY8WCBM/MsBaaYrNRjYlt7J2M8EKZNQxG+9mZ2IsiPj6UQkMom4LQAz+4GP6IyiwniW gchoEgB6iwFqnbNnhe1SxBjEbNbgJE2UNnqs49Aeq8QVgkKmtiEOp03nljgY6RSCaDif +oqA== X-Forwarded-Encrypted: i=1; AJvYcCVlQ4jaCNGeBuxrk+t0MYCJfYMnMYQ1FghHiTgC2RAgkFTYKUTSvq9gZn72KNcv8L0pZmJ9KhAFsoM0OmU=@vger.kernel.org X-Gm-Message-State: AOJu0YwsQOgtDIiTxUX2D0YIDXfbWdF99oTPpcyntSjaGEINnxMWjZmY qUM4QNnYB+8A/4a9WJttG+unNyxMMvtQ7BOWDc5Tj9VJC26qqBzNEDVA X-Gm-Gg: ATEYQzyZWKWtYFB0CYf40VYSo1CRWpb9mMTQ0Ez4VySBIDHPQxLMIbcXzrS04y13EOr TPir5NQo8zAm5ywSKL2rPOAQMfqBw56ZPAubRdX3OGu/XhRH7+NKVPdv8/59vEQSXrmlfktf3Lc W2PjHAUpocd9CVDNJOq7zj4XQXw15Up8p4amr7eIlQG2or1fNYqWiy/06jxbHr5AFCo6KzGKDdP tZ+cutHgsMbcOiRc2m3WQ3eqFUidevfpYoY6lpvLVa9LdZS24TevsqhGedSYmBQOmlIoJ2z9md1 +pThvoGvcrDvfK1kwMZYn/qP/l4OUhTbykZmPFnewEdI+HF1Zwa5OdGNN4P8N4M6OsqEt+/8oWX Nh+IVUBpxxyJlGhyF7uyUvk8EKkjBClBmZPP4++OQwFZ2MXgvgjgjZGVM5tJBFnrvOS3NdGREAx jNpVxaE5RnB1DCQ/yH1ZQv0ItTzCviaGN0UXaZegg= X-Received: by 2002:a17:903:22c2:b0:2b2:5515:661f with SMTP id d9443c01a7336-2b255157499mr60408695ad.9.1774941944981; Tue, 31 Mar 2026 00:25:44 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:5412:6527:d590:8704:ff8:2ffd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm109272495ad.6.2026.03.31.00.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:25:44 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v4 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Date: Tue, 31 Mar 2026 13:24:53 +0600 Message-Id: <20260331072453.6530-5-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> References: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Modernize the driver by using IIO_DEVICE_ATTR_RW and IIO_DEVICE_ATTR_RO macros. This involves renaming the callback functions to standard _show and _store formats, making the code cleaner and more maintainable. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 72 ++++++++++++++------------------ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 790b04544..c83f7f70d 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -122,9 +122,9 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -132,10 +132,10 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -151,24 +151,20 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -176,10 +172,10 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -209,14 +205,11 @@ static ssize_t ad7816_store_channel(struct device *de= v, return len; } =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -240,7 +233,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } =20 -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -270,9 +263,9 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -290,10 +283,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -331,8 +324,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1