From nobody Wed Apr 1 11:16:23 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9D13C5DA8 for ; Tue, 31 Mar 2026 07:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941932; cv=none; b=Ge3qcvV8NHCHW2ruuF8QVAQ071nJO6fl7YIwqGIfbkbevhQIHdmuWcDBU2Aa4UQwjlYqQ427tHo9JlfPgRPT+dW0OLPuFMYLvVHiPyYE4SJrnxRV0fZSzK9O6qXp/r/XKwMCz4KyGYYEvBAYQ531X4Qz0E44cMUnmczPMJvcfRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941932; c=relaxed/simple; bh=GnqjuQY2SpYNpEiu023jp+jx3wPKs2w4MJgRFZGBcBU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZEVTY7zT8p7IueOtbJqqDYNT9EZ4sSTxiZbOC3eVxwvhVLuse/a4iM/Cl8Ts0ZY59fGd71NKenm0AEZ+pGjMKzWbUYGAcVf4p0Ilgx65wm3Rn5rMhbXak/PBmqeMbhZbg+UmIQXHCyfTIR4hBoTax+7Ni4MJZeTD82lnVg5GsyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kS+acAMf; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kS+acAMf" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2ad617d5b80so37289975ad.1 for ; Tue, 31 Mar 2026 00:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774941931; x=1775546731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UUTK122ypo+0e+etGwYyhErGcBcCbI2DEOZyVvoyYr8=; b=kS+acAMfaUeDnndOCHFAvJoauEGmKeKj4d9UWvwJsFXKc3NjFg0GoVeQ6XPLtIx7SY P3SyW8CMIjT/oDEvbq5cSNlxOP/fm5ujz74bbyjhAq3BfNquYSeck4J3T4/TxVqodSa/ oC4kDbs9CVMpE2jcwKsLWGzQQfrnJzB/NABIZTIu+GmLgK+EayaVCgNfK/4rYeXlw1zk D4IZ90PvT5SOb0DJz2mRiR1JUoqeMGE1aUHC+vC73KJyYWyaKvmMQ8OskwOV945BzPZU tGDEp4TiKJ60pIUcxX+r6VZCNqzav2dkJyVHqdngGyYsISycIgmqlj6tqsDSonO3JRpm c3Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774941931; x=1775546731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UUTK122ypo+0e+etGwYyhErGcBcCbI2DEOZyVvoyYr8=; b=W8NhKMaqoON5VZenbhx6KlX++QsAliNEVmHcS4RXtChZ69z1/OhOn+6s/7B91Kl3Ij ydDkImn+YY/dwD4OMvxtFUV7aE5jjNIcuf6Da2v/uVU4Anta5ujaB/NfOY05XRoEsRUg VMhN/ZkZQaL+WfbpXVSQwTOFEU5MrwTvU6xFpuoh1q2DTRVGcOgDa+xV/EXTdpRjpzcU 8B5mR+6rsFk95OhZhXJ/P1JA8WKU3iMI/UI6D6wd5qZ8Mhhvp7Uqqu+C7ldgKILHfucz d93HxfaA57Qn0zHsfPr0J48vzmwvs3SK+IISZ4g4Vhlt9v4PhUInIiKG1hi2vcIBpLiZ IOHw== X-Forwarded-Encrypted: i=1; AJvYcCUwrOU6EdeksMIPZbifplmCZgsZveDt0Ac3TK3R49EM6gX5jTvegWvS2wFh3t3Pi1KLCaxHTDEtBxOWR/8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/+hp5fMGFBCqByEFocignVPJj+xd5nTr5605Ag6rLauouMOIQ p4VPHs1mm7V8FzoTef6Wcx00D/b/O7OWVt7JJ5Ej/XBBpZ2m6NHR+xnP X-Gm-Gg: ATEYQzy3yQ8gN+97IDhmMY729+KzQgldVn8LhyDhyEy6Bgn9pn/rghcY6UFRU2oUxNK Ms0pkVR8odPZP4zxGwPUZjG7y5C5Hh+XP4FMRfcpAtrccmBOhHdc091BYaoiPcK09grarxlpmbi I+5oJQ79IgmH9m13WwfyM484Kr7CgcHF0C8gDql0zSl8xYrxzTOkugBdiNcHbRxqbSCWVLzrH+3 HSGcuq4nsjonrF9O4gbCqCmQw3l8+zBqmTW40/vFaZhQjpffXMDaCOMJQ8NesRWqgYeXYy2gWFt kcWCSW416MkMLEgsLlO8QGewVAJsrxHK0UOJ/xLES6DpAT3e3+ffV+ahKNeIcu1PUMREhIWHIsA I1RAms/EpnAwBxPxssPRK2a0r1FhjZtqyFoIG7njUnbYF84AfwLJcr/JUnanuD/zDM4NQLjYROU MXcuvUTzrOETUWy48Gg4Hkmg9S4tA2HhJ5Ezdp/w8= X-Received: by 2002:a17:902:cf0b:b0:2b0:c90f:449c with SMTP id d9443c01a7336-2b0cdc22e03mr152495895ad.9.1774941930836; Tue, 31 Mar 2026 00:25:30 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:5412:6527:d590:8704:ff8:2ffd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm109272495ad.6.2026.03.31.00.25.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:25:30 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v4 2/4] staging: iio: adc: ad7816: use sysfs_match_string() for mode selection Date: Tue, 31 Mar 2026 13:24:51 +0600 Message-Id: <20260331072453.6530-3-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> References: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual strcmp() logic with sysfs_match_string() to simplify the mode selection process. This reduces boilerplate code and leverages standard kernel helper functions for string matching. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 9a2f60b97..253ef2262 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -59,6 +59,11 @@ enum ad7816_type { ID_AD7818, }; =20 +static const char * const ad7816_modes[] =3D { + [AD7816_FULL] =3D "full", + [AD7816_PD] =3D "power-save", +}; + /* * ad7816 data access by SPI */ @@ -136,14 +141,14 @@ static ssize_t ad7816_store_mode(struct device *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); + int ret; =20 - if (strcmp(buf, "full") =3D=3D 0) { - gpiod_set_value(chip->rdwr_pin, 1); - chip->mode =3D AD7816_FULL; - } else { - gpiod_set_value(chip->rdwr_pin, 0); - chip->mode =3D AD7816_PD; - } + ret =3D sysfs_match_string(ad7816_modes, buf); + if (ret < 0) + return ret; + + chip->mode =3D ret; + gpiod_set_value(chip->rdwr_pin, ret =3D=3D AD7816_FULL); =20 return len; } --=20 2.34.1