From nobody Wed Apr 1 09:45:14 2026 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 005413BFE47 for ; Tue, 31 Mar 2026 07:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941925; cv=none; b=hE4/63SzPQulZ6Y0G7wmFlsKpxXfu0f7/B3L0Dgsyq8umyRdyQUn3YxELGtpDU3c30gMjmEbJxLO7CiASjDib3jJ8p7mBX5N+abZgRPIQbxP6yq7f8I4+3btS4SuTC9OY8XvMUDEP8ZheH4dJNCwwUtrJyis259bAqyplUEtpn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941925; c=relaxed/simple; bh=7eZ/V2eaMySxWxCo4cGkZvPIdKQnHRuBxfyly5k7J8w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Suo4q1m8iWSmj1w13LgrEHI7JU57x/olgUaZteM5G3aX4HnSUcSTL0Mf1Ok8BsT14qJRXAgmxiyf4lnDzYWDNO0UfeZ5+J2LTwT0F9hCYYzMssPLUr0LL+L57o9rn+NboSfhBW+elZpt4s0sCAm/nJOp4EbsRGOAEW5qExoJCcE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mHZa81Tw; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mHZa81Tw" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so52336905ad.2 for ; Tue, 31 Mar 2026 00:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774941923; x=1775546723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fsyQeIKYq/U0F7fCPtRCvH+bKBGjWc1PKEHcjMfaaik=; b=mHZa81Tw94RIgZyjZmnVwfaEGbXyzjQXnUbLQPRkmwI0NGpHbNtC05+h7PVKZ200MU KG7UN/Hu2wDO+xFCb2FUt7Edzh9xZGwDnVXpKwfUcGyXNhKDgBZDjLSx1fdinY7A5ngb PF4WvjbjoWrdgU7NkpkT7wVmY9mrfNmZ79TOQcDMc1LKyVIWBgCIMYw9oZQmjVWRoN36 e3HH5UiXEpXrNdqCvmjzqVL2fcMDIN0MoFhe+eXwSeAUInXlJOogZp7IUAcLcP2EfQcY 8jj3foW1a5r6GinpuHsZXUFqN6QKm5ARLEQkXU7CRZstRMsQ6ZeFIeWamOXLSXySBLXj xhEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774941923; x=1775546723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fsyQeIKYq/U0F7fCPtRCvH+bKBGjWc1PKEHcjMfaaik=; b=sXeG+nrwyDRaYjjqOa2Lfbobo3lpT/uDn5oHF7BK3EeIsMCBy+z6xTvDUa9aigdNRd fzbR+Dc+Y5/FVP/l6RnlaKgScgjDWjiyX8pwc1PIPyeTwk9lm22j1zCbBZ3p/JQI1frA B4BmkVr4i5K2xfDBejClIB0D0Lw87OEOtU9Abg2lZJc2DmtKLkOVvkx+xGp4FHMloo/i hwvBvZKPb+WgAuOeXqOLpMEmUo2iEBDfeSAFWJcqMQP3bbHylCTms1rTyw7km5QhcJ65 gpRLWW1v1cPebl9y8Ua+oTzPRAD4851SIwPRo4E/KYTy/pbwENHhZ6aruDMVmPdAidps m7Nw== X-Forwarded-Encrypted: i=1; AJvYcCVN3+7Sw//R6qdGvXvoBAp+EMvQEL5uxuTct3avZrfTIOYY/HOYEgkaFZjswMFjLsaWaZBhydQh6h8IsRw=@vger.kernel.org X-Gm-Message-State: AOJu0YwWGBQog1EaBchWH7IHsnOiDJhnlTt8xRUta2QmEQ9HpXH47jrW EmFHfUAIrtq/6KAcq/tXdUHEy+d6imOrMs1awyqPGmSkuX0oVcUwSba0 X-Gm-Gg: ATEYQzxPXuwLYfV4xaGMd++uYeDX9FYWOW1Zwq1KpDBkf3JHGXCd4Er+CzKBzUywbIL aEUGdJS00iehcbSN1Efm7jnqRtoDzhuGQUaJ1qZ3+P8D9eIyJKN8HBSsXdwba+LX+LcnaPs5aHS 4dmdwk2Arxtye/ntht0dwkwGqGhyxEWkNStXyq6qo70p0vvhFo7rzqvJKDCK+P99yGxsMFLRoI5 qtv+NSf2+gtVvWVPJMKAhaq5hE1l5/ffELQ/REOFBOC8oaXPGUc7zxnzYnFkC3Qax0npKPRC8dv 1G1McEO0gEWOmELUpp0gV01TmrHEQ/OB1VaocaekQmlx8d4KADH2CJjh6mClWuGYLUl8Uu5uusr ViIQYkxoUOnQV6GEGPairv9zb70FW+hgl65bRwz1plzHC+XOzN1jGvQGP9OP9H77f4TCbZTyVTk aRvQdEJK75J0s15xDiCzQKYIAmGj6sw90Tx8g/zqI= X-Received: by 2002:a17:902:ea0f:b0:2ae:55eb:f82d with SMTP id d9443c01a7336-2b0cdc1fa6cmr162368355ad.1.1774941923274; Tue, 31 Mar 2026 00:25:23 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:5412:6527:d590:8704:ff8:2ffd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm109272495ad.6.2026.03.31.00.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:25:22 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v4 1/4] staging: iio: adc: ad7816: redefine mode constants to start from 0 Date: Tue, 31 Mar 2026 13:24:50 +0600 Message-Id: <20260331072453.6530-2-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> References: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Redefine AD7816_FULL and AD7816_PD constants to start from 0 instead of 1. This change is necessary to use these constants as direct indices for the mode string array and to align with standard indexing in modern sysfs helpers. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 172acf135..9a2f60b97 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -22,8 +22,9 @@ /* * AD7816 config masks */ -#define AD7816_FULL 0x1 -#define AD7816_PD 0x2 +#define AD7816_FULL 0 +#define AD7816_PD 1 + #define AD7816_CS_MASK 0x7 #define AD7816_CS_MAX 0x4 =20 --=20 2.34.1 From nobody Wed Apr 1 09:45:14 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9D13C5DA8 for ; Tue, 31 Mar 2026 07:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941932; cv=none; b=Ge3qcvV8NHCHW2ruuF8QVAQ071nJO6fl7YIwqGIfbkbevhQIHdmuWcDBU2Aa4UQwjlYqQ427tHo9JlfPgRPT+dW0OLPuFMYLvVHiPyYE4SJrnxRV0fZSzK9O6qXp/r/XKwMCz4KyGYYEvBAYQ531X4Qz0E44cMUnmczPMJvcfRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941932; c=relaxed/simple; bh=GnqjuQY2SpYNpEiu023jp+jx3wPKs2w4MJgRFZGBcBU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZEVTY7zT8p7IueOtbJqqDYNT9EZ4sSTxiZbOC3eVxwvhVLuse/a4iM/Cl8Ts0ZY59fGd71NKenm0AEZ+pGjMKzWbUYGAcVf4p0Ilgx65wm3Rn5rMhbXak/PBmqeMbhZbg+UmIQXHCyfTIR4hBoTax+7Ni4MJZeTD82lnVg5GsyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kS+acAMf; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kS+acAMf" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2ad617d5b80so37289975ad.1 for ; Tue, 31 Mar 2026 00:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774941931; x=1775546731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UUTK122ypo+0e+etGwYyhErGcBcCbI2DEOZyVvoyYr8=; b=kS+acAMfaUeDnndOCHFAvJoauEGmKeKj4d9UWvwJsFXKc3NjFg0GoVeQ6XPLtIx7SY P3SyW8CMIjT/oDEvbq5cSNlxOP/fm5ujz74bbyjhAq3BfNquYSeck4J3T4/TxVqodSa/ oC4kDbs9CVMpE2jcwKsLWGzQQfrnJzB/NABIZTIu+GmLgK+EayaVCgNfK/4rYeXlw1zk D4IZ90PvT5SOb0DJz2mRiR1JUoqeMGE1aUHC+vC73KJyYWyaKvmMQ8OskwOV945BzPZU tGDEp4TiKJ60pIUcxX+r6VZCNqzav2dkJyVHqdngGyYsISycIgmqlj6tqsDSonO3JRpm c3Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774941931; x=1775546731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UUTK122ypo+0e+etGwYyhErGcBcCbI2DEOZyVvoyYr8=; b=W8NhKMaqoON5VZenbhx6KlX++QsAliNEVmHcS4RXtChZ69z1/OhOn+6s/7B91Kl3Ij ydDkImn+YY/dwD4OMvxtFUV7aE5jjNIcuf6Da2v/uVU4Anta5ujaB/NfOY05XRoEsRUg VMhN/ZkZQaL+WfbpXVSQwTOFEU5MrwTvU6xFpuoh1q2DTRVGcOgDa+xV/EXTdpRjpzcU 8B5mR+6rsFk95OhZhXJ/P1JA8WKU3iMI/UI6D6wd5qZ8Mhhvp7Uqqu+C7ldgKILHfucz d93HxfaA57Qn0zHsfPr0J48vzmwvs3SK+IISZ4g4Vhlt9v4PhUInIiKG1hi2vcIBpLiZ IOHw== X-Forwarded-Encrypted: i=1; AJvYcCUwrOU6EdeksMIPZbifplmCZgsZveDt0Ac3TK3R49EM6gX5jTvegWvS2wFh3t3Pi1KLCaxHTDEtBxOWR/8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/+hp5fMGFBCqByEFocignVPJj+xd5nTr5605Ag6rLauouMOIQ p4VPHs1mm7V8FzoTef6Wcx00D/b/O7OWVt7JJ5Ej/XBBpZ2m6NHR+xnP X-Gm-Gg: ATEYQzy3yQ8gN+97IDhmMY729+KzQgldVn8LhyDhyEy6Bgn9pn/rghcY6UFRU2oUxNK Ms0pkVR8odPZP4zxGwPUZjG7y5C5Hh+XP4FMRfcpAtrccmBOhHdc091BYaoiPcK09grarxlpmbi I+5oJQ79IgmH9m13WwfyM484Kr7CgcHF0C8gDql0zSl8xYrxzTOkugBdiNcHbRxqbSCWVLzrH+3 HSGcuq4nsjonrF9O4gbCqCmQw3l8+zBqmTW40/vFaZhQjpffXMDaCOMJQ8NesRWqgYeXYy2gWFt kcWCSW416MkMLEgsLlO8QGewVAJsrxHK0UOJ/xLES6DpAT3e3+ffV+ahKNeIcu1PUMREhIWHIsA I1RAms/EpnAwBxPxssPRK2a0r1FhjZtqyFoIG7njUnbYF84AfwLJcr/JUnanuD/zDM4NQLjYROU MXcuvUTzrOETUWy48Gg4Hkmg9S4tA2HhJ5Ezdp/w8= X-Received: by 2002:a17:902:cf0b:b0:2b0:c90f:449c with SMTP id d9443c01a7336-2b0cdc22e03mr152495895ad.9.1774941930836; Tue, 31 Mar 2026 00:25:30 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:5412:6527:d590:8704:ff8:2ffd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm109272495ad.6.2026.03.31.00.25.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:25:30 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v4 2/4] staging: iio: adc: ad7816: use sysfs_match_string() for mode selection Date: Tue, 31 Mar 2026 13:24:51 +0600 Message-Id: <20260331072453.6530-3-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> References: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual strcmp() logic with sysfs_match_string() to simplify the mode selection process. This reduces boilerplate code and leverages standard kernel helper functions for string matching. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 9a2f60b97..253ef2262 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -59,6 +59,11 @@ enum ad7816_type { ID_AD7818, }; =20 +static const char * const ad7816_modes[] =3D { + [AD7816_FULL] =3D "full", + [AD7816_PD] =3D "power-save", +}; + /* * ad7816 data access by SPI */ @@ -136,14 +141,14 @@ static ssize_t ad7816_store_mode(struct device *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); + int ret; =20 - if (strcmp(buf, "full") =3D=3D 0) { - gpiod_set_value(chip->rdwr_pin, 1); - chip->mode =3D AD7816_FULL; - } else { - gpiod_set_value(chip->rdwr_pin, 0); - chip->mode =3D AD7816_PD; - } + ret =3D sysfs_match_string(ad7816_modes, buf); + if (ret < 0) + return ret; + + chip->mode =3D ret; + gpiod_set_value(chip->rdwr_pin, ret =3D=3D AD7816_FULL); =20 return len; } --=20 2.34.1 From nobody Wed Apr 1 09:45:14 2026 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 304E83CAE76 for ; Tue, 31 Mar 2026 07:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941939; cv=none; b=QRJHoU9pjLKoYhmkn5Vs6IBoQvJspobou4CKVVPxH03MUeNKfPRAOOTHbPP2xdN+9OvCj34xtHSsBEaL4AxyqQMCNN9thEotUEz7Xhl781+yzO+2hgyZiwaz09CE8iTjCV05ARTYFM7U5Eb7UU4IcDtlExZ6yxFz8YtHQEUlgKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941939; c=relaxed/simple; bh=tvHGLlUW0934gu/EunJKAraP8P2NLrTeFjBRV1t97OQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qilgUmmvSRH5sxyIbO6hr3OlHn4B2MpyyuyhBp40lIMOoH2J0xdSEOa/66wf7TXmY4sMxqSgpm5U+HhnIGJsFwUbSSxNtHy7vlIzkf0dq5WGsQmO4HLlcGNJMdh10cf4gkm5mo8q1POdwDQtyvSIjDNnwGXMlzv/dO/vTIuPcQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AE2BwzNS; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AE2BwzNS" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2ad9f316d68so23598765ad.2 for ; Tue, 31 Mar 2026 00:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774941937; x=1775546737; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I5w9449oT/0NgVOnXXa2/F/Il+1HxCjHPZUwGwVZnks=; b=AE2BwzNStX/aqv5GG+uKISpAIOQt3chiknc/pOxZWA6GIQJVK/3YWd/euGU4/FvtjM 8mqzumuiPsXyD/5/BdHVjOJLhXKetJzVc7eBzeFHyP91nNTI6gQeDPW/nx9V9X6EQ38y nf5HZRnN2AK0UoIeBe1q5hoNi+7j4BnIW+RjiSUzDdlo2OKXgF6xHuekVSgtG4rNDJTp OTh/y2jiTYZ2FKf1jEdTWNLpZRWW0sS6Mv+aUoY6IIksfANHTOEQJw5+ldmHQiKpzu7I CD190+iZjAjzHNBJGp894q7gci9behB3NzI7fg/OOrFS0rNDNGosiN42kZlttRPSM6E0 OVSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774941937; x=1775546737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I5w9449oT/0NgVOnXXa2/F/Il+1HxCjHPZUwGwVZnks=; b=EtWCSHqNFDiouMDQDXuQSp8jfycPGELrDUWdY3R1YDdPVekn7BBGGDLDzR3hI/ohOF pv9rg24fig0WukLoAH22zoBpm4q/dxv1lLg2Su3jqSvipGj3gLsOkbHRL1IkDdYbYJw4 jNORuISQ4A5AK4eB7sMK7Tsu98xrgHb5fgeKgSBMEHhrb2NK1oVxggKabuuAcIrzd9Zr HBSq6CpZC67Y+FDMfDudvr4bEbw/5ARVeisCXX81jZ4PUf0MM8Dl3tYyKpY/cpGxwind GnJ1jH9b0qiuDOurP7/3XD2Ef2CoV0vTY8LLbrOa61C9UG25ebk6hyWsU+pUcQ57CRG5 OqBw== X-Forwarded-Encrypted: i=1; AJvYcCUELmE2TgYnZEux1a/Rp34eFrpAt5ka+Qhg5ZKNjy2r3mLYA9NK3Hk84+UljmIbGgTbiiq/e6IQds7WTZM=@vger.kernel.org X-Gm-Message-State: AOJu0YxLji21Jyigd1UWnaLocSXPBhcUxAuuN3IfUZzN7Nwbgv+htV/C V6ffoiRs930sCK6ld0QCfA3XRsjUiTQKmsmIUfR19cA048DSbMpg9EwO X-Gm-Gg: ATEYQzzx+y7zE5xH57NEhPFLZyunDMCu3Q+0Z5GRIghl2cx2u+WHAzoZz7oRN+bXICe hTFx++bMUaaETKuVNCCnitXXG2Rkovkm79SkbqfviMrSokjY4KZfcrTWx9XTULds02qrueV0Idp i5YTUf9I3CCJXcQvf7ZC9QXhaumTDbiM7Sl4QmpJtg7DHGRhsWtYKejMTjRcXumx23Lb2KWKztU sGFg+sp56aSSs6eA24z825oRXx1tOvLDSSA+Sy81y0RoVAMxPtXnDgjTJGqiNMVEGpW1bcufzMP UXA1NjldJtHRXugfinXGNw+KrRpn/qavuGaf+NjpccLPJ24B7YtJTqE4n47R/Ogo8y/GE8LWuVe 62kGQOLZZ35XZsIkd5h9IdJddkK6z4lXxPJsrQYpzFbwytmYOevm/7hytalh0BW5fwhpk6vBnFH VkvAZNkNNGQpXbtfzi4ZN8J3KBvh1ZtxjZ0k5I83E= X-Received: by 2002:a17:903:46cd:b0:2ae:8253:1452 with SMTP id d9443c01a7336-2b0cdc1f89bmr165259805ad.11.1774941937496; Tue, 31 Mar 2026 00:25:37 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:5412:6527:d590:8704:ff8:2ffd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm109272495ad.6.2026.03.31.00.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:25:37 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v4 3/4] staging: iio: adc: ad7816: replace sprintf() with sysfs_emit() Date: Tue, 31 Mar 2026 13:24:52 +0600 Message-Id: <20260331072453.6530-4-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> References: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all show attributes. sysfs_emit() is the preferred way to return values in sysfs callbacks as it is safer and handles page boundary checks automatically. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 253ef2262..790b04544 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -129,9 +129,7 @@ static ssize_t ad7816_show_mode(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - if (chip->mode) - return sprintf(buf, "power-save\n"); - return sprintf(buf, "full\n"); + return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 static ssize_t ad7816_store_mode(struct device *dev, @@ -162,7 +160,7 @@ static ssize_t ad7816_show_available_modes(struct devic= e *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } =20 static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, @@ -175,7 +173,7 @@ static ssize_t ad7816_show_channel(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - return sprintf(buf, "%d\n", chip->channel_id); + return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 static ssize_t ad7816_store_channel(struct device *dev, @@ -237,9 +235,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=3D AD7816_TEMP_FLOAT_MASK; if (value < 0) data =3D BIT(AD7816_TEMP_FLOAT_OFFSET) - data; - return sprintf(buf, "%d.%.2d\n", value, data * 25); + return sysfs_emit(buf, "%d.%.2d\n", value, data * 25); } - return sprintf(buf, "%u\n", data); + return sysfs_emit(buf, "%u\n", data); } =20 static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); @@ -287,9 +285,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =3D AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] - AD7816_BOUND_VALUE_BASE); - return sprintf(buf, "%d\n", value); + return sysfs_emit(buf, "%d\n", value); } - return sprintf(buf, "%u\n", chip->oti_data[chip->channel_id]); + return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 static inline ssize_t ad7816_set_oti(struct device *dev, --=20 2.34.1 From nobody Wed Apr 1 09:45:14 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C1C3C3436 for ; Tue, 31 Mar 2026 07:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941947; cv=none; b=CZHNz3AwvrG4EjPYUtBswziaDO0q8TquEdPoA0mb9/NYAzIlwQXz7PLEXSE3YznyQkfaJVdNI5r56e74umPfCJTb+zhK1Jzv+srlG7mJNgq1ZhUuIpYDF54aJDBF5+s2igShhMWUfhxR6puC0nFcOvluYilOrS/iFcsJ9FPHG68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941947; c=relaxed/simple; bh=AaeubZhtz8ojYJt5zsFPfxtOPOpZylhKBuq2cPd6gUc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F07NgaNmybqlYrs5W3Ej9wd+0ykfGMY9VQSuKvDoGcJL3pgSpvgRmS2JCBtzDT7Wc6Oy6XhMBqAcLPmGcFasrBQbqH0cdYPMJvEWir2BtBa5IK2Wbztg/MqLZsPGGlKys+WSQ/VJE3GBYa2J1N9iV1gfggFpxMx+y1HphTgEcUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ISBDELZo; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ISBDELZo" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2b24fcc2b5dso13772285ad.1 for ; Tue, 31 Mar 2026 00:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774941945; x=1775546745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YdIxdgSG7WGFBTZ3ix+HECNRQzg5xB6W1qz3YgiFcVw=; b=ISBDELZoVA79l2qKRTz+OelldXMNPFQ/tLQah08s5Dg6mQmbNSvKfCpWQCeLBJ92ko d6NGoccBECucC48npR3iJsjbQWO//P5h3XhMLf7OSBxmsuFvP+tw+B6HxSRfb3xIB8tn SjxMikPTC/bpCcLBn+W95+Popxmj7zJMpnEb6A5bzEqPCGvpbLpTmRpi73IaDDjXBA87 mbWbHfw6b63JR5nghuD5tsQRI3RVFjFN9d4czdDqCtFY9LiqTjcn7RCz5ErMucQvF7cu LnIlEJL0cTwAr11mhrqABzq7/MV7KnThtAtfgFpffFyRfkt07rWFgBfX5uHuKIxC0DYP PqXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774941945; x=1775546745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YdIxdgSG7WGFBTZ3ix+HECNRQzg5xB6W1qz3YgiFcVw=; b=f1cfCzsIjdLBjGX/GjjpCU1D/8ItJdSmuzzGEXJQQ9UVIUcLRzYokfEfeBf3WcZyg+ Uej1ges5Gfq5/nxw3ZdqLeHben6Andc4K4U8PbealoiNZ6hIuYnTl3rcejfoSw2z+k1s JzGcxjmSfsMMjz8AmvZzpzWGoRlxK/4kBASXa/eYrxCdmlUfDB490cxSOT4Q5zZ28ZB4 5RY8WCBM/MsBaaYrNRjYlt7J2M8EKZNQxG+9mZ2IsiPj6UQkMom4LQAz+4GP6IyiwniW gchoEgB6iwFqnbNnhe1SxBjEbNbgJE2UNnqs49Aeq8QVgkKmtiEOp03nljgY6RSCaDif +oqA== X-Forwarded-Encrypted: i=1; AJvYcCVlQ4jaCNGeBuxrk+t0MYCJfYMnMYQ1FghHiTgC2RAgkFTYKUTSvq9gZn72KNcv8L0pZmJ9KhAFsoM0OmU=@vger.kernel.org X-Gm-Message-State: AOJu0YwsQOgtDIiTxUX2D0YIDXfbWdF99oTPpcyntSjaGEINnxMWjZmY qUM4QNnYB+8A/4a9WJttG+unNyxMMvtQ7BOWDc5Tj9VJC26qqBzNEDVA X-Gm-Gg: ATEYQzyZWKWtYFB0CYf40VYSo1CRWpb9mMTQ0Ez4VySBIDHPQxLMIbcXzrS04y13EOr TPir5NQo8zAm5ywSKL2rPOAQMfqBw56ZPAubRdX3OGu/XhRH7+NKVPdv8/59vEQSXrmlfktf3Lc W2PjHAUpocd9CVDNJOq7zj4XQXw15Up8p4amr7eIlQG2or1fNYqWiy/06jxbHr5AFCo6KzGKDdP tZ+cutHgsMbcOiRc2m3WQ3eqFUidevfpYoY6lpvLVa9LdZS24TevsqhGedSYmBQOmlIoJ2z9md1 +pThvoGvcrDvfK1kwMZYn/qP/l4OUhTbykZmPFnewEdI+HF1Zwa5OdGNN4P8N4M6OsqEt+/8oWX Nh+IVUBpxxyJlGhyF7uyUvk8EKkjBClBmZPP4++OQwFZ2MXgvgjgjZGVM5tJBFnrvOS3NdGREAx jNpVxaE5RnB1DCQ/yH1ZQv0ItTzCviaGN0UXaZegg= X-Received: by 2002:a17:903:22c2:b0:2b2:5515:661f with SMTP id d9443c01a7336-2b255157499mr60408695ad.9.1774941944981; Tue, 31 Mar 2026 00:25:44 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:5412:6527:d590:8704:ff8:2ffd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm109272495ad.6.2026.03.31.00.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:25:44 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v4 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Date: Tue, 31 Mar 2026 13:24:53 +0600 Message-Id: <20260331072453.6530-5-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> References: <20260331072453.6530-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Modernize the driver by using IIO_DEVICE_ATTR_RW and IIO_DEVICE_ATTR_RO macros. This involves renaming the callback functions to standard _show and _store formats, making the code cleaner and more maintainable. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 72 ++++++++++++++------------------ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 790b04544..c83f7f70d 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -122,9 +122,9 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -132,10 +132,10 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -151,24 +151,20 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -176,10 +172,10 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -209,14 +205,11 @@ static ssize_t ad7816_store_channel(struct device *de= v, return len; } =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -240,7 +233,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } =20 -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -270,9 +263,9 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -290,10 +283,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -331,8 +324,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1